From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63218A0093; Thu, 13 Jan 2022 15:41:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EF7C42740; Thu, 13 Jan 2022 15:41:39 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 0C7C040150 for ; Thu, 13 Jan 2022 15:41:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642084897; x=1673620897; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=l87oHdM4sGZb+Vx43WB+o3EJl6iGLXNjjeB1wH36oCY=; b=QcenO3BJt/nAcPMvThZE2bfrHjRP7nlYAbc5pF/Fzv1b6fo/Aah/GX/r 7NSuTcUmGoe3Y6jJp2mStQFIZu5aYaK688z/AK6rrkiNvRJ7zsp3dCDfJ zd/qhb5bRmUkwNauw2G6bNKqvekc7HGq9ZyH0gqj38IQUigMiH/ZuniQL BF6j5QNj/Ng8U5GwKkOOK07lNIdx11OKkHT/kWmVPQxCX10znikOrwUjR NSe9bKOzzQ1yybSfZDnzV4ld/yacCu9GIXNGDKp7snoqIxh7+dEDPAnep nz5C50hWBpV3RfUnbqWX5jv307r4NlDEXCUzoyJmG1UHtwqaBs1ktqQu3 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="304753262" X-IronPort-AV: E=Sophos;i="5.88,286,1635231600"; d="scan'208";a="304753262" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2022 06:41:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,286,1635231600"; d="scan'208";a="613968642" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 13 Jan 2022 06:41:35 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 13 Jan 2022 06:41:35 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 13 Jan 2022 06:41:35 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.46) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 13 Jan 2022 06:41:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Co/cmRye/uA6+yI08MbFTFKnrMbisSuw58EgfjI+U3pbAq89OJpOP0d3GYldn3vqO2OCklpNEKgTskm+Buws2rFFCGlyW7gNXWhLAQYW9vPgrgvVDwxowmkMnPxb/Ussxerr3lGFEFG72HPNojbsPupO3ymcwdGCRM6ihT2g41ph4AKmZM4OKI5KaxS/0zoPmwRxC9SicvAyrBl5kF8WsLzYLPbC2Kpvvi2pHcwHtCfB74czKt9Yf1z0ISJ39SMgVkxg5MN6Oou5raR4XiQonPqfj6kOuKdrydmawy7fVg8w66AqTvwAsHMSS+QohtPiqUujNV7RYNDHtr/R4heWtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l87oHdM4sGZb+Vx43WB+o3EJl6iGLXNjjeB1wH36oCY=; b=fG6NqjG1ZEKoO+K7LDMSfkzXZM0GwL34gs0pOjykCcOXRGx67iB6oKJisqiSKZCShcdggXuIYTWEN+y5PE++zpkzUlHRFNhZXMdVLv/UbV5YJGwcU6GJrjHUiduWNRDZYpBzXLTZ9bPdVmDthmZcq60EOZNCSWL8oBlhMRKKLLBj82LawDar5eSc/XJGhaYTkGplc0Ekfuq0VEr2gix9o8IiY5mMtJ6ZBTkoV3tKIEl7DvyfEpZumG6d51qlPwenuXLIvkzABXM00jdeareC1YgP6hHkG06oB0OuqkDNl19bk/HwVcWPx1KwFnwQXW7Uetu8Sdp8jkVR6s9Xp/RYDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM6PR11MB3882.namprd11.prod.outlook.com (2603:10b6:5:4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Thu, 13 Jan 2022 14:41:34 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::7de4:731c:cee2:49c2]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::7de4:731c:cee2:49c2%3]) with mapi id 15.20.4888.011; Thu, 13 Jan 2022 14:41:34 +0000 From: "Ananyev, Konstantin" To: Akhil Goyal , "dev@dpdk.org" CC: Anoob Joseph , "Nicolau, Radu" , "Doherty, Declan" , "hemant.agrawal@nxp.com" , "matan@nvidia.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "andrew.rybchenko@oktetlabs.ru" , "olivier.matz@6wind.com" , "Xu, Rosen" Subject: RE: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration Thread-Topic: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration Thread-Index: AQHYALPTAeqGGhhhEUOj73nYsC3Sy6xeCRBQgAAu0ACAAQCHYIAABakAgAABkfCAAAfBAIABuw6AgAAS67A= Date: Thu, 13 Jan 2022 14:41:33 +0000 Message-ID: References: <20210823100259.1619886-1-gakhil@marvell.com> <20220103150813.1694888-1-gakhil@marvell.com> <20220103150813.1694888-3-gakhil@marvell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4d64a819-af98-40a8-62e4-08d9d6a2cbc2 x-ms-traffictypediagnostic: DM6PR11MB3882:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7BZjeIJ4II/9VcmlENLMXxng2ZcAFRWvsWx+BOiEsTDKD4MNA6BzLMMMWY/tERh9RQbaQAmQ3VmhN4sD3EoOWEbVxNAiAOJOnXJmHJqGOX/oIboL1vcRSMJsJL5kzu0EUv8db1pH6iB3S/jdiungn+noDy7J7/P96vonOF0Qyiu7YJfDV7YZeSfGcSi0OUn30aTLyuP5lYVjZ3OdCUOiMBG6BTLuQiY0kLOw70g2cBHYbsOYLA8c/TrqZ5rYcolJqMbK3xHTAaVL1Wm+ySv90i8epNdDyG+HdEGm4Gpn/r9WqJqJRNTIJYy6P4y1V7kBsruBOA/JAmVdP6RNmqIICmfmiSpX7agUy8+o6qjSegnlgISNSG6Q3vO6qoPsG/fFAfyCbQ0p9JMqf+BTwCo0CLbmBh4KWKMcd0Vw60MUddyHVGRPOkaCuQJj7iCI0xecpZwmVdA3CimNP6j7Cy2IeyfsGqPdT3Mt3pUm+AgRBfgaX9kLme65+KInL+a/t+gp21giLs788nmyNmRDhWz3XJoDuEbf0gCtlk4mi7jR4Ef/2QnJtt0Q2kV7Q+6XblRcyg3kvYhIlq6OX4Jye544dnBP3lr7HklbFg+AG01qItP7P8A77PJyhwwj0vI8locAIcN27YM99BSiRA1NnK8/pJIdnGbxHL+5DIvwLcDwW6et0PcloNrW6rLU7wx8sF5wWrMk4kc6PSbr8EFN7hZI3Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38070700005)(82960400001)(55016003)(9686003)(186003)(86362001)(107886003)(4326008)(52536014)(5660300002)(33656002)(38100700002)(122000001)(6506007)(76116006)(54906003)(110136005)(66556008)(66446008)(64756008)(66476007)(66946007)(316002)(7696005)(26005)(508600001)(2906002)(8676002)(71200400001)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/rq1iHp4VlHbp9H2rFEP/2lfOFXjrIUORVJlVsbkZyoTZ5TD7BOpXzUiUU0m?= =?us-ascii?Q?bd9FTtfIKrKcLIKhNxmRffowzpo+zJq3jp5XVCfAsHanRK68EraSUUAwX478?= =?us-ascii?Q?m00+8ThUafkLrbB2yYdmWwNGynHJP0IMtU75TR7cvBD1/1cG00vad7HIQOd7?= =?us-ascii?Q?sPcmiJdlrLTXEU8GDoFPMCdC+aueo3LSetMkwHgaLSpLs6Nric7N95V4JEBs?= =?us-ascii?Q?Bdb1QQsXylg99Uu2IaQeYQhbUGwtxHmkcY+DxQ91vUQkFMAypozur3BcSM+7?= =?us-ascii?Q?z6s/4xqYavS4ArCQvY1vsU0JMWEGOJCqI/vRBwMkhr4lobvIshd4AaBbvU/g?= =?us-ascii?Q?In39r+UwFNn0R5upJ8/cabj156Unn21wyfqXF6bhDN7JqnU9ysnKvYM8XhJs?= =?us-ascii?Q?7v7j6K+zcPjxdAjdQShSqCGuok37M16ISq609K8EtOvIy+wu6lE3+JCxPW/b?= =?us-ascii?Q?scHFCJYqsoGOkulV6+JKAojxh3w6PtimmfjOoJdn3WMt0vxoUfsslb2QS6oU?= =?us-ascii?Q?Mtc2EsMwogcSH+rHQ5mbaXHqdI85TaxdG/9As/k4pni9Xxy+6MQsghIBV61J?= =?us-ascii?Q?lDVH8RVYVDgz+JJepI/6hs7onbWx/lWtDYZiEshLK8Gie5wc/QxEjHthZ/Tz?= =?us-ascii?Q?CilEsLwD7pVsX5nCHxcqbHb7nO47IQhr8GuCpMAj8PqZTk9QbjWsL20OMUnf?= =?us-ascii?Q?VTr1YX+ZSu+30WSQ+DGay0sR+CV9gZ2pk+ICQ3xD7NicUeUYTRv3y+iUByvI?= =?us-ascii?Q?7RYv4nWBojr7UXdFhPnPkeFP+T53cr6aS9FZkK+DBCOVEko8l2TW7rn63q6a?= =?us-ascii?Q?Yv16o51tYHLFLWs0jctmpOJLiF/BM/8LYpu3yxkIsqeRDakDK9fJPSFiUl3d?= =?us-ascii?Q?3eucs0uiQRLSlVfV8nzKU8//L7L5WKxzUAoAmzKnPaTg7SJBy3bEiMa0DD6q?= =?us-ascii?Q?SYcMXlzoibxEMO0XAMFY4Z18K/5aV/OAUG3OEgg+RNE5P0v+894xOt3aLYpy?= =?us-ascii?Q?UXK25lbv2g69DgMBHy09s8E5+ZAUJhhoCzdXrVMh5KR7kRPzsJPmZ/02UZr3?= =?us-ascii?Q?SwIDWYkfJZmg3X1Omd+QCDOaLaeC7VO31DDgE4jXXvkMWFfj3MVjgF9mFRJg?= =?us-ascii?Q?7W6E03Y3Lh2o3jU/HCz4pWEySiVdy3hu8g/pV03dDWVFeLw2oJXORO12+Byi?= =?us-ascii?Q?XlA7VZdv4E+xEwcbzyD+X9JpiRuk+w+fCoTHIjLx6GpAMMDcKcccCyQE4SZC?= =?us-ascii?Q?HmiXEyCfHx/B6JC1lVV6bvBrjFDFUZaSxgIVLdzaVYv70SGHDQW4XvmDLaUa?= =?us-ascii?Q?ldjQ2ZuguddOCJ5q+czjr9Ktd7InzFRnjHLDv4jzPGkBjwEQZa2KsNvTFSyy?= =?us-ascii?Q?fqjmxJ4UVHoYFICDETRXoYrO+mmwYPY06c8kRqN5QeWsqhoq7OyZQZ8pBoGA?= =?us-ascii?Q?61N0890MJVs18l0KhlYX2FIqcCrbcPLsJw1sW+fwUlvauUl6SaFGaayCXSvI?= =?us-ascii?Q?L4t/M70Xd3PbZVRmydKBqzna8KXSJIf5YpH70g/EicWZX8silNoYyyd0+S7s?= =?us-ascii?Q?sfbU6cj77aqYXukHn6cQBG6FS8FxZc5/qOkExodtuS0d+g3JLapJqTDCdkaN?= =?us-ascii?Q?DaPwj5lPwKV9NbS1ymGkSGGQOUf+DHl+GvfnfIQdb1ddqE3VzjDXZehWw/Kn?= =?us-ascii?Q?OpdCOg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d64a819-af98-40a8-62e4-08d9d6a2cbc2 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 14:41:34.0102 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XyFO2rf1/54cOQEopf3vHb36vwDPL+J9YLli3Wvm54ccV3yV/hbOjWO03+14C1rm5KBkQo2NWaNzROWCmvv2GB8XJU9w+FIkWTy8UTD66kc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3882 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > > > > > Another question - if we have reassembly_conf_set() would it = make > > sense > > > to > > > > > > > have also reassembly_conf_get? > > > > > > > So user can retrieve current ip_reassembly config values? > > > > > > > > > > > > > The set/supported values can be retrieved using rte_eth_dev_inf= o :: > > > > > reass_capa > > > > > > > > > > Hmm, I thought rte_eth_dev_info :: reass_capa reports > > > > > max supported values, not currently set values. > > > > > Did I misunderstand something? > > > > > > > > > Reassembly configuration is expected to be a one-time setting and i= s not > > > expected > > > > to change multiple times in the application. > > > > You are correct that rte_eth_dev_info :: reass_capa reports max sup= ported > > > values > > > > by the PMD. > > > > But if somebody uses the _set API, dev_info values will be overwrit= ten. > > > > However, a get API can be added, if we have some use case. > > > > IMO, we can add it later if it will be required. > > > > > > Basically you forbid user to reconfigure this feature > > > during application life-time? > > > That sounds like a really strange approach to me and > > > Probably will affect its usability in a negative way. > > > Wonder why it has to be that restrictive? > > > Also with the model you suggest, what would happen after user will do= : > > > dev_stop(); dev_configure();? > > > Would rte_eth_dev_info :: reass_capa be reset to initial values, > > > or user values will be preserved, or ...? > > > > > I am not restricting the user to not reconfigure the feature. > > When dev_configure() is called again after dev_stop(), it will reset th= e previously > > set values to max ones. > > However, if you insist the get API can be added. No strong opinion on t= hat. >=20 > On another thought, setting dev_info :: reass_capa to a max value and not= changing it > in reassembly_conf_set() will make more sense. Yes, agree. > The most common case, would be to get the max values and if they are not = good > Enough for the application, set lesser values using the new API. > I do not see a use case to get the current values set. However, it may be= used for debugging > some driver issue related to these values. But, I believe that can be man= aged internally > in the PMD. Do you suspect any other use case for get API? I think it would be really plausible for both user and ethdev layer to have= an ability to get values that are currently in place. =20