From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEE10A0093; Thu, 13 Jan 2022 15:36:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E4AF4273C; Thu, 13 Jan 2022 15:36:40 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 50AB440150 for ; Thu, 13 Jan 2022 15:36:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642084599; x=1673620599; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=lS1cqmEldTJiMepSZ/3OALliXQOoj/NX3sfv5mIxP3M=; b=dbCgrXCSoZVE5OSQAQhAiebQWdahXK2PTdiqsbpiG0OaIAWf//OyTz2x rXN7rhK6VUn+zfAEDx0wwHWsfuV3OLZxuYeHlPVhgUKckcKdn+5I30rYN 5z2NH+bIQCuAltLfBiU1NKn5HFX7kwDuwe0I1dSbayfYqqQMqgttVBrUL dRgJ2fUwB4HIhqAbMy90YUZ1/sM95SeAIA3ACvZcZVcqmkgk2LHw1HC/z Rou4aYfWTh9hbEWBJuCn+L51XbgcubPaFGfXN/3W4m6wN4EHJUSEDhfXY mkpxCBmp0E6BvVAIOPfHQHsDqHT8YF1w6os4/wF9MwlX3FABXZuc+6eur g==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="224000274" X-IronPort-AV: E=Sophos;i="5.88,286,1635231600"; d="scan'208";a="224000274" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2022 06:36:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,286,1635231600"; d="scan'208";a="529677436" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga008.jf.intel.com with ESMTP; 13 Jan 2022 06:36:37 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 13 Jan 2022 06:36:37 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 13 Jan 2022 06:36:37 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 13 Jan 2022 06:36:37 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.172) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 13 Jan 2022 06:36:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FfYCzVo/h56C7q3NPzjjyd/8oA4TCJ+b4mLPlli/8cxs6gsr40hh0wLCoUrBlL2XAOCfaYYcdkH24CsjX2eN92VDK8P0RL+sdPE0ddHtp++qCl8arL27gpfC+NKZftm9TYyxZ2jZIoJG2JSE643rvgCiLNtrLBnEDROTZSAdoj0ggXkgoimM/2X13KJMw5ODQfQ5Fb1Lv/WDyh7N0nSYgxNcXnGqZj8s2eD5bgCjYz+fFXDkStzIsccmobovFVgLBWNgCPPH0z/jLZhulnOTh36BXKD3zbThBcyTZupb7lrB6EL0+TR2dR1VGDgUHCwPPzDev9lqL48xTEaNuwSR8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lS1cqmEldTJiMepSZ/3OALliXQOoj/NX3sfv5mIxP3M=; b=oMa/FMuqny5cb1ySh0dmkIh2w84tl9Yfd6hT4Fj0pJFCmIv2Gmnl8BiYUCxeY85kecR36JWzwvC7b5RnjS5ed3wxrJ6AN4Ag2H2RUY97paAWoyxxtlwCS8sl/XO+tsdjR2/7mDYnhz8CzAQsNhHtRogM1U6A+2rPTkvR3zwZbB/tPC82XVC7QM0cgVJ3XIZll+NFMxaWghY2NZnH/VjJ+bIucsza6ctOBr1A6SxxHKZKLzYRhKBcZy9NEarURjft1iHYbDIPZzTCKd9wdNtYXorc8d53zm58COsyhFZLWJbvbL9+TOH/kH2cNABUoDzCtvzbdfZ5SAlYHnQu6vAbUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by BN0PR11MB5743.namprd11.prod.outlook.com (2603:10b6:408:165::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Thu, 13 Jan 2022 14:36:35 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::7de4:731c:cee2:49c2]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::7de4:731c:cee2:49c2%3]) with mapi id 15.20.4888.011; Thu, 13 Jan 2022 14:36:35 +0000 From: "Ananyev, Konstantin" To: Akhil Goyal , "dev@dpdk.org" CC: Anoob Joseph , "Nicolau, Radu" , "Doherty, Declan" , "hemant.agrawal@nxp.com" , "matan@nvidia.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "andrew.rybchenko@oktetlabs.ru" , "olivier.matz@6wind.com" , "Xu, Rosen" Subject: RE: [PATCH 3/8] ethdev: add mbuf dynfield for incomplete IP reassembly Thread-Topic: [PATCH 3/8] ethdev: add mbuf dynfield for incomplete IP reassembly Thread-Index: AQHYALPm5GZXp3/J5kytklOWiwFqV6xeCiiAgAArBACAAsmEAIAAFJZQ Date: Thu, 13 Jan 2022 14:36:35 +0000 Message-ID: References: <20210823100259.1619886-1-gakhil@marvell.com> <20220103150813.1694888-1-gakhil@marvell.com> <20220103150813.1694888-4-gakhil@marvell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 58f0fd2e-52be-482e-c148-08d9d6a219d5 x-ms-traffictypediagnostic: BN0PR11MB5743:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DWsRaGNVDMwVzSegDO+fNGeMmGeFOx8FTpO0aC2J6pzdhTAPC+9Wd3adrH9VuEUL4N+QilXi0rufEdEa3ulSMPrG/D0b2USQhbaHJRZtRxYgFkDUuq1/4z5tUKjKiCYAjWXwkpJyhicSBATKYo2bre0SMvsUzcyUUka3i2bVRv5CYm/f/rGqPdNYtRuHjQ3sBdfFFb/TJdubyi6gNZ4a/TiwN52Rp/4oUhGrpz3spXTKjHSXsP1FGcMGqg79l0RyI7LIHRdXwA8so3beCK5KOXziRAiqGR6fccGdUCsgThJ2gLozlim/5f1MBrLtwO5Sit8wm4sXzrN/N8xwhIrtnhvCeoBVeBEiuxZp7QuF9HrMes4I572/vZgZiOzkcdT2JkkWnGeu47PTj7henxzKHRvPQyeuBBGrICJsZXwUcOEYq3olETmyX4AIyiNpiKRoWkQb2E8d0evRZ9wN2Y+VyM7E/3nrnNd0ReL0qkx0kRJ51RzNU0biegYincG/9L5Vj8SRTYbvC0QVGcOBbYQEVNS9x8ECp2b5VBLJGIalxGb8QzBOtWSeWafQG7rTtVSK8pUrS5BQ4s/owYTiQRYFsrV9RQd2tTgwJnqYcuYlnbTWWzPb5kWRgsjYeJPJ99jrb0QGZEdKEdIW11t1iwof9bmNZv7Ian8jQIN4HZc/AHZ8nKj5EjOeppIuW3ew5bcGvHLEfw76T7wgNeLL+6S99Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(26005)(2906002)(186003)(122000001)(6506007)(38100700002)(82960400001)(4326008)(38070700005)(66556008)(66946007)(71200400001)(76116006)(8676002)(33656002)(64756008)(8936002)(7696005)(107886003)(55016003)(86362001)(110136005)(54906003)(316002)(5660300002)(52536014)(508600001)(9686003)(66446008)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Y1h2FN7on587Hd2uIb+mLGlJdmR8aoMjiPqUBjDRKIOu9zgXhL2+Y6rFfkYN?= =?us-ascii?Q?xBFuLTAdFR0OsLfiwl5vgOCeSMAy2dokaNm3sm9EiSlYYMBaNV3X95D5Lfqx?= =?us-ascii?Q?ZrOKvmpyPg5fPl7t+0CJpVuRztRqEXPd9qXqn9EXelMPky2wv4dv5+hs0Y24?= =?us-ascii?Q?LmUPREfH0m0qn/2styUAEiIDWffyjapGhYUckXsuUTWs3kzjELIBCEdwgL0q?= =?us-ascii?Q?ptbtbbES8Zh5D4gKqjolRI4953ngdolBOye6EfCdgl849dpP2XuKJLGBIakZ?= =?us-ascii?Q?8SuO98pMkEWirIwKyzjbpN73bIvBejTbrg8HG5UrhYUw39YuKYOZZEVPfs1/?= =?us-ascii?Q?ewDCcrc6mcezQcMaPh5xZLpkzKlbU6A43vl23k0pU87F9OjQju/zqqk1jHUK?= =?us-ascii?Q?0s6oGprSZCYfsXxInBy+Ot9Gvtpsyh4HWijr+SmWgQ1RASj8nGi8rEHaEKou?= =?us-ascii?Q?+thSIGWYlUHte79gYq6DEf8F7YM1GIJZdyuWT1HVH+kT5+8BYryYSuiGq4jm?= =?us-ascii?Q?p3V8gNVqkco+NEXZUt5oqqfr1OtRGT4N/boLUgjHOyIZ/12WOgOI3OMguAbm?= =?us-ascii?Q?htw/jB0cOSsD8HbPZj8QRdYYXyD1kKow1P5Q/ayJdmpqpMixZYTuedvZI6zx?= =?us-ascii?Q?Am0UsboHbFUG5c3hb4h3lBYG4uV0mKiOWVwb5wnGQ+LdhMOpaWMlhssSnCYa?= =?us-ascii?Q?autBYs0O4l6y+C3qfF/mviSYrKC7A38KbCnDam7W2RLSIPjKT9YwirffIbhw?= =?us-ascii?Q?WAXXavqzbYgGRqFiaRC8vU6LgzJFPjsX0yxr5EyswCeNMBfe3UJBKfKHwkrf?= =?us-ascii?Q?ChlgVeAyG9/yyJZxGdUWS3ybNm/jnCVSxcB5B9SaT0ZWFm3P1WNiTJfVTH+e?= =?us-ascii?Q?QVqMUdfDZqjac4v1ngGuGgZZ0bzMjiLaW7GNNNygth6rduoB3jmCvanv16DK?= =?us-ascii?Q?/uWiaQ3m9fKFUP+9A1LL9jWhsR049g62257TWA1cZhJZySG28xtsXYuDc+4f?= =?us-ascii?Q?Sattsw6+YL6xMl9ZD4mXqrGL6/f6FObiG32fF0xc8FIHUAAOMCLZg3PchUrO?= =?us-ascii?Q?bgCpbxtxk8mWByc8tdj1gu9p0z2ZA1oSjnxLHqoKaF/2SSTKG00JWK9nCQ94?= =?us-ascii?Q?mayqgP0zP8PP2gxKAU/CbQscBWhDNmgXdzo/BhrBWjErr9EGbalEJw287bbJ?= =?us-ascii?Q?RJAgZeVS1l6JDePxwLQyQrm+puR0TJmYmk0Oufzimhq41d6piU2lga6kGjia?= =?us-ascii?Q?pnIyJ5Ek6bVY1iBqU3y2+jbuIpIz6xHsUYhne6WtaEY7p3jqYvZJZAMr9NZh?= =?us-ascii?Q?SWyfLS6/0JcfrAZW8sWYMwc3hYWTL1asC7+DF3jnq5to3Db36FvpB9GCsTHg?= =?us-ascii?Q?XvFkO9v7dwaNCECm0CEl12loG4OQHahr1omUy6nHxAxcX6BTviXaaE/Wm4xQ?= =?us-ascii?Q?FIonAOBA4F5j7/MeBbpKgW3mOpl3RjMikAuEc5T6vL3vh1zwennCxwSKYvqN?= =?us-ascii?Q?QOYijwtlt+N4THAms4E3ywWT080kDEFnY+3UcoJ3iqVCciWhu37VB3TEiBrL?= =?us-ascii?Q?89Q6o+XghkIyA9ebLNCZcDAj7bQUcG9KC/IenrsEKx+lA9gJQQpYIUDtNc0J?= =?us-ascii?Q?jn2Fy/8bm8vlTIAVCZbcS2iLqk/dR7aLz0qOwVXFLFo2Wke0yA/1L9SRvl+6?= =?us-ascii?Q?xIZg3g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58f0fd2e-52be-482e-c148-08d9d6a219d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 14:36:35.4714 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: x1htugNZlKz67rXhHF/eShCF7dfMFkTH0OQ+tnyAcECGIJNtUbIMkd7PWHNtt46EGJpXdtws+zdbyislnTvyij+cnkdLdkKPQwwh14gAFZY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5743 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Akhil, > Hi Konstantin, > > > > Hardware IP reassembly may be incomplete for multiple reasons like > > > > reassembly timeout reached, duplicate fragments, etc. > > > > To save application cycles to process these packets again, a new > > > > mbuf ol_flag (RTE_MBUF_F_RX_IPREASSEMBLY_INCOMPLETE) is added to > > > > show that the mbuf received is not reassembled properly. > > > > > > If we use dynfiled for data, why not use dynflag for > > > RTE_MBUF_F_RX_IPREASSEMBLY_INCOMPLETE? > > > That way we can avoid introduced hardcoded (always defined) flags for= that > > > case. > > > > I have not looked into using dynflag. Will explore if it can be used. > The intent of adding this feature is to reduce application cycles for IP = reassembly. > But if we use dynflag, it will take a lot of cycles to check if dyn flag = is set or not. > As I understand, it first need to be looked up in a linked list and then = checked. > And this will be checked for each packet even if there is no reassembly i= nvolved. No, I don't think it is correct understanding. For dyn-flag it is the same approach as for dyn-field. At init time it selects the bit which will be used and return it'e value to= the user. Then user will set/check the at runtime. So no linking list walks at runtime. All you missing comparing to hard-coded values: complier optimizations. =20