DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>
Cc: "nd@arm.com" <nd@arm.com>,
	"zoltan.kiss@schaman.hu" <zoltan.kiss@schaman.hu>
Subject: Re: [dpdk-dev] [PATCH] ring: fix size of name array in ring structure
Date: Wed, 20 Oct 2021 23:06:47 +0000	[thread overview]
Message-ID: <DM6PR11MB4491753FD0CC55E8F55CF9A19ABE9@DM6PR11MB4491.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211014205550.10140-1-honnappa.nagarahalli@arm.com>


> 
> Use correct define for the name array size. The change breaks ABI and
> hence cannot be backported to stable branches.
> 
> Fixes: 38c9817ee1d8 ("mempool: adjust name size in related data types")
> Cc: zoltan.kiss@schaman.hu
> 
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
>  lib/ring/rte_ring_core.h | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h
> index 31f7200fa9..46ad584f9c 100644
> --- a/lib/ring/rte_ring_core.h
> +++ b/lib/ring/rte_ring_core.h
> @@ -118,12 +118,7 @@ struct rte_ring_hts_headtail {
>   * a problem.
>   */
>  struct rte_ring {
> -	/*
> -	 * Note: this field kept the RTE_MEMZONE_NAMESIZE size due to ABI
> -	 * compatibility requirements, it could be changed to RTE_RING_NAMESIZE
> -	 * next time the ABI changes
> -	 */
> -	char name[RTE_MEMZONE_NAMESIZE] __rte_cache_aligned;
> +	char name[RTE_RING_NAMESIZE] __rte_cache_aligned;
>  	/**< Name of the ring. */
>  	int flags;               /**< Flags supplied at creation. */
>  	const struct rte_memzone *memzone;
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.25.1


  parent reply	other threads:[~2021-10-20 23:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-14 20:55 Honnappa Nagarahalli
2021-10-18 14:54 ` Honnappa Nagarahalli
2021-10-19  7:01   ` Tu, Lijuan
2021-10-20 23:06 ` Ananyev, Konstantin [this message]
2021-10-21  7:35   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB4491753FD0CC55E8F55CF9A19ABE9@DM6PR11MB4491.namprd11.prod.outlook.com \
    --to=konstantin.ananyev@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=nd@arm.com \
    --cc=zoltan.kiss@schaman.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).