From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F917A0350; Tue, 22 Feb 2022 16:14:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2D3540DF6; Tue, 22 Feb 2022 16:14:00 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 8E95940DF4 for ; Tue, 22 Feb 2022 16:13:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645542839; x=1677078839; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=kVLVV6O66xstbtfJQbSOQ/d6qEf6+UUtUhCoaVZcBDg=; b=GIR/VCZe53ITtL/iOHuhjrj34cCAFRa7ZKCKEwV8yNDA06PzI6NKqFLg 3GGipVg/YWqM0YcrOqFP5CQpLIUjgNAvbzT7tmCNyNqJu00Kc82cXlQ7b AEFwpQ7cUj1xJGWXlPe4SbWm1/G2SUeFzbI+1mQKzx9uQeStDJH7brqg2 1EAocxHQtXTGLQvznmXYubSw87sZ/zrj3AX46fvzPlVS7ARjvjjET4eyW UBPztf2WPhslcPy8+D0aLlBpuRj16wWc4AeWsXflObmPL6aJwQd5SpKWG SIyoQ4sor9Dyna6ii0HhwwfvtAONWSHkp52/m94CPgkbO51FQT87RNPo8 A==; X-IronPort-AV: E=McAfee;i="6200,9189,10265"; a="251915246" X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="251915246" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2022 07:13:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="532260888" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga007.jf.intel.com with ESMTP; 22 Feb 2022 07:13:13 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 22 Feb 2022 07:13:12 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 22 Feb 2022 07:13:12 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 22 Feb 2022 07:13:12 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WhWAvNQbKgVTls9T49tbLDDTYn9NXdxUgGEUCkov3WwnncFaQB1I+/E46dlRmVHClG54bVKGRByO4r0rgGZRZQrO9WGAx4vS8xMbX8LXZ79quwCkUC+4OYFJzKfqZRmSU4s5F8Lc5GFbae3esZdWJNFW/KJ4+zStkA2jTaijwN1Kz9CWDtklvAcFXDjs9z85KiY0nKjKxHD/AC5rXC1NlJRXLNnnN/029PUPp0GPg/EVNzm5uJAcK8p5daNv6FoarIcIHXxSkuIh4ilnlhJOA4IuaXdp2D4wLSNqsWBjqdIqlLgvesCvKddiwpu/+vhk5C4MLsutpnDj67iBcApPhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PezJIPpCIH6KKAute/ruAVQq2OGFghsCvdKjj68c+BY=; b=juOx6y2lZQiIxspvCPnysbJOI6avNJLjGlYV/u7/+n1gB3ANDTD2ZQsTwIfPH8VL1Xb6hvboNZvWqrAcGPbNYXEakqGtrQy0IqlchH5V+HakgvwP91mgSllsxTJs0e0H/m3Q/kW8PI7bQTOWbORX+/4dOl6DT8xj03sOjvYFGaFULQ/fMf21wL4ra/0IYBPVbvm1MbxFB4JwlzaEQaalElunDUfXhO21Z7P6gxCpVuHaQTRvJ0qIaEBvXGgMRmXjoSU8hT2sbhrQMhKNfavR+Q3HK7Uwf3jWbXJtDQnAuU/MYog8cU8c8M+GKAOsqaNyUV81RpVupHt0mTZR3A2Y1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by MWHPR1101MB2286.namprd11.prod.outlook.com (2603:10b6:301:5b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.24; Tue, 22 Feb 2022 15:13:09 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::8ccc:ed65:78fa:1b07]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::8ccc:ed65:78fa:1b07%4]) with mapi id 15.20.4995.027; Tue, 22 Feb 2022 15:13:09 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon , Stephen Hemminger , "Medvedkin, Vladimir" , "dev@dpdk.org" , "Morrissey, Sean" , "Richardson, Bruce" CC: "dev@dpdk.org" Subject: RE: [PATCH v5 0/2] Add config file support for l3fwd Thread-Topic: [PATCH v5 0/2] Add config file support for l3fwd Thread-Index: AQHYGgG/2P6JAfnPu0eGpqCdewcShKyD+IYAgAKg5FCAAmOzgIAAe1hAgABhpICAABo2AIABKkCAgBRTGICAAAL2gIAAPHYAgAAJqgA= Date: Tue, 22 Feb 2022 15:13:08 +0000 Message-ID: References: <20220126124459.2469838-1-sean.morrissey@intel.com> <1763854.FMhQkTaH9n@thomas> <1908816.VSt6etZd6J@thomas> In-Reply-To: <1908816.VSt6etZd6J@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9546d6f0-fa7e-4042-8f9b-08d9f615d5d2 x-ms-traffictypediagnostic: MWHPR1101MB2286:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hKkLlP4rTB6emssQJxvYMQcNTcCzyYDXAQCShv2YfC6Yvl0bQU0ZjPyVGJG10SxmuXnkkIC33wq+S1GKvqZtBBQYLWR//6DXTHhtRi2anb1ohz4U9/lolF3aNNYrV9Tvk2K964Tl4BKsG9jQ0FpHejEBYqxIWfUUUMbFp/46QcYmUOqbx3EKFjSDb6NrtO7xp8WLY4E5+JHNc0J2CzL1xJ7UeKbyKK4criBzNteK1VeeWgaviggZYHYQkH/VSxkibIJFZVfCeHkM1nZ6XgGC6JCIvhNtrYlTpGRYJ+XzioXsJDblgCehB3noOIr+12FteCMwnSMYPTFYHtEiBtUOlyOZIIbhTfe4C0JgjYgEQe2W7wvfyt+RbzX3yIUFSQPHvQXPuahcdVCXCgCFe8J/F7NHnOQENNsucOd49WzGURMQllsl7JJ1jGpYxveJR0CRY2krKpqYVYDhEcBmp3c1ppGMIWK9S0AVigEle9Lnjt0vJD5kmGRCzpU0Gp3E0bxnsuOgWeDJWdgXZAwhmKUJqqV8smmJezNarUocQnjOW9J9jKAQn8Va9rp+Oc72CLXs7iUXikPjpbqrK1zDQj/xPMaUhhVxP5enbY7jHwC9r00PwWYesp6nQ3mI6cy9sWgHZHs8ysIyK8YojubbX1v4ib9IKV8CujyrsJFIBUn1g5OEXDmANuLCKXHTnWRCrohQ8dS7xmaewqz99hUJ1hEu3/aCYGlarZh7TCn+WEjY428= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(186003)(66946007)(9686003)(66556008)(76116006)(66476007)(6506007)(26005)(7696005)(508600001)(110136005)(316002)(71200400001)(86362001)(66446008)(6636002)(64756008)(82960400001)(122000001)(8676002)(38070700005)(52536014)(83380400001)(4326008)(38100700002)(55016003)(5660300002)(8936002)(33656002)(2906002)(32563001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?uTMPieNfycK9J2ziKaF1cxogJ7kzpAas9vb3SWLlZNdwRn1bFAVx4msmBqXn?= =?us-ascii?Q?PQzOvrJ0Irfm0SeoWrpEw8ATw4UdreE6Y2LESDwbfcvNEFv3ofFEtufH2d7G?= =?us-ascii?Q?aJVOhP/3uVfL1hbKBu6SVu20JEFp6EOI9veaBvix9hB7qdnMavdKJ6JJ/mMD?= =?us-ascii?Q?eBkFEAygHraeQAVuKh5CDuE56LCPvJzyQ62gRW5uvavPjh4yUPVmULXL5ZXB?= =?us-ascii?Q?Auz3Puj89RWopEFfQZeAC32chhC2l35G7QZphZ/j2NGb5L32R0w9RlXi3T/G?= =?us-ascii?Q?dvEQd3U26VCF+RkpdtX66ClAvbhGI9gN1wJu1BwdBcBq8okDTX2HffQ2q19V?= =?us-ascii?Q?CjcVBk05E3Gy4l3XoKTKtJJk9OMJlkAml1i5nzwIMEfYpVSL/TrMZ/+5veKV?= =?us-ascii?Q?UJnST52P+xcaIyBA1pFZxiI5ScEzw0l85zLL/WjfqZhW7Vq70p4JwVUYjran?= =?us-ascii?Q?oc+BJDK0C7BDyXCetxz12LBx4XR7/mALWZ/kFdvpKBZr+h5m8YxemV6cXFGy?= =?us-ascii?Q?XUfl5i/e/F12dEusF3Kpe6uP2bO3aXPjF5dqFOqrJoF56EkkYIb+4uk4Gki8?= =?us-ascii?Q?8PSYipag5McURnoktD4l1IsB2trhUAtyxSdpTwrunSDXaiyNGsqFTC9QBsFb?= =?us-ascii?Q?VLRve3kSV6DZEhOHKyjsPv2pyndpUJrvjiubFVy6Osdkl+9/kCLMFg5zAWqc?= =?us-ascii?Q?/nuiPiFSJ6lW33Rjgtk+6aoD1kLTuOjZj7FdgJ94/9RL4KCu5dWe7PqMg9Ah?= =?us-ascii?Q?oaLo9ocsc+tIo4apWa7V+Bval9+4uuPV44+zh/uz8d96DYf3/SUbqDPODts7?= =?us-ascii?Q?dZyk4++VSZHgEtQo0nFq5UXlDNB64H7WnZeFBvt7gzCu++BZUiAHIItRtAj3?= =?us-ascii?Q?vnkP59VhPoyF0Igh8Yemd3WxtJbIrGIoGj55Cz0lGtOYhRWm6MC7ussD3inn?= =?us-ascii?Q?UMWK/g8w4Rmip1VWbeUDILpTPOMU7uYOgCo+EQH5VGLojPY9pbd6ZxyhPvW0?= =?us-ascii?Q?ZzlDvNMnHRl1c4iiJzvaDjw/C82DkAZEYE2lwS9UEO47XDrxWBvGnP32tVvF?= =?us-ascii?Q?YIZd6xiUvFlMNNaNlnWVXuDXjc3u5tOYdgM4i0iSosf87jNXj1taRBzKIpJD?= =?us-ascii?Q?gN3It8P/Db+8UYaY8yBO+A2L9q7iiPyJNBb8BEtEFR+vO6VKmEdkXBIbk4MX?= =?us-ascii?Q?gn9VDsZPm60jKPCKpV9/kkt6nVW6tVGRP4mLQZHu+OW+nAdG17fgS8V9NISJ?= =?us-ascii?Q?aL0DSHDFV0/Of5fSmfWHRoZLgqQ396wp0m+clNd233w9K3JgRxPNYgv0iItR?= =?us-ascii?Q?MLQ6SCVjjc0juZHUKmzGGWbfgBs79HYDKDUlHjwmcKpT2OrQY91CufgQEf3P?= =?us-ascii?Q?/XVGwgwGI6Cb5arqQhjJ3D06sfrCfkv6l0IO68w5fCNLrQgiouaN9q54S/s0?= =?us-ascii?Q?pnHKQpUhG37cx1wDwaZUJUlJ0KQ4h2u9jlonkA31jxGcVUJUJGs2VMV8kmi7?= =?us-ascii?Q?NXL5GA9TbNr/XHPJqDpCBCYY8upo7Nmzv55QQjEfxcxbWxzAhDmvr8AK7w0h?= =?us-ascii?Q?pGTSlkjxBsAhGnOSkHHeKavy0/ARg5pX+2jlSnT9V8sQj5WyIPqSLMRpSAxp?= =?us-ascii?Q?BZat6cxKWkK2uAjwkqfneNZQUBZKAMuR0dgoGs0M9LY1BgmzVxakXqW2fTU1?= =?us-ascii?Q?CqkcbA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9546d6f0-fa7e-4042-8f9b-08d9f615d5d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2022 15:13:09.0478 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dj0lh1PhsXQTeRQJWk5BemWVsYhnqLk9MGsTbw8PYgyqO3+08thmugc7m17RE77Heb/Bjz4uUiFfTvFt8+gfEPRKbj0wuabTV2HIPtr2oq0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2286 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > > > > > > >> Or have a generic library for reading LPM entries. L3fwd is= supposed > > > > > > >> to be as small as possible (it no longer is), and the real w= ork should > > > > > > >> be done by libraries to make it easier to build other applic= ations. > > > > > > > > > > > > > > I never heard users ask about such thing, > > > > > > > but if there is a demand for that, then I suppose it could be= considered. > > > > > > > CC-ing LPM/FIB maintainers to comment. > > > > > > > Though I believe it should be a subject of separate patch and= discussion > > > > > > > (I think many questions will arise - what format should be, h= ow to support > > > > > > > different types of user-data, to make it generic enough, etc.= ). > > > > > > > > > > > > Agree, it is very application specific, so it could be really d= ifficult > > > > > > to make it generic. > > > > > > > > > > But several other also have LPM tables, so why not have common co= de for other applications. > > > > > > > > > > examples/l3fwd-power/main.c > > > > > examples/ipsec-secgw/rt.c > > > > > examples/ip_fragmentation/main.c > > > > > examples/l3fwd/l3fwd_lpm.c > > > > > examples/ip_reassembly/main.c > > > > > > > > Ah yes, that's good point. > > > > All these examples (except ipsec-secgw) started as l3fwd clones, > > > > so all of them have hard-coded LPM (and EM) tables too. > > > > Yes it would be good thing to address that problem too, > > > > and have some common code (and common routes file format) for all o= f them. > > > > I don't know is that a good idea to introduce parse file function i= n LPM/FIB library > > > > itself, might be better to have something like examples/common/lpm= _parse*. > > > > Anyway, this is an extra effort, and I think no-one has time for it= in 22.03 timeframe. > > > > My suggestion would be for 22.03 go ahead with current l3fwd patche= s, > > > > then later we can consider to make it common and update other examp= les. > > > > > > I don't think this patch is urgent. > > > I suggest taking time to have common code for all examples > > > and target a merge in DPDK 22.07. > > > > Well, yes, from one perspective it not really a critical one, > > we do live with hard-coded routes inside l3fwd for nearly 10 year by no= w. > > Though l3fwd is one of mostly used examples inside DPDK and > > it is quite a pain to patch/rebuild it each time someone needs to run > > l3fwd with a different routing table. > > Merging this patch will allow people to use l3fwd for more realistic te= st > > scenarios in a painless manner. > > So I believe this patch is really helpful and should be beneficial for = the whole community. > > Looking from that perspective, I don't see why it has to be "all or not= hing" attitude here. > > Why we can't move one step at a time instead? > > That would allow to split and effort in terms of development/testing/up= streaming/etc. >=20 > When a feature is merged, there is less incentives to rework. > That's why, when a feature is not urgent, > it is better to wait for the complete work. That's true till some extent, though from other side even without further rework that patch improves situation from what we have right now. So I don't see any harm here.