From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D352BA0C4C; Tue, 5 Oct 2021 19:04:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9EF68413F2; Tue, 5 Oct 2021 19:04:42 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id CF2FA413ED for ; Tue, 5 Oct 2021 19:04:40 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="205924206" X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="205924206" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 10:04:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="477757241" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga007.jf.intel.com with ESMTP; 05 Oct 2021 10:04:28 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 5 Oct 2021 10:04:28 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 5 Oct 2021 10:04:28 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 5 Oct 2021 10:04:27 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 5 Oct 2021 10:04:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OM3haJD9fAXTQzkd2nq/Kug+m9ngiWG/plze/7vz6NVImNAU73WyT3QaSLTYur/iiTaaU6M1jclH6HXkXvIW09AyEXPA15+S1GLqhvbcWduvbq0+5Tp1BYQp/bJcMQP5jEKTo9z4T/HDkP7/NIphycbudFrZUcmchcJ/fOas6a64qg3jnygWrMjo/+yHyo+9sm1auvyF+BBO5JjoTnGUbK3e1gYQCUblsIpjVMRuh+GR/2+pHNKtndgAFN+S3Iu/HYXoot5uYfNzHmS0vPR9BFSNSBKBm6Ew7V1FaDsdHz4ee8msul/LU9kLT3CEQF2p2KFyeamu6D36gHsPMTAcjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8fmiWWQhUtkl322VjCIFF7lDiGp3Nt3qCF7USPI6pLE=; b=ZTLcOCj+rO+EksVTrxgewKwNGjKMjsvkzgR9QkatlgUT3QEnhAdwAtm5zr6JVNdf1txayE8dNXUg9tcrDFOZoj20OKFSaW4hGBxpI3SlmgyGxjJcj4RRwtbyLD+mnrjMnJ4Lt6fOjgQYLcqeArJdGnpKc58YjG7ZcPKq5yHVJNCWQ5lhUUeYLAf6pcUMuavH79MNiz59QqOCh69pmdCEOxeRODCvCAPSkbC2EFL/poYK547W3ESZ4GFVdJvboMnevG0+iPBOfyMp1irK72UQrO1/ksq7AGqJFahRJEK/Zg7NaAGf8XB39/NkpWjfPmOCks+qiY17fAPqGjAIXyjMVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8fmiWWQhUtkl322VjCIFF7lDiGp3Nt3qCF7USPI6pLE=; b=aU9D8oYVUHVVR0/VsI/a1YZ2XfvJL8gjcQf8F8DluNPZ0hluf7abkrkIGLb/KwiRfE3AzUl6s1MnYAV8gqIbGWwN9QzVX/JxxmWwo2Z8frarahkakU7xF5OGSHVLKKk1yUxY0bmpMqR1xFt4EtlcDhaMJ2o/FmorPMaEUByrJeg= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM5PR1101MB2250.namprd11.prod.outlook.com (2603:10b6:4:4d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.22; Tue, 5 Oct 2021 17:04:21 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::740e:126e:c785:c8fd]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::740e:126e:c785:c8fd%4]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021 17:04:21 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon CC: "dev@dpdk.org" , "Li, Xiaoyun" , "anoobj@marvell.com" , "jerinj@marvell.com" , "ndabilpuram@marvell.com" , "adwivedi@marvell.com" , "shepard.siegel@atomicrules.com" , "ed.czeck@atomicrules.com" , "john.miller@atomicrules.com" , "irusskikh@marvell.com" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , "rahul.lakkireddy@chelsio.com" , "hemant.agrawal@nxp.com" , "sachin.saxena@oss.nxp.com" , "Wang, Haiyue" , "Daley, John" , "hyonkim@cisco.com" , "Zhang, Qi Z" , "Wang, Xiao W" , "humin29@huawei.com" , "yisen.zhuang@huawei.com" , "oulijun@huawei.com" , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , "matan@nvidia.com" , "viacheslavo@nvidia.com" , "sthemmin@microsoft.com" , "longli@microsoft.com" , "heinrich.kuhn@corigine.com" , "kirankumark@marvell.com" , "andrew.rybchenko@oktetlabs.ru" , "mczekaj@marvell.com" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" , "maxime.coquelin@redhat.com" , "Xia, Chenbo" , "Yigit, Ferruh" , "mdr@ashroe.eu" , "Jayatheerthan, Jay" Thread-Topic: [dpdk-dev] [PATCH v4 3/7] ethdev: copy ethdev 'fast' API into separate structure Thread-Index: AQHXuSfTraQV4QP1q0+OrjZunAm11qvEYgUAgAA5v/CAAAN2AIAAAeYg Date: Tue, 5 Oct 2021 17:04:21 +0000 Message-ID: References: <20211001140255.5726-1-konstantin.ananyev@intel.com> <2386814.hQzPKX2lIG@thomas> <7042975.2VkKJPXxgV@thomas> In-Reply-To: <7042975.2VkKJPXxgV@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ecc9eb9e-e2dd-40b6-a26a-08d988222d44 x-ms-traffictypediagnostic: DM5PR1101MB2250: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3826; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LQUSqGkIGmEHwk9P256m+7+kJRyzWl0rwvo5AcitzaEOevPf40K2NcMv+3nj3PgPFe6hShyiemgaxLBrIaI1KDUssNG06DjM+GZNrTZKeiyGyFPLIYXQO63ac/x8Z28Y7r7cFsNDokukrcqAbO3oeRdj7BqBQJvP2/mbRtAotBg/Azg0qU6/jl0hQWuWzglvvC8CBkphaNQax4gAj1o6w4qesge2PhgY6eJrxzHh86PPMyTH0n63aoW3DgmFj4xtIMFkJeQ6K0OHLpFyn7VYqjGJ2KYYXQXZ62o+0tYj2IfzfL457LlV4ezYlshe4s4FLVmtnUTXnzwGvmJ9YWCs+EOqwl4rbLjl076qJhuoCvCggyFnGHx7636+ev19wpU4MVkTK9MxmnNyrvVuH1I0fl12ZND+rj//b4OD/hBdDYmiwDZ5jGIu2tkGH+i1bD8Y7ipGiAlruM/89xg3/1MOrsfq3igdiR4KvjjUXyJLwwHOsVV/RWgbIRMCuNljrrFBxRYmyHAqMPxzKtcAJr3N2wq0rmxhZpnzdLVmOCjci1EYhjvCuJRnMXJKxz0o408UEFa7Lw5YAxB0B0Us79sHrIzVtrua7wviZ23Dpg5raUxFnfCp+o8sbOwGZNkUQ5oe3uevfkq5WQMZdqS4Rml3XSJMSrgdOrCOOjuprYNhvDHRDfM12pPzez9jDY58kEqefAfFV//WLnVGnuUIEwugIQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(66476007)(186003)(7696005)(55016002)(9686003)(7416002)(7406005)(8676002)(52536014)(2906002)(508600001)(26005)(5660300002)(122000001)(55236004)(66946007)(76116006)(6506007)(86362001)(38100700002)(8936002)(6916009)(83380400001)(316002)(4326008)(107886003)(54906003)(71200400001)(33656002)(64756008)(66556008)(38070700005)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ksClDKc9Hpi3EceIAlUSTV3FGACREch+L6JthlV0xe0XUOIoFJnRwkDsUfPh?= =?us-ascii?Q?edGLXusJOMb1qX62xdHq6r8QLI4xeP6wdkS5fIGRD5zQNibhWlDqLsTsUnrr?= =?us-ascii?Q?WP6+th3s4+KRmqYg09DQ4cmQNi+nhRPxIQ0IELGXv2GzElfggjXQjTSE9wKg?= =?us-ascii?Q?XpGsLqP4Q+7a0+jbMhOtbbfEfQteD1xkZckGDyZRNZoNr5LNkbr7Y4GIbXfU?= =?us-ascii?Q?W0HlsP4/na0WrC+qx6uuVxmzXfgeFSOvebcizrnx1DmJ3yuKyLKsyOx3vFj2?= =?us-ascii?Q?ERFOpKxYk/3zvBe90YWoOIUxrLZGql9XDyAI8lGbSqdRg3SScvcNXvO6tErg?= =?us-ascii?Q?LatnQipagBG73pn/GURXdt0DWzGB++ePHgLnEk0TsaFAC6bceRawVO9AiShy?= =?us-ascii?Q?hxMcFuf9GdiWp+BgT+zKacR/pEoAby4j2e19olOolke5ZzpMVNw2umQ91zXI?= =?us-ascii?Q?rNi0/60l5m/G/d5ve8pPk7AeeVjohQx6U8ZQj17pKAwOLm+i8+EStTrab5P9?= =?us-ascii?Q?V+7QEVu/Aneq3Z8yVI+algDp6d+Z+UnYgbU89BA4dA1GmW5ZR2FDufSvon0t?= =?us-ascii?Q?4chRM+JGLNIj/Pdash9ch49z6TlirvILr36kRbbPLM5WO4QEyG6DoSbgC3Dp?= =?us-ascii?Q?6sw/gKvJ6lvihuDqG80KhM4GcC1enf+LKUOWi0shBQPTPn6Q22fMmfCRBAEX?= =?us-ascii?Q?FNU1Ia/MXyupnzyTmhfl3Zi89BdF/VGJ3U3OXLVwy0PtWyCID17LyUqifIrh?= =?us-ascii?Q?MVE9gYBUDBxG6kyw+I5SowfLffDQ2TpMLgqnGdyUt1XEj7inBedFe7ZFKEos?= =?us-ascii?Q?A/3bROx3Rg8kJWIyyG7Rs+S6/pnQs7yLXFqTlFIzMgFxX1d0RKZnG81cqUoO?= =?us-ascii?Q?kiIOrYTYpXSyOODpWfY2NXLdXW/3VClDl36wyN6YQSphmC5p8Rye1F8x9FGz?= =?us-ascii?Q?SIoeA5OJwFgpktzfDOfqSUPmoHUNGLJN+Pb+VSSiKDaYjD0Pq5o32W1d5MrL?= =?us-ascii?Q?OFEW4H6nyqFNJKj9gFM1qNpbqHGAgJh8ci7rCQ9ydk3TJiH/V0vBjpHFc4c7?= =?us-ascii?Q?ncnyUnDehqucYiuXwtVa8c9bKkx93OtmjyDfceKEZ3R+hMXQRQ4CTSDKA4+/?= =?us-ascii?Q?GSsfzaLLSaEbRf3gu2ftrxfm8J/C37A/fv1+2Aa9Wdzpq5RPBsh6v+MRcWxS?= =?us-ascii?Q?oiD+jktt4q7jMcWAWHgcMlB1UZ3kGdiOxoe5EFPTgZH6kA8jPPi4ue7T2VOs?= =?us-ascii?Q?LwhHvD1PKGK3g/yXjTJ36xHZERlADSvG57aQFOa6nkripM7r9N8l87iahYkg?= =?us-ascii?Q?+TXEUDbcMRFIaEC/qpJoy872?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ecc9eb9e-e2dd-40b6-a26a-08d988222d44 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Oct 2021 17:04:21.7905 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4RE0FhDEuQct2ABHBu6AAS5KGB+4GxVLHXJJaRl6gUJvMPt6REBk1oHRJjMS1XLN51BKXX2Xg1zjVJBwLkTx8BkAKuptI3bWUZl32lmmIco= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2250 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 3/7] ethdev: copy ethdev 'fast' API into separate structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > +struct rte_eth_fp_ops { > > > > + > > > > + /** first 64B line */ > > > > + eth_rx_burst_t rx_pkt_burst; > > > > + /**< PMD receive function. */ > > > > + eth_tx_burst_t tx_pkt_burst; > > > > + /**< PMD transmit function. */ > > > > + eth_tx_prep_t tx_pkt_prepare; > > > > + /**< PMD transmit prepare function. */ > > > > + eth_rx_queue_count_t rx_queue_count; > > > > + /**< Get the number of used RX descriptors. */ > > > > + eth_rx_descriptor_status_t rx_descriptor_status; > > > > + /**< Check the status of a Rx descriptor. */ > > > > + eth_tx_descriptor_status_t tx_descriptor_status; > > > > + /**< Check the status of a Tx descriptor. */ > > > > + uintptr_t reserved[2]; > > > > > > uintptr_t size is not fix. > > > I think you mean uint64_t. > > > > Nope, I meant 'uintptr_t' here. > > That way it fits really nicely to both 64-bit and 32-bit systems. > > For 64-bit systems we have all function pointers on first 64B line, > > and all data pointers on second 64B line. > > For 32-bit systems we have all fields within first 64B line. >=20 > OK but then the next comment is partially wrong: True. In fact, after I replied to you, just thought that might be better to have first 64B line for RX functions and data, second 64B line for TX functions and data. Will probably give it a try. Anyway, will update the comment. =20 >=20 > > > > + > > > > + /** second 64B line */ > > > > + struct rte_ethdev_qdata rxq; > > > > + struct rte_ethdev_qdata txq; > > > > + uintptr_t reserved2[4]; > > > > + > > > > +} __rte_cache_aligned; >=20 >=20