From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7C26A0C41; Tue, 19 Oct 2021 16:40:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8677F411DC; Tue, 19 Oct 2021 16:40:46 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 7ECE74119E for ; Tue, 19 Oct 2021 16:40:44 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10142"; a="227300114" X-IronPort-AV: E=Sophos;i="5.87,164,1631602800"; d="scan'208";a="227300114" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Oct 2021 07:25:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,164,1631602800"; d="scan'208";a="494121581" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 19 Oct 2021 07:25:04 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 07:25:04 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 19 Oct 2021 07:25:03 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 19 Oct 2021 07:25:03 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 19 Oct 2021 07:25:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DhrG37i89FB7F07r86iW9PEYUYacFdtJCLIJlbytZ8RRsNYIPsyyZOdVmJ0HY2ujg+pH2wBLtcCEowGeR6Jj9sOoje+61eNs1vlGYYdaeSdQja4+gCUCw65mSnjAFHyjXKpKz03xJvaqN/pv1tUkmp65q8kRA+PtaNewQEJOiFc5bBZ3svAk0XEwJbW0MyV2ah3ly4wRWTEgs3RFF8FVfR64uqBz85n17AODbIRfeoTDpVff2/3mYOFl50sL8mH2A1rHs1inOeH5eQgX+moOuAJBDIsNNxe3rDLUXQIieVBeFIIDH7zdATfeZMy92Z/Zjl8uZrXCclMspmXas3hTXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SJ9Po3vtJNSqb5rEotwKxS4rsZAzMFty9Vr8fD5QXaY=; b=jxLgjlhdIK05iFvjgH/v49IBU5lYvsrq0vxtWEm6A9sm5cp5JSL6kAJtSW8ElSzeYWxM0OrJB9uMuyVMwSeIU2CQeSUZn/VQ5S2Bp4QWRb/II5XrwY4DMjKWR/DnuEnEr7nvNXl4lvoSFQWgKcjO4aY1UncWruOZWIlHunAd0DMPe1H2IFdQ8+/dGknDXvIco+aAk6z4knUUyM89dr5osFDZPZDbjrhiHRq7VUdMUF6jWyvFEvwF7yaK7jN1NOem1yM6cseCT0knblxtCg95zFFULCoNsS1Vu6IGSFhBCp7x/2X/zfxcVUU3oMxDzCSNFFzSd565jzfo8wRbL8OFFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SJ9Po3vtJNSqb5rEotwKxS4rsZAzMFty9Vr8fD5QXaY=; b=TO0HAYL5vio1wcmfsDc+H/ZSawAhEi4QgP+RVV+JjKBTjUPfL+4bBBXrEfHc5Z3d+yeWA//5vrxPNmCDHF/PN2xaDYqGXsIVSQGdBwFv62/Cgnx93RvPhWHmNRbHQIsbiXcXVTyqb2ba6J3cKhVaa27kGPCpdrT68uJQIFrrS68= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM6PR11MB3387.namprd11.prod.outlook.com (2603:10b6:5:59::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.18; Tue, 19 Oct 2021 14:25:02 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::740e:126e:c785:c8fd]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::740e:126e:c785:c8fd%4]) with mapi id 15.20.4608.018; Tue, 19 Oct 2021 14:25:02 +0000 From: "Ananyev, Konstantin" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , Anoob Joseph , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "Zhang, Roy Fan" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , Nagadheeraj Rottela , Ankur Dwivedi , "Power, Ciara" Thread-Topic: [PATCH v3 6/7] cryptodev: update fast path APIs to use new flat array Thread-Index: AQHXxC6k4IaYb3atyUmFYPOsJpuNIqvaPoBQgAAICwCAABsm4A== Date: Tue, 19 Oct 2021 14:25:01 +0000 Message-ID: References: <20211011124309.4066491-1-gakhil@marvell.com> <20211018144201.2028022-1-gakhil@marvell.com> <20211018144201.2028022-7-gakhil@marvell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d0ee75ad-fdc2-4937-f9ef-08d9930c3d06 x-ms-traffictypediagnostic: DM6PR11MB3387: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IPrfn/+1bTO4PpbjWcAm2e3b7mqByjFkoBR8B6pCA1Pmt4b0lf274BDCnd4/Y6IHITeCBHjInVvlSCoIIGiJKI/o6AKIfrziZ6SyjREUqI8Zm0CcfgjLcq/XJCaNYtvteVXrLo78eZ7iXscXtbzEtze1pAHSCjY5Wall5ZrhRrOqLLsVS03J09dH1m4dQL/zrfYURI26o43C4lwu4pIbsDwYknraAMdHwa2rWhKbM1yjj3KAwJFhPjEU3+6xkpYTplUdYNFRr0p2de69mbQ9rDLrUKW+huVxu80wt+wlZkwIFsV5Gu/KvX0JoaRI0Ve8JakGyrGoXPkl5QpGrxbG/gfQZuhCb9MRUR4XiMDwH8NOj4i2Y5wH1Q7q8cxD0e30hrs/ljv1AVxJYeVa39XkK5GoRU0QqC3RjmVNlEP2xXUy9QL0BLRiqWC5ZulQXkJuV4qIdXfttaxNsDj9dl0/uDOcobP4KmVH2jqknu4PRcEqnMlgzdXmJxl3hYua8XabVZVijPej/ez7CVHAp944/Z473MIzVSk9WIpLT9t5TX2sQD9lBGGwEhBpcXezY1bl2wq7z76AL6xeaYVL4/qk6VuDe8ystBjE3LeRofHnklaxtmw9q+kosgA2Y75QmawJeAZtg4F/Y7LCihZEv3JxZGPPzxF36Y5bPjO5OCl2jYz0ut3sJqN++j9fjQLAA/ojCOanbmg20ytFpMzunXprkA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38100700002)(86362001)(8676002)(122000001)(4326008)(508600001)(66476007)(55236004)(26005)(5660300002)(66556008)(186003)(64756008)(71200400001)(6506007)(66446008)(66946007)(2906002)(8936002)(82960400001)(33656002)(107886003)(7696005)(9686003)(38070700005)(316002)(52536014)(76116006)(54906003)(7416002)(110136005)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MQhZrsLMIMOgpfe3tFOGT7fKbZnrwvxVt6s+CbCNLwspdytRG40RMR36hUOA?= =?us-ascii?Q?pKbPCXxaX1E/qPWbxGFgl63rvPVLv2HOoU1zmBPsR+ag/+kHHY00MyfuzQvp?= =?us-ascii?Q?St2FrHdTJwWUE2oZw3viz+b+I3S8miSAYbFBt7WL9RvPu2fect4XL8N1/PyX?= =?us-ascii?Q?uJc8PHxGKvEEdIIrf79JwQZCeBPxpCmPgcKvgdXzJTPiqlgxfcK77zNlN60Z?= =?us-ascii?Q?OhLx9UHtPgBDDcVUBypSuJOOya3sZiuBpkQ/RerrJGS206Wh7N2UbUbAYoFN?= =?us-ascii?Q?fxk687BuK0W6VsolNr7UvupQac+mY9U0ZBOPt7uTMSuxT2l7TNxX9QdLiZJV?= =?us-ascii?Q?YoEy5Pdulfr/BwHHB/A+120eHhX/f4BKywE+FtryUrh10szRArkR5cJOkg7z?= =?us-ascii?Q?hDdQ1EyFAA8ZPgighN8V8ylOPIhllmJrZxg259uAAiR7754U3FFXDh98I2Aj?= =?us-ascii?Q?ROIPeci4JQqmmV4bMJRMg3Szocpjms+N15S740oRc9P3Y8qL86CUY341sKh4?= =?us-ascii?Q?DQwZ3wTrdRvxNHH3PkjxvYxMukHTYUIKdZI+gLGhl8oe9sz1wt+9tfvB5EDf?= =?us-ascii?Q?xkHe8gR+VdqsSXKKr1UOZjoxm4f9ZyCrHISfse16+O2rREJzIEFGYpsx05z6?= =?us-ascii?Q?zasX9p896S++XUQXvJiMhppyDyZnD0mJTM3FjwxCas19bY2VjEdnShTd99TZ?= =?us-ascii?Q?M71DG77GTBSHBNrsaJ+fnQz8rsby750SXd0zrzkWn+dFhfyH2Owjgi+yYnUQ?= =?us-ascii?Q?D0PQ1v25DRCXdgMZ6Qcp4sYlhasI6b/T5Q+ufGjqpSw/0z2iK/jzFOhKEkjX?= =?us-ascii?Q?nqD/yYxoLLqlwYVD3nax6FrIy6uNQuFok3RcmHNi7QJuX40kNJsPRGzaoAcY?= =?us-ascii?Q?QhGLKeN99Bbk8EeHZ34aeSdj7NgYIYUfYSF5H17aIAupFImeFAI0QrU06NlL?= =?us-ascii?Q?KXZCUhGS+oD4vf2w5qC5InDeBaD8JjKNf2F+u5cPotb0H7cAtI8AzI4mSa82?= =?us-ascii?Q?enzLZGhyGxzYrEVOCDXC/na7gs0pjOgVIBE/BS8HuVfTLdBAKl3DuDO1+bGp?= =?us-ascii?Q?+0TW1Pwz5TDf7Fs7IAFl5o/H61WkqfueRLy5rZTrX/F63/8ae8B7erqDK/zV?= =?us-ascii?Q?w4KfxoboY7DXOrwivRWSRoi/plQe7kLpZwqQfugVii9XT1Mv/13FI+YVcJ7x?= =?us-ascii?Q?MF5NHRm6T+/OCQsR1xLZ9SLX0O2E3MG+gsCzxMMRlPlUE7GgqrqpfrhU6BW8?= =?us-ascii?Q?6sgkWStbvTBs+lwkcek76LUDTFpAv5HkW647pJ6h1dsqzW8Mmgq0j2U1UU0Q?= =?us-ascii?Q?42L6pS7QajR1jKLAcuCKnPmk?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d0ee75ad-fdc2-4937-f9ef-08d9930c3d06 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Oct 2021 14:25:02.0285 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IJ7/iXaASkFoNfM8zcHTQskPf8UBBKi9CYGIg3Ah0n5AJgg3NM7ntWqG/fsQhmQ8y+jnej40C91VKHvGqQTNIshdIEVYBrM8smDT8Wyp3GM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3387 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 6/7] cryptodev: update fast path APIs to use new flat array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" =20 > > > @@ -1832,13 +1832,18 @@ static inline uint16_t > > > rte_cryptodev_dequeue_burst(uint8_t dev_id, uint16_t qp_id, > > > struct rte_crypto_op **ops, uint16_t nb_ops) > > > { > > > - struct rte_cryptodev *dev =3D &rte_cryptodevs[dev_id]; > > > + const struct rte_crypto_fp_ops *fp_ops; > > > + void *qp; > > > > > > rte_cryptodev_trace_dequeue_burst(dev_id, qp_id, (void **)ops, > > nb_ops); > > > - nb_ops =3D (*dev->dequeue_burst) > > > - (dev->data->queue_pairs[qp_id], ops, nb_ops); > > > + > > > + fp_ops =3D &rte_crypto_fp_ops[dev_id]; > > > + qp =3D fp_ops->qp.data[qp_id]; > > > + > > > + nb_ops =3D fp_ops->dequeue_burst(qp, ops, nb_ops); > > > + > > > #ifdef RTE_CRYPTO_CALLBACKS > > > - if (unlikely(dev->deq_cbs !=3D NULL)) { > > > + if (unlikely(fp_ops->qp.deq_cb !=3D NULL)) { > > > struct rte_cryptodev_cb_rcu *list; > > > struct rte_cryptodev_cb *cb; > > > > As I ca see you decided to keep call-back related data-structs as publi= c API. > > I wonder that's to avoid extra changes with CB related code? > > Or performance reasons? > > Or probably something else? > I just wanted to avoid extra changes and it did not look that important a= t this point > Compared to other patches. > I would have done the changes if I had some more time. Understood, thanks for explanation.