From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CB15A0C4E; Tue, 2 Nov 2021 16:08:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9E5D4113A; Tue, 2 Nov 2021 16:08:44 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id C378A4068F for ; Tue, 2 Nov 2021 16:08:42 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10155"; a="211335028" X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="211335028" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 08:00:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="728376005" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 02 Nov 2021 08:00:36 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 08:00:36 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 2 Nov 2021 08:00:36 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 2 Nov 2021 08:00:36 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 2 Nov 2021 08:00:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OBzBgjQwL1cQQeLFcOeKZNLeQ27BsDfNOUXjxC6r5bd2h1R5KoCCNRfWKJ7/E95B2z5AIqdckEEQG6g2Ybs8f1Imjd81DZot7zacvvZgxMsX0yBm2sFeyt4AEPLkL0dBGj+u/lAz03Rn3gwIJG8uCZUzzUEYb2mbG8UfRviqMMcGBRR/F1uGFIvNzSDUQSAkptROYEpH9xEEfCx5AsiWbnGNt52MYzc+oApb33xtudy67M96qBw5Xb2SvC/1ecPhrllIVqHUUgiKDbb26Lh5DO/ueFP3wK7mA/nNpjVcmPsDLGqun7QE6rO7VyCqQnpwFF8OzbqHjZN3yoYDu0hTBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f1fLFwOPQ7HpJEaGwtcYmX7EekVqAAm7upK5NZP3Qcc=; b=UBYnpkXaTg+at/jmuBY47b6Xq8TRyTzKyVvP7ZFaSQc5QJlN/iT7qHH+CeDcDI292wVmHYJggMjlIB+0F4zUGmX4oq2RrxcNRFIycx9yaJHOX8YgVn+GAIVITjIMlWm9NCpDXiV5pzM/2wFaZmgb99x4MGJJ89PvFz7QJSgmUCFaBqwqhnTpRfN12q0pDYk9WVR1Mc/T1c1KZePPq46Kg/jxpdw/4983gq2zFpYRcYPZjf+UU8IbLz924GrEOCzMiYGFS01NWPsGXcdac7wDH7h+OOcEdx5LZcTYwgZhwoOhgIclgRYhWqrBobZL/uJp57PKAFjJE1izYWWpX4lPhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f1fLFwOPQ7HpJEaGwtcYmX7EekVqAAm7upK5NZP3Qcc=; b=cb1S9cBoLDjoK4zRjFn7L26xkSrhgc0dIjuP/06ZfgDgW2oFTwwx4dv9hCVDE4elEAgJb0cmNEVY/GDw2uzGrjr8xeGIWBHlDt/iZqgQ6YXBVQ0aAo2krkpKLIC5sLjSBSXgqlgvS4R5/+c7ISFTuLe9debkmSOjrHp8kQvrO4c= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM5PR11MB1753.namprd11.prod.outlook.com (2603:10b6:3:10d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.15; Tue, 2 Nov 2021 15:00:29 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::2c0c:5383:f814:3b4e]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::2c0c:5383:f814:3b4e%6]) with mapi id 15.20.4649.019; Tue, 2 Nov 2021 15:00:29 +0000 From: "Ananyev, Konstantin" To: "Richardson, Bruce" CC: Ben Magistro , "dev@dpdk.org" Thread-Topic: [dpdk-dev] Overriding rte_config.h Thread-Index: AQHXzMu96w1iPybAWkKNztL+Glx606vuybQAgAFNvBCAABNzgIAAAhtQgAAiuQCAAAUIYA== Date: Tue, 2 Nov 2021 15:00:29 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aa622efb-a585-4e12-06d7-08d99e1182fc x-ms-traffictypediagnostic: DM5PR11MB1753: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LGznESjF4vurRx0cZltIQ7f1Xtiew9wX3WDfnNcFqVr+Zr+xnS7otVpa9ORaUVNCUnTxu//ZynOevYC9rhkQA3l+CK43mXbZEPSUHmFAvo3HZjTgliyvN0yWVhUSKxul/HqZpCbZzVIN5fvS/Fx7dtp7D3y9FgtlLJZDAFNYv6IMi09jrTLpuRjjFxIyackzESw602TDYmAJ1ZYXhKkPa2xLiy9rKi6pZ/3YqgMQNN5zkF0awM5D0taAu/tWym7UZmDAXeNPcXHd4qlCX0HCpkLC1uuDQ0mvr5ttTZjeGq5vQSHcAvvFbUBCzGXm4pjP3haOZgcpcAttShYy5LhWPe1HWXUmvB+ZIupNdnd/SPyIn2GAyDUQzCf++IXEckdm7SyCd0m53f7MTokylYYhvDOmn34zN68DNqN9NEJ8Czm+/vYsuH9u9tZZDCz2oFVkQYCtXE0EG4PNKuLo/EcJjf7lNNZrdm6C8ExRBjvzezqTmWKJrefMw+e96bl/xPc49UqzNIRu624KUd580EP6ADBNOtAXqBqEKFx+Ut1nYUYy8NIKcnd0buIRQHmEKsHt0zyeNBYHa+3fHb3L4hOTOZNgaCv7btoSqS7ZQUrhCveiDNBCk9wbx0joiadAVie2ovLzwi9fyJ6uafs1DKUor84sG78gxUBqTIiP+/cYO7s+dqyHPfBDX5xy+I9BqsCjN0Cxv88QQIyevWqZqgRxQpIljN7mY1XSBi6xwKBxacxngM1msySQ07XpSOjYaWoGjK9gqE4jLKpTCuCefkEFd14aGjfQ4NpQZccFhYm85tk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8936002)(5660300002)(8676002)(33656002)(38070700005)(83380400001)(2906002)(6506007)(64756008)(26005)(66446008)(66946007)(55236004)(66476007)(82960400001)(66556008)(86362001)(9686003)(6636002)(55016002)(76116006)(54906003)(71200400001)(186003)(316002)(7696005)(122000001)(966005)(52536014)(4326008)(508600001)(6862004)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8kDVnhcxdq3LIW5eNUcGlvRnajcHAnTJVysfProeLn7FaORw1inKwA0WyC3Z?= =?us-ascii?Q?RHF3FKGEJQMDLcP5y0RTtFwxlLFYKtUEe6kYQwan9zKPXTZgteOnOxu2I/yq?= =?us-ascii?Q?adw51kCqptowMgPQo7ndsPPmOqwnwrKAprUn0j4x1AEEvwtGBcgMMXgpBXLD?= =?us-ascii?Q?J3qN2G6llUFeM94l/MVzTJgkZiVPzVrMlELkgBBaAScpqXukTwwdXpX9eru7?= =?us-ascii?Q?C85pDKNctdRmprhQvAuxROLIH23reA7Ka4iCpzcnnTqXbEP41NQOkdjfV2GV?= =?us-ascii?Q?OAR2/EzvgsUZwLB/MaLwpZkzokHCqLHfAQ8GeT9StJZ/+szmZkvPTbTOcFCG?= =?us-ascii?Q?wDYb6TOBY2T9z5wofCz+OicixvanlI2ST5fNwz8Rjq8ZveUWRSivIE+pYZ17?= =?us-ascii?Q?Dx8iGgqVB3tGkNNVzPmVYoyoWjqfE5N9WE0VmymMBUJuXtmqJYPeIrnQUVdl?= =?us-ascii?Q?Eb/HCdqlahYEWUdf49/pwbWmHLPws3QW8zgzrXbKYMxEpMhO8CiWj3CbHwJW?= =?us-ascii?Q?zsi2brVHRUQLc6lyb43u0fPhwqPb7du6Kembxk43Y4TULoaxHw/FDW/BDtq3?= =?us-ascii?Q?8C3McSqNksa96rcZgChE4kXzc5TNMC7J7IrSjMDNhG6gj/5tvxmg3051iIa0?= =?us-ascii?Q?vTzO6anE21ce4j4CTJjMkQBEzc+y/v4DylkZpR9gkwaMimH9eSwC1WkfM09i?= =?us-ascii?Q?FvpkeLuLC5032r19cfdvsATOLijgfA9Z1FKMFpFGeIVzS+LniX2NxYdyZlzc?= =?us-ascii?Q?AQia9ka8BRdyvpwt52JooQ+MarMSvzyzjAd4WRaxb9yFlPqmuFgIs7mFx2e4?= =?us-ascii?Q?v+7ipUd7bhNzZ8wd2dd/gRMChodX0ONaRJeTim1X4H7ciwxMk3EkgfCeCMsG?= =?us-ascii?Q?eDNi2J8Cy0/KLgOkhYznrgMENslyOl5IGH6dNrpUEzpq0hDo3YvwgYA94RSJ?= =?us-ascii?Q?UT5RXqbHi0xDoeDAzE5rBwpWI/70A/8zPh9aQCHm/6wlXEjPP9QTEP9HLQoh?= =?us-ascii?Q?NseqG3CY9HYtpexAMZ3ADR3RzXQq+I/s1D4UJGVEwutXVJfvwGo67Tl5VQUX?= =?us-ascii?Q?XvCqKiuJToOI/eivhm/lfqTBO/pYeHCIa41niqIqNBrg047M49IcCNcJR1PI?= =?us-ascii?Q?KlJT9JJ9hP0lj2OCkaSLdrhLmo7B+GPvgaD5n4yxcfK1vdqPHiKnOei4eK/+?= =?us-ascii?Q?A1FW/EeZJ9spYAJRf7Siscraf2nHLgB2RoqCd/MMlj3uK7RL3ET4+EPmWw60?= =?us-ascii?Q?uBwRUBCD1dQLFoYL3aLRa5h01WUu6oT2ixTAKTAZ0YWaxInzupxtm5U4LIKH?= =?us-ascii?Q?fZ+T/lUmDVVeh71zsHIl9zUVmd4DeqVyOg9kwKb0yQKzl4iT+2oKr2Fbh2vq?= =?us-ascii?Q?4F/ssTzJTcPElcrCnxDYl9dzKYV3wZYjFCSeOw26ctJgvir9Qv7xZyIkU9RK?= =?us-ascii?Q?nOdGAP2FG4iM5hdUqmALR0G/zE7nSIumCD8dVHRDfRkl5sejVNAyc3fznMIr?= =?us-ascii?Q?5NScQqg81X3HNnQuU8J0pIbfdrZdBTjbV+poqQpNsuP+BR/EoTH2gsbFwG61?= =?us-ascii?Q?yVtIxvEKeAFeu24idpcowDPiSTXCu4SVy3TDx++Gv8FTlO6Fg8wwMV8HoX5W?= =?us-ascii?Q?Qc7nfOl0jt7hCFFigRrzqM2q6qMljoKHYRhq1Hym2A0TAy4xsLCh/SdlOFtJ?= =?us-ascii?Q?xEAguQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa622efb-a585-4e12-06d7-08d99e1182fc X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2021 15:00:29.8023 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UCGmI0HU3HmYewxMVw9YOoyQNAyYyhayLlMljogltL/+GlPB7oFBVDGNcwOXymA5pa5k/i6ABlHwVT5HCXDff/Hh0y/IZ/E0be63WUjNlwM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1753 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] Overriding rte_config.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > On Fri, Oct 29, 2021 at 09:48:30AM -0400, Ben Magistro wrote: > > > > > > With the transition to meson, what is the best way to provide c= ustom values > > > > > > to parameters in rte_config.h? When using makefiles, (from mem= ory, I > > > > > > think) we used common_base as a template that was copied in as = a > > > > > > replacement for defconfig_x86.... Our current thinking is to a= pply a > > > > > > locally maintained patch so that we can track custom values eas= ier to the > > > > > > rte_config.h file unless there is another way to pass in an ove= rridden > > > > > > value. As an example, one of the values we are customizing is > > > > > > IP_FRAG_MAX_FRAG. > > > > > > > > > > > > Cheers, > > > > > > > > > > > There is no one defined way for overriding values in rte_config w= ith the > > > > > meson build system, as values there are ones that should rarely n= eed to be > > > > > overridden. If it's the case that one does need tuning, we genera= lly want > > > > > to look to either change the default so it works for everyone, or > > > > > alternatively look to replace it with a runtime option. > > > > > > > > > > In the absense of that, a locally maintained patch may be reasona= ble. To > > > > > what value do you want to change MAX_FRAG? Would it be worth cons= idering as > > > > > a newer default value in DPDK itself, since the current default i= s fairly > > > > > low? > > > > > > > > That might be an option, with IP_FRAG_MAX_FRAG=3D=3D8 it should be = able > > > > to cover common jumbo frame size (9K) pretty easily. > > > > As a drawback default reassembly table size will double. > > > > > > Maybe not. I'm not an expert in the library, but it seems the basic s= truct > > > used for tracking the packets and fragments is "struct ip_frag_pkt". = Due to > > > the other data in the struct and the linked-list overheads, the actua= l size > > > increase when doubling MAX_FRAG from 4 to 8 is only 25%. According to= gdb > > > on my debug build it goes from 192B to 256B. > > > > Ah yes, you right, struct ip_frag should fit into 16B, key seems the bi= ggest one. > > > > > > > > > Even better would be to go a step further and rework lib/ip_frag > > > > to make it configurable runtime parameter. > > > > > > > Agree. However, that's not as quick a fix as just increasing the defa= ult > > > max segs value which could be done immediately if there is consensus = on it. > > > > You mean for 21.11? > > I don't mind in principle, but would like to know other people thoughts= here. > > Another thing - we didn't announce it in advance, and it is definitely= an ABI change. >=20 > I notice from this patch you submitted that the main structure in questio= n > is being hidden[1]. Will it still be an ABI change if that patch is merge= d > in? Yes, it would unfortunately: struct rte_ip_frag_death_row still remains public. > Alternatively, should a fragment count increase be considered as part of > that change? I don't think they are really related. This patch just hides some structs that are already marked as 'internal' and not used by public API. It doesn't make any changes in the public struc= ts layout. But I suppose we can bring that question (increase of RTE_LIBRTE_IP_FRAG_MA= X_FRAG) to tomorrow TB meeting, and ask for approval. =20 > /Bruce >=20 > [1] http://patches.dpdk.org/project/dpdk/patch/20211101124915.9640-1-kons= tantin.ananyev@intel.com/