From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFF04A034F; Mon, 6 Dec 2021 13:08:39 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B50074013F; Mon, 6 Dec 2021 13:08:39 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 18E9F40040 for ; Mon, 6 Dec 2021 13:08:37 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10189"; a="300686821" X-IronPort-AV: E=Sophos;i="5.87,291,1631602800"; d="scan'208";a="300686821" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2021 04:08:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,291,1631602800"; d="scan'208";a="460811669" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga003.jf.intel.com with ESMTP; 06 Dec 2021 04:08:37 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 6 Dec 2021 04:08:36 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 6 Dec 2021 04:08:36 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 6 Dec 2021 04:08:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EJEAxWmVYMfcQb7CIN+QLamHG2/PpzCPdmdhe8PzFjpJnXhaF2mShYlb/cndYQm7sabGSS7B2gIjdoKCdPjoY9/C2kPUqXwEN2gy8VuYN5AxCnENeuhxzaNDJ5vbKpyCbjwi4/Y9jyl+O+bi0yWAsRkBbTsdkfhvvCD3nukY1HKM4jYf9c255gvM/aRN2Vf52/jMDefx3CSSRHGovIMNE56fQra8u6Zcafq2KTzlIVme+FnpRyQShWFevXeino+JuZu3ERmMtKpnf3ZlwKdnUiMKscfpUc2C/nHNajMNLAM7uGsr7ks0j8q7Q1SfBIAWTP25RKjN1lYMUeJ+ZWmA4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b414/Sj0XDiyKq0jKLpc/rspzr7x4LMVnO3YOprFrMM=; b=TsmUZNKamb81L4TPCsmn1l7vPB+C9D/0GPK96IxUfmPITGQSiLAsBtMfcqOvlmymWx81Ku9CWiyw9FPK6C0c6KiaeOZ7rZFXlBxUxfcWmKr2nGLKI0GWqy97JS3jVKUnxZgcXW6OvYvTQWgy64rZnEW5flAiVCQ6Www+OF0//gvAcq/w7IqT0n4ZC6VQZQX8uSYb1tegcglsQ/iUH1qi7m49vVSvrXjvrzsWefKIll0OVdJnD72G1dATAE6cTyW1zZNVgJFtk7HlYxWvp0xHpRnpNeLI4Hemkj83NETHllf4pZfE9wH5OvoLiEBOYwtPztsG+KClCskW/0b8MqZXWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b414/Sj0XDiyKq0jKLpc/rspzr7x4LMVnO3YOprFrMM=; b=J0p/PWOzf/LCnoTyy2s2ZRYlwXhbaOnf06wK6OhT8nVz1l0CyyMjx/BHDjj+JcZ8H0DIh4ABBf08WRjqrJ4CSwTm8w6Da0vzCB8rb+loL0/9eTaiE+hwzUue6rYTETHobGLPjJrhhqPTaP1mn5y6OOsPe5qyyPma5mZMfU4GmCw= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM5PR11MB1386.namprd11.prod.outlook.com (2603:10b6:3:11::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Mon, 6 Dec 2021 12:08:32 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::58c3:2c1c:6922:306e]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::58c3:2c1c:6922:306e%3]) with mapi id 15.20.4755.022; Mon, 6 Dec 2021 12:08:32 +0000 From: "Ananyev, Konstantin" To: "Richardson, Bruce" , Lewis Donzis CC: dev , "Wang, Yong" Subject: RE: vmxnet3 no longer functional on DPDK 21.11 Thread-Topic: vmxnet3 no longer functional on DPDK 21.11 Thread-Index: o/jjZ+CyItzPMbs7SgqJF7gIpB8YY74FEI8AgAinjoCAAHwqgIAAL+/w Date: Mon, 6 Dec 2021 12:08:32 +0000 Message-ID: References: <2134779104.413217.1638218715124.JavaMail.zimbra@donzis.com> <1909271468.2730688.1638755553311.JavaMail.zimbra@donzis.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 470d5371-7955-43a5-8ecb-08d9b8b11f72 x-ms-traffictypediagnostic: DM5PR11MB1386:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XJAxMNwyfnlNLqkmtH9lL8barkFlBHmVCK727xHgXhTVTD03z885XayWuWYK0NVLgGV7Lsi56mfSIu0uKU5AEKjlSQrRhsmo9r+jJe7KEhxdURZF6d43w2aoOXGL55sl+y8uS+VNEoM78IunDs8zdvoxNeeUcFLogEqsqIywuLFR7LxVl02dnCHrzGRtIRiX5qyUfMranmL+eJiYfDVn08eT8srnw1775+9DrM6RFZDHWxY2FpwVgFZPkx3Z+d9ahSt8AuBBUcHulU0cC8Lpm7+V89fDH2U7X/gx2GlTDrD1zeLroobAlc/y4t5gmfiMDEmhA4Cn49XVafbvCv8nAe+PCVpAkqEBcR6NTxwAmcpnlJAi/NokAvOcGQgNGxvZR2s4T5HiDit7EISf7Q4/htUQxpAfJbP+7kHFK8Rdh/sNjRx3WryblUnr+HTGv1mEHLISz3RSwkhBKw2LucM2m47//XsNA8ZpcjoSyBQpGyLI7Io5W5Rd2ZYDE251eyNAtsrMurDiuSLl7nz/u/gDUHQ74NuZpegYqhLFHCWwMF8T9K1aWkjx7Ko0NZ86a7FicdRtNGf35KY4TdljuF1cwi167A5yZzFlE1yUcUTJSzi0ETMYsS/x6IWPLRpVUk3jBUSSIuLIK6vTakVtetg1fqua6hM/itIA1hpiUJq4BmS3Na17ykSx+/jJtSuHsc/Q+rb+3NI3jqE7fORaW5/38g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38100700002)(52536014)(66946007)(66446008)(76116006)(5660300002)(122000001)(83380400001)(186003)(33656002)(7696005)(54906003)(55236004)(66556008)(66476007)(64756008)(53546011)(6506007)(38070700005)(316002)(8676002)(2906002)(55016003)(8936002)(9686003)(71200400001)(82960400001)(86362001)(4326008)(26005)(110136005)(508600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?88t5O0Ktpm8XoV/+De839Cinorg0ZHkObJTuzXCn0UGxFR6kJlY/S6azpPvh?= =?us-ascii?Q?K7cEmRbdVChNgBwS1b1EMs6VtejGDFkullL8ZLMlPsBv3utmPuhc2XDokjU2?= =?us-ascii?Q?g4mJPhgEJNZq93RkS+ZViTKSA29FWujVAmDvICa7s3KRWz/MMMQvMqGFl9m7?= =?us-ascii?Q?H0jwhyd6ooMjyCUwx8EK1oxEZVZHQ1O6QQDkt/W9hNqWTzzBpHHkksGDMt0s?= =?us-ascii?Q?RPnVlDjwMJceRO1K1+nXa2mhNzgFlkt2K301YzyCi8HJtY4J7+biFU/dd9x0?= =?us-ascii?Q?tpQylBfWgh4q6aK9KwogGu3oUDWBulMDvh73uevDlJgDpajAJW6HHeoW6e94?= =?us-ascii?Q?X8EVvpHuHnMzYb8FDGPcsvF+WWsWPnaKEx1mCcBZYShfEKHcMooh5b6RDaZH?= =?us-ascii?Q?WoeJOHvK0axzWMwOD1xyHjY49UMQP35jNACnxP8Qyxleji7jJzPLhCvfaBbQ?= =?us-ascii?Q?6WCsMiYBya35i/Z4RMH6VvRLstwuHnzPw+aO0Tamh2ckkCsUoqswYR4IanWx?= =?us-ascii?Q?jNtQsLT6As3n9rn3RBGYBlw5JYuoDOJseryI5fYhpImbKH9Gj2o3ucKmlsW+?= =?us-ascii?Q?NTlelUFSDy8XJBX1P7En2T3+yiydVUOheBisEnM3lYLcDG5hwkoBVY0vT+HN?= =?us-ascii?Q?bo4D328L9UF9y6IlFB6oa0Q51d/2Qz/Sh3XMj0jO+96wuZIxGs+mcqAPsHab?= =?us-ascii?Q?rtHe3etCT4DnCJTtT8XRzlVOVTEHeQheCgx5REb2fUyOChTJDzoIDeq8AMEa?= =?us-ascii?Q?M/GS/BzPSvYKRvbpi8+FEYr5zPzaKZwueo4gJ9QMOZBtn48cTIr5tpgewr/r?= =?us-ascii?Q?CjrG8o4xYZSzSSozELiud5ihJODh3FgO1TML7kRp2iUmfDKSppjKX0jJFuN9?= =?us-ascii?Q?q5FGiRMcMASaoPwSvOHJJAbS3uHgvDeNRp7mPg8mRJe2w6jgPod/B17jt/sb?= =?us-ascii?Q?NckVwrT4qVvixw/KS7cP/E9wTa2wbS8E0/5qpyZRWdRj47oRaqOcTBT1S/C7?= =?us-ascii?Q?Dy9mU5cMFpHC4vU01kFAgbWN9fkPSDonCLqOuJSeVVDUHtEbLjfpFYc4FS+D?= =?us-ascii?Q?6zaMEThTzX8hvXBSGq1X5lyzN96OiOKebiIsT3WwJEGECG6HcdKgdlBAqwvE?= =?us-ascii?Q?c85uw6myjACj8xnOrUXueTJNGHJnyDq4FY+g4uAQIw5eBYT4Vdae86Mrzds+?= =?us-ascii?Q?2gdJhRJE5rIg7cR+7vy04TI47eMHhcM4gD5SjV424XfhS0IB9+yhrVc2E2J/?= =?us-ascii?Q?TvnFaMSP6GR04lRDtDDKQxL5s9rusMY972p6+77jTHqJZUCOkzkqH6xdQ+Ec?= =?us-ascii?Q?DwqSjEYRvIM6kiRkw7KmSBKh8xIRWcIkXOyUg1gcRLF5mRsoi1nxJvM+9HYC?= =?us-ascii?Q?FP12HCGmRQsGk1/dw8eLLSFtS6nsNI6NaZceZqyCRwMvQExV73tfHzxEZNCJ?= =?us-ascii?Q?DKXh0lhO/x19ez/aGpPVKKUkQmBy2ZPvVhmRIh6KI5so0cao0fFPwkytq8qs?= =?us-ascii?Q?9HNnyViXHlhKjUbmDG3ifG5cFLPBKDozr/ku5UO43o8HmJ8NaoA7+NaNUqz6?= =?us-ascii?Q?1lG2gEaJtYlGMTtR6L/W8g/u0qyW6vdce66sjgNsecCRCiSfH9BHUyFg8IUH?= =?us-ascii?Q?YIIqprNH2twKbwUQHhsUNlUpBazuGNPd3XJXD7TN0mj9JTbJOMy5kLHc7LEY?= =?us-ascii?Q?6D9WOA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 470d5371-7955-43a5-8ecb-08d9b8b11f72 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2021 12:08:32.4550 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hwr7R+VShVnMidXlHhA6g1TxG5FvsXxmmt2ni5TpeXmssR8wO8g/TEXnS7LBEQUlnln978VmUrv1v9fp7R6drW4oOkZPmC7mbhnm0fKgstY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1386 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Richardson, Bruce > Sent: Monday, December 6, 2021 9:17 AM > To: Lewis Donzis > Cc: dev ; Wang, Yong ; Ananyev, Konsta= ntin > Subject: Re: vmxnet3 no longer functional on DPDK 21.11 >=20 > On Sun, Dec 05, 2021 at 07:52:33PM -0600, Lewis Donzis wrote: > > > > > > ----- On Nov 30, 2021, at 7:42 AM, Bruce Richardson bruce.richardson@in= tel.com wrote: > > > > > On Mon, Nov 29, 2021 at 02:45:15PM -0600, Lewis Donzis wrote: > > >> Hello. > > >> We just upgraded from 21.08 to 21.11 and it's rather astounding t= he > > >> number of incompatible changes in three months. Not a big deal, = just > > >> kind of a surprise, that's all. > > >> Anyway, the problem is that the vmxnet3 driver is no longer funct= ional > > >> on FreeBSD. > > >> In drivers/net/vmxnet3/vmxnet3_ethdev.c, vmxnet3_dev_start() gets= an > > >> error calling rte_intr_enable(). So it logs "interrupt enable fa= iled" > > >> and returns an error. > > >> In lib/eal/freebsd/eal_interrupts.c, rte_intr_enable() is returni= ng an > > >> error because rte_intr_dev_fd_get(intr_handle) is returning -1. > > >> I don't see how that could ever return anything other than -1 sin= ce it > > >> appears that there is no code that ever calls rte_intr_dev_fd_set= () > > >> with a value other than -1 on FreeBSD. Also weird to me is that = even > > >> if it didn't get an error, the switch statement that follows look= s like > > >> it will return an error in every case. > > >> Nonetheless, it worked in 21.08, and I can't quite see why the > > >> difference, so I must be missing something. > > >> For the moment, I just commented the "return -EIO" in vmxnet3_eth= dev.c, > > >> and it's now working again, but that's obviously not the correct > > >> solution. > > >> Can someone who's knowledgable about this mechanism perhaps expla= in a > > >> little bit about what's going on? I'll be happy to help troubles= hoot. > > >> It seems like it must be something simple, but I just don't see i= t yet. > > > > > > Hi > > > > > > if you have the chance, it would be useful if you could use "git bise= ct" to > > > identify the commit in 21.11 that broke this driver. Looking through = the > > > logs for 21.11 I can't identify any particular likely-looking commit,= so > > > bisect is likely a good way to start looking into this. > > > > > > Regards, > > > /Bruce > > > > Hi, Bruce. git bisect is very time-consuming and very cool! > > > > I went back to 21.08, about 1100 commits, and worked through the proces= s, but then I realized that I had forgotten to run ninja on one of > the steps, so I did it again. > > > > I also re-checked it after the bisect, just to make sure that c87d435a4= d79739c0cec2ed280b94b41cb908af7 is good, and > 7a0935239b9eb817c65c03554a9954ddb8ea5044 is bad. > > > > Thanks, > > lew > > >=20 > Many thanks for taking the time to do this. Adding Konstantin to thread a= s > author of the commit you identified. Konstantin, any thoughts on this > issue? Hmm, that's looks really strange to me. So to clarify, it fails at: static int vmxnet3_dev_start(struct rte_eth_dev *dev) { ... line 1695: if (rte_intr_enable(dev->intr_handle) < 0) { PMD_INIT_LOG(ERR, "interrupt enable failed"); return -EIO; }=09 Right? The strange thing here is that 7a0935239b9e doesn't change dev_start or rte_intr code in any way. All it does - change rte_eth_rx_burst/rte_eth_tx_burst and other fast-path functions. Anyway, if git blames that commit, let's try to figure out what is going on= . Unfortunately, I don't have freebsd with vmxnet3, so will need to rely on y= our help here. As the first thing can you try to run testpmd build with last good commit (= c87d435a4d79) and then testpmd build with bad commit applied and collect for both cases: - contents of 'struct rte_eth_dev' and ' rte_eth_dev->intr_handle' for your vmxnet3 port - debug log output (--log-level=3Deal,debug --log-level=3Dpmd,debug)=20 Konstantin