From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Feifei Wang <feifei.wang2@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "nd@arm.com" <nd@arm.com>,
"jerinjacobk@gmail.com" <jerinjacobk@gmail.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
mattias.ronnblom <mattias.ronnblom@ericsson.com>,
Ruifeng Wang <ruifeng.wang@arm.com>
Subject: Re: [dpdk-dev] [PATCH v7 4/5] lib/bpf: use wait event scheme for Rx/Tx iteration
Date: Thu, 28 Oct 2021 13:15:25 +0000 [thread overview]
Message-ID: <DM6PR11MB4491B9FB4EF2F9F4E680A46E9A869@DM6PR11MB4491.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211028065640.139655-5-feifei.wang2@arm.com>
> Instead of polling for cbi->use to be updated, use wait event scheme.
>
> Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> lib/bpf/bpf_pkt.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/lib/bpf/bpf_pkt.c b/lib/bpf/bpf_pkt.c
> index 6e8248f0d6..c8a1cd1eb8 100644
> --- a/lib/bpf/bpf_pkt.c
> +++ b/lib/bpf/bpf_pkt.c
> @@ -113,7 +113,7 @@ bpf_eth_cbi_unuse(struct bpf_eth_cbi *cbi)
> static void
> bpf_eth_cbi_wait(const struct bpf_eth_cbi *cbi)
> {
> - uint32_t nuse, puse;
> + uint32_t puse;
>
> /* make sure all previous loads and stores are completed */
> rte_smp_mb();
> @@ -122,11 +122,8 @@ bpf_eth_cbi_wait(const struct bpf_eth_cbi *cbi)
>
> /* in use, busy wait till current RX/TX iteration is finished */
> if ((puse & BPF_ETH_CBI_INUSE) != 0) {
> - do {
> - rte_pause();
> - rte_compiler_barrier();
> - nuse = cbi->use;
> - } while (nuse == puse);
> + rte_wait_event((uint32_t *)(uintptr_t)&cbi->use, UINT32_MAX,
> + ==, puse, __ATOMIC_RELAXED);
> }
> }
>
> --
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 2.25.1
next prev parent reply other threads:[~2021-10-28 13:15 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 5:32 [dpdk-dev] [RFC PATCH v1 0/5] add new API for wait until scheme Feifei Wang
2021-09-02 5:32 ` [dpdk-dev] [RFC PATCH v1 1/5] eal: " Feifei Wang
2021-09-02 5:32 ` [dpdk-dev] [RFC PATCH v1 2/5] eal: use wait until scheme for read pflock Feifei Wang
2021-09-02 5:32 ` [dpdk-dev] [RFC PATCH v1 3/5] eal: use wait until scheme for mcslock Feifei Wang
2021-09-02 5:32 ` [dpdk-dev] [RFC PATCH v1 4/5] lib/bpf: use wait until scheme for Rx/Tx iteration Feifei Wang
2021-09-02 5:32 ` [dpdk-dev] [RFC PATCH v1 5/5] lib/distributor: use wait until scheme Feifei Wang
2021-09-02 15:22 ` [dpdk-dev] [RFC PATCH v1 0/5] add new API for " Stephen Hemminger
2021-09-03 7:02 ` [dpdk-dev] 回复: " Feifei Wang
2021-09-23 9:58 ` [dpdk-dev] [RFC PATCH v2 0/5] add new definitions for wait scheme Feifei Wang
2021-09-23 9:58 ` [dpdk-dev] [RFC PATCH v2 1/5] eal: " Feifei Wang
2021-09-23 9:58 ` [dpdk-dev] [RFC PATCH v2 2/5] eal: use wait event for read pflock Feifei Wang
2021-09-23 9:59 ` [dpdk-dev] [RFC PATCH v2 3/5] eal: use wait event scheme for mcslock Feifei Wang
2021-09-23 9:59 ` [dpdk-dev] [RFC PATCH v2 4/5] lib/bpf: use wait event scheme for Rx/Tx iteration Feifei Wang
2021-09-24 18:07 ` Ananyev, Konstantin
2021-09-26 2:19 ` [dpdk-dev] 回复: " Feifei Wang
2021-09-23 9:59 ` [dpdk-dev] [RFC PATCH v2 5/5] lib/distributor: use wait event scheme Feifei Wang
2021-09-26 6:32 ` [dpdk-dev] [RFC PATCH v3 0/5] add new definitions for wait scheme Feifei Wang
2021-09-26 6:32 ` [dpdk-dev] [RFC PATCH v3 1/5] eal: " Feifei Wang
2021-10-07 16:18 ` Ananyev, Konstantin
2021-10-12 8:09 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-13 15:03 ` [dpdk-dev] " Ananyev, Konstantin
2021-10-13 17:00 ` Stephen Hemminger
2021-10-14 3:14 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-14 3:08 ` Feifei Wang
2021-09-26 6:32 ` [dpdk-dev] [RFC PATCH v3 2/5] eal: use wait event for read pflock Feifei Wang
2021-09-26 6:33 ` [dpdk-dev] [RFC PATCH v3 3/5] eal: use wait event scheme for mcslock Feifei Wang
2021-09-26 6:33 ` [dpdk-dev] [RFC PATCH v3 4/5] lib/bpf: use wait event scheme for Rx/Tx iteration Feifei Wang
2021-10-07 15:50 ` Ananyev, Konstantin
2021-10-07 17:40 ` Ananyev, Konstantin
2021-10-20 6:20 ` [dpdk-dev] 回复: " Feifei Wang
2021-09-26 6:33 ` [dpdk-dev] [RFC PATCH v3 5/5] lib/distributor: use wait event scheme Feifei Wang
2021-10-20 8:45 ` [dpdk-dev] [PATCH v4 0/5] add new definitions for wait scheme Feifei Wang
2021-10-20 8:45 ` [dpdk-dev] [PATCH v4 1/5] eal: " Feifei Wang
2021-10-21 16:24 ` Ananyev, Konstantin
2021-10-25 9:20 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-25 14:28 ` [dpdk-dev] " Ananyev, Konstantin
2021-10-26 1:08 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-22 0:10 ` [dpdk-dev] " Jerin Jacob
2021-10-25 9:30 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-25 9:43 ` [dpdk-dev] " Jerin Jacob
2021-10-26 1:11 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-20 8:45 ` [dpdk-dev] [PATCH v4 2/5] eal: use wait event for read pflock Feifei Wang
2021-10-20 8:45 ` [dpdk-dev] [PATCH v4 3/5] eal: use wait event scheme for mcslock Feifei Wang
2021-10-20 8:45 ` [dpdk-dev] [PATCH v4 4/5] lib/bpf: use wait event scheme for Rx/Tx iteration Feifei Wang
2021-10-20 8:45 ` [dpdk-dev] [PATCH v4 5/5] lib/distributor: use wait event scheme Feifei Wang
2021-10-26 8:01 ` [dpdk-dev] [PATCH v5 0/5] add new definitions for wait scheme Feifei Wang
2021-10-26 8:02 ` [dpdk-dev] [PATCH v5 1/5] eal: " Feifei Wang
2021-10-26 8:08 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-26 9:46 ` [dpdk-dev] " Ananyev, Konstantin
2021-10-26 9:59 ` Ananyev, Konstantin
2021-10-27 6:56 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-26 8:02 ` [dpdk-dev] [PATCH v5 2/5] eal: use wait event for read pflock Feifei Wang
2021-10-26 8:02 ` [dpdk-dev] [PATCH v5 3/5] eal: use wait event scheme for mcslock Feifei Wang
2021-10-26 8:02 ` [dpdk-dev] [PATCH v5 4/5] lib/bpf: use wait event scheme for Rx/Tx iteration Feifei Wang
2021-10-26 8:18 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-26 9:43 ` [dpdk-dev] " Ananyev, Konstantin
2021-10-26 12:56 ` Ananyev, Konstantin
2021-10-27 7:04 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-27 7:31 ` Feifei Wang
2021-10-27 14:47 ` [dpdk-dev] " Ananyev, Konstantin
2021-10-28 6:24 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-26 8:02 ` [dpdk-dev] [PATCH v5 5/5] lib/distributor: use wait event scheme Feifei Wang
2021-10-27 8:10 ` [dpdk-dev] [PATCH v6 0/4] add new definitions for wait scheme Feifei Wang
2021-10-27 8:10 ` [dpdk-dev] [PATCH v6 1/4] eal: " Feifei Wang
2021-10-27 8:10 ` [dpdk-dev] [PATCH v6 2/4] eal: use wait event for read pflock Feifei Wang
2021-10-27 8:10 ` [dpdk-dev] [PATCH v6 3/4] eal: use wait event scheme for mcslock Feifei Wang
2021-10-27 11:16 ` Mattias Rönnblom
2021-10-28 6:32 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-27 8:10 ` [dpdk-dev] [PATCH v6 4/4] lib/distributor: use wait event scheme Feifei Wang
2021-10-27 10:57 ` [dpdk-dev] [PATCH v6 0/4] add new definitions for wait scheme Jerin Jacob
2021-10-28 6:33 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-28 6:56 ` [dpdk-dev] [PATCH v7 0/5] " Feifei Wang
2021-10-28 6:56 ` [dpdk-dev] [PATCH v7 1/5] eal: " Feifei Wang
2021-10-28 7:15 ` Jerin Jacob
2021-10-28 7:40 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-28 7:51 ` [dpdk-dev] " Jerin Jacob
2021-10-28 9:27 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-28 13:14 ` [dpdk-dev] " Ananyev, Konstantin
2021-10-28 6:56 ` [dpdk-dev] [PATCH v7 2/5] eal: use wait event for read pflock Feifei Wang
2021-10-28 6:56 ` [dpdk-dev] [PATCH v7 3/5] eal: use wait event scheme for mcslock Feifei Wang
2021-10-28 7:02 ` Jerin Jacob
2021-10-28 7:14 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-28 6:56 ` [dpdk-dev] [PATCH v7 4/5] lib/bpf: use wait event scheme for Rx/Tx iteration Feifei Wang
2021-10-28 13:15 ` Ananyev, Konstantin [this message]
2021-10-28 6:56 ` [dpdk-dev] [PATCH v7 5/5] lib/distributor: use wait event scheme Feifei Wang
2021-10-29 8:20 ` [dpdk-dev] [PATCH v8 0/5] add new definitions for wait scheme Feifei Wang
2021-10-29 8:20 ` [dpdk-dev] [PATCH v8 1/5] eal: " Feifei Wang
2021-10-29 13:54 ` Jerin Jacob
2021-10-31 8:38 ` David Marchand
2021-11-01 2:29 ` [dpdk-dev] 回复: " Feifei Wang
2021-10-29 8:20 ` [dpdk-dev] [PATCH v8 2/5] eal: use wait event for read pflock Feifei Wang
2021-10-29 13:55 ` Jerin Jacob
2021-10-31 8:37 ` David Marchand
2021-10-29 8:20 ` [dpdk-dev] [PATCH v8 3/5] eal: use wait event scheme for mcslock Feifei Wang
2021-10-29 13:55 ` Jerin Jacob
2021-10-31 8:37 ` David Marchand
2021-10-29 8:20 ` [dpdk-dev] [PATCH v8 4/5] lib/bpf: use wait event scheme for Rx/Tx iteration Feifei Wang
2021-10-31 8:37 ` David Marchand
2021-10-29 8:20 ` [dpdk-dev] [PATCH v8 5/5] lib/distributor: use wait event scheme Feifei Wang
2021-10-29 13:58 ` Jerin Jacob
2021-10-31 8:38 ` David Marchand
2021-11-01 12:44 ` David Hunt
2021-11-01 6:00 ` [dpdk-dev] [PATCH v9 0/5] add new helper for wait scheme Feifei Wang
2021-11-01 6:00 ` [dpdk-dev] [PATCH v9 1/5] eal: add a new generic " Feifei Wang
2021-11-01 6:00 ` [dpdk-dev] [PATCH v9 2/5] pflock: use wait until scheme for read pflock Feifei Wang
2021-11-03 14:46 ` David Marchand
2021-11-04 1:24 ` [dpdk-dev] 回复: " Feifei Wang
2021-11-01 6:00 ` [dpdk-dev] [PATCH v9 3/5] mcslock: use wait until scheme for mcslock Feifei Wang
2021-11-01 6:00 ` [dpdk-dev] [PATCH v9 4/5] bpf: use wait until scheme for Rx/Tx iteration Feifei Wang
2021-11-01 6:00 ` [dpdk-dev] [PATCH v9 5/5] distributor: use wait until scheme Feifei Wang
2021-11-01 16:05 ` Pattan, Reshma
2021-11-02 2:00 ` [dpdk-dev] 回复: " Feifei Wang
2021-11-03 14:55 ` [dpdk-dev] [PATCH v9 0/5] add new helper for wait scheme David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4491B9FB4EF2F9F4E680A46E9A869@DM6PR11MB4491.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=feifei.wang2@arm.com \
--cc=jerinjacobk@gmail.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).