From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C42CA0C43; Tue, 16 Nov 2021 11:33:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0F2964120A; Tue, 16 Nov 2021 11:33:02 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 8765841178 for ; Tue, 16 Nov 2021 11:32:59 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10169"; a="297090125" X-IronPort-AV: E=Sophos;i="5.87,238,1631602800"; d="scan'208";a="297090125" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2021 02:32:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,238,1631602800"; d="scan'208";a="604253794" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga004.jf.intel.com with ESMTP; 16 Nov 2021 02:32:58 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 16 Nov 2021 02:32:58 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 16 Nov 2021 02:32:57 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 16 Nov 2021 02:32:57 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 16 Nov 2021 02:32:57 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LB5mLBY+UXXV/0VXkxph4/04kTijWvGiVNWcQNOJuntXCRsxUaV4XmwvubPR2duRtIkUsXGqvFdxcggkMZU8gQnEwmExD6MNHUANP2FvbV+P3ZmKjfR6YNfewAG7PxzN4tSC8B9p5K1oTUcEQksszDZyxI8kN9XeQZNqUCoNSHqHZVIMR9lWMsAchPzyMTwESJaYdKfcmvxLTGsRHVtxb2foPKyLMr7jXnB63zU58ZcZKE072Q1HwNMr8COCQLdtKvOjnIbWyyjMHt6dn22Svjw15YWFLRyuxnK74VwIPBhKYeuMxsacLFqd/hp9oCtRAWpPL9IuPmITGOSgl08LIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ma3rApabo63UhMwdtDc60KJ9SuJhEovA7tFGRWyoLQs=; b=dajaezc8zh8OBQVNYpztnzSDSuC5EjpDpk1GRrE+wzBJXSnWJg0mJ5YF/75VKT2xhrrJ+lXubPUMbA9UsHShgArKW1nkfZiyvxgnc+BRD/vrGa1twK/16mCM5JTVJ1LIDjFL827QE0Sfn94zdxoansdVkmFMOeZfhCcB5V2FfBNkaUMUCKKdoGf+MHHk65CmwvRELh/zWWc2h3y3XSfobkPzuWGS8mRA2BpswcOR6e/SKLz1Rr0KE+GFCpEy5AV9pa9InK8iji8EzFqIFj362F2UeAsAEb5ec/e+aKv1T5v/Kuc8qX+S7zauA9BXlsP+ozju+hNvkCrz9z4MY9e27Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ma3rApabo63UhMwdtDc60KJ9SuJhEovA7tFGRWyoLQs=; b=oLm4P7AqRy/4sbRalYLLXndGzBJ6gziCu4SX8uTNG8q9/B4zLiwkc7yNyfyKw2rTsBqGD5qLygffNBB+cSbrUQVug577kYzmNg6PFawegbqAbHxkUW7XLomZ1PYfdf82GOKpnuhXkflaDrmRkLxRoAeXfRgzrqZbkCeQQFNFzTM= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM6PR11MB4106.namprd11.prod.outlook.com (2603:10b6:5:19f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.27; Tue, 16 Nov 2021 10:32:56 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::2c0c:5383:f814:3b4e]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::2c0c:5383:f814:3b4e%6]) with mapi id 15.20.4690.027; Tue, 16 Nov 2021 10:32:55 +0000 From: "Ananyev, Konstantin" To: Tyler Retzlaff , "dev@dpdk.org" Subject: RE: ethdev: hide internal structures Thread-Topic: ethdev: hide internal structures Thread-Index: AQHX2oBofNbGuaICuEq8Rr8LZhage6wF8xFg Date: Tue, 16 Nov 2021 10:32:55 +0000 Message-ID: References: <20211116002440.GA17166@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> In-Reply-To: <20211116002440.GA17166@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d117825b-4e2f-479f-54cc-08d9a8ec73e5 x-ms-traffictypediagnostic: DM6PR11MB4106: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1ppzGnV/IDMLbgf1pl+0IxC7ErCwbQnevL6Lou7U7jadfqH7e9RIHJ6tcN/3MIzB27QEo2oRibgRzTCHEclJmPMm8a6cdZvq2eD5JbFFW8tYlyeqjzDszrIotnMGzPuVe9cJBvssTZvOEC4mUzycuS5JaQiasUks/xncSCmvvdarftGDlnKBl6xT0DePBFOfJ8qW2n2T7GKYx8UW0e3X/KcY23bJ+Yl30fIc+ki/7oldXoXj0/tgikIzKILHwSDE1TV9BEWWmmiqDe80897waLxHaTzXQnBKumpQN3q5HFJxCTlFjql27fIyEc2O6nGDPETX2iI5CekKQH0IbF5qsnIRVB+AJBSEbkLIVWOWr39XFdfZ86iVi2j4Y0Fn9QSwZ8qo0vsi9oJjq63r7+QxrVVerUR369mRRxvMPEPRo37r81IZ+mb3V1gGNITBDQkD0C5lpKbu1LTLolZbJySmEsh7bUzUGPRc+8ZSIfozF8J31zCKm88HG/wpbMO0PxDpGG8uJKjHdnZ/k18DJEuYi1HL/9rIT2Li2KvrllkMBkEXBsUE0NkaZoyLk/6VPWEJ9sej7+Z49aK6KHaFWB4yp5CU0WGtVRvPmcPRD/4S9g4U/5jBTx8UEuoDzW5tgPUhEzeCyXnAgt3UpMhQzTOAvw3eMd63Uxi/oTN69CDtsOfICfi2CvaXNKhPqK/EqF0T4z64iDphIX6VoOwRcj9ueg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(66556008)(508600001)(33656002)(2906002)(66946007)(76116006)(8936002)(55236004)(186003)(38070700005)(66476007)(66446008)(26005)(64756008)(110136005)(316002)(6506007)(82960400001)(122000001)(71200400001)(9686003)(52536014)(8676002)(86362001)(7696005)(38100700002)(83380400001)(5660300002)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xSnZAQNOVE5e/X2LvpBXW4pmOfwS35U8puaDV1gLGVlHLqSpwPhySUei2tlu?= =?us-ascii?Q?G+2gh5SCsO6hLoFYI/k8NfIyeZcDHpspoR5RNdWS3qd2IWGNwh/KcJaRtqut?= =?us-ascii?Q?yuTDxzGeHwPpVpdtCVpugcIZKj42MeNjCm+LujW1oVYnSw0koTIHHq8IQuhV?= =?us-ascii?Q?dEx87xsoW0oCQzLslUHpMIQVqL9TdB1ZwS6PSPPAcLOT2y5lrXm1b8vaPoN8?= =?us-ascii?Q?OQgqXA+p7BBmg2EFe0f/FLx52ybS4fHhnQBm6lOQGgGLgMc4/IgKvp/mW0Ai?= =?us-ascii?Q?9tNbvCzE7QYUbYdCZCYXMzKdDeZT+ZyGIaYuU2MT048GAVEVC6+umYeNv6br?= =?us-ascii?Q?da7ksJ6yK2WUns5kiyPfFTaGVmD1X9MThBv0Uh0dUKZDjOE8hByH/NuiyWKG?= =?us-ascii?Q?S5uS3qEdmw0IvumBwOoSoUYLzixbLHJzaiEaKozFdtQJAPtQZjcTz/aeuY5j?= =?us-ascii?Q?TQSn01W2z9m5w7W5kLuFjGHxk6aeEvs8xLKX8EXa/Nwvj4MiSlEEGawvxKIW?= =?us-ascii?Q?osVJImeTfHHwYuuaIVCwbz4L7v+4Z96MWCV0OkIsCALUtBFFYFq1Pu8CqHRd?= =?us-ascii?Q?bl/f+A+jRGMiXIuXLWU9Rx+/0XSkCRzPpCeOc7sPWC10PM0/ACFeE3orlgcF?= =?us-ascii?Q?NcyxymJQTepFZ23lhxMOyTEtcX5LUEk86bL6DafVRXnjCaMZWX4cXQUNeJEv?= =?us-ascii?Q?zMihau45ownTV3263IzFisXILv/jEHfXwlIh8hB8nJhNXi9rDX2XPQkhuq5L?= =?us-ascii?Q?1olKJhJvup6EqH02wDeUZemMShm9LJdYg8QBRPL7zf8fpwSvszXP+tjr1o1F?= =?us-ascii?Q?yh426jkZPFGX1m/fEDrx8Yo57EQv3E8WG8iBJNDDT8uSXHHpp9uUvLPHkY3i?= =?us-ascii?Q?yFz8iqJ1Ee668F2l9exaTRnJNaA1vpBg5mAOrHi+TbrwarYwN80fOjhjHQXK?= =?us-ascii?Q?oH1zxhWC1DOV4b9Xyiv8aEO/Kv5TgXtp/0pqHldRJH9Cn7NX0JI1V8y41ZIE?= =?us-ascii?Q?LT9JgtGSPXC7QwaPayNx5ePXW5w9B26+FwMrB6frLT8ZluHkZg6vT7TJEsqw?= =?us-ascii?Q?2MsiP7L0aqJhJt3X/pW/+toq/LJu6JVAyRt+oLLb6LQc6n+g8Epg2AHczAp+?= =?us-ascii?Q?n0SrpZ0fJ9bwNEKy+U6Su/PbRd2eFaZQ/utJDNxztrC5Zh0s+P93QMOQij1i?= =?us-ascii?Q?xuv2A5nUMUB828zZUrDt5e8KnjmSvlsv0J04yBfEwObNAG4PVfvQgiNmlvOH?= =?us-ascii?Q?clKTa6HVoaWMNYVES9xSbLcnnUyMoTqmsHDqZJFHk5dYl0cDVDyM6n8cahIT?= =?us-ascii?Q?RMozK1rZdnhoIvjGAXIJlohQB9jldUJPrJlIgfFIIrMn6NdueVcfI+4Q8NBS?= =?us-ascii?Q?bcH61x571KaLZZ+hB+GGgAptq8JoNH8RvzB3oeFVikCVK9SMG7x3PGcRa9Em?= =?us-ascii?Q?0vZ4/LaFDl5DhndxuN6BFqV4zHV1HfgiOaSa1B5uZ4bn9ot5ZDhvZro4Nchf?= =?us-ascii?Q?ouuES/AyfVSTXIQ388JJKQJaOiiG+9oEIkghPqn5B76YtLTcMpIQJJwBWsAv?= =?us-ascii?Q?wMJYtgCvo9kOQpsJA+u3f3xYhB9MUklL+V30i2RcmvKcrJJkyzgETpg5ImUm?= =?us-ascii?Q?+i8tr2tj8WNSkrK7gvlwiAbMthw1MjTGejXL8MxF7pD1dkZCk9S6G4hsUBeS?= =?us-ascii?Q?zEeA9g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d117825b-4e2f-479f-54cc-08d9a8ec73e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2021 10:32:55.8993 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kpC9b7ObnoRbkBuBfxBsHcPj8wkthmGqZ2aXNAg2Cc3sc0HqcyExGjhW7MTxyiq4oyhuN25DDH6ndZkJTZM0hmjAh3M1UneF4Xf4sp2ZqlM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4106 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > hi folks, >=20 > I don't understand the text of this change. would you mind explaining? >=20 > commit f9bdee267ab84fd12dc288419aba341310b6ae08 > Author: Konstantin Ananyev > Date: Wed Oct 13 14:37:04 2021 +0100 > ethdev: hide internal structures >=20 > +* ethdev: Made ``rte_eth_dev``, ``rte_eth_dev_data``, ``rte_eth_rxtx_cal= lback`` + private data structures. ``rte_eth_devices[]`` can't > be accessed directly > + by user any more. While it is an ABI breakage, this change is intended > + to be transparent for both users (no changes in user app is required) = and + PMD developers (no changes in PMD is required). >=20 >=20 > if it is an ABI break (and it is also an API break) how is it that > this change could be "transparent" to the user application? >=20 > * existing binaries will not run. (they need to be recompiled) > * existing code will not compile. (code changes are required) >=20 > in order to cope with this change an application will have to have the > code modified and will need to be re-compiled. so i don't understand how > that is transparent? =20 rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback are internal data structures that were used by public inline ethdev functions.=20 Well behaving app should not access these data structures directly. So, for well behaving app there should no changes in the code required. That what I meant by 'transparent' above. But it is still an ABI change, so yes, the app has to be re-compiled.=20 Konstantin