From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C541A0C4E; Sat, 23 Oct 2021 13:46:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ED2D64069D; Sat, 23 Oct 2021 13:46:49 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 165B440041 for ; Sat, 23 Oct 2021 13:46:47 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10145"; a="210228772" X-IronPort-AV: E=Sophos;i="5.87,175,1631602800"; d="scan'208";a="210228772" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2021 04:46:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,175,1631602800"; d="scan'208";a="553585619" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 23 Oct 2021 04:46:45 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Sat, 23 Oct 2021 04:46:45 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Sat, 23 Oct 2021 04:46:45 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Sat, 23 Oct 2021 04:46:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DYatk0C5vcirCAMzqM1eQ1sPYnrdOo/JJUY65Ut1evep4YxdRI3kNknBp7NQiHVweN4Af2lAGWzweYzbbVxZUuAmsPwEatqGUepyMgV370LJUq9yZO+O4y6eLLYIQpaQ553Jkh7tlWoaRDvf4TNnfesvIG63kXyo9tXiO1Kyi/ol9hbEKtOPjV3Hd0Rcq4XXYm2p2gZhK2jHENcvV/vtViBP4ph+OIa83R/2H67tBkP5ffhVJV6xFoC3q1qtvwU8MKhosYHemreCHDH5cM0YMLdBw3Ea1V5VfU+RyWL+3e4AzMOADg5zeqQf7VfVZwMbJVKtF4g2dky314OJzRgS1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Sis53wFD/GXHJM39TuZ2pgKad7ACGy0Kgmb5ODfn+A=; b=NiuOHptXhkNcQwkM9915H+0Oz4wDmLjF2nCpNU08HcsDEDNJyLUddNvUGDXoelM1FCRxACgeKEKNjc//FsuTtKBLsjqUF+YdmXLT1Y7bDH28cicsj05or0IPdouiJkXNzlX9Bk0aVGwH+/3BaftOlGcQSPn7WiIe1hF74QP0CXoVf75X6jjlH1dIDXqYFnhDbj3FCHi3uO1nDpC1f+dQCzsd/Ni0xmecN1N3uadKMXX5d1zr5/m0XLy0K/cq2uJaIsbtYA54pg+VXtf1Zee9SRGU0m8VR4YjAzbR8nG0WRO6CprUKitunC4nMfDHhFu1IN63IZpdRgThSv3AySy5IQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Sis53wFD/GXHJM39TuZ2pgKad7ACGy0Kgmb5ODfn+A=; b=Gl5ufyTOuMUfasF4MvhxOpzt8X7bKLc7uvSU/GNLsMYwCFGo2b1Xg4MhOG9Lq1mdK0ROn0y/72/F1Uoqq18aQLESBvyIvp3dyO49pvFyJ8vadxmcdvh2H1V/iKeNjPjd3Q9BaagjijUsRathbqGNLH5Ka9oJUHwtifna+gwcbYE= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM4PR11MB5536.namprd11.prod.outlook.com (2603:10b6:5:39b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Sat, 23 Oct 2021 11:46:44 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::2c0c:5383:f814:3b4e]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::2c0c:5383:f814:3b4e%6]) with mapi id 15.20.4628.020; Sat, 23 Oct 2021 11:46:44 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon , Bing Zhao CC: "Yigit, Ferruh" , "andrew.rybchenko@oktetlabs.ru" , "dev@dpdk.org" Thread-Topic: [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions Thread-Index: AQHXx4nV9yD7Ux+55kyOu1uLYtIAKavgQgCAgAA0zbA= Date: Sat, 23 Oct 2021 11:46:44 +0000 Message-ID: References: <20211022211407.315068-1-bingz@nvidia.com> <3239661.XpjLsnopmV@thomas> In-Reply-To: <3239661.XpjLsnopmV@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8701f8b8-facc-49fb-a56d-08d9961ac9a3 x-ms-traffictypediagnostic: DM4PR11MB5536: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QbNoUBhx+z3ngGllqI7kupCJXy/WlLA9Y5phVccHXrHR3w6Mzqbv3NV83cDxm0lcLmo/Rpj7donMK7HiFdTSxpWTe1rLUQxebQ+eF9LQ4HfyXAe7NuAtAtd+s2TOM2TRTStnZQuWWENxAa5A53p2T8RwAN9yv+fAoCjZV1AAO0HNO4A0Y1VY8wfbrBfESqHX51DIwo3xiuVFUivBN4V8nJjw6sG+bNaCfqf1Hhb+Lz6B4bpdJEuzT4g+/FYVGAftZEXd0ifGxebyMFGFKc+Fbg3q5gex/BMcG3wVSSBHkHC9/BRKl6OxSYddKTCVaG2se0fxZpTezdonrojYqAQQRlAWpPccvX3tMHuqV6yjrBVy3Qb/NkrEc5MdHv/It8j6z23Xe5kuTpPlYIfhK90FSUDF5iFFnbWL1ii+WCpmVpFC5HJOv3YNHRpI2EpieelsEoWCVyQQWha/m/np+biF8FGUu0NAIfqMM0C+mx74AvKInDAnopx2LDP/H1rOsfOwj/SNS0KDTeSglPAs6JYFF7NwvC6uJJrnWS1sYHMM4wCNrW+y1thruGduT6+BCpUy2e2MU/LH0dwJxFJLwI0+jKGW+dqrJzrmakTajykBPnP7pXT3w24n6cPKzXvt8JPEIBHTUi2s/zPrMz89VU72fElAASR7Oo7s5bOuN16RNsBVNede8kCnby12mwU98zJQRuumdDtIJx/tRJ8S8AHy5A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(316002)(122000001)(83380400001)(33656002)(71200400001)(52536014)(4326008)(55236004)(5660300002)(55016002)(53546011)(6506007)(38100700002)(86362001)(2906002)(8936002)(8676002)(82960400001)(54906003)(110136005)(7696005)(66556008)(66946007)(508600001)(66446008)(38070700005)(64756008)(66476007)(9686003)(76116006)(186003)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?LZlddUoA+ZEHUu0EPx7zHe3zDqqmy1W2gR3NwV1crgOOKvt1sFicy8nt9Kqp?= =?us-ascii?Q?m/J+OjxQywaZM9RKmgYZJRa19gH6fbj1RJati0boYXMS9krMwb7eSIswccTD?= =?us-ascii?Q?I2DsV9Dv+qwQ2jf/NukxizoMzYzr2i1Zkq3rRyeADzmNXCeoU9YOg+RgmHFM?= =?us-ascii?Q?YqoQaYBN/icxyl6SONTgbDU/zLY9zL4jz5rdkWeVpd9xWeare49Q6RgTxJdE?= =?us-ascii?Q?764EWCfozDQpyu8bvKQGe8PJC5kEVfR4s98i9381UT9gdu+5lRz73wkfS8sr?= =?us-ascii?Q?lygZTWSozbmp2807Z8PoO5GqfYtBj/yvVTRPacT47dHWO5M6TdSplokc48V6?= =?us-ascii?Q?u6xiJ1ZvvKxKZ17xBAR2NHmdQ+SO7NfWeje/w8VI1ybeVudhcFjA4QdTB7iy?= =?us-ascii?Q?PzM0a79cNOzHzVj64Hi+DZO26F/sIpWygiNdh7VowVTJ/p65SVvP4OQooUz6?= =?us-ascii?Q?h27iMvqytm5umpI0IWPP9znwWShQggkxU5Rpg2pxjSDRbI3N7I9RW3y3w3Oe?= =?us-ascii?Q?6sgyubefkeXDuUEDkprjRpfgtB73vvCv1i+bywprbS1oq6vWuWqYv7frOr59?= =?us-ascii?Q?hlRssPUTtv0kK2B2XKzZJ1FIerJl6VmmLHunbZ4gar8rQ9jD37BATmKynLGS?= =?us-ascii?Q?xyUF6a53MN1OEBaeSqkrNMuMjoA5T6FADg+7YK+imbhCxsLyk3msDAKr0AYa?= =?us-ascii?Q?/s1T36uS8+ckzbtB6qUwsSmxhgATfn4/2p5PrW2Kf/4EjCsJf4aUd0uodW3/?= =?us-ascii?Q?n0upPC9hUBaUJF+25EiUALN65iNL+y5ye6WijHyTWoFQqy/NJ1BFJ+8DOGle?= =?us-ascii?Q?KvNjcenDaVqt5HJsqBcQ0UH5rjI9OxIstho6R6heNvj4ezK9A0XKevmTj9l7?= =?us-ascii?Q?j6yz3XbZQhp7kkRLcb883nY06WTww7O4kgppVadIjkVuEYuitZZ1NaoDjLZ1?= =?us-ascii?Q?Wzu98xjAmrex7BqPpneddfF6yDBr5VJ+lJeNkX+teMMtF5STK50rDaqRbmbf?= =?us-ascii?Q?M985rf3B/prnNqIgBuO3B0JX+6X+ewGGHkzGLBV3xH7in5MEPIrw2z0MmaDW?= =?us-ascii?Q?giqUL+ZbOLWE5z37esGvDb79jQ5AJKe7a5XYM6aACu/TTW66xF6/6lDXsLYX?= =?us-ascii?Q?wnBVOJ3ZUDZHRR9D1lRasFHk8HZv0BUytcrkVqy2LkYNNbUbjY1iKXovvhZ9?= =?us-ascii?Q?iciCJ3TQ5P0/nlntOICA0m2fySgNmf63oI7eGqQqQlu3yCVdqkikRdhJ5viR?= =?us-ascii?Q?W7WsR567+3glwar9CMpIcrksYQc+n7BZCcZza/UX0dSTJ19nTk9k4iSBztLg?= =?us-ascii?Q?IglK1nYKcbu6roEesKm6txL0T/xo2r7n2xhBQ4SF5WdjJQgup65tqYC0tqIh?= =?us-ascii?Q?fmae3RvDlFkGmUat7NChjtNfbFX05sKwoIyyDEXIILOgVzXLM+jT/50F+oqZ?= =?us-ascii?Q?0i3+qGdmuEFkBk+L8bG2JGuFVc2rMBAn7PkVtbMUWgIVjxnYMzfldZlGmVK1?= =?us-ascii?Q?PozC4oWF7hD9fjCF5ygBS15DwoLMGRnH7ccaloyEJw8z6qMUkdhHGDIeZVtD?= =?us-ascii?Q?ujmm2VfHMgDj4Chfn0r+qmfskFxAnWfVPv3lHRzQwt5uORScT92FFmLKA3kl?= =?us-ascii?Q?DqqD+YM9LkQdMc/Wrq+/cwVoi9YRVLLOJqjZMUxe7TogQ4Rqjx6kpiP4W1lR?= =?us-ascii?Q?pfITBw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8701f8b8-facc-49fb-a56d-08d9961ac9a3 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2021 11:46:44.4248 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8UI+avhLYtNP5uumQYx4uzapdwI57GtYben47P9PfO/0mPtpwRBX0NsFSJvnoygQTQ3g6H2xod3Lya1bPkVHbt7rSJMa4MgMBjyx9D9SpR4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5536 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Saturday, October 23, 2021 9:33 AM > To: Bing Zhao > Cc: Yigit, Ferruh ; andrew.rybchenko@oktetlabs.ru= ; dev@dpdk.org; Ananyev, Konstantin > > Subject: Re: [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functio= ns >=20 > 22/10/2021 23:14, Bing Zhao: > > When stopping a port, the data path Tx and Rx burst functions should > > be stopped firstly conventionally. Then the dummy functions are used > > to replace the callback functions provided by the PMD. > > > > When the application stops a port without or before stopping the data > > path handling.=20 If the application really does that, then it is a severe bug in the applica= tion, then needs to be fixed ASAP.=20 > The dummy functions may be invoked heavily and a lot > > of logs in these dummy functions will result in a flood. >=20 > Why does it happen? We should not use a stopped port. > Is it a problem of core synchronization? >=20 > > Debug level log should be enough instead of the error level. >=20 >=20 Dummy function is supposed to be set only when device is not able to do RX/= TX properly (not attached, or attached but not configured, or attached and configured, = but not started). Obviously if app calls rx/tx_burst for such port it is a major issue, that = should be flagged immediately. So I believe having ERR level here makes a perfect sense here.