From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C10BDA0C43; Thu, 23 Sep 2021 14:44:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46E6A41260; Thu, 23 Sep 2021 14:44:11 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 470AA41257 for ; Thu, 23 Sep 2021 14:44:08 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10115"; a="220633443" X-IronPort-AV: E=Sophos;i="5.85,316,1624345200"; d="scan'208";a="220633443" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2021 05:44:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,316,1624345200"; d="scan'208";a="484980801" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 23 Sep 2021 05:44:00 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 23 Sep 2021 05:44:00 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 23 Sep 2021 05:43:59 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 23 Sep 2021 05:43:59 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 23 Sep 2021 05:43:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hX4n7KOmsYvwFUA2JswfgPPIHeqLoYUrORb3dlX2nr79CbO+BCkW7dTmHPD6B2p7Z2nOOn27ZRVAWwqBLRd/fQoo+EM9skCjhoenRhNpsmXfmNAXRnQ29BS9Hqts0MgswPzbt7bA8RtcUoiT28udNr22Lds6o+1ET1GZavWTf3knalAg4Mw1JLS5+siWyq3Tj1h9DxAyjMQ2VZWTl41NS8rQ6YfmI2cCcILcZBeh8a5y0PE5hiwy8634TH7dJfKNnvEKC8DmW3hIq7wB5DFAU4WhfAHE4GRqIRtDFbqYAmIXZEr5ARcrXwTMMKUiB1fk3IDgihlI8NNEEHyd9eEMhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=9JVo18TQ9rWPs5mRFiaT7NL+KO7hlxJPopS5w18T9Rs=; b=Vh8T+LDn3OxPY5+5ib/V0/fYZx4QcdGa/0ehRJxTGNwp/G9Nyv4MjfBk2UQfc54Ivokck8tEV9Jyf49kNk7vqSEI6s58uUl6lRW4MbyyvzcIzSA0ED/6E+3LcBIVwZNT/SfneKh1O1GV3A7Zjjqb/M486n19pBXUE27oMkhHvCJ/o1a4uFDY3eWDYVRZewuVZ0IB6fvOlgA36kMIOIM34AbguYuIx4Kf0Owen/4evpUkGxOBsrkIlil+8w5R3gr3elPY9IlPK+Sw9KeQYfQ7OW4y9NgIzivuRn/8SiPC/HrOsFUVrrFdF3/GOaDYB4miPdg68nH1+inc5I0JHCyHjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9JVo18TQ9rWPs5mRFiaT7NL+KO7hlxJPopS5w18T9Rs=; b=C93ynlfHiprkBcZkcL0pUQkawtqNxTWsP6C2EQogaaHBPUyhuTDQ4610I40oV/iFuZIH0GUdnA9lBBJzRoYhOZyG6CYW2VsxgFneLqb70TD1XzBXb8c9bx2UKktPZOZCdlsMz7ypfxfdvkUW6vcgLKD1ADi5/NRPwPM9K19LnnQ= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM5PR11MB1625.namprd11.prod.outlook.com (2603:10b6:4:b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.17; Thu, 23 Sep 2021 12:43:47 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::740e:126e:c785:c8fd]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::740e:126e:c785:c8fd%4]) with mapi id 15.20.4544.015; Thu, 23 Sep 2021 12:43:47 +0000 From: "Ananyev, Konstantin" To: "Nicolau, Radu" , Akhil Goyal , "Doherty, Declan" CC: "dev@dpdk.org" , "mdr@ashroe.eu" , "Medvedkin, Vladimir" , "Richardson, Bruce" , "Zhang, Roy Fan" , "hemant.agrawal@nxp.com" , "anoobj@marvell.com" , "Sinha, Abhijit" , "Buckley, Daniel M" , "marchana@marvell.com" , "ktejasree@marvell.com" , "matan@nvidia.com" Thread-Topic: [PATCH v6 02/10] security: add UDP params for IPsec NAT-T Thread-Index: AQHXq6YLkgTIcUlOakaASMqQCEKEJquxmDDg Date: Thu, 23 Sep 2021 12:43:47 +0000 Message-ID: References: <20210713133542.3550525-1-radu.nicolau@intel.com> <20210917091747.1528262-1-radu.nicolau@intel.com> <20210917091747.1528262-3-radu.nicolau@intel.com> In-Reply-To: <20210917091747.1528262-3-radu.nicolau@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5f9e1671-2bba-4565-a75b-08d97e8fc9bd x-ms-traffictypediagnostic: DM5PR11MB1625: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: osxNlsXDLUBckRRJD3GLtuLCLBC7JnHWEfvOh+Knme1AJXmF0hi0fZJrnhA+auZaqo47c2owhEC3dMUGMo/9F/hUpIIUysCCGAQEqXbQDarUOmoAAPnrhtHYUT8O/2VZ6LpuouwfE7cw5nogUjIlaCb2qHf8qLJmbJmS6lHvg1eut9OoWX2g8B8/PCcBkQdxtU5BQ/6gaBBBhZCYlhGkZFwFBBt3sihyIB6sXSW7ire6x+7bJgMyYGp1sJiptLec/DN0azfaWYJJh7AuqWiUUDqYuAF/9rr8dDtyqQ9rBpUbjZ23fUKKGTBda4TjHadtA6uUCasrC/WVNa+TmkE6Tvmxtq4hH3xMe7NtxiJFF9oX5xxs8hIhx2bAxuICsdmmh7LxIvd2xRZnsv29hRglS5undMeydre/doxZcBfJMWHFrfe7Ic9hGbm3hbERGIXOd/380Q82QIR0uVKw7Se4NVyhiAw7M/srss4kyuQ26mKX+vX+X81PF7mxSRFVZghJHxhF1V/T/BE1vCRSvkkQhdUbj7yeG2K6PEfpyfzfq7+0IP4y511RKPgvLMxlXwijEDcp9E8c/ZHemgWWfIQeJn7WGE8Q+alKnnxTdEtAftxGWJ1i2knKkI+0Vh9HIOOzeafPfaNKpe9H7AUeapgji5yWLqE4VpIwDAz2EeWDXGGgahJiTVRbOwqGFt1C02b7s5nTx6fN97BYs52zKvCA4w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(508600001)(26005)(122000001)(55016002)(186003)(38100700002)(38070700005)(15650500001)(2906002)(9686003)(33656002)(6636002)(6506007)(55236004)(86362001)(4326008)(7696005)(83380400001)(316002)(8936002)(52536014)(8676002)(5660300002)(76116006)(66946007)(66476007)(66556008)(54906003)(110136005)(71200400001)(64756008)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2AyJ/pq7FQqAKCYTa+FPTCiq9sIKLp+8MynmKS50IJVGMkKqTk2EUJDZSMuH?= =?us-ascii?Q?C7O7UTVjwf+Uruw0bUu0yWdTQ+YN7BR0baYQb5/p68KEW2KSyyuS4xJXfWzf?= =?us-ascii?Q?CGjy747d69FthIyA6ez/25sfbvpQW8L1p69rFyAuOgVVhDElk2+fEfmqrPqF?= =?us-ascii?Q?3oflQo+cR+WKKh9ZgJxD1WpNTLms+EJ5VYWVMIYCD73Jr1KlNPMFOF5wqPFm?= =?us-ascii?Q?hbiy2NVNokqmCAAdR3PCap8zB4Cn1+wObMMSYP7OtTabWYuDfTMBPARc7HMm?= =?us-ascii?Q?ognhp/OP4iLt6BvOJ/k6VuR5WGr2pgqs8hE0yyR5HXm4IIrX/mM44Z5G0SxC?= =?us-ascii?Q?qKnycLqyoykKUPZ1jvQcpQN1XJvEjqhqJPx8oNI7RdhWZ2KdI7NUAluFzDjI?= =?us-ascii?Q?UJ1i7EulVlTIGN3OnVlertyxtFjiE3V5A3R9W13XfVy+E48UW/fFf+QeWVz4?= =?us-ascii?Q?CU7xKVfgK2pyROVgKqLPcilZ9qvIRGICkrGmTX5qSW00GEvsgiESw+GKmHJj?= =?us-ascii?Q?DWSWjm6cSGntlD+g+jHhKIAL5Uyvo5C7+2I3OArfyWgebyDzG03cx7uKOyJg?= =?us-ascii?Q?qIRvx4I8UaAMUFAa1LCZbcbLyT2fHFLZToWIqLHteds/wWeMBiq2WQrvK475?= =?us-ascii?Q?7WkYPWzHIpht/XW5mH6Pc1PEu4ssZRKt4B+VoVFlyupsB6KYj0I85qzucSWt?= =?us-ascii?Q?GlHSjyErUDJLk85e2ho0MFsgips98+MOKVq/pgnMXpVNHJ1WbHzKAmy20Emh?= =?us-ascii?Q?1JPnup59pgEvnkt2OO1jh5eXIPrqlU+zYXkUbISAN8klpkPIN27otfYMFKeC?= =?us-ascii?Q?g0SaWf0CNgPrUJ4RuXOjrOjzDOhPIJLSnuKCeiQajhcDj5R14botBfI+vVgq?= =?us-ascii?Q?FUl+alnn3C0wdeSGJBejgZpOKO5nx40q5/g6AtovYO/PLXUENvDQEiiAyjPw?= =?us-ascii?Q?gxExdbrc5fapodtyXgeO6Zaqh1OPWGzjuUwkT3/MKjO8wEnalQIbFUsYhfl4?= =?us-ascii?Q?WvoyIgmYsNuxijG0Gy6rddbUnYVimIfmMUC8csGWGCQ1caWbspWlcOcEb/zX?= =?us-ascii?Q?mTOTmjJypWxyKBVn2UH4j0BjcDv+PM1tsV3YOEXw+UrPJVzAZSnSP+C0XDW4?= =?us-ascii?Q?dYDSIICXNBJoHy6X0v27BGAcG9wFo5dKfwsCLsvUnhqr/rRuet1BwSSmA4Ui?= =?us-ascii?Q?ZKCjnVKhpO/+YV/n+6I6X79WIz6swWZtJn2bFqAo9xm697CEjr8RwD/fh/pu?= =?us-ascii?Q?d5znZOghY3oxkOIkDZra7ZBxLJwucJL+y+PKI2QrCRfKc4jlme5uMcvv5snn?= =?us-ascii?Q?UqvE43+0XrgX+QOUYAltFI0i?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f9e1671-2bba-4565-a75b-08d97e8fc9bd X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2021 12:43:47.8269 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hNpHfOqdvITdxtaH0AUx5dI1tzW9zffVMonufi7Mubhw9nH1pPW26izYihAJO+dNIuMKnuZvq34SzRuW4d20Ld2CQ6mh8LBb3upLRTbye74= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1625 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 02/10] security: add UDP params for IPsec NAT-T X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Add support for specifying UDP port params for UDP encapsulation option. > RFC3948 section-2.1 does not enforce using specific the UDP ports for > UDP-Encapsulated ESP Header >=20 > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nicolau > Signed-off-by: Abhijit Sinha > Signed-off-by: Daniel Martin Buckley > Acked-by: Fan Zhang > --- > lib/security/rte_security.h | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h > index 495a228915..84ba1b08f8 100644 > --- a/lib/security/rte_security.h > +++ b/lib/security/rte_security.h > @@ -112,6 +112,12 @@ struct rte_security_ipsec_tunnel_param { > }; > }; >=20 > +struct rte_security_ipsec_udp_param { > + > + uint16_t sport; > + uint16_t dport; > +}; Would it be worth to have ability to access 32-bits at once. Something like: union rte_security_ipsec_udp_param { uint32_t raw; struct { uint16_t sport, dport; }; }; ? > + > /** > * IPsec Security Association option flags > */ > @@ -224,6 +230,8 @@ struct rte_security_ipsec_xform { > /**< IPsec SA Mode - transport/tunnel */ > struct rte_security_ipsec_tunnel_param tunnel; > /**< Tunnel parameters, NULL for transport mode */ > + struct rte_security_ipsec_udp_param udp; > + /**< UDP parameters, ignored when udp_encap option not specified */ Any reason to insert it into the middle of the xform struct? Why not to the end? > uint64_t esn_soft_limit; > /**< ESN for which the overflow event need to be raised */ > uint32_t replay_win_sz; > -- > 2.25.1