From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3035AA0C43; Fri, 15 Oct 2021 20:39:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC0AB40041; Fri, 15 Oct 2021 20:39:00 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 627154003C for ; Fri, 15 Oct 2021 20:38:59 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10138"; a="314164289" X-IronPort-AV: E=Sophos;i="5.85,376,1624345200"; d="scan'208";a="314164289" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 11:38:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,376,1624345200"; d="scan'208";a="716615660" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 15 Oct 2021 11:38:57 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 15 Oct 2021 11:38:57 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 15 Oct 2021 11:38:57 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 15 Oct 2021 11:38:57 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 15 Oct 2021 11:38:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=atyRxiNtMAmuL1R2jiPDFodrFxhkHKXd6hnCbHW6Qx9vIgt1k+AkurkZhBEOPieWw7Gzw5pAlNEUMLhAgIuZtm6OFiGHjePSZF/zkKF73JJ/0BxM4knRO9Xo6pc807qntAkZ4tj5s7eqi/6pWHP/sk3N9GLKq7TZSLOSuwUR4hOxUjoelqJwgvktrhLmvfSjqjpam8wFlhSXNnnPv7h2QVZ+0KLxOdppDEWIvHWMxA6aS2VCiKT7XZPr83KyUhFtwI8d7WEFKqajhvloOEMs/5bxaRMSNS0tQr9fGArQsfZ6sfGH0/XAin/uuolP8HmbCAEKRSht6EvTE8oC0wZEkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GYyPMHOFmgoiL4R9eTlHs1DRQi6euSxZmNmgWWJN8xk=; b=G+T1duzlr4HiFdBgJzwpUXXfKlW9VkHcoHK9X1SrfnhI4fePW/cNSNA29KfVFLWGG+SUe++zb9fWpI8qhaacLfAQfvN+M1ccyAmTs14lm+eWDx1uneF3MWwmueRSHk9ehxYRnuXA+nQlvBydmaM9iBL0Db5U/quJ6LFnkQ32F1o/GqHGcsmcrbWR1RtMRooc4sqiLUIIi4OfIkvKleIQ9xgY/l4Q8rdVIJCBbYxzEyuiC3pQjcXxcIyhDm/zo3+zZGWHT4MFd8hSY+151o3BfCuQFd7ZCmVTM65tWfnv/xXIUjlpCuPXF+6O0yGo2oAzKJB1SuvKhPqWvHY/hzSnkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GYyPMHOFmgoiL4R9eTlHs1DRQi6euSxZmNmgWWJN8xk=; b=BJdgXMrcP8BVFN7EpfQMWMT4nCn6/vSjsJtkip3Jk1/S3g6kv/pyxFn4t2CXV/X2FSCsNP6bLPk//LRtO6ahgui11r1DjTKqOixbVxOoZ9eF8HR/Ut7l1VnHaEaaTBE/BalDlcMVFApucnMDGu3CMzW1fqEAs1sOIErrQKEkZ+g= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM5PR11MB1290.namprd11.prod.outlook.com (2603:10b6:3:c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Fri, 15 Oct 2021 18:38:55 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::740e:126e:c785:c8fd]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::740e:126e:c785:c8fd%4]) with mapi id 15.20.4608.017; Fri, 15 Oct 2021 18:38:55 +0000 From: "Ananyev, Konstantin" To: Akhil Goyal , "dev@dpdk.org" CC: "thomas@monjalon.net" , "david.marchand@redhat.com" , "hemant.agrawal@nxp.com" , "anoobj@marvell.com" , "De Lara Guarch, Pablo" , "Trahe, Fiona" , "Doherty, Declan" , "matan@nvidia.com" , "g.singh@nxp.com" , "Zhang, Roy Fan" , "jianjay.zhou@huawei.com" , "asomalap@amd.com" , "ruifeng.wang@arm.com" , "Nicolau, Radu" , "ajit.khaparde@broadcom.com" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , "Power, Ciara" Thread-Topic: [PATCH v2 0/5] cryptodev: hide internal structures Thread-Index: AQHXvp2i+ByViO7bvUGDTOio7NBIoqvUaYCg Date: Fri, 15 Oct 2021 18:38:55 +0000 Message-ID: References: <20210829125139.2173235-1-gakhil@marvell.com> <20211011124309.4066491-1-gakhil@marvell.com> In-Reply-To: <20211011124309.4066491-1-gakhil@marvell.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 14ab481c-918a-4d1d-5d41-08d9900b0b29 x-ms-traffictypediagnostic: DM5PR11MB1290: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +yBf3oh1T7+Z1g/FJJY5utfo+qMJj4bgdHsn196KPFZ1WoZfAIxP/tUBmOIzfefHH4nm3Gkmkye50rOSghBFNyeKTJ+zMDnuACUumkRKmIPkPG4Mtx67IlXOgmWFFZMDsdeUpW4IB4g1gJmA2Yv9l0cFTI66ZPgmGBmx8Pi7rX8SJPXUnQwTb5X9MsZuYOBs5fMEq5CeVXuk7h8a5IBWWheCBNDkn5FFVNnFCcMCe+DUfc+jDSktx4SfJbcxAHUfBL30N0ULaqdBffKECuoHc72jH68BxO6YBUcEzuX/2iMXZjj5iDMydI0Y3HeOxi95mBcKq2sB5aTqwdvKXgQjOgv+RFaqYVvKGtQSJr77CSrnJzIy1oOYlnFc25/Lau1XbvUSK1RbvabE0k42ngJGuS5m7+a2qIDFPrmJBJ0CZGHWxKeVXjhzFPX+MkGO+D6l9NRToWRSuHfzdFp7pj/THyvE2qHLw/WtC0TBldTvUcCh9yZ1l04fWegJhYl8ZObev5jSAZtNsn8U+eox2dw3hX8YfFl1jaWMnmgZCyNEbVQVlkMbZ546aMG5G8OXHSzZ0/1dKzyDR/ITdVitfLPQhxldrqHL+r3RlrGSVarTaE4iRUqMqFLPl+kCRAfJndYOYV3mZp6GHgq7IH0EaJ+0I4M1h547EvcOc5D0N+k5bIHCKw8wBUEDEkbLw/r0TM5tY0zEl7DuAwIUHVuWuCL2mhWju6nidSHIKZuNoE9zUmgPp76K9nK1E/Vx9FLwZUFv/9NwUH32NiwXq5Zb+QdGHGAtY62YsqjRs8cSSdnsiF1Wyv+ci2TUVSUlRLPWd8airbHtmThkQPZjUCQ4Wk/Jbw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(71200400001)(2906002)(86362001)(110136005)(66446008)(4326008)(66556008)(55016002)(64756008)(38100700002)(76116006)(9686003)(38070700005)(54906003)(66946007)(82960400001)(66476007)(7696005)(966005)(107886003)(316002)(8676002)(52536014)(508600001)(6506007)(83380400001)(8936002)(122000001)(26005)(55236004)(186003)(33656002)(5660300002)(7416002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vT5Fsms5dEcH8lu5fwRcY3kjVe7QV4Fd3Yjb9VnCowtKpM76r67fmN7jLhqC?= =?us-ascii?Q?rwflYQ0LU8dqHB2KjDgtlFIFjQcmghWF7xS50gTew5NcgtyU1pFv3juqGh50?= =?us-ascii?Q?vpROblhjyxXthZPDEzyTAsvLkH6R0aLNe3UxwXQQYGAk8avQmU8ixHI4kaSN?= =?us-ascii?Q?wKvd3gCGU3MkgsFHmnmoPYm3ruLg5jynKKDNW/892KUrZmJ1RxJ6ycEVIjtD?= =?us-ascii?Q?ZOZvJu/8CBxWts1D1E5Axta73LXbNYYYnlMeZzP1Of5KKpAxTqhBAOEd5ZJz?= =?us-ascii?Q?5YdBihq0h2BX+Z4IaQjijuil2y2vyJCNzxSLoLSZrSaR0JAg0ICHphrPaeKQ?= =?us-ascii?Q?sZFQIFO9fbJ6/VjwP1UvFVM9m1irrTGgZ7B5Z6XE4BD8DlbBYS+whBIC1F/I?= =?us-ascii?Q?coLjzBu4RUR4dLtJCVs4PQvZC/2qIgduUcQXECSxVyXaThwwXtpIbtsqTQDd?= =?us-ascii?Q?78O790jdgqVOCTpZyKjLOSZtwt/0rC/iU/w2DLokT3gRMPHWZvNfJmNOC8Qj?= =?us-ascii?Q?D9seE9sBPFWhfhM4KRie3n+lb8wYszxnlI7lhurgZ4olFCXEqKf7xLMwqEMt?= =?us-ascii?Q?u+v68L9S8pTzttITXPy90aK6daUH+KkieMSChRlUAOl+CV/quOtgj9rzg9dg?= =?us-ascii?Q?eyLCualB511fs6nzwNW3IFNRHvneJfbpWttkgWF6Ja/bt098co/n7P30H1ri?= =?us-ascii?Q?KTF8oUNN9RJr5FxziUxoqsBbqzrhnJBwB5DKoXZbmS12TxKPk1C95Y/ptpgC?= =?us-ascii?Q?Ezc9ZeyaPxuymCkPI2Cs36Q+aFiFrthzkXAwJiOEBHrMr/Ws5xoLzRc9TZtZ?= =?us-ascii?Q?HjBD7jegzM8Tu8CbhmldUN6NLDv4IfqAK8jFph1dKTj9aCQoLi0Q1eoUfcXC?= =?us-ascii?Q?i2sg07jC1gnyt96nTiAObfwgBLjrazVEzJz8w8iQE58C3R6TqiS+ft9b4vkq?= =?us-ascii?Q?rTMRF1fpa7Dg6QQK1OjhjAhCusuhYh/cYtDXPy9zsd3gjSrhJymIo8X/gHqA?= =?us-ascii?Q?wYtXhOlfq0Awbkf/dIh/VdjCs3z4b26XX+R5Fc6Pam4HkDhADw6cjmJHoZ1n?= =?us-ascii?Q?G+KCIq+q/a02DYYWhIxBD+PLgTH7VzXXbJRursPse+jIwXRv+1x1rYGgnFwa?= =?us-ascii?Q?/ovxEkT7hg1PJj4IBoTf6+7XGT6acYVT1lAh6uDBXDl+VLdZomd3lr2i/UkO?= =?us-ascii?Q?iGccRB/z3P5e3PNXRwGea1Dq3Xz7hHaJg73RrikKeQwMJVv7vN5WChoxvAvS?= =?us-ascii?Q?wqDMxeWYxDQehSNKGjKD6TnNS7whsSUpPU6G83FWD4M65OASx04bZyn1zQrs?= =?us-ascii?Q?L1OzsvlVggj8gLK716koYYvi?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14ab481c-918a-4d1d-5d41-08d9900b0b29 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2021 18:38:55.4616 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xBL5gIwoCCc8SUl6doLoQwpVuczIKK/cXiPaRiehktbRIJVyL6P9Id/a2MCFYwMeZMvEKoZhn3+0QhiSoSJZBjF7navxM9m1HBIHFHY/eCQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1290 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 0/5] cryptodev: hide internal structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, > Structures rte_cryptodev and rte_cryptodev_data are not > supposed to be directly used by the application. These > are made public as they are used by inline datapath > public APIs. > This patchset, creates a new rte_cryptodev_core.h file > which helps in defining a data structure to hold datapath > APIs in a flat array based on the device identifier which > is filled by the PMD. >=20 > Similar series for ethdev and eventdev are also floated on ML. > https://patchwork.dpdk.org/project/dpdk/list/?series=3D19428 > https://patchwork.dpdk.org/project/dpdk/list/?series=3D19405 >=20 > changes in v2: align with the latest versions of above series. Just to let you know this patch set causes to seg-fault ipsec-secgw: examples/ipsec-secgw/test/run_test.sh -46m ... [23695833.390785] dpdk-ipsec-secg[2491066]: segfault at 0 ip 00005643257309= 63 sp 00007fffb9111d00 error 4 in dpdk-ipsec-secgw[564324df0000+134d000] [23695833.390791] Code: 28 5b 5d 41 5c 41 5d 41 5e 41 5f c3 0f 1f 00 4c 8d = 04 cd 00 00 00 00 49 89 ce 4c 89 e7 4a 8d 34 00 48 8b 46 08 48 89 74 24 18 = <48> 8b 08 48 89 88 80 00 00 00 f0 83 44 24 80 00 4c 8b 2e 4d 85 ed So far, I didn't dig into it any further. Will have a closer look at Monday. =20 Konstantin >=20 > Akhil Goyal (5): > cryptodev: separate out internal structures > cryptodev: allocate max space for internal qp array > cryptodev: move inline APIs into separate structure > cryptodev: update fast path APIs to use new flat array > cryptodev: move device specific structures >=20 > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 1 - > drivers/crypto/ccp/ccp_dev.h | 2 +- > drivers/crypto/cnxk/cn10k_ipsec.c | 2 +- > drivers/crypto/cnxk/cn9k_ipsec.c | 2 +- > .../crypto/cnxk/cnxk_cryptodev_capabilities.c | 2 +- > drivers/crypto/cnxk/cnxk_cryptodev_sec.c | 2 +- > drivers/crypto/nitrox/nitrox_sym_reqmgr.c | 2 +- > drivers/crypto/octeontx/otx_cryptodev.c | 1 - > .../crypto/octeontx/otx_cryptodev_hw_access.c | 2 +- > .../crypto/octeontx/otx_cryptodev_hw_access.h | 2 +- > drivers/crypto/octeontx/otx_cryptodev_ops.h | 2 +- > .../crypto/octeontx2/otx2_cryptodev_mbox.c | 2 +- > drivers/crypto/scheduler/scheduler_failover.c | 2 +- > .../crypto/scheduler/scheduler_multicore.c | 2 +- > .../scheduler/scheduler_pkt_size_distr.c | 2 +- > .../crypto/scheduler/scheduler_roundrobin.c | 2 +- > drivers/event/cnxk/cnxk_eventdev.h | 2 +- > drivers/event/dpaa/dpaa_eventdev.c | 2 +- > drivers/event/dpaa2/dpaa2_eventdev.c | 2 +- > drivers/event/octeontx/ssovf_evdev.c | 2 +- > .../event/octeontx2/otx2_evdev_crypto_adptr.c | 2 +- > lib/cryptodev/cryptodev_pmd.c | 51 +++ > lib/cryptodev/cryptodev_pmd.h | 82 +++- > lib/cryptodev/meson.build | 4 +- > lib/cryptodev/rte_cryptodev.c | 50 ++- > lib/cryptodev/rte_cryptodev.h | 367 +++++++----------- > lib/cryptodev/rte_cryptodev_core.h | 62 +++ > lib/cryptodev/version.map | 7 +- > 28 files changed, 398 insertions(+), 265 deletions(-) > create mode 100644 lib/cryptodev/rte_cryptodev_core.h >=20 > -- > 2.25.1