From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 4A12CA0C47;
Wed, 22 Sep 2021 23:08:28 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 3633641225;
Wed, 22 Sep 2021 23:08:21 +0200 (CEST)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by mails.dpdk.org (Postfix) with ESMTP id 1CB29411A8
for <dev@dpdk.org>; Wed, 22 Sep 2021 22:58:46 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10115"; a="203197710"
X-IronPort-AV: E=Sophos;i="5.85,315,1624345200"; d="scan'208";a="203197710"
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
22 Sep 2021 13:58:46 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.85,315,1624345200"; d="scan'208";a="513129900"
Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81])
by fmsmga008.fm.intel.com with ESMTP; 22 Sep 2021 13:58:46 -0700
Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by
fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Wed, 22 Sep 2021 13:58:45 -0700
Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by
fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Wed, 22 Sep 2021 13:58:45 -0700
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12 via Frontend Transport; Wed, 22 Sep 2021 13:58:45 -0700
Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.44) by
edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2242.12; Wed, 22 Sep 2021 13:58:45 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=oDvJezTLVgtitoenvEnVlF1VeyLB+GBvoBSv0Umv+fZ+sSWBj2FUkhZLCHw9lugE1BhAxVhNUEBdE82UGqKIRPHCCVLh5tw4cXBG3gwviyBkfUnSBVDHQoIvVGyFaITXhtQ9ZDkjTNFf5iwrBOHUMA+zs9qrMlJhD9nnN3nsTzOkSCeXPFFgEh7f3vISKq20l1SYQO0ZZc+rluAdVyjEPGcLb2aP/byb0ENz2m7bmlLQt1j1eZnq0Kd3zfUQe40dF61tJpvZsagt/XXwxpEveuwoPBZzkmu4SvywjoU6iOzggZCg5wsUKcfW7uggrvlvLSEcCQicp0fHDdqrB2j2mQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=vCfqaGsHxkAfCI3uCB5PjcTlK06EMioNn+SFZPOtdkc=;
b=iDyglfcFLmpJJxX33IoQapYgGIso9KsSpA7LSP3B7aEJZXVEFHECymzNd+Wjucww7UFoA8kZ0CV3cPc812mv1yZfN/dGrQKV7LknCFl2DMq/YcziibvlrKEofGynfLtBgU6n701XmM/FsnXDfDr3SONUSf5sckzI/+kOYzW4qmLZTqTLoboW/HDVpzyAMhkjj0O+yYA4AsNnn0erfSaxBizBCG6XmBo1MdWEFUVJFXAazMre14py2XnyiqrTPOr/KttNiSYzCLGW9vSH9Uhm8rsS0YDEsJOP8j5eY7wMu6r24Cg7LkprbeOMJtAcK3eMufGqZxqYzqFQBgNwtCd/eQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=vCfqaGsHxkAfCI3uCB5PjcTlK06EMioNn+SFZPOtdkc=;
b=zrMCcLyoC3sEAdyMMuAsWqOMwVhjWjVQfp/kUDBTt5RgPTR5QFFwtzYf/xuujZGdExxbZHvNuiJ0CFjDHV7F0rlO+v3X0BMvoUn30gsbM/mCJv9qb79fZOlg7MVT1ZT/AbeDz+7TQveVVZ1gnps9tLfC/c0Ezu6PnjCHLtO7fXs=
Received: from DM6PR11MB4547.namprd11.prod.outlook.com (2603:10b6:5:2a1::19)
by DM4PR11MB5357.namprd11.prod.outlook.com (2603:10b6:5:394::11) with
Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Wed, 22 Sep
2021 20:58:41 +0000
Received: from DM6PR11MB4547.namprd11.prod.outlook.com
([fe80::f817:45f9:dce3:867]) by DM6PR11MB4547.namprd11.prod.outlook.com
([fe80::f817:45f9:dce3:867%9]) with mapi id 15.20.4544.014; Wed, 22 Sep 2021
20:58:41 +0000
From: "Shukla, Shivanshu" <shivanshu.shukla@intel.com>
To: "Kadam, Pallavi" <pallavi.kadam@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "thomas@monjalon.net" <thomas@monjalon.net>, "Zhang, Qi Z"
<qi.z.zhang@intel.com>, "fady@mellanox.com" <fady@mellanox.com>,
"Narcisa.Vasile@microsoft.com" <Narcisa.Vasile@microsoft.com>,
"dmitry.kozliuk@gmail.com" <dmitry.kozliuk@gmail.com>, "Yigit, Ferruh"
<ferruh.yigit@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>, "Xing,
Beilei" <beilei.xing@intel.com>, "Menon, Ranjit" <ranjit.menon@intel.com>
Thread-Topic: [PATCH v3 1/3] net/iavf: build on Windows
Thread-Index: AQHXpcF8hIRms6q2Vk6ToK+hx8dmpKuwnZkQ
Date: Wed, 22 Sep 2021 20:58:40 +0000
Message-ID: <DM6PR11MB45474309492269A791B38BBD8CA29@DM6PR11MB4547.namprd11.prod.outlook.com>
References: <20210909200533.3747-1-pallavi.kadam@intel.com>
<20210909232321.5091-1-pallavi.kadam@intel.com>
<20210909232321.5091-2-pallavi.kadam@intel.com>
In-Reply-To: <20210909232321.5091-2-pallavi.kadam@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-reaction: no-action
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
authentication-results: intel.com; dkim=none (message not signed)
header.d=none;intel.com; dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: e13cdeb3-5d32-48e0-9ce1-08d97e0bc1d9
x-ms-traffictypediagnostic: DM4PR11MB5357:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM4PR11MB53571E0B1B4B008CF8A324198CA29@DM4PR11MB5357.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:6790;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: G2ETTeNCh+8J7fWfni2TSqQeJHo3jt/ZZ9N6e+SNT5qRe5EL52V9wbqBNguyMrTJlmt9XdNoXLWtVK3jIjUzcJVBQWiW46vbY1ithQva6cMY2d2O3ukZnU0s3OtGUx3vE91dnxte3PWIg+C9fR3cX/nfnc48vHfpptrjqF9xeF6iGS88WzQh9NqU1SRpbNZV1IlrRj6nVyGCj0D/RqAFgYcHkQgH5WBP2kB1Zs3uv8HjX27bgGlB7otA53qHrgYDcGRuv81jqBob1oiJb+Jbbr5rlRzdbb0QOj2ejiv7+tCNnnD/40D60acgvqpVxOLuAR6GqiEYMx90prOmR8XsJDrRMrANuTfAY+e+u5VfzJERoy+IhExGsMpcmdr6GzjAfa1EpTctihy247IAtx0YlO7j/qvdWfPemU81EfN7cykbrcunziLSVgvBC3Xd0JRjnpLkstirLh8uH4OkP4AN3qaiLAnta7sl6eo3msNu47/DSBgXUaPhYThTp9S9I4wNtoTmwlv2Mc/6HL9z9owh/MQBn75BvGg29jBwNPc2hUmrNFX2tWw5vrJCPozJh24PmLe1XsXKU//vEmrMJAugV8+AhQWghatharOlsLk4b75Psq7+UtfwQNr4X7bhwe2Gq8mYsG0bVf5h/308qcajSb12Mg3pmSp8otlpE7VfwSi14U55FvpvtxTnRV5N9Q2c7ST3Xp7amhkJwiSUuxXnmQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:DM6PR11MB4547.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(366004)(45080400002)(83380400001)(9686003)(86362001)(38100700002)(107886003)(508600001)(55016002)(66446008)(4326008)(66476007)(2906002)(76116006)(8936002)(52536014)(71200400001)(66556008)(64756008)(33656002)(7696005)(8676002)(316002)(38070700005)(6506007)(186003)(53546011)(66946007)(110136005)(26005)(54906003)(122000001)(5660300002);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Vp4enk/cAzossmgxDtv4KOWKObPILCrDfHx+1Ki46tP2aAU/KmZsOJA80l7k?=
=?us-ascii?Q?cLb2NH1ToJQ75rA3PLlDdCLJj7/BO5dkkXJsPhFFh867tjizoOcbD25QhWuw?=
=?us-ascii?Q?KvEuyKgEgSAZq8FAgVW16czDQPP2ulhjk45PuJASdWZbhXsWtnuQJpp41aWm?=
=?us-ascii?Q?auIO4oxUavNQm9crWOBcuxwsjO/S47OC4inqHWHYDmm0YbzhJA1WRAs07j/9?=
=?us-ascii?Q?VSaXIy6c2GvxCPRFKQ52LH/pQfJQQqo5Ioxauds5I0iXD+DU5FaCz9FRpjYv?=
=?us-ascii?Q?Rerd3jv+Z89ibbG9svkN5s6kghdVyVcQQEksXsf1ThPP/+cFJY+hTVmjuo2m?=
=?us-ascii?Q?bNYzXsDkwADOvepQqJvvVOfm5B4LISS5ZGdkuR8Tmr4FptWAELk13t0iBhF6?=
=?us-ascii?Q?T9gDV1nEJBTb7wpAmPhyk0vEViubTFdMdbljxx2yVzBRbvXDClcO1AWJ31Xz?=
=?us-ascii?Q?EA5gyE7RKbJ8wV0fAHCF1I7AK5n1MNI14RSl+BQ+clWQrY5sygQiVXaCK+1z?=
=?us-ascii?Q?KVMsHIGzZMFKD7FbRuB0Pw1D9yVD1VSGWxsnCIK0gpVGXa72+3MIglkUMyeR?=
=?us-ascii?Q?8VjB9fNlHgYkmWas2zYJn42UWZSxTqKRSgneaLRtiiD/VioCbH7CBSgaJ6NB?=
=?us-ascii?Q?Ap8YvLNn8a5l59Ek8dvVoex6gCtpzGHwHyNX++GxMC51REazcsuGJ4NaSLMS?=
=?us-ascii?Q?5tF5PiN/Xdspnrt3J3WEETC0nXUniP+bsIcTxGBvjHar2Q/aFzZ4m2ICDuxQ?=
=?us-ascii?Q?I0Kw6kGn2NXMKoBVW+fbhEX0eInvlSeHgMh8nvJBiDRUAzk7SbDCVoJER4e1?=
=?us-ascii?Q?z5qDPE8FZwTN6OxlRzP84+bgVzW6lVbbSEkIcDgOsRgS53iOXS/pJBtvGWqs?=
=?us-ascii?Q?p9ShTgQM2gpErU0VpicyafLhoazK8F5HuG+RvvlwjK30MI+B3mzaTtYzyuN8?=
=?us-ascii?Q?Y+aoqvlwUT3ItbF/zOMRxm22Wk3AcMWlBoWuo4UHwtDY5IXJQz7v25MBNsaH?=
=?us-ascii?Q?omAhINdLzhjL6b2i/RoGcBNEicn9grvNEx35ongHfBVjDONm9VfWAme71NwP?=
=?us-ascii?Q?BMVsQnTLrd6RBIdaFbSINF7GHltpqaqbQv+JxASDyyMkb3+V308G2jENcT2p?=
=?us-ascii?Q?FuyaZDxOCqtxAzeTghigsp8dPYZpO9R167dVwqiXmx0YaqkNKqsnIeH/g/0d?=
=?us-ascii?Q?uGGC9wYSL0XZ1VIAHrHrLeWsA/IIMXf4yU1yBd/j0m7X+AGVJSdpx5aT/ek/?=
=?us-ascii?Q?IkWfDREBjvnhrHOE2BDz9Yd7qt6EDmRJb9xISsOhsgaCKUzQulXP7zROmJV+?=
=?us-ascii?Q?HSI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4547.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e13cdeb3-5d32-48e0-9ce1-08d97e0bc1d9
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2021 20:58:40.9449 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DaKEip6yIYgj/kFnsfkR9kqlZETMI9fNE/m7Ae2S+2ytMypzJyj+LzlHXmK82GLV5As3Iu36x2II6fTREPNj6blo5ZpN57cQ+k4CKSKfQt0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5357
X-OriginatorOrg: intel.com
X-Mailman-Approved-At: Wed, 22 Sep 2021 23:08:18 +0200
Subject: Re: [dpdk-dev] [PATCH v3 1/3] net/iavf: build on Windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Ack-by:Shivanshu Shukla <Shivanshu.shukla@intel.com>
-----Original Message-----
From: Kadam, Pallavi <pallavi.kadam@intel.com>=20
Sent: Thursday, September 9, 2021 4:23 PM
To: dev@dpdk.org
Cc: thomas@monjalon.net; Zhang, Qi Z <qi.z.zhang@intel.com>; fady@mellanox.=
com; Narcisa.Vasile@microsoft.com; dmitry.kozliuk@gmail.com; Yigit, Ferruh =
<ferruh.yigit@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beile=
i <beilei.xing@intel.com>; Menon, Ranjit <ranjit.menon@intel.com>; Shukla, =
Shivanshu <shivanshu.shukla@intel.com>; Kadam, Pallavi <pallavi.kadam@intel=
.com>
Subject: [PATCH v3 1/3] net/iavf: build on Windows
- Enable IAVF PMD build on Windows
- Replace x86intrin.h with rte_vect.h to avoid __m_prefetchw conflicting
types
- Fix for pointer and integer sign warnings using Clang compiler on
Windows
- Add extra cflags '-fno-asynchronous-unwind-tables'
to avoid MinGW build error:
Error: invalid register for .seh_savexmm
Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
---
drivers/net/iavf/iavf.h | 3 ++-
drivers/net/iavf/iavf_rxtx_vec_avx2.c | 2 +-
drivers/net/iavf/iavf_rxtx_vec_avx512.c | 2 +-
drivers/net/iavf/iavf_tm.c | 2 +-
drivers/net/iavf/meson.build | 9 ++++-----
5 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h index b3bd07=
8111..55b20a80af 100644
--- a/drivers/net/iavf/iavf.h
+++ b/drivers/net/iavf/iavf.h
@@ -335,7 +335,8 @@ _clear_cmd(struct iavf_info *vf) static inline int _a=
tomic_set_cmd(struct iavf_info *vf, enum virtchnl_ops ops) {
- int ret =3D rte_atomic32_cmpset(&vf->pend_cmd, VIRTCHNL_OP_UNKNOWN, ops);
+ int ret =3D rte_atomic32_cmpset((volatile uint32_t *)&vf->pend_cmd,
+ VIRTCHNL_OP_UNKNOWN, ops);
=20
if (!ret)
PMD_DRV_LOG(ERR, "There is incomplete cmd %d", vf->pend_cmd); diff --git=
a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf/iavf_rxtx_vec_a=
vx2.c
index 475070e036..96c05d9319 100644
--- a/drivers/net/iavf/iavf_rxtx_vec_avx2.c
+++ b/drivers/net/iavf/iavf_rxtx_vec_avx2.c
@@ -4,7 +4,7 @@
=20
#include "iavf_rxtx_vec_common.h"
=20
-#include <x86intrin.h>
+#include <rte_vect.h>
=20
#ifndef __INTEL_COMPILER
#pragma GCC diagnostic ignored "-Wcast-qual"
diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx512.c b/drivers/net/iavf/iav=
f_rxtx_vec_avx512.c
index 571161c0cd..cb0b057b0f 100644
--- a/drivers/net/iavf/iavf_rxtx_vec_avx512.c
+++ b/drivers/net/iavf/iavf_rxtx_vec_avx512.c
@@ -4,7 +4,7 @@
=20
#include "iavf_rxtx_vec_common.h"
=20
-#include <x86intrin.h>
+#include <rte_vect.h>
=20
#ifndef __INTEL_COMPILER
#pragma GCC diagnostic ignored "-Wcast-qual"
diff --git a/drivers/net/iavf/iavf_tm.c b/drivers/net/iavf/iavf_tm.c index =
3c80276ff3..8d92062c7f 100644
--- a/drivers/net/iavf/iavf_tm.c
+++ b/drivers/net/iavf/iavf_tm.c
@@ -321,7 +321,7 @@ iavf_tm_node_add(struct rte_eth_dev *dev, uint32_t node=
_id,
}
/* check level */
if (level_id !=3D RTE_TM_NODE_LEVEL_ID_ANY &&
- level_id !=3D parent_node_type + 1) {
+ level_id !=3D (uint32_t)parent_node_type + 1) {
error->type =3D RTE_TM_ERROR_TYPE_NODE_PARAMS;
error->message =3D "Wrong level";
return -EINVAL;
diff --git a/drivers/net/iavf/meson.build b/drivers/net/iavf/meson.build in=
dex f2010a8337..36a82e3faa 100644
--- a/drivers/net/iavf/meson.build
+++ b/drivers/net/iavf/meson.build
@@ -1,11 +1,6 @@
# SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Luca Boccassi=
<bluca@debian.org>
=20
-if is_windows
- build =3D false
- reason =3D 'not supported on Windows'
- subdir_done()
-endif
=20
cflags +=3D ['-Wno-strict-aliasing']
=20
@@ -25,6 +20,10 @@ sources =3D files(
if arch_subdir =3D=3D 'x86'
sources +=3D files('iavf_rxtx_vec_sse.c')
=20
+ if is_windows and cc.get_id() !=3D 'clang'
+ cflags +=3D ['-fno-asynchronous-unwind-tables']
+ endif
+
# compile AVX2 version if either:
# a. we have AVX supported in minimum instruction set baseline
# b. it's not minimum instruction set, but supported by compiler
--
2.31.1.windows.1