From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C10AA0C47; Wed, 22 Sep 2021 23:08:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4F90E4122B; Wed, 22 Sep 2021 23:08:22 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id E9921411A8 for ; Wed, 22 Sep 2021 23:00:19 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10115"; a="210779745" X-IronPort-AV: E=Sophos;i="5.85,315,1624345200"; d="scan'208";a="210779745" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2021 14:00:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,315,1624345200"; d="scan'208";a="557628973" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 22 Sep 2021 14:00:18 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 22 Sep 2021 14:00:16 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 22 Sep 2021 14:00:16 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 22 Sep 2021 14:00:16 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 22 Sep 2021 14:00:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ca5ogzj70MfE9S7OJCGNMqVMXvoik1r1ePhzpkNCP6h2BIzgoRtFqpfNIpJ2hO/yHnUqx9gSxwT6TmDtonTEqPFkenYIHuOPV504GAkL936uE/oyQiVdu0Cb2+Ozab7CYgh/b1IB1YEsdYmbE00La0pciCxTXX8zhRkQ1o8rIzWzu05E2IvcMuJ6W2jh91y0B9cSUcy/yXgaSLYbEZXZZL6IMsRsVstNdxX3luUwn6NOHZMfgQ1ctkV4q5JoUrJd+n7OTTfIlXWDH23HArI6YTuPQCE7jV2PBkgihAQ6eN6hSBvx6EHYWLu5IiZBnM0bgSajoBv6rSC1hM4qGHi2og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ieZD4fHJDLoq1hzCh4MI7d4EbeF4D2hQ/7BZOo2Nb1o=; b=aP2k7D0VmqX6/+tf6MtUqZCrmj5nItsMKd2mnUJYU5yVU9D/itw3u4sCuDO3Eu0Agmt1oapNb2Xyrabb6AEYbE/2fsAHwD4c3V1i6axVMNa4RFRkQQwm6VFXL0xbt+aVYV7zPzeXEqQ2oZRRPNPn/7dTawGBcIUfu1IRAgMNlH6la98VWcjek994bqFKmgTmGLdyEZAnnOPbfvU/hMKzAE/w3pMzpajnyjODepRmN5rPF7+qS1IQg/r+eVXI39XSOrfPALbq+KuQ9KO5FyyyoyNlsoysxYExChCBu8c3rz1fUrMiITS8rAtdZ97XHl14pBKrAOV3Bqx1OZEmnZZbfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ieZD4fHJDLoq1hzCh4MI7d4EbeF4D2hQ/7BZOo2Nb1o=; b=hFSBpd2QRqOZKi7wKBzT2N2UPlwo3MhtRV2z7xP3UDQsxaKEOV/Rv5iyavMEAKN9g8Rf1Wk13x5rB5UnKW8iisqRgRCUCMDnrVWK9dt/MORRUpBTCHEgH9cb2X5Z3z521JS/m3XjkKWc9ofwWUeggmgckYAlywm/+yqT5mC10ko= Received: from DM6PR11MB4547.namprd11.prod.outlook.com (2603:10b6:5:2a1::19) by DM6PR11MB4250.namprd11.prod.outlook.com (2603:10b6:5:1df::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.18; Wed, 22 Sep 2021 21:00:11 +0000 Received: from DM6PR11MB4547.namprd11.prod.outlook.com ([fe80::f817:45f9:dce3:867]) by DM6PR11MB4547.namprd11.prod.outlook.com ([fe80::f817:45f9:dce3:867%9]) with mapi id 15.20.4544.014; Wed, 22 Sep 2021 21:00:10 +0000 From: "Shukla, Shivanshu" To: "Kadam, Pallavi" , "dev@dpdk.org" CC: "thomas@monjalon.net" , "Zhang, Qi Z" , "fady@mellanox.com" , "Narcisa.Vasile@microsoft.com" , "dmitry.kozliuk@gmail.com" , "Yigit, Ferruh" , "Wu, Jingjing" , "Xing, Beilei" , "Menon, Ranjit" Thread-Topic: [PATCH v3 2/3] lib/net: fix support of random Thread-Index: AQHXpcF81OrBmlzgR02PG9O0GTZq56uwngjw Date: Wed, 22 Sep 2021 21:00:10 +0000 Message-ID: References: <20210909200533.3747-1-pallavi.kadam@intel.com> <20210909232321.5091-1-pallavi.kadam@intel.com> <20210909232321.5091-3-pallavi.kadam@intel.com> In-Reply-To: <20210909232321.5091-3-pallavi.kadam@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 455d5a9e-28f0-4b69-34bb-08d97e0bf75f x-ms-traffictypediagnostic: DM6PR11MB4250: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1002; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Uzk7bY0VoIBiRhXMgrJSheqrfdBt4jh6sfhqn4pCsOukBbsRNsFl93pVFAybIse3ls9DjZWOlO4lLeFSzZigmjLw4fqZ9Be2MXRkTnikUTvltx0gqtJFqjt5mEbZxbnHSVpkihpK79XPlwyKexijqrEEn/VtP2HvQJfU61sKgzHuAZ654SkWbv4c5t1nsqt+d4DEOiycCahtLt0arXEXeWgpWBPK9vOm9WqstKY3wNbNzYOWn08QRsamW0HZqAgoaOhovEYP4b56UOl9OTu8CSPcUnNNzY9kc/XUgi5TdKXX88H/ktAayBz3qad0fzhk5TiyAw/fKW6wKvXVzMOY62GdQaTEiVK4O0lkYgx7mN7wlxkYCggDuNYpxtqyEDGftJfvxor6sxCwe3vJklkZ/4CXAJwWDqzHClCBK607XqPRuKgZDIXMubXFxFWng7ocuTF5p1k6gv2Memupzaaz2JWGbGIt7E834WhAL+xV7X8QtrmRb3RYY0dJvEgXV0utC+jzF84iAEmJBZmYpx4nQNeK0/8X2b1KyTYQ3xFRktxCXWvYRpjotwYugg6AYSx4ememKp18/tkFMBDh+0C7jKGIMJXID1Ns0HLyxpb81ZZWY+xU2ZcaCfRh0Gwc/aMUGcR6JMxvjTVOhZhIDZiBmVdrMpNYWI260KsXZknLmR2DOk4RbbA5fWH5DyGGkJL31kicWu9C5TcT0FRodiohgg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4547.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(54906003)(110136005)(66446008)(316002)(8936002)(7696005)(508600001)(83380400001)(2906002)(122000001)(66476007)(6506007)(5660300002)(38070700005)(86362001)(38100700002)(107886003)(45080400002)(76116006)(9686003)(53546011)(33656002)(26005)(186003)(66946007)(55016002)(71200400001)(64756008)(66556008)(8676002)(4326008)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MZSxcRolEwzeQtrGeq/PiekeEIcSnqfKtADG85ooRoXH0KLezKBBcrgmZqGT?= =?us-ascii?Q?0a9+xs3jtfne+NXIC4tzz9CgiBoUAzxB3MBf8Z8gNMgEh95vvzK7UPz+qWRa?= =?us-ascii?Q?cJccJCPBqx5Ui41RJMIwaWT3Wgn5BvoE3IiMheo8XrScmggjDNfqQDPjNW7v?= =?us-ascii?Q?5sjXytvjzq6wpuRHE0ozexHL8Vm/3cun59Kz2irfAxgE0TKAJptooPQnkUe7?= =?us-ascii?Q?dRzAavWPcg4FqS4r6SKjhkDUMXvEsZCnMDAFfN1eQpRkVNYBgbamA6HA1qFX?= =?us-ascii?Q?hMOp3qrAun2/ueuOi8DThaHrndm2AdCPqNz3Q/yD2/i6YrQX5ZEm0JQwCgir?= =?us-ascii?Q?Q7PG8MIe8yVthQl9mefN4vKTVryTImWcjgOX+MQ+M44FloK6O5whr76pj/vJ?= =?us-ascii?Q?zNVSQDqJrGrTNamb3ygi28/fqdSBHvFk5UaBgr4thgRHIzqcNWGTWmY8HCfa?= =?us-ascii?Q?1JN6UaSLPKnW94l2zeQgw7ebxYbqwG/V1oPcCaRIZCjp4Djm5jFZA2Sm1IJY?= =?us-ascii?Q?2ueviRvL3hGLex8zsBz36pggu6ZZ6xzVEwAWZ+3CJRpq1gWCB8Pn4m36R3Ub?= =?us-ascii?Q?RI0T8w7i0siXb4koaPlZF6rB2nkts4qQvPKztariyXfdXIjCbwxiJYzX9F8C?= =?us-ascii?Q?5q6b9SSSyhrP1XzhVuOQKnR2o3iUywgv1790sCSeEmHGB8KZvdPHCUnaHcUr?= =?us-ascii?Q?KikovA1UiofNtzUApcLn1qXHaPu/ThANJ00+rXhgF6bQizDVHPrMZJyiKj3R?= =?us-ascii?Q?WdpN9MSQPPt0MB7Hfz9Rf99b5TMTL6NHCe4vUc0KT/ozQqdg4FRT/WIj+f8L?= =?us-ascii?Q?7jriMuIn3AE/W44ICLHgkOvSZhWF+r01FmA3V1R6OKpSh7jXjayOq1t1vEY6?= =?us-ascii?Q?CB2lHkmvpX3K5c3dpQSB0Uq2l/p7QVOKRLGIv6N0TVKuFD/E/pmmAr6Kp5kP?= =?us-ascii?Q?gJ/8difsiLCzuirduBNx8IdV+j7uvZd/h0LL3Ns4+KFs/WE6TziA+2W1M1Q+?= =?us-ascii?Q?FdUmbLA9BWqii772UhNyIjyliOz4xkqd+YykLbotG5eOJObjN1u919+jicwA?= =?us-ascii?Q?/BeVRRSoBp1iFyqqhq8YVviuhIrXeGhF8xsF1PmOwFSbbD7Tz2Likdsl4DRb?= =?us-ascii?Q?lo6q5GsAogEj06H5yk4+Ny/rP6TmNFV3jFPXYENvT80xfH29rUMJu/frCxFf?= =?us-ascii?Q?tj19+pBSXMWfv5FBTTvUZJYxYVSSMK/xJuXxEl8Y5yhAq3mP3jHhJd/Bibp5?= =?us-ascii?Q?/g6h2ESnakuC4mz6OvffxnF7w3S6ozGOiuyjBsbd1r6iSw+JyWw6ZUW7wGoq?= =?us-ascii?Q?OTk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4547.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 455d5a9e-28f0-4b69-34bb-08d97e0bf75f X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2021 21:00:10.8741 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TROW20goM2RH5VbEYdMYqVpagpBZ5smS/OaWTs3+6qvpZXvm7zt3ZiO6PFXGVS4hGewiPxGisyxDx0Pw2hRyH/KiXT3UBVd+GOf7k0fdgsk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4250 X-OriginatorOrg: intel.com X-Mailman-Approved-At: Wed, 22 Sep 2021 23:08:18 +0200 Subject: Re: [dpdk-dev] [PATCH v3 2/3] lib/net: fix support of random X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Ack-by: Shivanshu Shukla -----Original Message----- From: Kadam, Pallavi =20 Sent: Thursday, September 9, 2021 4:23 PM To: dev@dpdk.org Cc: thomas@monjalon.net; Zhang, Qi Z ; fady@mellanox.= com; Narcisa.Vasile@microsoft.com; dmitry.kozliuk@gmail.com; Yigit, Ferruh = ; Wu, Jingjing ; Xing, Beile= i ; Menon, Ranjit ; Shukla, = Shivanshu ; Kadam, Pallavi Subject: [PATCH v3 2/3] lib/net: fix support of random IAVF PMD needs to generate a random MAC address if it is not configured by = host. 'random' is now supported on Windows. Fixes: 16f0d03098cb ("net: build on Windows") Cc: fady@mellanox.com Cc: stable@dpdk.org Signed-off-by: Pallavi Kadam Reviewed-by: Ranjit Menon --- lib/net/rte_ether.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/net/rte_ether.c b/lib/net/rte_ether.c index 34605838b5..ce= d65ed9f3 100644 --- a/lib/net/rte_ether.c +++ b/lib/net/rte_ether.c @@ -10,16 +10,12 @@ void rte_eth_random_addr(uint8_t *addr) { -#ifdef RTE_EXEC_ENV_WINDOWS /* FIXME: random is not supported */ - RTE_SET_USED(addr); -#else uint64_t rand =3D rte_rand(); uint8_t *p =3D (uint8_t *)&rand; =20 rte_memcpy(addr, p, RTE_ETHER_ADDR_LEN); addr[0] &=3D (uint8_t)~RTE_ETHER_GROUP_ADDR; /* clear multicast bit */ addr[0] |=3D RTE_ETHER_LOCAL_ADMIN_ADDR; /* set local assignment bit */ -#endif } =20 void -- 2.31.1.windows.1