From: Raslan Darawsheh <rasland@nvidia.com>
To: Raslan Darawsheh <rasland@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Matan Azrad" <matan@nvidia.com>,
"Slava Ovsiienko" <viacheslavo@nvidia.com>,
"NBU-Contact-Thomas Monjalon" <thomas@monjalon.net>,
"Benoît Ganne" <bganne@cisco.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: fix link state update
Date: Thu, 19 Nov 2020 16:27:05 +0000 [thread overview]
Message-ID: <DM6PR12MB27480B75D4DD4B8CC9A6776BCFE00@DM6PR12MB2748.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201119142018.25277-1-rasland@nvidia.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Raslan Darawsheh
> Sent: Thursday, November 19, 2020 4:20 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; NBU-Contact-Thomas Monjalon
> <thomas@monjalon.net>; Benoît Ganne <bganne@cisco.com>
> Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix link state update
>
> From: Benoît Ganne <bganne@cisco.com>
>
> mlx5 PMD refuses to update link state if link speed is defined but
> status is down or if link speed is undefined but status is up, even if
> the ioctl() succeeded.
> This prevents application to detect link up/down event, especially when
> the link speed is not correctly detected.
> As link speed is nice to have whereas link status is mandatory for
> operations, always update link state regardless of link speed. The
> application can then check link speed if needs be.
>
> Signed-off-by: Benoît Ganne <bganne@cisco.com>
> Signed-off-by: Raslan Darawsheh <rasland@nvidia.com>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
next prev parent reply other threads:[~2020-11-19 16:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 17:24 [dpdk-dev] [PATCH] " Benoît Ganne
2020-03-29 7:00 ` Matan Azrad
2020-03-30 9:55 ` Benoit Ganne (bganne)
2020-03-30 10:12 ` Matan Azrad
2020-03-30 12:03 ` Benoit Ganne (bganne)
2020-03-30 13:44 ` Matan Azrad
2020-03-30 13:53 ` Benoit Ganne (bganne)
2020-03-30 16:13 ` Matan Azrad
2020-04-01 10:17 ` Benoit Ganne (bganne)
2020-04-01 12:46 ` Matan Azrad
2020-04-07 12:54 ` Thomas Monjalon
2020-04-07 13:41 ` Benoit Ganne (bganne)
2020-11-19 8:30 ` Matan Azrad
2020-11-19 14:20 ` [dpdk-dev] [PATCH v2] " Raslan Darawsheh
2020-11-19 16:27 ` Raslan Darawsheh [this message]
2020-11-19 17:48 ` Ferruh Yigit
2020-11-19 18:42 ` Thomas Monjalon
2020-11-20 10:51 ` Ferruh Yigit
2020-11-20 13:50 ` Thomas Monjalon
2020-11-20 14:21 ` Ferruh Yigit
2020-11-22 10:03 ` Raslan Darawsheh
2020-11-22 10:04 ` [dpdk-dev] [PATCH v3] net/mlx5: allow unknown link speed Raslan Darawsheh
2020-11-22 12:58 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB27480B75D4DD4B8CC9A6776BCFE00@DM6PR12MB2748.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=bganne@cisco.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).