From: Raslan Darawsheh <rasland@nvidia.com>
To: Michael Baum <michaelba@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>, Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v1 1/2] net/mlx5: fix Rx objects creator selection
Date: Tue, 15 Sep 2020 13:37:57 +0000 [thread overview]
Message-ID: <DM6PR12MB2748154073249DAFC6818422CF200@DM6PR12MB2748.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1600023922-14738-1-git-send-email-michaelba@nvidia.com>
Hi,
> -----Original Message-----
> From: Michael Baum <michaelba@nvidia.com>
> Sent: Sunday, September 13, 2020 10:05 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH v1 1/2] net/mlx5: fix Rx objects creator selection
>
> There are 2 creators for Rx objects, DevX and Verbs.
> There are supported DR versions when a DevX destination TIR flow action
> creation cannot be supported, using this versions the TIR object should
> be created by Verbs, what forces all the Rx objects to be created by
> Verbs.
>
> The selection of the Rx objects creator, wrongly, didn't take into
> account the destination TIR action support what caused a failure in the
> Rx flows creation.
>
> Select Verbs creator when destination TIR action creation is not
> supported by the DR version.
>
> Fixes: 71dee7694a70 ("net/mlx5: separate Rx queue object creations")
>
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> drivers/net/mlx5/linux/mlx5_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/linux/mlx5_os.c
> b/drivers/net/mlx5/linux/mlx5_os.c
> index 41db75e..0511a55 100644
> --- a/drivers/net/mlx5/linux/mlx5_os.c
> +++ b/drivers/net/mlx5/linux/mlx5_os.c
> @@ -1272,7 +1272,7 @@
> goto error;
> }
> }
> - if (config->devx && config->dv_flow_en) {
> + if (config->devx && config->dv_flow_en && config->dest_tir) {
> priv->obj_ops = devx_obj_ops;
> priv->obj_ops.drop_action_create =
>
> ibv_obj_ops.drop_action_create;
> --
> 1.8.3.1
Series applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-09-15 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-13 19:05 Michael Baum
2020-09-13 19:05 ` [dpdk-dev] [PATCH v1 2/2] net/mlx5: fix using hairpin without dest DevX TIR support Michael Baum
2020-09-15 13:37 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB2748154073249DAFC6818422CF200@DM6PR12MB2748.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).