Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table

[Raslan Darawsheh <rasland@nvidia.com>]

Hi,

> -----Original Message-----
> From: Dey, Souvik <sodey@rbbn.com>
> Sent: Tuesday, February 2, 2021 7:49 PM
> To: Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf
> Shuler <shahafs@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Souvik Dey <sodey@rbbn.com>
> Subject: [PATCH v3] common/mlx5: fix storing the synched MAC to internal
> table
> 
> From: Souvik Dey <sodey@rbbn.com>
> 
> As the internal MAC table is divided into Unicast and Multicast address
> sections, we should check the type of synched MAC address before storing
> it to the internal table. Currently the check is not done, and the
> synched MAC of 33:33:00:00:00:01 gets stored in the unicast section
> (mostly index 1) causing all subsequent mlx5_set_mc_addr_list()
> to fail with error -EADDRINUSE, as the mac_list contains the MAC
> 33:33:00:00:00:01. This denies adding of any new multicast address to
> the internal list and also fails to add the MAC address to the device
> in case of SR-IOV VF.
> 
> Fixes: f22442cb5d42 ('net/mlx5: reduce Netlink commands dependencies')
> Fixes: ccdcba53a3f4 ('net/mlx5: use Netlink to add/remove MAC addresses')
Replaced  ' to "
> Cc: stable@dpdk.org
> 
> Signed-off-by: Souvik Dey <sodey@rbbn.com>
> ---
> v2:
> * net/ -> common/
> * space after mlx5:
> * synched -> synched
> * section -> sections
> * rewording which causes -> causing
> * typo: case (to remove)
> * added Fixes for LTS ML
> ---
> v3:
> * Changed the "" in Fixes tags to ''.
> 

Patch applied to next-net-mlx,

Kindest regards
Raslan Darawsheh