From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E499FA0524; Thu, 4 Feb 2021 11:43:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D42292406F2; Thu, 4 Feb 2021 11:43:43 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by mails.dpdk.org (Postfix) with ESMTP id 482B22406DB; Thu, 4 Feb 2021 11:43:42 +0100 (CET) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 04 Feb 2021 02:43:41 -0800 Received: from HQMAIL107.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 04 Feb 2021 02:43:41 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 04 Feb 2021 02:43:41 -0800 Received: from HQMAIL101.nvidia.com (172.20.187.10) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 4 Feb 2021 10:43:40 +0000 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 4 Feb 2021 10:43:40 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 4 Feb 2021 10:43:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YbVc//JM++S1/pzm5IkmgGbnaE6aut2cBBcOJfEVoRuMsnFRsdl3imaGe8QcMWWI3WEmEwFUZY/9Wosz9yLPhuq2v2iWBIRroCiJ0gimv3h9TJ+/AOMWpolz4ZZ27dnRKFnmS6nkEgp4RPN4MxQ1boca+N22T0u8YBz9EILU8rZNT7b3kXKdk9j1xzeehprUPdoAujdsPI54w3P8g6EQEdjql60a2TkhtA3JhPEaRXhQ8YZ0Mvljn45/kz/5ktbj5bDUr9iI9SDO6e7NrF1G+KUC8rR9nD505TU3KpUV1vAdjMGLI5cObbbiToZPrefj8pLt7G86a3D5nZWPbyZcxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZP/GIi3e3Wl0lJJgkCjnJIxyNcLWJpBYjJmYFwWz/k4=; b=l65tg4wfSiULli13hu6JvBb7+ySpb+DvyXchPUXhNzuIkTxnynuidcP4bULffVROWdOfM3C1vkubWZx9ZnAXcPBq8MDrm6RZLhL3QsnQXYZ3qaVGkTw1zXs3UX/vIb0OGqnZjS91nYzhZMKaz7MGylF0rbMVKNFIVnrV/Pl/6Zu01eMYGlu14Bn9kiws/x0+UhUXjafNWBWNEQUwgv3XY4BpU9iYFi2D94aG9A/vp4tgw4PDgp6PP608x81oHLrqQ97wNxCgSS+7f8jO8go45dDNY97XHdxf9EGrl1O1HwA4GloMjZRuVon+A5zL3cGakO8rtFix9OqQ7iA5lWZ6yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR1201MB0091.namprd12.prod.outlook.com (2603:10b6:4:57::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.17; Thu, 4 Feb 2021 10:43:38 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::759a:fb10:c6af:87a3]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::759a:fb10:c6af:87a3%7]) with mapi id 15.20.3742.015; Thu, 4 Feb 2021 10:43:38 +0000 From: Raslan Darawsheh To: "Dey, Souvik" , Slava Ovsiienko , Matan Azrad , Shahaf Shuler CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3] common/mlx5: fix storing the synched MAC to internal table Thread-Index: AQHW+Yu7sOBoNiUts0y6DIsq6YZALqpH0d0Q Date: Thu, 4 Feb 2021 10:43:38 +0000 Message-ID: References: <20210202035352.24512-1-sodey@rbbn.com> <20210202174841.15784-1-sodey@rbbn.com> In-Reply-To: <20210202174841.15784-1-sodey@rbbn.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: rbbn.com; dkim=none (message not signed) header.d=none;rbbn.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.228.214] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ac9e52ef-4941-48d8-b5bb-08d8c8f9bb22 x-ms-traffictypediagnostic: DM5PR1201MB0091: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-header: ProcessedBy-CMR-outbound x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EGzVbOwZ6S/FG8MUyQC9AuMdc9ljx2z5jnR7gVDt1x6NVKoEWc2or13HpIg4AFPnYEUWEWZpZll2uP5+2I2L/DEbJezXpLexo7ETYwBeJnl9ud3aGwpM5WTULwlBAsjt9RHnAWY1jVkg2vIwALr48Z44a6Y/k8uqCX7PUZtEPlvUscVi0V9Z0ujW+h0H78WvMwV2XVWefpEW3gBPE/NFHNeteel5QW2VuzTBt1ZAMiNSKaKywLr5lbousYXW8QAaa8bw+PRoj31JX6gDmH1RsIhs4zCi5JywAO4jH/ssbAIcKFuuj0YPTtvYA1MJJ9yjI9UNXRZzWwYsyWfkYFLumGMn/a2oRYDs+soBAuMKcXaEFCbwOwIPjLSfmRUSVN/BD7JEq+C2Yl9MAdtCcz0X3PZQTh0dF+1PUlDxI3afZPOpaQgJqNKLEH+XiO+p10UG5QDxSWfDexsmDKi/mBgqIP1TYsYW2JIwJZODoNc0ddw0i7KFEO7DQvd/qdshkuw1/QnFn6zUMiXqDZFTu0r9Bw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(396003)(136003)(376002)(39860400002)(2906002)(53546011)(26005)(186003)(33656002)(54906003)(110136005)(8936002)(316002)(8676002)(76116006)(71200400001)(66446008)(64756008)(66556008)(52536014)(66476007)(66946007)(5660300002)(478600001)(6506007)(7696005)(9686003)(55016002)(86362001)(83380400001)(4326008)(6636002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ahsnc2IbLGJleszG+0+9Eb62F0SPr6tl1K7vfA2NbgDs/QbOglpJAsTDbhbM?= =?us-ascii?Q?DBXBcLulC+XJhE+f0+KqQiK6Mtw5bOl3a/ZIP9JlleImxEvRA7FPW6Ff3gYb?= =?us-ascii?Q?8PFD1jmh5mOFkqBP3IQmD6zuOy/ciyDASfjmoizHY824utBjS+5m6faQubDL?= =?us-ascii?Q?AUwlyKvXl3wCpbYQrN+Rsk2DxtLrODf7ut56gxmYm4JXkgXQaEJaKB3mgcHe?= =?us-ascii?Q?Wa3/aI2Csh5PfihUJ6ZSe2OhcowMWSbCBNWGJeGbYCZMU0l2EI1IEvQ2PN3z?= =?us-ascii?Q?2Fh+FgCQ1i6VXRWTK0utKsEaBcpuef0AhbE1GsU2kN5UyJhaPxcuMimEjXls?= =?us-ascii?Q?/7iIv8iaQdPThSHMav/U/zkTJSqd9qs5b+mR/fn0jz1sktltiX3fGZUyblua?= =?us-ascii?Q?+YSrPCOGyc3ygEdKb+HXXTNj3ftylLayXkPuh4CjoveXgMpKV96Oc2jLWhLa?= =?us-ascii?Q?1r/855sYmWZPhFaIgjVkYPZ9I7qWoGBDa6LKgPtkJWZLOIY3lnLXp3dXZwZw?= =?us-ascii?Q?JTHInRGMfyDWyaZTCw5niIgttm2xhP8voe0a90MGl6G3Q7rCNfSHT/sCt8vi?= =?us-ascii?Q?HBwKxHIlTFRloOVELVXAF7fyZJI/jf5efYxwPVZlQ4wtqUys7f+CSmiaXTHj?= =?us-ascii?Q?sr0S+hpdAkUzRoa9zG6TUTmDKkB5Xz/C37148NT80XiHFfj7vib3hWqp2NM8?= =?us-ascii?Q?NmtfjkecwlWfcLprcmNnhvqAET6L5LUpICgFAxPIOuZvyml0vwq2Mhri8V/p?= =?us-ascii?Q?PG44GE3xXpTCn1iymn9Q/3K55im+0c6fWEOVfUd0v22NcdS8i/XGoM914+B2?= =?us-ascii?Q?J2e73NRbRqJc7IKJC7lKjz/Q72sgmWj03d1xPcA/4nwM0nIKV1e+icY4MXvh?= =?us-ascii?Q?4cn+R+cHpYzbcDnFlU2uUAt26kIVN7JWv/TGkqszVelEUMo1KPJ81X+JWduk?= =?us-ascii?Q?KrZhUXVQHw8f5SbLB13kfvrOfBdnmO4NRs+uMqcM3CXPoed37JbnWmS8+qie?= =?us-ascii?Q?7f+b0UHZK4RgOAhlyUT+1bDsPg2kEcu/iY+6LJ65MnFKdEURAIwPk8EWP/Rf?= =?us-ascii?Q?cHb+c1gX4OAs2ndL7Q3O4nLrRuW1wyGr2t2LNPECt88PhjK1FfBmKQOz67Oe?= =?us-ascii?Q?o/E3nA7GosBn0wEBsoxDauQ4wVWZa/ogOjaJ8Cm8uAoidbeK4Q/8SM5X4Xmy?= =?us-ascii?Q?UHyDTzWxahJxJ3GxXpW7o7yhaov97VfD3Z2cbvn+7oYhd20+n8jVbYCgTOdI?= =?us-ascii?Q?3N6/K0Byn8VZHk86tgXYNnMFTwzS0fRVqJx4PSV4OviEGQiyaTL7xi0w17/k?= =?us-ascii?Q?xMOYlAfc4ouMufP7N6IZcRyY?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac9e52ef-4941-48d8-b5bb-08d8c8f9bb22 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Feb 2021 10:43:38.3901 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rDaCkuYeBe2rWH6UESVjj/bHdJrFBTg0vt2E4N9whoEWet4r4ra5YdLqNq46ffNucIhtoEWC5YAJgTDAKoWnMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0091 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612435421; bh=ZP/GIi3e3Wl0lJJgkCjnJIxyNcLWJpBYjJmYFwWz/k4=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-header:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=EUX8VamSNggTuGdiHVgeqVWxoK73Kmw97DnjxX5jTuHRRDQpS1id1HAAem2DJf7cC kb7yvofRR4Ti+fIRWd8qj8C4Xpa5JrtD8uaruyzJ/cfWLxCX6mQ1ZB6+SpZFz5zxGU Q96gUhUd9AND0879FBYR31BQzYPZJ/MfV8t9Y9COEZ0CvC1Bd417e4L7Z1eefL8uZi 9DwYB3grHos9eJ6fO7+HXGFe6/QlH16YnEsKvGtrfUHZwez2aAvq7BBTr3GmQcdmyl ia5NmVnE8BgLvY4h4mcPFoBwNUZ6p3yGi36XpnUJWQ5rR2ZjB1yXteGuCGvC70U5/V SwRU4qvnwofLw== Subject: Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Dey, Souvik > Sent: Tuesday, February 2, 2021 7:49 PM > To: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad ; Shahaf > Shuler > Cc: dev@dpdk.org; stable@dpdk.org; Souvik Dey > Subject: [PATCH v3] common/mlx5: fix storing the synched MAC to internal > table >=20 > From: Souvik Dey >=20 > As the internal MAC table is divided into Unicast and Multicast address > sections, we should check the type of synched MAC address before storing > it to the internal table. Currently the check is not done, and the > synched MAC of 33:33:00:00:00:01 gets stored in the unicast section > (mostly index 1) causing all subsequent mlx5_set_mc_addr_list() > to fail with error -EADDRINUSE, as the mac_list contains the MAC > 33:33:00:00:00:01. This denies adding of any new multicast address to > the internal list and also fails to add the MAC address to the device > in case of SR-IOV VF. >=20 > Fixes: f22442cb5d42 ('net/mlx5: reduce Netlink commands dependencies') > Fixes: ccdcba53a3f4 ('net/mlx5: use Netlink to add/remove MAC addresses') Replaced ' to " > Cc: stable@dpdk.org >=20 > Signed-off-by: Souvik Dey > --- > v2: > * net/ -> common/ > * space after mlx5: > * synched -> synched > * section -> sections > * rewording which causes -> causing > * typo: case (to remove) > * added Fixes for LTS ML > --- > v3: > * Changed the "" in Fixes tags to ''. >=20 Patch applied to next-net-mlx, Kindest regards Raslan Darawsheh