From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AF74A04B5; Thu, 1 Oct 2020 12:03:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C4A881DACB; Thu, 1 Oct 2020 12:03:45 +0200 (CEST) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id D6C021DA2A; Thu, 1 Oct 2020 12:03:42 +0200 (CEST) Received: from HKMAIL104.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 01 Oct 2020 18:03:40 +0800 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 1 Oct 2020 10:03:40 +0000 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 1 Oct 2020 10:03:39 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LWtNp5jnIUEf6pY7jDZHL8caiUFmVzj2ykBr9i0Ho4TCybPD9lKmcYdFW206wMQy+iYopq0a39MDLx1n87uWIBe1mBGerInu4iuMgGQPl50yuxBRthXAs6gcQnBrfbapAlH1anUJJPSYwQ/9JMWYPeT1fPFKOnQ1+SJQRa/I9vkfMrhZApbepaHwL8Xk1fL6AP/9AmQIbRaBaHTLJiO5wEHyAeVDCp+rty1ySyGxY9QglordzR5IB2d4T/QzBb2dHWAEVa8L1WDc8dlKcd29oTcmKPJTogx+gbQvbiZs8i56hCiHqMahAtjGwVR1z6k9J38RxZBIO2r6wi3E7IdZYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gMtIwpJ47ujSdkOOOo9nczr5QrQ4z7rpRG5oXY2HNZk=; b=NTpRazK7qwDd8N0KWrdUu3e008o+O143vebDB+sERKsLitHm+f4tPsTaEJ67+vLrVU/wwXMA0mBihg8r3YxZ50xz0cRz1o1W2S3lLE4AzOj+hO57MWcepO13McJHdOTvamZ/bjqJz2umbkfLB1EWK1ILavTW8/PH+ZW+eXGXj/UhgwYvbDDFqPSjJ+2TVi+r9nsuFIQH3RkAi3C6H+hsQDEmKlYERMHnEmuPbRfOb7Db+tP38LKsUUMvldlXIt294n98U3hK92KwIt27q4aNVp+pcbPO3/Dafo6bdNvkzerQmTPlnotBocEgROfQO3LGivDs0h9+mLo4Nu5WB84wyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB3066.namprd12.prod.outlook.com (2603:10b6:5:11a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.35; Thu, 1 Oct 2020 10:03:38 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3412.029; Thu, 1 Oct 2020 10:03:38 +0000 From: Raslan Darawsheh To: Suanming Mou , Slava Ovsiienko , Matan Azrad CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix incorrect meter table define Thread-Index: AQHWlvWI3oZ1CP3+VU6lWWRaGdqzHqmChjmA Date: Thu, 1 Oct 2020 10:03:37 +0000 Message-ID: References: <1601448421-186392-1-git-send-email-suanmingm@nvidia.com> In-Reply-To: <1601448421-186392-1-git-send-email-suanmingm@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 711a26a0-2ea7-4f11-280e-08d865f14448 x-ms-traffictypediagnostic: DM6PR12MB3066: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i61XX0FW1d18Tm81P1l47YPR5aJ70pbKfWMh7zkWfDvIRrJzyH6u8h7lDQCz/3zQL5rDt0EKwxGe6mvOlV0W1l4MnfpijsIZX5Iesr89jDfMXl31erSwm2/ToT4XZluHoGs/ju1n9aJpVc1iL6PIr69oseUrFUpg2cKOQY/GTBHflsblu+xdMeVsIrx67wMF656FiKycbKQnEARZ/Hhm42a90uyokGNq36RQX3+1SxbeaIGeWqhcwNmQcxCvR7R+/wVpMAdCmrnUz5AJHVyk5C104rb321eNJygEb+CYb0/sG6JmID5hhsSfxSSmnglmAc55TguRtOVnqC7sqqL7sw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(346002)(136003)(366004)(376002)(53546011)(86362001)(6506007)(478600001)(26005)(450100002)(6636002)(7696005)(83380400001)(186003)(5660300002)(9686003)(55016002)(66476007)(2906002)(66446008)(64756008)(66946007)(66556008)(52536014)(110136005)(33656002)(54906003)(76116006)(71200400001)(8936002)(8676002)(316002)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 1AGM8LFT3nAiBsZlITMOGTvCGuPF4CS/KMLaSjXZpJ8RzZOSCjND7JrqGRFj9BfsjAe+Kr4X/NdeFgte871m+M1YAwC/8cqsbUdP2nBpdoGaEZgltw0zixoNitW5tGH84KJVkLUb3Jre98ESIveROkO5VpssqYBVv5ZO872uBP98hh6DczJBQERwfRv3xmShgssXZV25L1iW9uLHD8SF2VbcAtc4VlTXCQTVPY1RtvwJ+o0nlS6vrVjhqOkSDQEORy7DHTA/X/yrVRscyqDg7nlhSlwe4yEPBJI26AHHwGAE9Y2w3GZCctGwGjkKamwtulEXKp7qgETuoqUBU1E9wzixlFUpRLllA5aHfTc0cEUSs76C4j00XBNm51wFv6tYLb8Ci++/9QZ5PPxEGEo+d9L6pQADfT8+vphmZokPWuSB+y85gjAUo1kjPYU5PamGUa4Nn2BbCr9Dh+WLT4vBVBARabBQKYB8VKi8PqBncUH74YKCRhO8uxoIWQeE01T6OIPswEw81NsRcTC98HvjejdnWPvycoGt7TQlwVOD71rojHafsqESREvMYLmznCVMe4pb+vISOJTPqUlrK8ddDHqNONQmdRzMZHPoa0oHHijJFpEjNCVwH0y3JBxy4Yali6G7obFI0I0/3MPA1ci/Qg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 711a26a0-2ea7-4f11-280e-08d865f14448 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Oct 2020 10:03:37.8679 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gL//tV181QYRgO4FkFoIA+TNruo4CJdFdSQZMiUFccG+k63l+iZXjH0bw9To0gbVp3RSTQ9s6GqDIdOHL1NJ9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3066 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1601546620; bh=gMtIwpJ47ujSdkOOOo9nczr5QrQ4z7rpRG5oXY2HNZk=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=Sf1MTOVB7d+CAA6/rTwq/QBBjDPTMMAR6uriC08B1kGs8xBXMkzS6w1EnyL+L2Fzt J2qGiv3alsHBZ+tLYP7OkFphCYoir9rAQoYeXvyDt01KGui0VwODvR1Ps4rYO01pSw uWa3zYbvB7VZV85w5ubKK9JP7V2nX77PjkWgH3/+QaMa9LN6lPriED4EtGc9JxJ0AX 0iywq7ACmwRCso7QjczAcrxjArGEFKVKvWzfwnZd9daY5p901hx0D521HuWWz4PIL8 n48v1650mMLoKKwcd00yO1J3Vt6JQMiUTDwL0ant0dAuPcdR909/BT2M5qMXrGM8nr e5nHxIc1aqG6Q== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix incorrect meter table define X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Suanming Mou > Sent: Wednesday, September 30, 2020 9:47 AM > To: Slava Ovsiienko ; Matan Azrad > > Cc: Raslan Darawsheh ; dev@dpdk.org; > stable@dpdk.org > Subject: [PATCH] net/mlx5: fix incorrect meter table define >=20 > As metering and metadata features were developed at the same time. The > metering and metadata tables are defined conflicted. >=20 > This cauese the meter suffix flow jump to the same metadata table and > cause flow deadloop. >=20 > Adjust the metering table define to fix that issue. >=20 > Fixes: 46a5e6bc6a85 ("net/mlx5: prepare meter flow tables") > Cc: stable@dpdk.org >=20 > Signed-off-by: Suanming Mou > Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h > index 0907506..1b7bac1 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -503,14 +503,14 @@ struct mlx5_flow_tbl_resource { > }; >=20 > #define MLX5_MAX_TABLES UINT16_MAX > -#define MLX5_FLOW_TABLE_LEVEL_METER (UINT16_MAX - 3) > -#define MLX5_FLOW_TABLE_LEVEL_SUFFIX (UINT16_MAX - 2) > #define MLX5_HAIRPIN_TX_TABLE (UINT16_MAX - 1) > /* Reserve the last two tables for metadata register copy. */ > #define MLX5_FLOW_MREG_ACT_TABLE_GROUP (MLX5_MAX_TABLES - 1) > #define MLX5_FLOW_MREG_CP_TABLE_GROUP (MLX5_MAX_TABLES - 2) > /* Tables for metering splits should be added here. */ > #define MLX5_MAX_TABLES_EXTERNAL (MLX5_MAX_TABLES - 3) > +#define MLX5_FLOW_TABLE_LEVEL_METER (MLX5_MAX_TABLES - 4) > +#define MLX5_FLOW_TABLE_LEVEL_SUFFIX (MLX5_MAX_TABLES - 3) > #define MLX5_MAX_TABLES_FDB UINT16_MAX >=20 > /* ID generation structure. */ > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh