From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D134DA04E7; Mon, 2 Nov 2020 17:27:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A25BA2C16; Mon, 2 Nov 2020 17:27:41 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 265B72BD3 for ; Mon, 2 Nov 2020 17:27:37 +0100 (CET) Received: from HKMAIL102.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 03 Nov 2020 00:27:36 +0800 Received: from HKMAIL102.nvidia.com (10.18.16.11) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 2 Nov 2020 16:27:36 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 2 Nov 2020 16:27:36 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WVNVB9oB074U0MCj/z65x2IXAX/0p85PCvdS6zthRJWTFo5dcNIEpP0CwK93/eYIXx/RGhI4Fdp76QTl+NxNznBDDxgxqm9qAn3R8/C3q3yQ84lS96NO5TRXxnRQlkvE5lf+uepYkK4L/189r4GSN/Y23Q/EuResEfoZQ7YEWYBA95DuzaGrTVlWiupXvOloBcecf+nawWx8fVaKxo2b2VuBRAljwz/1L1otsr8/ugTKkgYrkkEhxEmaT2k/JFmAn9NG+0Vi/IiMghTVUKZLdz1WIq1Dq7IWSKLiFs54TlyKqdhlD6926HZYl8pLP7vOYEM8IPZfs9H9C/tIkv+BVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RkjmLmoJE8UQ5DQliC9MDhFEq/bjL/OOx9rctDe8Ots=; b=Jrr/Yunsv5YTompR5vgbuX6mTm/g0S07ddurNZB15Bb0fZNsDJ4bwQvJpG1rlv1ZzSLxMpRTqscDlKtGs8yrAB05knJ5YZQDEGDRJY2Nm6iOw/CIKqPXgdCMEXKGGqPx7/F8PL5gDeI2ePQqXMBqMsE7pKdIOufKgM2B3cnwngkb8NB8zm6B9r1n+tLU9N9nzHsrHsvIwMLAdH2s7fyYzMxiSk21gmSMMNDUyF0vGcNVNzzdv562rNXAZJgVokPepNHwN0+am0D++JWL1zrR8Yl86b4EI5TI4x+YUVm9VTZpsii58AW8M/db2+akojo2rIZNnCB4Smn+zgTTfNY7tQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB4138.namprd12.prod.outlook.com (2603:10b6:5:220::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.24; Mon, 2 Nov 2020 16:27:34 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51%6]) with mapi id 15.20.3499.029; Mon, 2 Nov 2020 16:27:34 +0000 From: Raslan Darawsheh To: Gregory Etelson , "dev@dpdk.org" CC: Matan Azrad , Eli Britstein , "Oz Shlomo" , Shahaf Shuler , Slava Ovsiienko Thread-Topic: [PATCH] net/mlx5: fix tunnel flow destroy Thread-Index: AQHWrOcAsY0VO95++UmsCca4RBIPB6m1EAkQ Date: Mon, 2 Nov 2020 16:27:34 +0000 Message-ID: References: <20200625160348.26220-1-getelson@mellanox.com> <20201028045806.25616-1-getelson@nvidia.com> In-Reply-To: <20201028045806.25616-1-getelson@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3748188a-ab09-40fa-222d-08d87f4c345e x-ms-traffictypediagnostic: DM6PR12MB4138: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:287; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7hEZ0AWwyvKOUyog48LDxYyigMDjd4IaaCbvVspRBoeSLSlVC07zBbzSjw8J5MaW2jNxXoQFIRGDQx/Sk9zc264xt4TKcNrMVSGjmaxL95/v5DKfFJTO+gkhE9UwYtGfz1u7C1p79pNof8xVKchNnj3+9Kr9OQ49ZMUIgHAzNzpig56qRqElGZj5n++40uTXuJRq8j3fjXBCJjdPzB2PYlzmTjpucr8DQij/lylWsjpOqbkoGSvruHwrl348pKqQDntnGQJiGPFeQQIstHSJYsIH3NDctMVD733TB3WlKGepPsUj8bny5JI3UY9UqBBk x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(39860400002)(366004)(136003)(376002)(55016002)(8676002)(86362001)(4326008)(186003)(53546011)(71200400001)(316002)(7696005)(9686003)(52536014)(6506007)(33656002)(8936002)(26005)(54906003)(4744005)(110136005)(66946007)(66476007)(2906002)(5660300002)(478600001)(83380400001)(76116006)(107886003)(64756008)(66556008)(66446008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: s3OEZIxUOee/UqExXhvA1li+L+7geza0JVO0Ok3ZOKGDstAWYfc7pbbSxJ5quZxEpOSS1mVQhlk+U+I+VNVc23MMRKF8asCwex5eED6gL+OEsS1HAI9a35Fw6MMUxpMN1ScLTrTqfHKEwegRG8B0D9YSGkQe0kqZy+WwESscStgNEm3GJN3Hl4NoYoGfBbowOjbaldfZOFuTIf/X3rBChW1YoeWOt7IOeNhnFpKb9wpGjaxZc0/5aRZEZyPKcyooZFbTy6fC3AD6TuwLMVSp5bx+16wDUW4xuFJ7/IaMgGtBl8hM/gnVzE9oKvh0zRXQHCA7WONnk1j5GkGYCaTNoYha70TqPYLXDKryHcxDLavarD92m6VMU7V5zPWXOpbMmPRLru0MLCxnU9jhC32J/E/aInAaS4xBhwwMaTVA5vgnFSz6fbI0oNzsDAJFHhxq88GAdSWMMBPMRkZE1eIANFHu2+dB0/PGIfRv4NhCGZJBCNFyjI+i5h7rHSTsICWqJaMbNXt5WhVwRHCay5H/HhafO3oArbBOW8piSl7AE5to8lVy88LQgbkdmMWmJp9Un/DBifojO5EtNFlRVxUlYuL4Wz0TKx7r96aAbOZL6Agk82BwQ4qUeNFFTF5ol/zKmP0923hFf3P6e6yJQkMEGw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3748188a-ab09-40fa-222d-08d87f4c345e X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2020 16:27:34.3872 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y6WQ6G34eU2P2Vmo9lcVAYbHYjTXlMpTrko+9Iqd1DONB48WiK8LJoJj0h+iL4h2KRN7+d2XmR+pbrkKnjpvjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4138 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604334457; bh=RkjmLmoJE8UQ5DQliC9MDhFEq/bjL/OOx9rctDe8Ots=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=Y6pCnz4pwPB3DJABKt7DiCzMi6rdBLuyR7wdd5SRyDk2Gk/8iMP9JK6WcdzCDWRGJ 4R6QrO7kTYBrKnSJ4UAqULyhqR+P5Op0YrtQi7yUWwJbRcsQpz9gQDOWuGA28P5RPm YVPx4GX0ithJ8itsUZ8Vbu4NZs5Ft8wsKuJnhSsjjIpgHimAgqJTNquhWG//bms2Or w/iJb+3Hs+ZfY6fePdSjUi/JXCHejhtdL3EHOP+NFLFoT6wrITMYQkUa/sUoMBhEn1 oR/YbamGbp8Yu7NW5B+sb9IwNYg/b/EciLL66lvktDIQyiVyDlX9/elIio1iuujZQW GMPnrhBz6Worg== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix tunnel flow destroy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Gregory Etelson > Sent: Wednesday, October 28, 2020 6:58 AM > To: dev@dpdk.org > Cc: Gregory Etelson ; Matan Azrad > ; Raslan Darawsheh ; Eli Britstein > ; Oz Shlomo ; Shahaf Shuler > ; Slava Ovsiienko > Subject: [PATCH] net/mlx5: fix tunnel flow destroy >=20 > Flow destructor tired to access flow related resources after the > flow object memory was already released and crashed dpdk process. >=20 > The patch moves flow memory release to the end of destructor. >=20 Added missing: Fixes: 424ea8d8fe55 ("net/mlx5: implement tunnel offload") > Signed-off-by: Gregory Etelson > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh