From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34DCBA04DD; Thu, 22 Oct 2020 12:02:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1DD1E6947; Thu, 22 Oct 2020 12:02:06 +0200 (CEST) Received: from hqnvemgate26.nvidia.com (hqnvemgate26.nvidia.com [216.228.121.65]) by dpdk.org (Postfix) with ESMTP id 4A90E6938 for ; Thu, 22 Oct 2020 12:02:04 +0200 (CEST) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Thu, 22 Oct 2020 03:01:50 -0700 Received: from HQMAIL111.nvidia.com (172.20.187.18) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 22 Oct 2020 10:02:01 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 22 Oct 2020 10:02:01 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UFsfLH9fm0+zjil7gFrKbhlC76GlycM06yV5frop7jr3Yh5fMv3JeXQCmJ7rQysumeCH8dmMknbiKdCGcqTr5n4hSxPtPT1a4XAghYKOJhMf73NxWXfeQDcrrU8dbYRGUBarvPgOXTpEb3iRMuS8FMMe5rqjUlYV4HxR9EmKB04Zyn5Mogrep/NmkbdBLF0m9REQ7I6LKgKQ84pS8Qfg8JqhE9mTZMl97i7e93QmXoeTrJpG0x48c4yWL+Z4EdBZhjU6u85w9/I1zEAeab+0Uz6UBXKHk1DWfRVIGfXQ1NTAvryH0oFeaVnupBMFTP7NR35vzR6PEonamnGy/+qNeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=taSlbkdd486XmGvxfu0dk5J9mzfwjQyeJkkA2uZLIrY=; b=Sa/4R39a7CXbggX+7ib3daP2A1158PPqpxh5bYrRQ94xkh287tVdAVH+QqyVg4XaEp2qldFXyoi65uE/qh5sYOJCseV8Yv12Kq4Jk/5DZaOA/Ynf8ZTvnQZw7P6hAA6BpZdVvP0P7vxmJPKgMoTOOigmxk+7Ov2LRJ0VINCU66pF7bWQ9qEN5idnqZ4ONhF7PRr0ObvbBQaFDGQeO5iDG6fkUxmcWSQz27/mNT6LI+gJYWUHE2KMHjocvmCB5h85RnJq0h160ROhT1Uri2Yulau89palP8MRJqPzE7atetof76nGuI9iTFFhiW+UmBDYCSrZt5TH14eBShIHRsN2jQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB4401.namprd12.prod.outlook.com (2603:10b6:5:2a9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Thu, 22 Oct 2020 10:02:00 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3477.028; Thu, 22 Oct 2020 10:02:00 +0000 From: Raslan Darawsheh To: Eli Britstein , "dev@dpdk.org" CC: Dekel Peled , Ori Kam , Matan Azrad , Slava Ovsiienko , Shahaf Shuler , Asaf Penso , Eli Britstein Thread-Topic: [PATCH V3 1/1] net/mlx5: fix IPv6 next proto validation Thread-Index: AQHWqE0gBVE7XNVXnEqR4OqytkeIi6mjZAoQ Date: Thu, 22 Oct 2020 10:01:59 +0000 Message-ID: References: <20201022082629.9160-1-elibr@nvidia.com> In-Reply-To: <20201022082629.9160-1-elibr@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 32ec97c5-3641-4d1a-f61d-08d87671848b x-ms-traffictypediagnostic: DM6PR12MB4401: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4125; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: A9e+86Gj00nck46a7BlHAtV3BtM0PZMXp0nSa7uMATXDrtVMx6Q5/RqVKDrYHK+wz6hqMVfIRN8cNUCB9cGrdiD17mwQY+RsUEEpItIKt2f/6GOcftO1N5t+up+1I3v6i9rKirr6CynwDDOUD330doFbAkK6wLs8kIcSiucLdN7ajvjQ5LaiEBUpCfAJPrBmeIlaWZdAzjIHRRSB5FhyWj3v/y+ur29oQkQ6CfVM8lp8j1dSd8gNW6oFQMWuCwFlvPNQqhI31bNXb1PIwkINAsrOBa7CqHB6L/8c1/5wz2IILYwTtELuP6U4EVdkRaFh4KrP44ntLEhERAG9P4bd3Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(136003)(346002)(376002)(39860400002)(8936002)(7696005)(6506007)(2906002)(54906003)(478600001)(86362001)(110136005)(9686003)(83380400001)(66946007)(26005)(5660300002)(53546011)(52536014)(64756008)(186003)(33656002)(66476007)(8676002)(66556008)(316002)(71200400001)(55016002)(66446008)(4326008)(76116006)(107886003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: 3tfqtW7QDhdgB+JOnZnZR03u7daLt0gtHHl0VZ3qhrDkLIyquZ+8ZbaKtDgmExeASfvGB11m75G2e2ae5BkTBLkzEBby4B1NP3QDRYzy8ASmdB+W9CEz3m8X7e49rKiYp1PMcfA9NCqov554j1Kf1ZioXykCC7kub1V3x5/HUBCd7wUOyNJfO4Kx23XzA5E8moOPaiEdgjakI99nOVbNjfrENM+veBOHd8KBxqnpjz4QfPnSBPpDM+gds7JRGunwbR94A+ZyzdJMCTRFl6FPxaAspdyPOGEYG4dqqpkkdNNozYc843ztCJuSMtNsNHuvcymw02HB0fMH91xQjows6sQ7qfcHtW26pk8VkeFkdC6p1u8vAliNrh8/Sfv9/qncALlIABipMZ2+I/k51LSC0LitDhwFlKP/aboBsRYRGBFksy98f31trhU05VkGZkGZZW6uT4Uq0t5w/f1tvK+JpLEQ2sGUNuB9Gp5/ixJc5EkYsTrL1qpKphgioD6tFotMcdLZWuXIR0T9nhQXOn7bl3ljRBg6gwUztqeNpCW8Hx5stUYO+VF66PVq5kpCQkhXhBMMj2d2E8OXW06aPAdgOCplm57PZTrITPfLNxFQac4ZCrP8SD6+2xXVpycbTTB974JQVSl3JPpiK4QeJSeqPQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 32ec97c5-3641-4d1a-f61d-08d87671848b X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Oct 2020 10:01:59.7823 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IUzilcsiHJWRiTQ8zLa2UffMMVCXVB8+583rCNaC67YXRHliFpOKCM1g2dMz0hcQslIrApLFwNnnH6j0bYQmzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4401 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603360910; bh=taSlbkdd486XmGvxfu0dk5J9mzfwjQyeJkkA2uZLIrY=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=P84FX8NtNX95d552zM3J+U7iF4b0Pbl4NcHaZFhduEEyD/6Ah4Etvuj/h/oz4u8d8 k7VOfr7/dKjTrvOhKkg3a/9LJSBEoTIMV5PrZVzfN3WCeb76sTiy7CLvf7tQNSOQLe w/aLo9pwdsdchazdImqbCEagiBPmgyyQTv6dTiraV9kgrlpY1Grc7iT0QceJVVBNL2 oVVZABMeitCczxm2BGm5fLepbLiPBjinBOLJLJxblbUBLMnZidRPvl4KZ7sguDAx2i IIqeWEnY4YB0Kb28i12QpX7sV96htigP87uldvpYsA35/gmW6kHkcNGnjsUDEZreq7 wQfQmY10fgGmw== Subject: Re: [dpdk-dev] [PATCH V3 1/1] net/mlx5: fix IPv6 next proto validation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Eli Britstein > Sent: Thursday, October 22, 2020 11:26 AM > To: dev@dpdk.org > Cc: Dekel Peled ; Ori Kam ; Matan > Azrad ; Raslan Darawsheh ; Slava > Ovsiienko ; Shahaf Shuler ; > Asaf Penso ; Eli Britstein > Subject: [PATCH V3 1/1] net/mlx5: fix IPv6 next proto validation >=20 > Previous patch added validation of the IPv6 next proto field, in order > to overcome a known limitation. > One of the values checked is IPPROTO_HOPOPTS, which is defined as 0. > If proto field is not specified for matching, or mask=3D0, as in the > following, a wrong validation takes place. > flow create 0 ingress pattern eth / ipv6 has_frag_ext is 0 / end actions > drop / end > Fix the validation only on proto asked by the user. >=20 > Fixes: 92be60e1b541 ("net/mlx5: enforce limitation on IPv6 next proto") >=20 > Signed-off-by: Eli Britstein > Acked-by: Dekel Peled > Acked-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_flow.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 22fb4ee60a..d7243a878b 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -1979,8 +1979,8 @@ mlx5_flow_validate_item_ipv6(const struct > rte_flow_item *item, > RTE_FLOW_ERROR_TYPE_ITEM, > item, > "IPv6 cannot follow L2/VLAN layer " > "which ether type is not IPv6"); > - if (mask && spec) > - next_proto =3D mask->hdr.proto & spec->hdr.proto; > + if (mask && mask->hdr.proto =3D=3D UINT8_MAX && spec) > + next_proto =3D spec->hdr.proto; > if (item_flags & MLX5_FLOW_LAYER_IPV6_ENCAP) { > if (next_proto =3D=3D IPPROTO_IPIP || next_proto =3D=3D > IPPROTO_IPV6) > return rte_flow_error_set(error, EINVAL, > -- > 2.28.0.546.g385c171 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh