From: Raslan Darawsheh <rasland@nvidia.com>
To: Matan Azrad <matan@nvidia.com>, Slava Ovsiienko <viacheslavo@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue stop state
Date: Thu, 5 Nov 2020 17:41:25 +0000 [thread overview]
Message-ID: <DM6PR12MB27486001E5B504845EFCF8AACFEE0@DM6PR12MB2748.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1604386112-342335-1-git-send-email-matan@nvidia.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Matan Azrad
> Sent: Tuesday, November 3, 2020 8:49 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue stop state
>
> The Tx queue stop API doesn't call the PMD callback when the state of
> the queue is stopped.
> The drivers should update the state to be stopped when the queue stop
> callback is done successfully or when the port is stopped.
> The drivers should update the state to be started when the queue start
> callback is done successfully or when the port is started.
>
> The driver wrongly didn't update the state to be started when the port
> start callback was done what remained the state as stopped.
> Following call to a queue stop API was not completed by ethdev layer
> because the state is already stopped.
>
> Move the state update from the Tx queue setup to the port start
> callback.
>
> Fixes: 161d103b231c ("net/mlx5: add queue start and stop")
> Cc: stable@dpdk.org
>
> Signed-off-by: Matan Azrad <matan@nvidia.com>
> ---
> drivers/net/mlx5/linux/mlx5_verbs.c | 1 +
> drivers/net/mlx5/mlx5_devx.c | 1 +
> drivers/net/mlx5/mlx5_rxq.c | 4 +++-
> drivers/net/mlx5/mlx5_trigger.c | 1 +
> drivers/net/mlx5/mlx5_txq.c | 3 +--
> 5 files changed, 7 insertions(+), 3 deletions(-)
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-11-05 17:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 6:48 Matan Azrad
2020-11-03 6:56 ` Slava Ovsiienko
2020-11-05 17:41 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB27486001E5B504845EFCF8AACFEE0@DM6PR12MB2748.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).