From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C93AA09E4; Thu, 21 Jan 2021 13:10:35 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C6EF140D21; Thu, 21 Jan 2021 13:10:35 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by mails.dpdk.org (Postfix) with ESMTP id C5223140D0F; Thu, 21 Jan 2021 13:10:32 +0100 (CET) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 21 Jan 2021 04:10:31 -0800 Received: from HQMAIL105.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Thu, 21 Jan 2021 04:10:31 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Thu, 21 Jan 2021 04:10:31 -0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 21 Jan 2021 12:10:30 +0000 Received: from HKMAIL102.nvidia.com (10.18.16.11) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 21 Jan 2021 12:10:29 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by HKMAIL102.nvidia.com (10.18.16.11) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 21 Jan 2021 12:10:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bcfDtKvzEwxfP3hIWsc9hNHCjVPuNo714mDbyuPvzjkWtf72A7BrR9vR+nMe0xBuDKpurFQSXjp5TviA0wIk9YlJBiC0eOlQWoxMJsKMQ3Au2tJd0dIb5K0e+MFGbmL5BpCChBv5LWiBTA1B/YiggLjs804NK1c2xpWgBieQulXAFHy/senk4dwxVGxSyDxgA/GAHZo0TR/cLIlQfDNzIpdbemkACI+Fy++U7WWqNIEGS4spj0/qzMVwccbUm5dBo7XMPrG4yb4G3wSDApZFTl7IMGA+R50pLcOS7Uy8//fA3w9gRMp+xw50GQQoTZCb35a8kt5MnCaLwXoHJL1LsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5lHnjwjLoZssc9PBCUtInxp7gIvVYHZQN38lcdfF65g=; b=jeANLdP2wVcJizFUxdzhVLizFdeCxVzw+47lGlZuXaoKsSCCO+fUj9XjogO9SquIOtSAU5869xuZvY6VjiCqK0+LWTY5O8F/JSza3pqhqmsDtk9jpGwmtrHDSHAhM2ukEcA5MOWzBpQTA1NDMaxoKcmxEanzbULbsxa9STjFOmInBi5RCp6RcwWyyWsXRBW9zTTULr4gba3OfesbiMRa5EhH6MJgp/4HOH5Qr/ZYuEIRmq/n0MoaXJO/wIw1IE/1BpbM/q104XqD6GzwwqiGNxUSGnlbvgi3ScT3CNpdRm5112WdHiKpkpZVNaqUR59jZTASEEjuk7Xq1E1G/iw4IQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB2375.namprd12.prod.outlook.com (2603:10b6:4:b3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.12; Thu, 21 Jan 2021 12:10:27 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::759a:fb10:c6af:87a3]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::759a:fb10:c6af:87a3%7]) with mapi id 15.20.3742.012; Thu, 21 Jan 2021 12:10:26 +0000 From: Raslan Darawsheh To: Dekel Peled , Matan Azrad , "Shahaf Shuler" , Slava Ovsiienko CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix flow split combined with counter Thread-Index: AQHW7LTp0uGfXW1AUkKQNsBkm6ui0KoyA0lA Date: Thu, 21 Jan 2021 12:10:26 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.199] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 87b2d328-3e15-488a-05c9-08d8be0589cc x-ms-traffictypediagnostic: DM5PR12MB2375: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NNimKs8OXGslV35m+wzln6na6QSuZdZ2nhofC9jO6sJM7cMl5k66LhFrZtM8z4VfWdW5n2QZVMK5uP4Sk+oxZDIKrGcqyDIpordCEWLGXtCwco1lOnSfW1OIPqOXbn3FTdfsx3tBK3N1uKf9vzpFI0U/SaKtlPOHEYE6JlbH78iCjWvagpXsI6ApZMC9TmqGxoZj1nHaq0B1baTJeC7T0sz7JTnmyYiyQFQuU04bcXB1PwNEzhxEesSFs/y0cUW2bUkvVsNbHmGZqTJ2BGqSTgH4ZMzNipB1j1oqIEB0u0NBoboG56Xr34+AvxTZ+OK53F/u6JgN0b6FLDdUXqxGH/YkQYgkOq0sekPH7jsrDg8Fb5nurwbQ205M2gRRGB0LGw1leTouizawbkRpZ9Gcwg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(376002)(39860400002)(366004)(316002)(2906002)(110136005)(66556008)(66476007)(450100002)(53546011)(54906003)(64756008)(5660300002)(8676002)(4744005)(76116006)(66946007)(6636002)(7696005)(8936002)(52536014)(86362001)(26005)(66446008)(478600001)(33656002)(71200400001)(9686003)(83380400001)(55016002)(4326008)(6506007)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?HiLWTPorgRuwsOEgoiIOCoxW77KShJtdkVQDf/RNOcIYMBvmBIeLzM4FILiI?= =?us-ascii?Q?jGtiifmgnljJ39xhq3Fg7dcl4WRSVAUqg7nln8rHoxsdYIP+hNUx1rNgWkhd?= =?us-ascii?Q?o8n9q1UokOy7WxSuLAJwXR0ftBs1z8MKdkds43DHfi7syNk1PYPRCx/oBUtK?= =?us-ascii?Q?WFLNrrlt9C3lRQ6vhDdXZUpN0Ca2OadWS64xrm98W2SFe7i5fQP3D5obg4xz?= =?us-ascii?Q?jU4uyrgoPvRjZKn+hQ9mp0Qq9xH7AHITCveCsERbV+1X3JKzINzC3G4vchwe?= =?us-ascii?Q?oJXyaRyZK4Hk2ZCUpguFYgElGvmT3bloO43S/1ukGl2TT4qxPVUfRYSgV/Fq?= =?us-ascii?Q?wVg/Eb/7EsN2hm9IGS/LOI62Z2hjH2y6bAd9IxVB11GlJ4S4RweRUgd9cnYk?= =?us-ascii?Q?2bJTXDZ61NPFII04zEVfNfMERrtvdSnBJgEF7EmZCWiTNx3ExP9OJAubGDGH?= =?us-ascii?Q?F93LRzyBvbFRM8/lDZPYdIVGCZgWPg7id2fYnfI8dsVdF9NvpUuj+9No6TjZ?= =?us-ascii?Q?5KBLfA4FnxAxGdBVvACytIjfqdV8/oMQJGZNAAn7qyxIVQWM6lfsRKjTyObS?= =?us-ascii?Q?AvLeCOQqhkxkFIJA3POguIwR5d2y3ds6eHboVU6FtsqdBH6WI3RDfKMfnhHe?= =?us-ascii?Q?EYC+2hbmUeu6Mt3ZGl5ctf5/5dGbjJQsXQJZ690AopvkRCkqqPQLD8339Otr?= =?us-ascii?Q?B2RkFTf1/omwieUi/K/Mu8KQgvNL1ZvZ/o2FZGTdJSUKlssHVonk9k//ciQF?= =?us-ascii?Q?jEyKfgBo1pOIuYCTYGLEQkrHil1xG3FYaUvr/DIQkgPAcazMuj1vm5Mg9uzs?= =?us-ascii?Q?aMwpdhcvvz7iEb++a6WZAiqAI7cE/Lu2hfTSyiTBoNj03VS6D79Qy+kVaAgN?= =?us-ascii?Q?hVSGXngRBDSALA8f3Bz/Svf7GiYa/K8ysz/GxHkCiJauzgxWS+qPtCDFU6jb?= =?us-ascii?Q?0z3Hp3cxbA8MObeDQS6+qgOMeSkd2r7Xic/oOTV3DpM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87b2d328-3e15-488a-05c9-08d8be0589cc X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jan 2021 12:10:26.7169 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IfXrzzdlflsseSN4XCh8cBsF6tdAAti4NHgN+3AwWh6JUO1P06feBtg1/lqsG8SZtUz9cjMcLUkBpZ+YGrpbuQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2375 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1611231031; bh=5lHnjwjLoZssc9PBCUtInxp7gIvVYHZQN38lcdfF65g=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=N+9ZcamH4HGi84cYFs92FGhCDd4QQZjuekaH+xEQvP7m2rP4LOBrVN17W7EhqXTry Ffs/QaBC0ItuzOm61swusrP8ZZQ0nuwj1PuAo37juWFgrZB6czVYs1grId80n3T0GV QrXp05sMM2nYNJY+aKM/TKExo7fnzIO/t7Pxb59cafPxYy5jdETRvRlv6VAxWoA8aH RcHEaMMLV+iN5HTn+eQ3tsVFlsiXxTISRN55ORlUb6vmH5FI89FTrEV2BnvRgNGNA5 BQvMmFkWzquCGOwORCchxMEdnNYKmcfDXu8qrdxeZdV5e6V1w5w1y5qTbPk5X2qQLZ oLtS+sK3VPYjg== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix flow split combined with counter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Dekel Peled > Sent: Sunday, January 17, 2021 11:41 AM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix flow split combined with counte= r >=20 > Currently, for a flow containing a count action, if flow is split to > sub-flows, a new counter will be created for each sub-flow. > However only the counter created for the last sub-flow will be queried > on flow query and cleared on flow removal. >=20 > This behavior is wrong, causing a leak of resources. > Need to create just one counter per flow, and use it for all sub-flows. >=20 > This patch adds the required check to make sure a counter is > created just once per flow, and used by all sub-flows. >=20 > Fixes: fa2d01c87d2b ("net/mlx5: support flow aging") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dekel Peled >=20 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh