DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: fix TCP flag field modification
@ 2021-02-05  3:03 Alexander Kozyrev
  2021-02-05 16:27 ` Slava Ovsiienko
  2021-02-21  9:32 ` Raslan Darawsheh
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander Kozyrev @ 2021-02-05  3:03 UTC (permalink / raw)
  To: dev; +Cc: stable, rasland, viacheslavo, matan, orika

Wrong modification field ID is used for TCP flags: the inner
TCP flag field is changing instead of the outermost one.
Use the proper field ID to match the expectations.

Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action")
Cc: stable@dpdk.org

Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index 76696b7b62..a44291a3c9 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -1653,7 +1653,7 @@ mlx5_flow_field_id_to_modify_info
 		break;
 	case RTE_FLOW_FIELD_TCP_FLAGS:
 		info[idx] = (struct field_modify_info){1, 0,
-					MLX5_MODI_IN_TCP_FLAGS};
+					MLX5_MODI_OUT_TCP_FLAGS};
 		if (mask) {
 			mask[idx] = 0x0000003f;
 			if (width < 6)
-- 
2.24.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix TCP flag field modification
  2021-02-05  3:03 [dpdk-dev] [PATCH] net/mlx5: fix TCP flag field modification Alexander Kozyrev
@ 2021-02-05 16:27 ` Slava Ovsiienko
  2021-02-21  9:32 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Slava Ovsiienko @ 2021-02-05 16:27 UTC (permalink / raw)
  To: Alexander Kozyrev, dev; +Cc: stable, Raslan Darawsheh, Matan Azrad, Ori Kam

> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Friday, February 5, 2021 5:03
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>;
> Ori Kam <orika@nvidia.com>
> Subject: [PATCH] net/mlx5: fix TCP flag field modification
> 
> Wrong modification field ID is used for TCP flags: the inner TCP flag field is
> changing instead of the outermost one.
> Use the proper field ID to match the expectations.
> 
> Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

> ---
>  drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c index 76696b7b62..a44291a3c9 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -1653,7 +1653,7 @@ mlx5_flow_field_id_to_modify_info
>  		break;
>  	case RTE_FLOW_FIELD_TCP_FLAGS:
>  		info[idx] = (struct field_modify_info){1, 0,
> -					MLX5_MODI_IN_TCP_FLAGS};
> +					MLX5_MODI_OUT_TCP_FLAGS};
>  		if (mask) {
>  			mask[idx] = 0x0000003f;
>  			if (width < 6)
> --
> 2.24.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix TCP flag field modification
  2021-02-05  3:03 [dpdk-dev] [PATCH] net/mlx5: fix TCP flag field modification Alexander Kozyrev
  2021-02-05 16:27 ` Slava Ovsiienko
@ 2021-02-21  9:32 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2021-02-21  9:32 UTC (permalink / raw)
  To: Alexander Kozyrev, dev; +Cc: stable, Slava Ovsiienko, Matan Azrad, Ori Kam

Hi,

> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Friday, February 5, 2021 5:03 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>;
> Ori Kam <orika@nvidia.com>
> Subject: [PATCH] net/mlx5: fix TCP flag field modification
> 
> Wrong modification field ID is used for TCP flags: the inner
> TCP flag field is changing instead of the outermost one.
> Use the proper field ID to match the expectations.
> 
> Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-02-21  9:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05  3:03 [dpdk-dev] [PATCH] net/mlx5: fix TCP flag field modification Alexander Kozyrev
2021-02-05 16:27 ` Slava Ovsiienko
2021-02-21  9:32 ` Raslan Darawsheh

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git