From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8006AA04DC; Sun, 22 Nov 2020 14:01:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6550E72DF; Sun, 22 Nov 2020 14:01:11 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id D347772D8 for ; Sun, 22 Nov 2020 14:01:08 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sun, 22 Nov 2020 05:01:08 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 22 Nov 2020 13:01:06 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Sun, 22 Nov 2020 13:01:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VDDm9YpQNvUsPAt+xVFz5hQpZjQzbmOhHga2E7mAyLhdiJfNe7T3+DH3OX/NgJvO5bL/0/uvywnrsKYjJTohjYZHMynx3G71VM8jVTJSWfR2gefeTt8EK6pPvmVwVioLO+khOFBfA7ANbJCJO3jsqGNKMpqwQaElGxMnX+IxjUciFS2MObqTNmAGBqQPYz0eJzwuiHAhXjJ2KXKF3DHgCzbwxs78GFAzd0LWXgXfka6RwfLyAYUyR8NFjgHsZ60TzS5zhz8PmhghbZBaqYmbwjwHKzgljXsNupLywOUuFGfgt82RmZL7BAerkDKn78uh+yCtNGv5bHmFrHN4J5wYSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FpfQHK006niKWzwzxqf4aR+wBn6dJ0/pHt2BMYNrTrg=; b=Hw+x1tcYwLs9LUoLBAkyFx3zmPK2AI5VRqQzlnEKVCCYWyFsKTDVs3BOiPEA16+Ww0sJXAUISQ+vECwdEYM+Ko4cMSazR1p4U+PyHOjKD4CbJuZn9p6+UtNHB/HA26pJTHcZXy4S85XHEE33KfbyLBJKjSpB2R1/y/4LTI9WsPkIWphHZtbyr+lhzQyP48WzitvKUF/qVxfe27tSdMh/YwzqvqaA/zIpoeWNW3+V4EHLHK7KP1/VzSPpy3YPWaveN670FRaPCZJJ0HgFvoeABbUrDjgrne+NKf+jft3+HQRA/HDHdvdgprdLoG/mwKa4zlWCYgaiWVaX963BSCyG8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB3532.namprd12.prod.outlook.com (2603:10b6:5:182::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.20; Sun, 22 Nov 2020 13:01:05 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::759a:fb10:c6af:87a3]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::759a:fb10:c6af:87a3%7]) with mapi id 15.20.3589.029; Sun, 22 Nov 2020 13:01:05 +0000 From: Raslan Darawsheh To: Alexander Kozyrev , "dev@dpdk.org" CC: Slava Ovsiienko , Matan Azrad Thread-Topic: [PATCH] net/mlx5: fix mbufs overflow in vectorized MPRQ Thread-Index: AQHWv7hljkxmoU9080qme0olL0nT+6nUH4iw Date: Sun, 22 Nov 2020 13:01:05 +0000 Message-ID: References: <20201121034239.13404-1-akozyrev@nvidia.com> In-Reply-To: <20201121034239.13404-1-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.205] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b196bd3b-fd6e-46e5-2d11-08d88ee6ac51 x-ms-traffictypediagnostic: DM6PR12MB3532: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:849; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EfoqB0kucySKxBooOaZvG5yG0DjDG+Xot2D5eOiRgazvkk3xIXuEDO3aGkVILKqAtcE13rLD9PmZ/RuxzxxeO+Dl4yLfJC+z7nFz6hhT5NaOUqyhKFN94wQ1B4AoSJr0VtcfNfczU3L/yT4eYEJil2Ms0R1ZTWPk262e82k8pSjLwSwt2rK5sUfnx+mdj0uo69mCxMiAKe+SSPlJnDJWAGWXZ6e2NmkIxHxmIPR5YhIUCDJBFqnLcTeL7TSRNlXh1lE/VAzzlNVMPGcVWAavyB151VVmnlvlVGsmr+A5saiundsXPV9XOAn5CaCpX4a/NXBsliZf89FVRCzHpFEp3A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(39850400004)(396003)(346002)(376002)(316002)(107886003)(478600001)(186003)(66446008)(26005)(55016002)(110136005)(66556008)(4326008)(71200400001)(8936002)(66946007)(8676002)(5660300002)(2906002)(76116006)(54906003)(64756008)(66476007)(9686003)(7696005)(33656002)(6506007)(86362001)(53546011)(52536014)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: Xs+o1sYtyjp4kbC507Gmh70s86wGr6z7N/iyFrN2xCxeVDnEF6SIXiHY4yzsC3oXzXSP3mbRJWGVBARXIOYA7c6L50IdkZ9blJrAMmhMtFyeJu77EK38U7mGIRTJcfwUvENzUKWP85nh3iI17NL5ld+iVf6dmFdw+Z9BgpDu6bOlM4n8LmEB6yoC7k0baIYdl8ayQ64WxoDHuNNw8QT8XOg5Jw6igmvCGzCE4xbM6Az957B9Tm6vdUgHvIHSbwPY3YncsdOTOOyJrGcPZ4oYnBbgz0JvyTxzXZmP4bWf3yam4C6oJYWBTPVb4Y3ykXU0xTJkyUs5tAzcfurAcQW3GKh5mIYr34tZ6thn1UipKatW+tqOl/yb7SAxeTL229MMPZ1pq/LT3TSQzAcwsBQtFVKY8V1tgNBkxcVFE8gPbcPxDVk/gc60Drni4IofOPJZkkEF+ayvG+feT38JR2tuiMcB0UorPZqYpR7uSi0i4ODlvLp0ku/UXK5QLIr5thqBbEDzHCTBI7BWmydtTaKopYh26pRnwbQ7+eKVOO9rTZQdvf2wFS/eznt97Pq4o3TmPRKoUL1yGAbyHcOJRJnllvp9ttz0OTiIjZ32Ly3NDkiU92jIFZ1GtOGe6E5j9EWQeqTOZqhm7qx5fJ53oQFPNfscViTVgb2GbycvznLp/Ztahexc+rOREtEygUhRMeH2mOWkmtEWHXXt+VM6xQ3M0Tvqi4xx9iEVfPljTED/oLEsRIZm4Gtnm1IwEYrVaPyJscipf98Y98rCl1232+c57+ttb2nXAo3IMy7X4jae/EW9YVyOVqlnIf+lpSzVf9HLX7HTcgOvfytZ7KgIJjlQWU3Wm0kHEW+p0IW0C6qOZ6nBr/5OP9G1dYoYUxU59PIpX4WRhHfhRDAl05JkxvQUPA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b196bd3b-fd6e-46e5-2d11-08d88ee6ac51 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Nov 2020 13:01:05.6669 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jjj40ghxQth74hKwbMCv1XvCwl5GA8IHbx401kLWnhKCGNI506pbxtdtfwlj5+MPN24xDVlAeaiLyEFqFz9YIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3532 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1606050068; bh=FpfQHK006niKWzwzxqf4aR+wBn6dJ0/pHt2BMYNrTrg=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=UZ89IVOl2wlDsSuC5un7fRQmZxjMXfwKzUxLu59/v/yg5e/Bmb4KwmWe5ofJX2xKQ T1mfM9rrfqg4NfPzJrae4NYtxxkjmMb0M9h1yhpp6nd+4ebWeLsS5DHOkZMyQBTNhS 4eDG6y08qCEWBiWZHef0jKfatGuSaMI6CW9JcH0ZKzM0kisrfNeevcjz2xJVMBMp18 3iD1zDJlatoom/REsihRvJdcthEhPnUVHPuFXvy1MBmXWdNWrdH8yeAx8m/yhVahMN p72vrNgz/q/g8nI7++K7IHoSojPG9SCsLV2jn/zM3UvGiBfqx3KUcvBagyF95HKDZW Mt4SL1viJNbuA== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix mbufs overflow in vectorized MPRQ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Alexander Kozyrev > Sent: Saturday, November 21, 2020 5:43 AM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH] net/mlx5: fix mbufs overflow in vectorized MPRQ >=20 > Changing the allocation scheme to improve mbufs locality caused mbufs > overrun in some cases. Revert the previous replenish logic back. > Calculate a number of unused mbufs and replenish max this number of > mbufs. >=20 > Mark the last 4 mbufs as fake mbufs to prevent overflowing into consumed > mbufs in the future. Keep the consumed index and the produced index 4 > mbufs > apart for this purpose. >=20 > Replenish some mbufs only in case the consumed index is within the > replenish threshold of the produced index in order to retain the cache > locality for the vectorized MPRQ routine. >=20 > Fixes: 5c68764377 ("net/mlx5: improve vectorized MPRQ descriptors > locality") >=20 > Signed-off-by: Alexander Kozyrev > --- > drivers/net/mlx5/mlx5_rxtx_vec.c | 17 ++++++++++++----- > 1 file changed, 12 insertions(+), 5 deletions(-) >=20 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh