From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1089A034F; Mon, 29 Mar 2021 11:06:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C7A6140DC2; Mon, 29 Mar 2021 11:06:46 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2081.outbound.protection.outlook.com [40.107.244.81]) by mails.dpdk.org (Postfix) with ESMTP id EB30B40151; Mon, 29 Mar 2021 11:06:43 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F+MeM4K+Jk11YqazZNj/fp9zA3vkySZIa1JM0A9qkh0R+zMMYQQz+C9k1W3UDxxambjf6uu1hYTLaErP7sSuL4cu+BHUG9sUtP9x7hlm2VDEaoMvc/smDtr6MA5wJ/nCp2Bw2kIMczUywOpodZfzbz/wiyjgQt0agvKO0ciuxXYT1bT5clJX4Qyjfq7dvLG9numRyHAuHxAxF65GrdmDYq5ve6hx6S+PhSAl9PvS1gmh5Yx0mkD34GRhYn0gvz5x6g+EIOAk0+SzS9if3mOEz9oJn8g8380t0VJJ9/CzuzI2KT+S1WNOiz7dsDZEduxuj8WvU/OgjMay8ScOmGJwTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CxxgJzjsnekEtWsUZUJovx4PQLIHnCRCMPt1BsNq4o4=; b=kz3sZQYEShIMlVujIhWFk7WenmHT2NMn3eABzApE03ZlrX5ryRM+f2Y2QpWbJ/3FFddilzVAPLzuM5nwypAgNae0qfS5DdCZmErySWSthPed8WDLLd6IvYX7xn9ocGj0qPrEqtOiqI6Eor1+EK4UHlkpFBIrzHdDtr6MZUTGbTc6eqBHDKI6cqLIW8nfn+fFvdr2s+c/DFY6zwfzcAL3NbqRBKmjAQ1G5Wo+UqatYLjKAYozKfKC2wk93oDFa3KZhulA/qN6cC1d7XwaHw6hDlNtSUvXU5ZhttTLLGDySkzB3bpZn/u6MKDjs0qt08HLF3kIi2b7eles6wth4eKfUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CxxgJzjsnekEtWsUZUJovx4PQLIHnCRCMPt1BsNq4o4=; b=dHIwR3reBDWogrV/XIdJy1ki+JdG2lCEZHQqYrBYnmkEOpqA69Og3OXQ6IIAd9L1v6mWGpQBXG3AsAZOm4ACA7psjgFqNHb5M2s2KLD1e9euCkcJ/imfq/qMPBj+RIDQeRCsJOb3w3B5oAQPMQnBzfKWnpogtXcYEUYd4/MnN8CLCy6tixBfjqeDA6g6Z7Z8pwSSa9B8kFbvdioYgxb9ZJrGJWXO0LZL6fUYfSuzQO9yo/qHrW9XUaoc74J+aS/V1ZTKJID7plo3hjcwEMDUra6X35zO+Z3nsafF/i2r5i6SKf5DVlmJNQyzLwlbB4UALqvQynsRpCK8Pe/S/GP0AQ== Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB1420.namprd12.prod.outlook.com (2603:10b6:3:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.29; Mon, 29 Mar 2021 09:06:42 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::3d94:1f7f:178f:aba2]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::3d94:1f7f:178f:aba2%6]) with mapi id 15.20.3912.031; Mon, 29 Mar 2021 09:06:42 +0000 From: Raslan Darawsheh To: Ori Kam , Ferruh Yigit , "dev@dpdk.org" , Andrew Rybchenko , Ivan Malov CC: Slava Ovsiienko , Shiri Kuzin , "ying.a.wang@intel.com" , "stable@dpdk.org" , NBU-Contact-Thomas Monjalon , Olivier Matz Thread-Topic: [dpdk-dev] [PATCH] ethdev: update qfi definition Thread-Index: AQHXH93CHFKg8hGNOkKmiIu21+55uKqWQ7MAgARubICAAAKu4A== Date: Mon, 29 Mar 2021 09:06:41 +0000 Message-ID: References: <20210323121134.19113-1-rasland@nvidia.com> <20780a26-f27a-8d43-27e3-744293538cca@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.18] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ac3f1c65-1f6d-453d-98ed-08d8f291f821 x-ms-traffictypediagnostic: DM5PR12MB1420: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nypJkxO1ECFvar9uT2OgyWj1KJ1Q/X6waGaRxiiaUQbDiZPUXZk5s+xRndcDtsdWRtvpAjfShBLZ02ARzT8b3ThbB2DbSHQQsJLbsT7pmSgGNg4d0qfxoBXLP1r6XtS4fcuRjYiWI/euZZodIq9kCd7c9ormz6mAZgy1fSquyim/VF8cbkPk8ezObOIodh4M+2JRj1dBNCJK51KbyOkZ72BKRmiLcGeI3NtV3q5s7UVTusNJdEws8OHmTyCAy+VxFzfRBOMepsaPwI905hhHSBjuUUjM8V5o5zDBlmOMCNKtQi02LOXlP0l35tg4ahYA8ZnvigmPrEVkLLESGg+QtzDmT7FaCF5UJeV/qhriBV6GZU9gjywg+HTtsCI3FfP5rrNR/Op4hm8hV6XuGi5RKoFkaZoutCB07PIJHkh/uAqXi/JIU4FLjsH7UtwLU4+JVCTBtmcEJy1Mx6L5gBPgNZCEFrcpPzwTDXo/palHUUZyY1UdbNUY5ULauSvNo+WexGuYHr2835+bpU7LFaVWSRBfID+wINE24UxBBL6O+4wI+nVQjBd0G+WfDbGDV/MZsK3Ib53XInYjiI2m6JGgcRo5I7JtFUcE5YRv5K2sN9szRIhOHxliEXxhuU7v7KZMmLuLkbCFBmBI5sySGpiy96ip/viT8OA8a3urkzOTKwNlr+Cbfo7FAACHTz4admB9ne3Oqf/7Sf5diMixiPQNEo7fDR3kjOddWtczJAK5LvU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(366004)(376002)(39860400002)(136003)(64756008)(66446008)(83380400001)(8936002)(2906002)(66476007)(66946007)(110136005)(478600001)(71200400001)(33656002)(45080400002)(38100700001)(54906003)(66556008)(7696005)(316002)(76116006)(86362001)(6506007)(5660300002)(26005)(4326008)(186003)(9686003)(55016002)(15650500001)(52536014)(53546011)(8676002)(966005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?0kHWTalF1FCmcjJbGcSZ/MZAHoUu0X1NgsLyF8AAvRmz7efLO7GlPvzC+lV5?= =?us-ascii?Q?c1FP1GQT/JuHDiCffjXiI2YjGkMJ97s2PUDTgROv3zk81K53gnMW5P9DxFlK?= =?us-ascii?Q?GKivun+HGyBpTAMW8Mfj3/4J6Fl7G9UNt4Ob/W2PbBJIOWsnb7XMEb+Lm6AI?= =?us-ascii?Q?H1sBp+wt2kds87qhABxoCzMy+bonPesNHN2bydRGbBV9tm/4zEJr0AHEE1tg?= =?us-ascii?Q?JQCATUNxyZaHCEXTerUnzI7G3t6R6zu+7Je1Y2S9fh0JPqqqTPSc6V6hiNB8?= =?us-ascii?Q?zWPEm9DF+UnS2Z5vvphqFgdIrec6HICAb6V7WeW4C0ySV8zbpSGLj8Yir5Tx?= =?us-ascii?Q?McLYl/0/7RCvUinxXLpPCmYJPRrhCK5WlSEl7ZexVpHNf8xNDqi+fcrLh7Am?= =?us-ascii?Q?m1KJQg4gb3u2PcBQEWD/T3HuyDWFjhTJ1Z2N0TvCvhtU3Daw5WmD1iB0tRsD?= =?us-ascii?Q?kag6vH0MW6xbVpt6Xz1XSg6cONMIISj57HZqoqo7P7n4tv4K7WSX3abFkVV9?= =?us-ascii?Q?hv+Ayz2T0+UQsFfcXZr6R6DHtRf37NM882Sp7kvPeBUGVR6dSMbij2nzsPzz?= =?us-ascii?Q?jIGKh8ZFx1H/QUn5DDGliy7xGLsjktV4XFR5HUeb+HHUKKgNIndOI43SgqW2?= =?us-ascii?Q?7APskNPPnGgt+s+MIv6bUuyKoGlYMTDgHdt/HV9URXFS2qs7y2yHF/lM6/zi?= =?us-ascii?Q?F0g7GrAKHKPDfOUq4e40CCE9nV9wslEu2O7RswzWjEVDxso07+ZSvX7cuSBk?= =?us-ascii?Q?CPEDBb6pL+QjJDYkFl7i27h3NwrdKbAnhPNhu6dEfYN4TIwY3iR7nlFFDNkc?= =?us-ascii?Q?JGzhdoetnmtxF9/nOlNhtVjFa2Yg0yx2fbbuRzUtEj/OxACb2FyyAkz+k7f6?= =?us-ascii?Q?XD0Rg0UvqHMUzndabezqV12G2DmV5sRZXv47B/00U8Ne/1cCkr5lyN/YMV2w?= =?us-ascii?Q?fWI4689vrp6WihDLko0qUuWniiGjNE6NDDwFPkt2/i5yEQlmMZRGPNY54xbl?= =?us-ascii?Q?hAcr9eQI7Loq7hResFw4XoIw6lImzJEVgTJLEtyVt0ol6MntJyUxnoJslkix?= =?us-ascii?Q?rV+B4UskNX6wSmsnZ8MKmXmen3sWsSClzuF7C5Vezp2tihsOPSVqu7Plx+hE?= =?us-ascii?Q?ASR2F3J3Vyb+U81oNnM91w/leolODya3O3WG69cXbdgqeTVMQZ5czOGeRjnJ?= =?us-ascii?Q?3vHfdIqy3dYd1ee8QWZZyTWldT5VjZzYePzSBrYzdtvBTY2TnOEcgM4BP81v?= =?us-ascii?Q?7Ln2DUjifzRX9MgI3ogrSKvPkh627kXLl3D6oJuh4mlJAoiLU68q7Bs7GZjG?= =?us-ascii?Q?7b7lLGwud+G596UjdZR1jZnT?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac3f1c65-1f6d-453d-98ed-08d8f291f821 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Mar 2021 09:06:41.8896 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7yf1Bxo0fXmkvFy95YZEKKkTtDM69PbtZ0+oYnuPqjDqGDNvi4ENF9RwTm6e6Jjbe416zPf9qFH90iM872jGQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1420 Subject: Re: [dpdk-dev] [PATCH] ethdev: update qfi definition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Ori Kam > Sent: Monday, March 29, 2021 11:53 AM > To: Ferruh Yigit ; Raslan Darawsheh > ; dev@dpdk.org; Andrew Rybchenko > ; Ivan Malov > Cc: Slava Ovsiienko ; Shiri Kuzin > ; ying.a.wang@intel.com; stable@dpdk.org; NBU- > Contact-Thomas Monjalon ; Olivier Matz > > Subject: RE: [dpdk-dev] [PATCH] ethdev: update qfi definition >=20 > Hi >=20 > > -----Original Message----- > > From: dev On Behalf Of Ferruh Yigit > > Subject: Re: [dpdk-dev] [PATCH] ethdev: update qfi definition > > > > On 3/23/2021 12:11 PM, Raslan Darawsheh wrote: > > > qfi field is 8 bits which represent single bit for > > > PPP (paging Policy Presence) single bit for RQI > > > (Reflective QoS Indicator) and 6 bits for qfi > > > (QoS Flow Identifier) > > > > Can you please put a reference for above information? > > > Sure, will send in V2, > > > This update the doxygen format and the mask for qfi > > > to properly identify the full 8 bits of the field. > > > > > > note: changing the default mask would cause different > > > patterns generated by testpmd. > > > > > > Fixes: 346553db5bd1 ("ethdev: add GTP extension header to flow API") > > > Cc: ying.a.wang@intel.com > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Raslan Darawsheh > > > --- > > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 3 ++- > > > lib/librte_ethdev/rte_flow.h | 4 ++-- > > > 2 files changed, 4 insertions(+), 3 deletions(-) > > > > > > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > index f59eb8a27d..dd39c4c3c2 100644 > > > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > > > @@ -3742,7 +3742,8 @@ This section lists supported pattern items and > their > > attributes, if any. > > > - ``gtp_psc``: match GTP PDU extension header with type 0x85. > > > > > > - ``pdu_type {unsigned}``: PDU type. > > > - - ``qfi {unsigned}``: QoS flow identifier. > > > + > > > + - ``qfi {unsigned}``: PPP, RQI and QoS flow identifier. > > > > > > - ``pppoes``, ``pppoed``: match PPPoE header. > > > > > > diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flo= w.h > > > index 669e677e91..79106e0246 100644 > > > --- a/lib/librte_ethdev/rte_flow.h > > > +++ b/lib/librte_ethdev/rte_flow.h > > > @@ -1392,14 +1392,14 @@ static const struct rte_flow_item_meta > > rte_flow_item_meta_mask =3D { > > > */ > > > struct rte_flow_item_gtp_psc { > > > uint8_t pdu_type; /**< PDU type. */ > > > - uint8_t qfi; /**< QoS flow identifier. */ > > > + uint8_t qfi; /**< PPP, RQI, QoS flow identifier. */ > > > }; > > > > By design requirement, rte_flow_item_* should start with the relevant > protocol > > header. > > > > There is already a deprecation notice for using protocol header directl= y in > the > > rte_flow_item* [1] and Adrew/Ivan already fixed a few of them [2]. > > > > Your patch is not directly related on this, but since you are touching = to the > > flow_item, would you mind create a protocol struct for it first, and us= e it in > > the "struct rte_flow_item_gtp_psc"? > > So the protocol related update can be done in the protocol header, inst= ead > of > > rte_flow struct. > > > +1 Sure, I can create the new protocol and use it , and will send in V2. But, = wouldn't it cause any ABI breakage ? >=20 > > > > [1] > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit.d > pdk. > > > org%2Fdpdk%2Ftree%2Fdoc%2Fguides%2Frel_notes%2Fdeprecation.rst%3F > h%3 > > > Dv21.02%23n99&data=3D04%7C01%7Corika%40nvidia.com%7C6391a4c064 > 0 > > > f4592b70b08d8f058e322%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0 > > > %7C637523611870497932%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjA > w > > > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sda > t > > > a=3DvU%2F5oO47zb9erTnZL1pl9j0nHCKzea3NJgOeo1FTW0Q%3D&reserve > d=3D > > 0 > > > > [2] > > > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit.d > pdk. > > org%2Fnext%2Fdpdk-next- > > > net%2Fcommit%2F%3Fid%3D4a061a7bd70bfa023de23e8e654e&data=3D0 > 4% > > > 7C01%7Corika%40nvidia.com%7C6391a4c0640f4592b70b08d8f058e322%7C43 > > > 083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637523611870497932%7CU > > > nknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI > 6Ik > > > 1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3DWurlQ5VSLqFGVthfRj363xZs > C > > No3xJuvxNQCFVcxdkk%3D&reserved=3D0