From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30AC9A04E6; Sun, 8 Nov 2020 12:13:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9159629D2; Sun, 8 Nov 2020 12:13:26 +0100 (CET) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 9A3671E2B for ; Sun, 8 Nov 2020 12:13:24 +0100 (CET) Received: from HKMAIL101.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Sun, 08 Nov 2020 19:13:22 +0800 Received: from HKMAIL104.nvidia.com (10.18.16.13) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Sun, 8 Nov 2020 11:13:21 +0000 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.57) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Sun, 8 Nov 2020 11:13:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YF9Al8ckUCQ2paydLlNp32YZ9t/CkGHLs9g43sjFuPuo6Pfjk8tTfewZFtKgB2EBSxBbE/QuPoZneIWN+ANaspZTMF7ccgGfDN6gMks19cKVOJmgCcMQsEqC0FAQstlYrMl1eq3WAdF8SJbdawdnHWxUfu9UVWMb+dkr+dfQjXy9lMjJ+C5NwnHcyVt7q3ebYRT6F+IJUsXYlouDXuHTHnEv3Q9piIJXIiIxhR0N1TgDpKsrDmBUqkWbHJo+8PKVVKYdr7R07P9kdy7bfjlKN4cHGnhFEYTJwMYV0kl4YtdhOWiqiJxzJ3MUOSukO1ApNoYVZo3HSALleCDiJS1bTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9gnH8688Iy/JetiRSjIpRcSTaql+RhgsKEHoDi9hq+w=; b=RlJALtxdd2fHub+LfFfTRCmIBZGicgnS6SaDeFyoY8w8osxRDd1a+XArIbFNJyD6WE2oYIUYsUS6uss9erMwoQkbT//F9IVoNp5cBMDlwNbPUiOGifJ2EfAkL8+GcMFVvI0LJf6WgJSK8llKr8xQQH6m+0AVBN2x8oo/zvo8+CpXm5LdVHgpQFwVK9J+LLeZBvXgawc0mWo4NtpmY88GnGEu9w26RbvA8zpuCMTZFeZ8/yVnOCmsQZQi+Pay1kymzQGOv5Wv6GTjuu9v7feZI9BeMuzfR0XGDJiqQvoytjBimQOgewqJUc8I3KMFs2l41wqO8LtVoLwmkiAAdilq6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB1465.namprd12.prod.outlook.com (2603:10b6:4:7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Sun, 8 Nov 2020 11:13:18 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::2115:9e13:d36f:af51%6]) with mapi id 15.20.3541.023; Sun, 8 Nov 2020 11:13:18 +0000 From: Raslan Darawsheh To: "Jiawei(Jonny) Wang" , Slava Ovsiienko , Matan Azrad , Ori Kam CC: "dev@dpdk.org" Thread-Topic: [PATCH v4] net/mlx5: fix incorrect group value of sample suffix flow Thread-Index: AQHWsq6mG+IXQQpls0em5SroTWFHpqm+Gtcg Date: Sun, 8 Nov 2020 11:13:18 +0000 Message-ID: References: <1604213400-287636-1-git-send-email-jiaweiw@nvidia.com> <1604496589-410416-1-git-send-email-jiaweiw@nvidia.com> In-Reply-To: <1604496589-410416-1-git-send-email-jiaweiw@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.229.165] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 827ff485-9fe0-4db9-4809-08d883d74b9d x-ms-traffictypediagnostic: DM5PR12MB1465: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: V27RUjbDZSLIUbMnziSnX+lJat7yhjlDIBTtW70/sOFThlmzfbzTBUl2TYyy8l0uktqsMGXNuR7cLLzRXxEBTknNjkH/un5wLBMolvzD89HuAM/3dGD2s6FPH2Hz7wuTTje5Fgp/9XHVgc4/zKmqo42qI1nL7kO0juSUY9W0s011QhpMzMcD+F+0b0vABJn1rSrRODoHGS7WbiuzTPxxyET4bIafRrd8qQi838SPQwMaa19/9OmCKbJqMq58c3+JqspQRVfPfYJDLVhZmxyHFbogdI1bXc4dr+HlGYHsu2RmSqGgSb63AqHA/+xbkXyt32Gm+eg1mtGU4VSy+8saqw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(136003)(396003)(346002)(366004)(6506007)(33656002)(52536014)(8936002)(7696005)(86362001)(76116006)(71200400001)(64756008)(66946007)(2906002)(4326008)(66556008)(53546011)(66446008)(66476007)(478600001)(186003)(5660300002)(55016002)(83380400001)(9686003)(26005)(110136005)(8676002)(6636002)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: f9zXYpY3wxfDjiS9FW9p9r1ENgggQp6Uq+LNIGkDD3aZIugiWrHWcefcqmVTouL3rZA12DUDcDbmcM+WhR8GfFPm+3hKxAO8doCJfdOB2bxPURKTz4dtHyq4E7g9V4fw8EV5xpvgupPqsIUL3t6p6TkpKaMz1TYj9+PXjUi5y9aV2PDT3UBv7ayq2bGLYDyJbXuo3neceImroXfDc++sGyoM6ARpBuNcQ+jxG6BBv41CFQL6cZjzkeiLS2N8ksQQMkKNeb0ZxD3R//DemJGmcWM+NGZeUJ31mfd0jc/C9YRYIkpc8stEqR6bqoDbALGltleJCSQ6JQpIbNJp6/SbmI0XhYhrn7U0dGReukpAZ1szyOj/8mkpZg8kgGiq5e5y1W8kQUD02czubVd5Y1uiAspj38pfBtlnBxY/lVYiLHkHW2RKcP5Y0uJEu+11IVBMu5ctI3/kyfWgZ0sVhZeZWn9nfkiV6URrk3zIe4UqMgTndinICHMvbtETtlBFKXkx/AoDRwR3ZDFz5Ma5GQ3prJrGTw32M5YxDcr5W8LNTvjGkVsRUtuYP/BJ2EMpaIdtNi5aqXTU/qHYRJ4mV9T4cFaYeGQ+INQdvgQua6How0Sg75uwjzZvYby+Abc3qxaRsvWFZZmPaG+c1A+0i6HKAg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 827ff485-9fe0-4db9-4809-08d883d74b9d X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2020 11:13:18.1681 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tHWWiuflNvwXMhYExIQTBL128C2QkL5ucKd1BNXOxkwxD24D8REBAB9cEzIkwAdRF99S7IrUHqD9z4qyoqoGew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1465 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604834002; bh=9gnH8688Iy/JetiRSjIpRcSTaql+RhgsKEHoDi9hq+w=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=REjq4jydHcjc7EYNEBd3aYSwnyX9fmNV2QGasOw17Y75hWqwNnE+4JEX6Jy/Sgtrt 1v4t4LT5oex7aMW1AsUmK655wSRxP0QIGk5B2KlmkhFpqRbq0EdRnUCKYzooevQnHu s9N9hwX2LipDvhbVay2D6Dei0f3x8liIZmTCwAjbKjlbFa+uwq6J3gK/Ht8ouySQqb J6wK2CCtVXH7SCvDcdKPsByNIOfQzbKSOeCkg/zirroaH+GbacTtxxPoG/VIsUm9aw h4+FTm0NEIPF0sSPrF/ankVJcVpA1RL/LW5/t/aeAMutZBR0bEaL3j6eQ1uOJR7tCM HpX+vQ3pHTuVw== Subject: Re: [dpdk-dev] [PATCH v4] net/mlx5: fix incorrect group value of sample suffix flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Jiawei Wang > Sent: Wednesday, November 4, 2020 3:30 PM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v4] net/mlx5: fix incorrect group value of sample suffix = flow >=20 > mlx5 PMD splited the sampling flow into prefix flow and suffix > flow. On the sample action translation function, the scaled > group value of suffix flow be attached into sample object and > saved into sample resource. >=20 > mlx5 PMD fetched the group value from the sample resource to > create the suffix flow. On the mlx5_flow_group_to_table > function the group value of suffix flow was scaled with table > factor again and translated into HW table. That caused the > incorrect group value of sample suffix flow. >=20 > The fix introduces a 'skip_scale' flag and sets it to 1 for the > sample suffix flow creation. On the mlx5_flow_group_to_table > function skips the scale with table factor to use the correct > group value. >=20 > Fixes: b0c8d823552a ("net/mlx5: implement tunnel offload") >=20 > Signed-off-by: Jiawei Wang > Acked-by: Viacheslav Ovsiienko > --- > v4: > * Init the flow split data for each dev_flow > * Rebase >=20 > v3: > * Rebase >=20 > v2: > * Update commit message > * Rebase >=20 > --- > drivers/net/mlx5/mlx5_flow.c | 159 ++++++++++++++++++----------------= -- > ---- > drivers/net/mlx5/mlx5_flow.h | 15 +++- > drivers/net/mlx5/mlx5_flow_dv.c | 2 + > drivers/net/mlx5/mlx5_rxq.c | 2 + > 4 files changed, 91 insertions(+), 87 deletions(-) >=20 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh