From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9E62A04DD; Mon, 26 Oct 2020 19:07:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C6AF12BA3; Mon, 26 Oct 2020 19:07:54 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id F28782B9E for ; Mon, 26 Oct 2020 19:07:51 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 26 Oct 2020 11:07:54 -0700 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 26 Oct 2020 18:07:49 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Mon, 26 Oct 2020 18:07:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T1pSWIHHGMH4TuA0qKNWUP3O6TQ3uaTpghGFCUuUbB4f9YyYRvulqXP/RkyheCnuQ8K2QuFKOnFMxvG7MC3oBvVLWMlSYCJCQc5kLGzg0IqhqAQ88UlpaLyrylYhdat9dnvH4O5lYQqY940MBIHiAB1buVt6wv0eputZktiEd8BLA0wdWRLvSBNbGtA4V2te1KkCdAt8WDzw6drM+8I7x+aNYn9dIAeSoU30kxB8HP4s2eVQ9Vvn2Zn0e6xZaPVDiafhXRPijY04ToS5VM9JDiEknVgJwi9CkPTx5z5LB7tyxcCdwAJphBwy9QUlZGB88dQlJxkMYzDHbHR3IOvGvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sFS2irVaH4Ku8Kz1cQNk2jdak5wzToawTdgOCHq1qqk=; b=LM0MOvYTz2MUk/+g46wIGH0QRaWBxb/cara/utcXPk94kyvp8gnPwzSktZUhIqS+y16YVdADX99KkcQVbqUfdAKr0VRHNKCQB2pbk1ducGo3Ko7b9DPyY5ysqikrxdlg1+JceQGcVKCmzFu84p4Jn+QPvsg4LIeEkhHshpxiAWnUKrm+pl5LCN0PtmRr6C+b6PaI65mjdPVVyepxI7niNURR+Swa1sxd/3z5GsPK0JnOOVY8gPbbIKVJ2wWVA4r9gQ7RT9Fn7cx/fy/EU4epdUbAfz2AbFIA/mr/56jIlkM1+EE1gyQgVTPi5fH2xkXlph9K9xYcnikaHrj8gW9flQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM5PR12MB1897.namprd12.prod.outlook.com (2603:10b6:3:112::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Mon, 26 Oct 2020 18:07:49 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3477.028; Mon, 26 Oct 2020 18:07:49 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" Thread-Topic: [PATCH] net/mlx5: fix Rx queue initialization for scattered segment Thread-Index: AQHWq7vtOGNT1I14WEGtX1cYUh94P6mqLjyw Date: Mon, 26 Oct 2020 18:07:48 +0000 Message-ID: References: <1603381371-5360-2-git-send-email-viacheslavo@nvidia.com> <1603732656-24395-1-git-send-email-viacheslavo@nvidia.com> In-Reply-To: <1603732656-24395-1-git-send-email-viacheslavo@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.229.126] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cef700d2-4d6b-4b1f-d4e9-08d879da0c64 x-ms-traffictypediagnostic: DM5PR12MB1897: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:425; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1i9u71nbWknfKwlDneRjM2qVJjleyFzGqIOsLULiAWLZHanjgsGibNhUzaDHSgMTfQPXwTu+DSnWaqQwK1PXd63hL+swoNYzeiCN3Ey2LTnT+tcPHqb9HiUkHJ0FxPBhwEmp3Y+5nQZ59aXDRgqRt2tR7rR8P9LzuV6m9KcU06SFooAJnCxX470CnEU69Y8dEEKL0ORTUWrXAj9asTL3xUMCH0vdB8QntWuNPZsTwF+9OnzjpwUTJw5N33FskW21L0AynxQuIFrf7dH2coaTDjqPN/lM0Yklo7PdFZ6/PRYShak3lnLMDTJHK0QPoojdgPgpkcRxRtVg2XgeBk/JvA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(396003)(136003)(39860400002)(376002)(478600001)(26005)(86362001)(66446008)(66946007)(186003)(8676002)(6506007)(5660300002)(9686003)(52536014)(66556008)(2906002)(66476007)(64756008)(53546011)(316002)(110136005)(76116006)(7696005)(33656002)(8936002)(55016002)(71200400001)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: fGZWWPrCsVeQL+OKhYe0HLdvP6S4qrETH+2N1QuKGNrndD0UKBTmACHSxEFG3l+nlTpD+KJRstz6ssXSGepAvsKVdAd2ixoIqFnw2VsVT4UKPqNNxI4xujDncmCBrtodvlDV3xhjb7bzgAsjnjiz7axTrGk6lM+lwkefchtULJfXOkV+2BAlnd6kHVm1WaMw32GjOB3h2gANVggu711qLCDT+vToNGSApGlOkeoAGQirKU9UGn5diSI40/E6Ur2ANRRTCktv1DYKyuW/2Jh9IauxILcJN7QgDHK2FNvVCibRkvRbBvLSdnpCgsCwZtldZGslLgDEubUf2prctGjZ1Xhfu3A/KPvU1abtnGG5A/7hKzJ0BHU+Hi4zUPcK96xKbKNTzJ9kbEsQdvOYvgic/BL0oPcCZcGCgYvuLh7B5g0nHY0GpjOc6M/A5jtLvafZqt9JkcQlN1Ny0TbTwThnW5ybhMuox0Nd/n7WeTax6YgOU6/n0TEf8wnb0+5yp2jD8qVtpKet2gzuZvgpWV/fHxNBDNsSeCFJ+UaVNJ4YCynhTVslmq77QXPkxhTDDvuZdshwDjPRv/9rkAr+Ofoc2mqkrrEUbPkqsCCmsXN2+CMteSu96hkppcIo36qhotgqrQuEkhsusGkyNUy8RxLgWA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cef700d2-4d6b-4b1f-d4e9-08d879da0c64 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2020 18:07:49.0181 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: diDXsQh8sje5Kg6KcAaa/OAtd7uS8nUqmssxEj5Smz4IT2SsLON7r6bgbMjrf1jMZrvo75EBE9DlWC1vILJOmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1897 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1603735674; bh=sFS2irVaH4Ku8Kz1cQNk2jdak5wzToawTdgOCHq1qqk=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To: Subject:Thread-Topic:Thread-Index:Date:Message-ID:References: In-Reply-To:Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=OS0lHF+MkQNwYYpa/0CEM7IoQe0sKM1bsQyYgb/SzJeoZC8mOwW5vyF6L9ssDXAvm xgBZ+GL1FDhoKI7QOrkq3DrgzXUoDVchestXdt48R2VX7IwsE31nHmyZUKCH/oG1vF t20jKKL1qq9DgtyyrBnqnQOk2MhsExMUHz30oWeH3ucMqR77JAXV82UWDTiOoPFfVh NIgpvMFrEzb7EPOvxW7ITMMG//ihMaOyzZBHolHewCNy+l6aJKkKNZGDWk2akl6+Jz 9flk5r7dcSh9LSxsFu+5bQf8REiPvqLpUNgpg9hgiQkYAn1bkZzsboisw11EE9VGyq vTjeh4PKqMx4A== Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix Rx queue initialization for scattered segment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Monday, October 26, 2020 7:18 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh > Subject: [PATCH] net/mlx5: fix Rx queue initialization for scattered segm= ent >=20 > During integration/rebase there was introduced the bugs: >=20 > - double memory allocation for queue structure resulting in > losing the part of configuration settings and following > crash >=20 > - the erroneous fix for the segment logarithm >=20 > Fixes: 919ef3e26cff ("net/mlx5: configure Rx queue to support split") >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5.h | 1 + > drivers/net/mlx5/mlx5_rxq.c | 11 +---------- > 2 files changed, 2 insertions(+), 10 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h > index 258be03..8d65828 100644 > --- a/drivers/net/mlx5/mlx5.h > +++ b/drivers/net/mlx5/mlx5.h > @@ -730,6 +730,7 @@ struct mlx5_ind_table_obj { > }; >=20 > /* Hash Rx queue. */ > +__extension__ > struct mlx5_hrxq { > ILIST_ENTRY(uint32_t)next; /* Index to the next element. */ > rte_atomic32_t refcnt; /* Reference counter. */ > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index 1cc477a..4e17535 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -1486,15 +1486,6 @@ struct mlx5_rxq_ctrl * > rte_errno =3D ENOSPC; > return NULL; > } > - tmpl =3D mlx5_malloc(MLX5_MEM_RTE | MLX5_MEM_ZERO, > - sizeof(*tmpl) + desc_n * sizeof(struct rte_mbuf *) + > - (desc >> mprq_stride_nums) * sizeof(struct mlx5_mprq_buf > *), > - 0, socket); > - > - if (!tmpl) { > - rte_errno =3D ENOMEM; > - return NULL; > - } > tmpl->type =3D MLX5_RXQ_TYPE_STANDARD; > if (mlx5_mr_btree_init(&tmpl->rxq.mr_ctrl.cache_bh, > MLX5_MR_BTREE_CACHE_N, socket)) { > @@ -1560,7 +1551,7 @@ struct mlx5_rxq_ctrl * > * Determine the number of SGEs needed for a full packet > * and round it to the next power of two. > */ > - sges_n =3D tmpl->rxq.rxseg_n; > + sges_n =3D log2above(tmpl->rxq.rxseg_n); > if (sges_n > MLX5_MAX_LOG_RQ_SEGS) { > DRV_LOG(ERR, > "port %u too many SGEs (%u) needed to > handle" > -- > 1.8.3.1 Patch squashed into relevant commit in master-net-mlx, Kindest regards, Raslan Darawsheh