From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3094A0562; Sun, 11 Apr 2021 14:35:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9E4C1413EA; Sun, 11 Apr 2021 14:35:44 +0200 (CEST) Received: from NAM04-CO1-obe.outbound.protection.outlook.com (mail-eopbgr690045.outbound.protection.outlook.com [40.107.69.45]) by mails.dpdk.org (Postfix) with ESMTP id D3FB8141210; Sun, 11 Apr 2021 14:35:43 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hm/xE2IhRb7oN/32mPmRnObVbYAkyxySloN0vWcU1gwdTV4qsKhI4AnnHk0AA6LIlCrp5imK63pzhjQJXxwmuKpb8H+O9kTb0p9jOqHUdikkqvsAIQr/R6id0I7kQdXvkFbWPi/MPnhUjHmofnPtYLLfllqo1W0yvunN8hxXla0nvSS7G/CZLDQun8eiF4FZvw9R29Z8tsY5cKgQMHhkq596djzTPd7RI8W6rgAZnUaogxRorVvrUAoEZ+hK7dmgd4rjjW7sQ2ufI1SSIo98GLwXxY9Zm8uGG2MzYENJ+efWjVzTTarAEo2z4MlSFWQEz8yWpH44r2lRdUpQKyf0uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l/7GDgyVlsweerU5+4snL5cdUg4zjdkf0zvvx+U0r5E=; b=LicmgfAkarRvfrwLrIh+sCIJhTRE+j5ljdu5HAnyQHNSJsxyYqlzwKaCERfz9V473aM8uYyc1SMg24V0tyoh5kBMsp4S9Z39gM8At9/XYEkbURquEM54ARUed0WdrIIE6Jai1tHu+5GX7MelWnaf5r/cXyCkSVXax4E2Ltttl9TDl9PMAVfXzwajtt7LeFwh+uG0pUpNr1mlfz/h2IJCs2x1hBeDQk6QXhkoE1sSh+gnXcKlUyTHyuQ0UKBkH5M3nvg+18oPuFpsB28Y4v6SZfli/KMSUhl70IYvXH/UdofLvGBR+wMuBJS1fH3xxdlrTYCcIkziblUVZKG21Eh7LA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l/7GDgyVlsweerU5+4snL5cdUg4zjdkf0zvvx+U0r5E=; b=tLYX08wiwPKkEEwILiyyHr9liaWRB39EIK/achn3IUi9ZZyRJ3xmRYU/GrJDZ2pUtzIcSz3G44OmupHpSfAYtNAteKVUiKQe7o/OeR1BPJTRKw+OLqdjWGT+UFXdh9ISFJqiGzpYgiuRbzAA0slL91n9PunFjLkuYPmGSTOfT3L7a2yEG6MmHMjl5r+oWOpQTiVl6OICvGX4rrx6jO7Ux+GHztjxhsltuVDC4aFxaSXpwnZMKCW4hxyDf1AMWJqAYLRVNwwbtErxdUBOdAQx6nSdRCFktseMS0a97SIN6PMt1r2h6x8EUESwFnn8kP26HW06W58V/PzCK6hJ6g9Png== Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB3530.namprd12.prod.outlook.com (2603:10b6:5:18a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.27; Sun, 11 Apr 2021 12:35:42 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::d011:3b55:aafb:9280]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::d011:3b55:aafb:9280%5]) with mapi id 15.20.4020.021; Sun, 11 Apr 2021 12:35:42 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , Ori Kam , "stable@dpdk.org" Thread-Topic: [PATCH] net/mlx4: fix RSS action hash key null pointer Thread-Index: AQHXK8Lv9KjU2xXad02XB/9apPN58aqvRrrQ Date: Sun, 11 Apr 2021 12:35:42 +0000 Message-ID: References: <20210407153015.32035-1-viacheslavo@nvidia.com> In-Reply-To: <20210407153015.32035-1-viacheslavo@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.161.230.40] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2f90c400-6e3e-4784-4b12-08d8fce65250 x-ms-traffictypediagnostic: DM6PR12MB3530: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tm4/h5gOV7J+926fDDnAN/nlQu8C6iYLD3+KTpYf0aS7oIF5VspvmT246LrRiFGsof7iIUoJhEEepx8dLdbuYF1aDIWfhUzVmZaM680HNv46gC2cU3wu0Sda5DyUEvpwDEUyrFMM24TtNM89bPV8xqh79vwCj3x5ws66tw+w9//6leI7dH2MJQEEw7Dd45k/erxkbqAB80c7NepiQlT3lg8B5s7yD9/JB2B2BQWd4BYxJ+pV/3ZDS8jVwU4R3K9S+o7y71EdQunhWJJXOBv7OBFfFsBof//HRJzHQEq9wJCbFy80VkhMhXmnPvuI4Ih0rBpdQ+KjUzdWbZ3QxEaa2cyFp+MI2qkfJWnlsX8z3bTQmB1F8odvZ17AQpyp94B9qN50FFDgzbd+0S+Ivjl+9FxjTUP4dH4YXJWYK0TnhAKdOho2wNDfGYEotwnhGCe7i4g6M3z+xtddpNoJ91kGrhdptkFQDJxrpt7mjVHWeTSvikIrSR0ZCIOsE13srlp9EoEgMFCAjWzKkJ6XMI6i06Nkvz5mvU0Cj2gAsboVptI7tVjNmt6vq25DA1XJXZ5E56LWqgsRaAjKjjDvjvBBQ6JC5tdchOb3/vCJ4WkJWNg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(39860400002)(346002)(136003)(366004)(376002)(53546011)(8676002)(2906002)(55016002)(7696005)(4744005)(8936002)(6506007)(86362001)(38100700002)(76116006)(66556008)(66946007)(450100002)(71200400001)(66446008)(54906003)(316002)(64756008)(26005)(110136005)(186003)(5660300002)(52536014)(33656002)(83380400001)(478600001)(4326008)(9686003)(66476007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?aoxNqp+qFpmUjbg33hMiesShpS12DzcdZWEOKJYgPQKb2QPjnuTK8HjLlx2o?= =?us-ascii?Q?kPLDR4ooFINotRMLjqkmUlS5302sk+f/BjValRuDsrJibj+9n9lVduV07mRg?= =?us-ascii?Q?N0Qnmf9L6THyCAbW9bJ0l1bhtFw0+RLPJY6MMGcmi9quFF2aSjfGtbAXyUtv?= =?us-ascii?Q?ASIIQBxNKic4morKGUSB4e80DWjJk30j1UH0ZQ5uthMVKNL2emklae2YFjce?= =?us-ascii?Q?eBlbBDRbzgwfO0pXAN45bPnFVvIBNYvwMHyCD3ZqQAwbLxnnuV2jcR59y5NJ?= =?us-ascii?Q?q0a22Mk2XH7ipfBzjnEK5Tra3d6Aj/0QIXlNdZ6kxQ/mTr6Mi035TEaFv16i?= =?us-ascii?Q?+Xo50NJ2MT8qyl6TbdtTfEajk4FqakRuNVPgaj4pNJrh1l1JVPbiyRUXAOSi?= =?us-ascii?Q?hYJgP7sS6tjaqRL0ucwBb9wFEluuUIREEH5z/aOhQdpcopfceyc5rcOJIJzL?= =?us-ascii?Q?7yCqGm35VE1pb/voaicnROtAwbL0ccVr6bgZa9AuqRY+7PobuTfikBoJdIpw?= =?us-ascii?Q?vMpdofsaR6pKX3hD7ByIAJbXNA/bEBKeRG0FRCBG54dUcBCpwap60+8OITB7?= =?us-ascii?Q?EAyZ52gfzVXs8oLwyvOM32q7Uq2ydauZ9N6m+dahSn+/rf7vsMnm06ZWgQCW?= =?us-ascii?Q?0EcSFxr4DAW0bU2w0LDEix09YF0hLxzzEx1WgMvODEnvNXpayesWEzAzFJG1?= =?us-ascii?Q?b61658iajx8JgOQg0/CWDuSihGpILoZ50wO79EfV97th1XhxMzSfyDB8xAA+?= =?us-ascii?Q?51t1+drAT2znWOP92QUo45AbwX5JT2H7O8ZD2CQgYWTWVarEuYNbWtqee3Y1?= =?us-ascii?Q?P7gRs0N87bL7AXaZkFFw2z4FzzP+wV6HV6sl9Ty4pe1v1S1Z4Lg4caCg3SKj?= =?us-ascii?Q?t3i6J7iRsQYOi7OG6fW/6y3HfZDMmU+g/KJUHX+m6WZN+DYzNu5H7NA/czR0?= =?us-ascii?Q?/POId6jF349A4R4Np0d00jmjGZ51E62NNf0M0WkAOJ6NOZZAsUFj9AAGwUBb?= =?us-ascii?Q?WPla8BaPhT6jyAfPx2DoIa0KayLKi/brNEoNrh/CHUmG6HR1pq+/fEGFTNN+?= =?us-ascii?Q?+WprYDXZ5O7K4rjmXaoKwLdxuuT43JhZbgqE4ODrXDMHNl9dHE4luOgtAQSz?= =?us-ascii?Q?C3Cx0aPSYizg7n8yGObi/Y+qdkoep67mgRBQsXWafxMKM5haNM5I478LOR+n?= =?us-ascii?Q?BdbWGJDcBsO658FKkJ8BUQX7jB5hsGtg9OIWayWMV0FCBdhbgmhxUPBh0eLR?= =?us-ascii?Q?CqM/JBqYWCr4UL58ROZMReFTMyrT3DOA7UJKTp7Qke0OWscO3WXn9RiB63+x?= =?us-ascii?Q?HT4n/BXxQAxlXMVqWX36k66j?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f90c400-6e3e-4784-4b12-08d8fce65250 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2021 12:35:42.5287 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N63sDIxDeuLGgniCmVSOpGjde7+vT4ISPdo1ITllUwkZtNT/HTpsjdBUjXp6d2v9yOhUUtMXA+7isv0rPJhg6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3530 Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix RSS action hash key null pointer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Wednesday, April 7, 2021 6:30 PM > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; Ori Kam ; stable@dpdk.org > Subject: [PATCH] net/mlx4: fix RSS action hash key null pointer >=20 > If RSS action contains non zero hash key length and NULL > key buffer pointer the default hash key should be used. > The check for the NULL pointer this was missing in the mlx4 > PMD causing crash, for example, in testpmd with command: >=20 > flow validate 0 ingress group 0 > pattern eth / ipv4 / end > actions rss queues 0 end key_len 40 / end >=20 > Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Viacheslav Ovsiienko > --- Patch applied to next-net-mlx, Kindest regards Raslan Darawsheh