From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 240F1A04AA; Tue, 8 Sep 2020 14:06:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 09B4C1BF8A; Tue, 8 Sep 2020 14:06:31 +0200 (CEST) Received: from nat-hk.nvidia.com (nat-hk.nvidia.com [203.18.50.4]) by dpdk.org (Postfix) with ESMTP id 021F3255 for ; Tue, 8 Sep 2020 14:06:28 +0200 (CEST) Received: from hkpgpgate102.nvidia.com (Not Verified[10.18.92.77]) by nat-hk.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 08 Sep 2020 20:06:27 +0800 Received: from HKMAIL104.nvidia.com ([10.18.16.13]) by hkpgpgate102.nvidia.com (PGP Universal service); Tue, 08 Sep 2020 05:06:27 -0700 X-PGP-Universal: processed; by hkpgpgate102.nvidia.com on Tue, 08 Sep 2020 05:06:27 -0700 Received: from HKMAIL103.nvidia.com (10.18.16.12) by HKMAIL104.nvidia.com (10.18.16.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 8 Sep 2020 12:06:17 +0000 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.58) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 8 Sep 2020 12:06:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CobsVJBiG9HTf5050VBYzuSn6Xj5YC95WhWj7cFD4qrKha0UN+cKt8jxyPg/YWK/57hONhpLqneYoMPJfJYhZFao2aYlRhbneKGLapXwggU+js/FT7r4q224rsUH2S1cmun3cOKOhR0dX2YY6GcA6CymqV+Bk8uyWFfH0pqW88UlJwICegSTzYpI505o7IlbhE8wAYzOOAx8NxJEJFBPoyF55AAtwLPlRpkkI9zZZGZWNZsIc3hJGaFQPIV0HwJBma/1gwBr6ZcIIPZOcBE8UCt+MEWSWEKl1kEKm12nmNcx/1E6jT7Uh7qnPUDoZ8UksFafYx1wte3IXNutpL9nPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9p9W/dFtlxO/cRuppU4He3UOxls1d1tFVJt4/ypNTjk=; b=XF2+jQk+mzH75IJ3jpOladyZrRIC4rr/nD8+almTUGKhc5i2WK4qUyEQWHxtj02k8iYsTt5PBrPAuehDbO+Gh0PcgIxoJBpURslY8W+fUmpdvPayssc7LxaPZ4oDZ1Fl6109vKT5LERzS4g31pX31nRQo652XWSlNKvVdGM3HU/HK3Vc+kJYxe4McAq7zvU/WB8yjECPSQdPDFX/OLSmtuKmdTVI5eaE9iMYpkrAw2VfOZdWVjwJEu5919OvkFTLrJTAIVL2nOssHABi5qLYy7oDPdmDfyJDivWTSWuX4lYYyb/USEgfaDlFBbL223HaAtaef3GKixyKZ4aMkCsXGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB2748.namprd12.prod.outlook.com (2603:10b6:5:43::28) by DM6PR12MB4450.namprd12.prod.outlook.com (2603:10b6:5:28e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3370.16; Tue, 8 Sep 2020 12:06:14 +0000 Received: from DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb]) by DM6PR12MB2748.namprd12.prod.outlook.com ([fe80::f506:4af8:281b:cdeb%7]) with mapi id 15.20.3348.019; Tue, 8 Sep 2020 12:06:14 +0000 From: Raslan Darawsheh To: Ferruh Yigit , "dev@dpdk.org" , Stephen Hemminger , NBU-Contact-kys , NBU-Contact-haiyangz , NBU-Contact-longli CC: Raslan Darawsheh Thread-Topic: [PATCH] net/netvsc: replace compiler builtin overflow check Thread-Index: AQHWhcfgeb3Zf2h9HU61v+HQ63K88KlepQ9g Date: Tue, 8 Sep 2020 12:06:14 +0000 Message-ID: References: <20200908100642.1197765-1-ferruh.yigit@intel.com> In-Reply-To: <20200908100642.1197765-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 936b9f86-9fd6-46b4-bf7c-08d853ef95b2 x-ms-traffictypediagnostic: DM6PR12MB4450: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-transport-forked: True x-ms-oob-tlc-oobclassifiers: OLM:3044; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nAHIRLDpg+S+yPeDRNgE0apgPixWCwisThP9wG7Pne0FCE52xLRAoKxbmTTZbKfzSSNioFE2ShvoWz1qxBGTmMpt0bDhrSwait951euFa267Wm19noYOCDsD1aQFaZGIKwJ82OmkZbnotHTtX8V9e82Nk0U8XKqYarGrZSY+4U72VBXaM8EtwiKetKpoTNJ6SkjNaGnH8aFnBktaM5rBc1SABXI57oWejjK7z/QfJrrOVtJqoB85sW02lAVyZG0FvLPChEZODZEyApLUl4O+Vrz9BSwRalQzuzcLDSYzs5DC4xuV499CPUTQ/pjj7OD5vNO6TjI7ry9Zm3pwA9lYXA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2748.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(396003)(136003)(39860400002)(376002)(346002)(26005)(2906002)(186003)(6506007)(53546011)(86362001)(478600001)(4326008)(9686003)(107886003)(110136005)(55016002)(8676002)(83380400001)(33656002)(64756008)(8936002)(66556008)(66446008)(76116006)(66946007)(66476007)(7696005)(316002)(52536014)(71200400001)(5660300002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: HRQh+siE73eKMO2UU0KVNMT8aZi0K9+Leue4I/mH5GcZGqnzKrHMC0VbSuKSMUuHcIiaPu6djSTHrCpHwvely7EcVLzDuf4PKcvbpwFVkded/l0eqAkj5f7cEQC0mb6z+E6xOegdrI2YzWDc3Vd0rfCpVDhrKe5YmTptW/joo8oDr65ZSL1dCqKFgCppoLOpQStTYbXFAoKImc1I24djWYThxJFFMX9AGC/UzYxK8RIaZQHgQ9rxyFsMHPmEaKGsaxTibR3gfkz/4tr0ixOwXcfPu7exTYsYgHAFuBcpmgNsT3TQ1k5K43EU/FVZbN041vf0tJ34iAUMN94rqj50P/6usMV6mnr0wHmrxHb0CqufzgAlpfAusLLU8Falgw/EDs1B3EmMGjW49RhBnAsNNWXNcbQZ+BZQjYf956v9MhOvMpvEyLWxtMQqyZkUDSAcr/3habPOCM7Iir+dMvGzHaxWk4XNErq4gUOcBPWv12pRuHmJoqV7ex9yo1rL/CTFD18C8fISM8dPFqAfcYGVYGlrLItGHtG8nzUtXy/Z90Mzbeds5H5m7ceNYCziDnyM2MLBVhvDiTk0l+dwx1lwkMVjC2ZjKluEUrXEfSSxYxCC1ZrFsxiNDy/Lejag91TKImQ3/AnkS40JU9+iyi2TsA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2748.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 936b9f86-9fd6-46b4-bf7c-08d853ef95b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Sep 2020 12:06:14.5514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qc53YFMTAMBlfagdSsL/3siYK8hR6fxCyk8URpuwVohSBg/IOO2DJ3IKzFilWEOWm92IJY0XTGaBATdKsr+f3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4450 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1599566787; bh=9p9W/dFtlxO/cRuppU4He3UOxls1d1tFVJt4/ypNTjk=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ld-processed: x-microsoft-antispam-prvs:x-ms-exchange-transport-forked: x-ms-oob-tlc-oobclassifiers:x-ms-exchange-senderadcheck: x-microsoft-antispam:x-microsoft-antispam-message-info: x-forefront-antispam-report:x-ms-exchange-antispam-messagedata: Content-Type:Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=FmI1qIWD60L079Lj6JU6DvKWNjzxwOKCoLs8W6u8cdUCoLe7arpmdtYDi3a80yZB6 Dr6d9dNrPxAWEAdDAjDQ72xQv/hDRAWPg4h8UtZzx2cF2IycbrUEj71dUdOSiHPP92 hvcUsh7EUw+ZECJJxmT05xDslQQiFuHeqFvmf+pPo/uJh/A8daOQm91arkMci9MR8d aNsoHvtlP/KEM2jaYnRlolPbxGSjMIXyrjHBLNzHRxXwbIqAXKos3sdhR5iH5F8YRx 1TQcUS+3VE4NdM3c8TbrgDLlPDPzxtlj5gEOkXBX0x5XQEC51hrBN/vpHLmLE4zSxh si1sB/uwLcAFg== Subject: Re: [dpdk-dev] [PATCH] net/netvsc: replace compiler builtin overflow check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Ferruh Yigit > Sent: Tuesday, September 8, 2020 1:07 PM > To: dev@dpdk.org; Stephen Hemminger ; NBU- > Contact-kys ; NBU-Contact-haiyangz > ; NBU-Contact-longli > Cc: Ferruh Yigit ; Raslan Darawsheh > > Subject: [PATCH] net/netvsc: replace compiler builtin overflow check >=20 > '__builtin_add_overflow' added to gcc in version 5, earlier versions > causing build error, like gcc 4.8.5 in RHEL7. >=20 > Replaced compiler builtin check with arithmetic check. >=20 > Fixes: cabb3c0f29f1 ("net/netvsc: check for overflow on packet info from > host") >=20 > Reported-by: Raslan Darawsheh > Signed-off-by: Ferruh Yigit Tested-by: Raslan Darawsheh > --- > drivers/net/netvsc/hn_rxtx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c > index d8d3f07f56..3e8d3b407d 100644 > --- a/drivers/net/netvsc/hn_rxtx.c > +++ b/drivers/net/netvsc/hn_rxtx.c > @@ -666,7 +666,7 @@ static void hn_rndis_rx_data(struct hn_rx_queue > *rxq, > struct hn_rx_bufinfo *rxb, > void *data, uint32_t dlen) > { > - unsigned int data_off, data_len, total_len; > + unsigned int data_off, data_len; > unsigned int pktinfo_off, pktinfo_len; > const struct rndis_packet_msg *pkt =3D data; > struct hn_rxinfo info =3D { > @@ -712,8 +712,8 @@ static void hn_rndis_rx_data(struct hn_rx_queue > *rxq, > goto error; > } >=20 > - if (__builtin_add_overflow(data_off, data_len, &total_len) || > - total_len > pkt->len) > + /* overflow check */ > + if (data_len > data_len + data_off || data_len + data_off > pkt->len) > goto error; >=20 > if (unlikely(data_len < RTE_ETHER_HDR_LEN)) > -- > 2.25.4 Kindest regards Raslan Darawsheh