DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@nvidia.com>
To: Slava Ovsiienko <viacheslavo@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix external buffer pool registration for Rx queue
Date: Sun, 21 Feb 2021 08:14:12 +0000	[thread overview]
Message-ID: <DM6PR12MB2748F2C5B546336D425401D1CF829@DM6PR12MB2748.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210212110630.2605-1-viacheslavo@nvidia.com>

Hi,

> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Sent: Friday, February 12, 2021 1:07 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix external buffer pool registration for Rx queue
> 
> On Rx queue creation the mlx5 PMD registers the data buffers of the
> specified pools for DMA operations. It scans the mem_list of the pools
> and creates the MRs (DMA related NIC objects) for the chunks found.
> If the pool is created with rte_pktmbuf_pool_create_extbuf() and
> refers to the external attached buffers (whose are in the area of
> application responsibility and it should explicitly register the
> data buffer memory for DMA with rte_dev_dma_map() call) the chunks
> contain the mbuf structures only, w/o any built-in data buffers.
> Hence, DMA with mlx5 NIC never happens to this area and there is
> no need to create MRs for these ones.
> 
> The extra not needed MRs were created for the pools with external
> buffers causing MR cache load and performance was slightly affected.
> The patch checks the mbuf pool type and skips MR creation for the
> pools with external buffers.
> 
> Fixes: bdb8e5b1ea7b ("net/mlx5: allow allocated mbuf with external buffer")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

      parent reply	other threads:[~2021-02-21  8:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 11:06 Viacheslav Ovsiienko
2021-02-14 10:42 ` Matan Azrad
2021-02-21  8:14 ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB2748F2C5B546336D425401D1CF829@DM6PR12MB2748.namprd12.prod.outlook.com \
    --to=rasland@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).