DPDK patches and discussions
 help / color / mirror / Atom feed
From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Weiguo Li <liwg06@foxmail.com>, Alexander Kozyrev <akozyrev@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Weiguo Li <liweiguo@xencore.cn>
Subject: RE: [PATCH] net/mlx5: fix the unlock mismatch issue
Date: Tue, 7 Nov 2023 06:52:37 +0000	[thread overview]
Message-ID: <DM6PR12MB3753005DE9072E4C40998D8DDFA9A@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <tencent_D1651EC7D3B588081DFD6FF1112691E61807@qq.com>

Hi, Weiguo

Good catch, thank you.

With best regards,
Slava

> -----Original Message-----
> From: Weiguo Li <liwg06@foxmail.com>
> Sent: Saturday, November 4, 2023 6:08 AM
> To: Alexander Kozyrev <akozyrev@nvidia.com>
> Cc: Slava Ovsiienko <viacheslavo@nvidia.com>; dev@dpdk.org;
> stable@dpdk.org; Weiguo Li <liweiguo@xencore.cn>
> Subject: [PATCH] net/mlx5: fix the unlock mismatch issue
> 
> The 'need_lock' parameter controls whether the function acquires and
> releases the spinlock, but the first unlock operation occurs regardless of the
> 'need_lock' parameter.
> 
> To fix this issue, the spin unlock operation should be invoked within an 'if
> (need_lock)' block, ensuring that the function only unlocks the spinlock if it
> has previously been acquired.
> 
> Fixes: 48fbb0e93d06 ("net/mlx5: support flow meter mark indirect action
> with HWS")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Weiguo Li <liweiguo@xencore.cn>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>


  reply	other threads:[~2023-11-07  6:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-04  4:07 Weiguo Li
2023-11-07  6:52 ` Slava Ovsiienko [this message]
2023-11-12 14:23 ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB3753005DE9072E4C40998D8DDFA9A@DM6PR12MB3753.namprd12.prod.outlook.com \
    --to=viacheslavo@nvidia.com \
    --cc=akozyrev@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=liweiguo@xencore.cn \
    --cc=liwg06@foxmail.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).