From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFD97A0A0E; Mon, 5 Apr 2021 12:56:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F783140ECB; Mon, 5 Apr 2021 12:56:09 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2058.outbound.protection.outlook.com [40.107.223.58]) by mails.dpdk.org (Postfix) with ESMTP id 56988140EB7 for ; Mon, 5 Apr 2021 12:56:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VUXgViVhWg8epd14wGlDB2yD3P2PwSlVSGj+aEUZ6EcJ/AXvoINIpB6qU9J/ynWDJiWe6JpzdaDz7yd8gK+DtVnQa5vOnTCuYfKt2mmy/H/k7CYgYdaxmTYeCnB4eV2IiYC4lJyQWJrPoPj6E86NNWqiEH36nGjM23w1vAG2cB6enn/ibRPEvA9/caHwb90InA9Gi5LYEEswy+gyCRJdEKqRAulTRYtBZxeVpR6DyVZqQ+98uHiQ1VWLFGw+X4/UXrMtnrBoJL38B1hEwCirA+wNnV0Rs9BYt36kl0eQrRY7+OiPlB6Wpe1FSYzVhr7JlQHUZ3KG+c+5zmupRa87ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yUITBTJf+WX2o3ETEElZ9KOJAa6+1RzfB2Lxzy+B8Xs=; b=XcRh7+cDBwlQJ1suhmGAIT6yTUlIV9Ry0k4ZgIFA4wOgCtAmqfdVB3cflLgHO1THWw59voY/m6tMok+CeFuisQAEWLqYTC2aoxkwumvChrBpxNHTu4XnozZfXkQgfi8IluKKZUfb66bUvh7HsoN5tlsw+Sec/qFJ0uTZ0En/RH3QtsEZ5aY8S+wbqip2UoPZAEmL3qUO/E/9a/Wl9hdIjgpkT25Cc/fEbc6TxqYJSQ9iCpUwtkfRBa+UUiodtMRNklsNpBd9xP4On0e7asLp+SJ3Ht9wELeH7rZRK64QV712sICA82905Uau7zMQ2dtl1DmvWuiWitI9bhimpoAq4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yUITBTJf+WX2o3ETEElZ9KOJAa6+1RzfB2Lxzy+B8Xs=; b=SFCN5ypTuj1178puYfuA2rLlAv9GKNANBg7knlwu1HVue/Pc9U1t/yyuklDUtVR6h2eD+rYzGnaorY1v/ReEbMRjw4qoM7nqzDC0EE6vummCqvmLlPsKAr1GNPZOxGezV62/FzkG5P5J0EtsMSJmaxBPPh2zA6pjxSWIwa1cJi+llv80lDXI2pZ+LCuq5Zxwx9L76H+Bc6mF1/l1bsGuLdgybK8M5uPiKzfE8rmagg816+ePjfQEVrrRsW9/Tyr0/utYH7jsgc5h/mSC5NDaPWJm8jUeg0gE30ybxvAFdaJgquIn18tnS8xahXSRXHFRpldOxMOE7WiT22kfl2oYfQ== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM5PR12MB1402.namprd12.prod.outlook.com (2603:10b6:3:73::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.25; Mon, 5 Apr 2021 10:56:05 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::20f7:11fc:9d46:9258]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::20f7:11fc:9d46:9258%6]) with mapi id 15.20.3999.032; Mon, 5 Apr 2021 10:56:05 +0000 From: Slava Ovsiienko To: "Xueming(Steven) Li" CC: "dev@dpdk.org" , Matan Azrad , Shahaf Shuler , NBU-Contact-Thomas Monjalon , "Xueming(Steven) Li" , Asaf Penso Thread-Topic: [PATCH v2 2/2] net/mlx5: support new global device syntax Thread-Index: AQHW7a5pYYYmmRLaxUWJ2y9obfhfp6qmOSEA Date: Mon, 5 Apr 2021 10:56:05 +0000 Message-ID: References: <1608304614-13908-2-git-send-email-xuemingl@nvidia.com> <1610983607-7969-3-git-send-email-xuemingl@nvidia.com> In-Reply-To: <1610983607-7969-3-git-send-email-xuemingl@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 78ef6398-af0c-4fa5-c1c0-08d8f8216931 x-ms-traffictypediagnostic: DM5PR12MB1402: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qVhDyv8xth8dDqoB6/m2mz4cJ8W+0OhT7gcJycu/0KhLonEGF6yEZpZBjABVRw+DCSlcKnsca50roIuhRyvDwCJqOhXxnG3M2TLvIOqT/ecCQLj7EJNphYSSHZSLpNjUBh63h9w13Pa9Om61fJZ55S6c5noW427JXqnJ1ogTXKd84eyGEUFEm7n9sSU/ZtFVoGFMwWDm+NWLEeQHq+ZgriNwbrbeprAIclTACInw9/ZnJum18diEhozLZ77DwLyBc47qh9/bpZQtDb5Mw3rC7hqAYfhDLHuQE+FCJnx27MACJ047b0gk8Vps9i3jvxmd7THvH9E2o5auE8fJLIHG72MqBwM8DjVeVtr0d7dCq984MTlKqXtRo5XFJVKJ2bzMZooBRPHXhclOeSTNUTTeor7V/KB3Azzk2IAt+4R97fchmPI1/RUTKk6Qn+sjRSIeVI3Q7T7u+CJJIVJZ1gHBS2SGJOCgwAobnle1jpdat4lt6qzRTxhXd2ZaITftnyHxUAAdCHbrfw21arbMK372OnMwg09KX2fdEOmUhaPq9thUALGIoCejEEf3RfXSo4gFsqHi2RvrWPkTFmE2R2fm1n+EA/RuOUAhAj3YTvcBH5cp6vIxCpWEtRPKXu3USpPuA7K8EvPPmqMwYKdWhGZvUp/VwhMOTmG/7aPuv25bA2o= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(366004)(346002)(39860400002)(136003)(83380400001)(53546011)(33656002)(86362001)(6506007)(8676002)(478600001)(107886003)(4326008)(5660300002)(7696005)(6862004)(6636002)(2906002)(9686003)(66476007)(66946007)(38100700001)(316002)(76116006)(54906003)(71200400001)(26005)(66556008)(186003)(66446008)(64756008)(52536014)(8936002)(55016002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?DDFToVBnf0rXCG60MIJiO1AyjPt1nINqlon7LONnyzAi6sgxc7YSbxiU/Fr/?= =?us-ascii?Q?DEFNe1Yxlh1mSHuvRtJtRaVd8SqHcTp2LUXWDXIp7e5FjKrPlJ2mi+ChmHgF?= =?us-ascii?Q?bYlFzNLI6YxrseqwW4pGvtngIiitN8Q6mqVozVPVlRrtoJ9yDzRDwNSlDEyt?= =?us-ascii?Q?KGZtwqp5k0xLGbE4yf1GN5tmtA1oYqT6s812u52ME1Y6cmc1bS+TegPRG+Pt?= =?us-ascii?Q?dZpNgLBq3O/xtx8JUlBPxx3XEExIh2Xc2j7jNesfb3RPr9QH6HmfebgQyE6L?= =?us-ascii?Q?L5zwxj8udOvrkfslV52PVWAU6Qx/d40smN9YqXKUZjDqXumayYqn6Eywo0P3?= =?us-ascii?Q?avBwcsxOhUo5bv3f7Xv0qjmfF56kuI5LQs9WsrCPceNekR2L9xPZN/RCdg8F?= =?us-ascii?Q?j4XXbHLR8A859+KYJh+AuTlb6zkT4Zgc0sdOKnthw4Z8ZOlfz/XGaAUyebBa?= =?us-ascii?Q?cGEa0GkAQsAdjRpPqaSCmwwCX4+aT9sQ8t2DHDbFKRbCM5loVTPCbzsPMZ8i?= =?us-ascii?Q?NgsbFR5WAqUAQjfBK19zSLvW+INNqB9lgpX8bogMo/KuYLjXRrqgnLwy4eK5?= =?us-ascii?Q?yLM3WEO7Y0VpLqwhYnugE9TjN4RC+Xs7SEu62mV1H5V2w9Q2VnEEmhvvHgQG?= =?us-ascii?Q?l7an8fSCrKcFwb6+7W+TaQpZDAbzEH6OJ7BghcYV+KQ+i03sRbGgJKfBHDv9?= =?us-ascii?Q?2Qcn2Cnu8snh+OLsxflE/nfCdrArnHZYdAN4/u7EfW1xMdzQ9bol8BdtuBWX?= =?us-ascii?Q?d4UBgh80d25Ie9jQoj3kxMPvst5Dibejree1MQY2L5D+gaFhjL/eHCwGs+Fu?= =?us-ascii?Q?1ghc7090y9Fdd36ivBhq+vf/kERA58DSqUhKvgMO5ZK4mSwnI4LH+Os9NTQc?= =?us-ascii?Q?Wg1JUwb41VH4PnLLbZjOlpeKgW/DpY/QB/lhfNSlC7+HQoRadwPyT9RmoX9v?= =?us-ascii?Q?aHcblz6c55//X5GaQkNKoiBZtO+1fvil4PMV7KkBH746pcV0rZoNnMsYevLY?= =?us-ascii?Q?rBirYMwJcbeIOFC5YhQXxf4lY0hwf5OXVFwksRO0oZzYQD7t5UvuMwlHcCxz?= =?us-ascii?Q?T26r0FlTG0K0ReA6qu4M9F9Fb3vnEUevEL6Nmwlr+WlCtsYhSZdGli8mczx/?= =?us-ascii?Q?ek3bTCGoz4Dg3OHQQildwQt/oMlyZnRfPoq6FtiH1JIIqWOyTbC8d4b5ub2Z?= =?us-ascii?Q?GNRFDBnvw8LCPIpw+0ugkgF3rFGd5mFi/ec28euwIA/e2JycyLbS3v5rHVeC?= =?us-ascii?Q?IGz2QHtjnbuU8dCfrKmBZQsipH98j4X3IjxaISOOs8E4JXoOYKUAgEJJMDmu?= =?us-ascii?Q?juA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78ef6398-af0c-4fa5-c1c0-08d8f8216931 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Apr 2021 10:56:05.4213 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: apke4QHCHGC8P4di9zL6FGcx0zvFpN3X0b7kRlLuKOix5JHBYc1L70QsNApG+QMUryNJVx436ZoZH/uqKcNsdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1402 Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: support new global device syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xueming Li > Sent: Monday, January 18, 2021 17:27 > To: Slava Ovsiienko > Cc: dev@dpdk.org; Matan Azrad ; Shahaf Shuler > ; NBU-Contact-Thomas Monjalon > ; Xueming(Steven) Li ; > Asaf Penso > Subject: [PATCH v2 2/2] net/mlx5: support new global device syntax >=20 > This patch support new global device syntax like: > bus=3Dpci,addr=3DBB:DD.F/class=3Deth/driver=3Dmlx5,devargs,.. >=20 > In driver parameters check, ignores "driver" key which is part of new glo= bal > device syntax instead of reporting error. >=20 > Signed-off-by: Xueming Li Acked-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index > e245276fce..3b0e59ce1d 100644 > --- a/drivers/net/mlx5/mlx5.c > +++ b/drivers/net/mlx5/mlx5.c > @@ -41,6 +41,9 @@ > #include "mlx5_flow_os.h" > #include "rte_pmd_mlx5.h" >=20 > +/* Driver type key for new device global syntax. */ #define > +MLX5_DRIVER_KEY "driver" > + > /* Device parameter to enable RX completion queue compression. */ > #define MLX5_RXQ_CQE_COMP_EN "rxq_cqe_comp_en" >=20 > @@ -1597,7 +1600,7 @@ mlx5_args_check(const char *key, const char *val, > void *opaque) > signed long tmp; >=20 > /* No-op, port representors are processed in mlx5_dev_spawn(). */ > - if (!strcmp(MLX5_REPRESENTOR, key)) > + if (!strcmp(MLX5_DRIVER_KEY, key) || > !strcmp(MLX5_REPRESENTOR, key)) > return 0; > errno =3D 0; > tmp =3D strtol(val, NULL, 0); > @@ -1749,6 +1752,7 @@ int > mlx5_args(struct mlx5_dev_config *config, struct rte_devargs *devargs) = { > const char **params =3D (const char *[]){ > + MLX5_DRIVER_KEY, > MLX5_RXQ_CQE_COMP_EN, > MLX5_RXQ_PKT_PAD_EN, > MLX5_RX_MPRQ_EN, > -- > 2.25.1