From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA1CA41DF5; Mon, 6 Mar 2023 14:19:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4EB340E50; Mon, 6 Mar 2023 14:19:33 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2073.outbound.protection.outlook.com [40.107.101.73]) by mails.dpdk.org (Postfix) with ESMTP id E266140A8A for ; Mon, 6 Mar 2023 14:19:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ClTHbpBFFQhOgSaVVwHvvIZhW77YfqGWkvOfxQZg54HntNDI9yL4kDAMYqKRouxsls8dZg8EV4gxi57ncoY+ecm3y3joWpUoEo/Zk60X67ZqKEBxPqUfs500DLYWI9pms33xnDrv7aOO0eFi7oitL6Uxih11w8pL3Kmn0Tk4nXkTnxkszkgT4Al6ZUiuwGUScSh5HZPhzPj7ts3xFwSTvf/oIkptiaXNLs/P9YvqLZoqcykl3HthGQxTkpZxJFcqGf1iRQ7dgVufhz7h37uUFougQnGBD0rjW+8ey9KusktPNIEY7HPANewqInf5YcmZf+pfT5Xjd0U2R3kkP8R+Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=47pRyXtsGxZIdYi8ocmEhH1HvAY4Df/MUYI+Kduo2YQ=; b=od0xhk3cwdpMlZNRjXM1U+dlTa4a2zGMONgcriHgeiaeq3wM9lDOgIkDEH2YqO1F7S/so+EQjG5SLskitZHLCDcBd1rnKJj2Si8De0c6E7JuSYWYIJvR2YwRlmhAACyyfLPGzukrcuZvZeaMAjpYsqrpssu0fSjpL3vxmEfO+wSd4EfkTTvq4KolN/74M+4oo4OJySLDFMk9VA2Bl5DAGdgYNFXr0Ylkwn8tuB/NCLS4hJ/u3p9kE1EbhNjnfwPUvAtj+81FvanP8v7FpRl1cyn++cdgYC2ktXzF2r2EVppmiM+Xq57xRblTSoXxQFNl9ZfkVOEfP/iz8OQu+8TtDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=47pRyXtsGxZIdYi8ocmEhH1HvAY4Df/MUYI+Kduo2YQ=; b=jtn2teFg2oRDYuyAfuZGKZNemv5ojnwCQZFFiBNYe1QLvX1D9/NnSjFIq4MJgVVLCU9SnG2AGL4tb+bIXET+w16VLnXHavDLZ6hJzm/irK3EX8Tr6EQVVeT/4B+WdcPf/b4q7MQK8PEcp4KxxJk1LarS/Vz4MeeNohHUUo6XqnSO6523orEDXAv38ojllkYRZAMMeOBv4OPuVkHQfCHKrsjEGsowREd51ynfKq5x9ZN43jO9Dx7ol2e3XR41yMdUqxNH1rh2zKlkNHuAakXYr1V3TxGQwEI4z3s3YPWzMBB4cZsUYNGt+wghic7F65cvj8/MaF1duK+wFj9d5ciU2A== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by IA0PR12MB7579.namprd12.prod.outlook.com (2603:10b6:208:43c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.28; Mon, 6 Mar 2023 13:19:29 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::2a72:9d50:8f0d:a925]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::2a72:9d50:8f0d:a925%5]) with mapi id 15.20.6156.028; Mon, 6 Mar 2023 13:19:29 +0000 From: Slava Ovsiienko To: Stephen Hemminger , "dev@dpdk.org" CC: Matan Azrad , Gregory Etelson Subject: RE: [PATCH] common/mlx5: replace use of PMD logtype Thread-Topic: [PATCH] common/mlx5: replace use of PMD logtype Thread-Index: AQHZR64RwUIjWxML302chhNM/s64ma7tzOyA Date: Mon, 6 Mar 2023 13:19:29 +0000 Message-ID: References: <20230223174127.189231-1-stephen@networkplumber.org> In-Reply-To: <20230223174127.189231-1-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB3753:EE_|IA0PR12MB7579:EE_ x-ms-office365-filtering-correlation-id: b44afd5b-d161-47ae-5a51-08db1e456a81 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: saOFVHMxuu7xX2vFcbO8rWQoCdqwxy3CuE7VPFvZuArkc771Pz0WqawPJlZdzhsdE285oRumCi2HLKmDBtaKGJxm+zkl4+ndH2AV2n1hF7c9WkmfAnLMnejiQJ+64VU/G7R+2OCoec1CT5WyIjA1RDbfFsvZQb5ak6LOpFueQueUakhxwRLWfwF+BVKjSPfMA8uB+hOdV7vDymyHKhwZ7m1p2Qk72a8kGapWNS7CcICcAQxnDlDcB0VKw20zb30VleWksNMAxbtvN6TtVI09/T+M8wQzwchAklDQ1Apk82zOUokhyCwsuuwo+oK2EM6Rwv8lLRZO7ZSgRJZBD9mvLKnLoU5fkjd19P4xRPp+rGsH9hulQLcDvVx9057O6SivLWUv78iM5UZyluv+qfnygD5LT+2kRKEWJTKb8Giwh/SV8jFzw4s6XWt1AkA3GXhipybP2NcPrKE7she5s7uiN+llEr+UE4ZqpzEKHp6dJUEVyszmS0DDSSvTCEzksOH6/FuPdRUUwDXpgAQxZB3azuM7P0mMeVDKRKGLqzeCe5lQsP6jKJ0O+2bpemS5R/c+TuG3Kb4Q4WCBbMyFy7XjsTMQkVpuxwwDtRXWX0sceCwfaHebNxsVSqtpDiC+3Bgdc5dua8/45jDjgOLxJuykFBE5pfgUXP4RXCCHbjeQj76roYNMSzmL+Tx3adh5oGxheJHPhMefls5jMMMMhUj7CA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(366004)(39860400002)(396003)(346002)(376002)(136003)(451199018)(107886003)(83380400001)(33656002)(478600001)(110136005)(54906003)(55016003)(38070700005)(316002)(38100700002)(122000001)(7696005)(6506007)(53546011)(26005)(186003)(9686003)(41300700001)(5660300002)(71200400001)(66476007)(2906002)(66946007)(76116006)(64756008)(52536014)(66446008)(8936002)(8676002)(66556008)(86362001)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?koi8-r?Q?+ndd/Toy6mbY+/yFaL54UHrowyc3M+3oB4JJtALPB9lwhNsD+nV9+DH2ztZwGt?= =?koi8-r?Q?/2Kz2SgPM/1WBCqW3b61070wSHDo0fbxQ7rhPVm4zpSw9XKOAoJ9w4cBMVW3zA?= =?koi8-r?Q?d2hB15el+icGBBsSBdyDg1faP5tKwe1Zofe6ft9tukdp8bswEvSeTLjNf/NqCc?= =?koi8-r?Q?H6gtQ8WEtNvv0SV5YueKMOTbzNmvdZ7E/5/lE6LHLJgr6dNX6RXSoBdzzg/tUD?= =?koi8-r?Q?aK1fQ7UcWRy4VjU4hiEJUOOiAltHP/Jr10Io0f6KstI4Kf9Ea2bRx6OBpxALYt?= =?koi8-r?Q?KjAqcKxcNT9d+afMiOpmexznQMM2bCGYPqLTQtuYM5TybbwunwZ1UR58gMIQAd?= =?koi8-r?Q?Qeqd8Qhq4L+A0Tm2ZB36YtetHLKkUy8oO7kXUJMpdsfmVg6k4iCYA8Ppp6fsE1?= =?koi8-r?Q?LllKKoI9OwtgCp8u0PKbCzerGh8C83FkO6Qg9jO6QE2XR4G5x3nKQbEtEsYRfw?= =?koi8-r?Q?qXFPenrj7geLWzHUdMaA3i4Ji5Fq5beiVskKvZyqATRTqunep1RMpnBRXyBLea?= =?koi8-r?Q?JXE1PQuC0BAnQGoOh8HqB1STaR5034ujb6RFAFlrlbvg8c7I/R7uDUp7Q03uL3?= =?koi8-r?Q?N1/a5oIcPdI4o50aGc7yXiZWykw9wu2nMAesabzzOJClx8+qEyYe7HsU8Jyi3D?= =?koi8-r?Q?dXUZKFxuzo9HN7O8NvY9axSn8Kb91KCXqWVJ6566JHSEEDS2ssj+p2Ql8Tk2Ka?= =?koi8-r?Q?4ajTDs+gKNQxA5eQPHfE1p3F028n12iMtyOY7tPKjeIEvOqrdPG/t491D4hPm2?= =?koi8-r?Q?L6EdVywuR6GrGmQtfccEHvy0A0qnL9ktAJS2IyhE2cmBGVf0bzKOAXFCaKfwJc?= =?koi8-r?Q?LNesww/bhMNZ0upVw9VdYDm8DPESdprU+fUUrgu3ZFQ2pd5HlKgKdR8CsIuH9H?= =?koi8-r?Q?+V0o+PeVfNxjd2lAP1xqV4f8gXcuCcsRyzy+4sYtDJoEn7AZwWE+6RvPlMzrfa?= =?koi8-r?Q?cAxsiJt38aNfhArz04Tp+uAxcGme6P/MNup3BBy2RdLG3tUNtySqbzCVrE29n8?= =?koi8-r?Q?7raLRe8xdvV3jxXGX+7v8QJEHaUbncyvOJX4Fy1lJPzpn5+CZbeW/czjLK9OYz?= =?koi8-r?Q?SYm6roAQ3h6FO6G/zmdlLthqaJW7WL/ULcWP3aIkiOo46yUqx5jJ4FEZAcXL2I?= =?koi8-r?Q?4rLsfewYok+I/SubKbp2foHU+nSEsFK5tqiOz29+lBm8rHROMLE1P8YOFHGsGw?= =?koi8-r?Q?nD30/hDTTf92gURKw7X/bvxwX8Jn0IXMkD/SIgtcBffnvP32GSae5czGDmRsl2?= =?koi8-r?Q?p3qfKCYbP9P5s80+X8GDwOhz9YokL/F4hQ28FNZubJ6wGVq/HnA1n1KaPgXMAS?= =?koi8-r?Q?4vWzunhyx3GgmhT+6RIULn7Cq2oo9ULx7kxWwUODmXIeZpRSVK1JOnularpd/6?= =?koi8-r?Q?xuNhemgFWVvXvmtE1gvH7DDEGfhqn/3DrkostvkCQ5Y02wMEtBK1TNPbHV6f+1?= =?koi8-r?Q?51Kw2NFjB+jWz8qTfxog8p7OuiSnDcNQ2seLgQPSufusN2ohXog2W0BUP63ZIW?= =?koi8-r?Q?w1rJjF1rzV8nDBkeLAp4QPElEhUwG0RkljUJIDSGeB0N89lK/y?= Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b44afd5b-d161-47ae-5a51-08db1e456a81 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Mar 2023 13:19:29.1339 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7MoYVFFRd6hyeL6AEuWuOu4EoiO0jHoG+H4hiPlJf/myV/mMfop1Antx/V4U7abVGZnck0R1GF9hBUwgA4LLeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7579 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Stephen We have another place of using RTE_LOG in mlx5_glue_path(). Should we update this one as well ? With best regards, Slava > -----Original Message----- > From: Stephen Hemminger > Sent: =DE=C5=D4=D7=C5=D2=C7, 23 =C6=C5=D7=D2=C1=CC=D1 2023 =C7. 19:41 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Slava Ovsiienko > ; Matan Azrad ; Gregory > Etelson > Subject: [PATCH] common/mlx5: replace use of PMD logtype >=20 > The goal to eliminate the generic PMD logtype. > One place it is used unnecessarily is in the mlx5 common code. > Change the one RTE_LOG() call here to use the same macro as other log > messages in same file. >=20 > Fixes: 9c410b28b27a ("common/mlx5: refactor HCA attributes query") > Cc: viacheslavo@nvidia.com > Signed-off-by: Stephen Hemminger > --- > drivers/common/mlx5/mlx5_devx_cmds.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c > b/drivers/common/mlx5/mlx5_devx_cmds.c > index fb670950ef64..710649f86533 100644 > --- a/drivers/common/mlx5/mlx5_devx_cmds.c > +++ b/drivers/common/mlx5/mlx5_devx_cmds.c > @@ -543,7 +543,7 @@ mlx5_devx_cmd_query_hca_vdpa_attr(void *ctx, > MLX5_GET_HCA_CAP_OP_MOD_VDPA_EMULATION > | > MLX5_HCA_CAP_OPMOD_GET_CUR); > if (!hcattr) { > - RTE_LOG(DEBUG, PMD, "Failed to query devx VDPA > capabilities"); > + DRV_LOG(DEBUG, "Failed to query devx VDPA capabilities"); > vdpa_attr->valid =3D 0; > } else { > vdpa_attr->valid =3D 1; > -- > 2.39.1