From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Alexander Kozyrev <akozyrev@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Raslan Darawsheh <rasland@nvidia.com>, Matan Azrad <matan@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: do not allow copy to mark via modify field
Date: Fri, 16 Jul 2021 10:47:55 +0000 [thread overview]
Message-ID: <DM6PR12MB375321D75D86512A2A2804E2DF119@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210716084305.646731-1-akozyrev@nvidia.com>
> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Friday, July 16, 2021 11:43
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
> Subject: [PATCH v2] net/mlx5: do not allow copy to mark via modify field
>
> The Mark action is a two-stage process in the Mellanox driver.
> First, a hardware register is filled with the required value, then this value is
> registered in the software resource table.
>
> The MODIFY_FIELD action can instruct a Mellanox NIC to copy some value
> from an arbitrary packet header field into the hardware register, associated
> with the Mark item. But there is no way NIC can modify the software
> resource table as well.
>
> Due to these driver limitations the copying of arbitrary value to the MARK can
> not be supported and should be rejected in the MODIFY_FIELD action.
>
Thank you, Alexander
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
next prev parent reply other threads:[~2021-07-16 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 18:34 [dpdk-dev] [PATCH] " Alexander Kozyrev
2021-07-14 6:30 ` Slava Ovsiienko
2021-07-16 8:43 ` [dpdk-dev] [PATCH v2] " Alexander Kozyrev
2021-07-16 10:47 ` Slava Ovsiienko [this message]
2021-07-22 14:28 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB375321D75D86512A2A2804E2DF119@DM6PR12MB3753.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=akozyrev@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).