From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A35A3A0C41; Wed, 17 Nov 2021 13:14:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9175D41144; Wed, 17 Nov 2021 13:14:51 +0100 (CET) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2049.outbound.protection.outlook.com [40.107.96.49]) by mails.dpdk.org (Postfix) with ESMTP id AD6F3407FF for ; Wed, 17 Nov 2021 13:14:49 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EgYb2nRxxJuX4MN4gz1ijDjSQNGCL3yPz8xzqXeDSSJxfAnfN5RTUKPIVRF88JGEUsFQwgMwbo0cSdWnvIzbItXRJjLDwmyiaYaPyCKChB5o+aR7dxqLSqUpS/trvzJh1pWVtqc1ayUFoT0ZcmDTxo0Qzuh1jpH3OxD73SpyEAOq3E5UV31iSVK0rmK2DJndCWifLkUm+j0grPoj7lDtlll1L1h5oDZdp9TlM5Do9Kxl9njypWR1pdMRM+5yW6y6wpotjBhAI0IrA1AfJ1hyKZd4MwHVmRfHevrAElsUlsOmfQkqH6GdAtz36jyVTCnx+mvYVxgtqi2RTmpAzC7Pcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rH2DvWfCM0GCpDPL1mGmzbzC6j4REixJ9SKfnO5guGQ=; b=OgQyyjlJOtRmPA6BAqCRhD8C7BEXPzXNavCaoJGcKumXZSx+qiaARU049KMXLLPVVs+hzOJjYSFTq+ac3ul0sZLV+mS8PDMmxqvpC4nDXKi/7nxD1tf7YlHkMYQexZwhAHxTGQ3zGCOD36ABmxTPaZjZwP2k8fvVkWibS6uRyUq2Em33wUyFRVmi3Z/PMonBYPz2hCrdOsR3lHlh2RMSKc621l4fL0Fsi53je5LOUffABOrqCQyW40LnkQvrGEtnYQfF/v7xGoSbhEv71vhkReSGhvuzRgJAC3j6CimE85j6OHs5eTJuUmRip5TkLRtCjWwnru+Hnf62lLF6OWiOxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rH2DvWfCM0GCpDPL1mGmzbzC6j4REixJ9SKfnO5guGQ=; b=Ded+A+70lT/p7O+b5Be9ihYjtPFRaT4NNOOA7hHIkHHseguXxhRHp6vF0rz2/+pmJ+cNoWghRHlnEIZJtjc1Xg4/lMtc22VjN7mEkrR7ShjJV+sFGB9ldNxh/Hac1H/WnWmWRliu0ZDRklinwE5h8SlEopMgo/kb96f4QEkWWVzkhEoAchOnMnS30n8IcPLtiZ6rVX2Sj2rNAGXaFjzMmUnFB4tVeJ0Lrgp7V9EQskTxvMy4qg8Y9zyk+5r73tLlzfoqwwSHSFP3DrUtCjE8qkVnTwYyVp+SFEMbkF7cV0ATFwW6iQEIueqE0AIAV+2p/hOQF6VJ/kxcnEmdHu0C9A== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM5PR12MB1914.namprd12.prod.outlook.com (2603:10b6:3:109::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.27; Wed, 17 Nov 2021 12:14:47 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::8dc4:eba4:b43b:7d59]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::8dc4:eba4:b43b:7d59%5]) with mapi id 15.20.4690.027; Wed, 17 Nov 2021 12:14:47 +0000 From: Slava Ovsiienko To: David Marchand , "dev@dpdk.org" CC: NBU-Contact-Thomas Monjalon , "ferruh.yigit@intel.com" , Matan Azrad , Suanming Mou Subject: RE: [PATCH] common/mlx5: decrease log level for hlist creation Thread-Topic: [PATCH] common/mlx5: decrease log level for hlist creation Thread-Index: AQHX2ylR5nKtgbFpwEaDX85y5efFTqwHojWA Date: Wed, 17 Nov 2021 12:14:47 +0000 Message-ID: References: <20211116203354.14167-1-david.marchand@redhat.com> In-Reply-To: <20211116203354.14167-1-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0aac9611-adad-4073-8a6a-08d9a9c3d90f x-ms-traffictypediagnostic: DM5PR12MB1914: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uG6pINItFCjO4r4kWpVMFs21Y80BGtmIOuVYSnaQSd4cy+JG7WmV/ULnxiRx0H41ot0Fs0X4pa/o5qCEz5zvJ9NoMAJun63VEN470/k5vH+ZIXb+2pHo1Dbyb1OZ4xYKOKNiCFvqXT6O8KT7DOvrpucUKT2gCI0zR5AbV3ZfiIzjrnkkZQ2dWpeNtmBhJmiNYhKJojWu7xrsevPNMLJxGIEHyhMW185Sij/Ym6rIKj2M4RwwOjwePJahf1DHqpT+Wx3fu3HeGq8mCHHYu6SkiVqj8brAFapeA/qlPAQDeL1DY2Vwyx/Z280l8draQIOjyTlnvreCfySZvbyDvhVmKaGEpu+wpzgqeZ+JCkIxRzPt8CwaF7EogYhn3Bin/rAbuG3CTbmPg8mYrVM6XBK8r4vz1dhqtMxPcirnsH16GDADMo5fs2crW03/QjQ27n+YqS2mXeV8FomMfRgDvcK/Q9eBCAmgxjOpWPhw04aayem7zMPzeqID4FgkumMumV6W+oXl+nGNv7REQzp/uyAaZI5l6CBU2T8uy7epaTdZ1hV8vb+vX3OWoMgimy7BG/r4nlWv7RMJMkfh7E4jnLLORdmIKeREDvLWe/3HicL/Ljw7iv/9SaxZn06eqL03PBwM3ZRr05p6VHiOcLkv0xIeFr7RHAs4YcXQXQaTa/5O4FiWhk7yR6UsRUAlRV3dTV5GVKYOM4YuvlitBqjWwXUh6g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(8676002)(7696005)(52536014)(38100700002)(9686003)(53546011)(316002)(508600001)(76116006)(6506007)(64756008)(66946007)(107886003)(66556008)(55016002)(66476007)(186003)(66446008)(54906003)(26005)(110136005)(122000001)(4326008)(71200400001)(38070700005)(2906002)(83380400001)(8936002)(5660300002)(33656002)(86362001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jWLb2hWzprNv1MJbl7xSDU9k7r87HN5rGq6xZ6SM6Qjbw7nGT7yK0aIBI4HC?= =?us-ascii?Q?d+Qy1cjA/N+DQ7ull1TF3ysHwBOluLJ3+cb+7N/e7v4NCgqosetZeNCAHf1/?= =?us-ascii?Q?DvoROvZEdbAjARSRR2oNqm+VEgG3rfnSa+6ziBdz0ZmmoTvI64YCw9ajrCAC?= =?us-ascii?Q?kg3lIIxVa0j5EZhnbVSG1ZIsrJ2OxgFVwCLKRf4nZ3kPGxS2/b84LtGV8vcR?= =?us-ascii?Q?UUa4km0Cq4QG3LQnwsArzfEh1P4R9ku/G+yKVXSZIt6AHsr5fDxaLndiWvfu?= =?us-ascii?Q?Z2+MoaOyE8lm/rloOJnC8urfuQPPcH28l14k8+hKpc8gCTkJN/llULQl1sqp?= =?us-ascii?Q?lGBrKQ9ScTJatVjdFyjYz+2djMfMeksyaqfWLmMQwWIeeF+N/7WCi7XEbaL5?= =?us-ascii?Q?l/FRopxm3IZQqih0E6Cz2HNelMR3ssEFAS4zEINYWt1BFlqnMwjQi4S626Mf?= =?us-ascii?Q?Q8Tz+httB9qdaudwTNEmEcpoMcJElnogjdMdskCW1ceYg8ccM9JJTJPnTXFo?= =?us-ascii?Q?uNUXj1j9a6VxfzCLqR2kP5hm/Od57zO4bXWhWT+Gyh5GW1qwDFSR5SAWbrdt?= =?us-ascii?Q?Ip8wcqfEFCZ4sz7RN1SAt7bTpt/CbHS9eY9YyEfKyllQ8SCEd1QBnKjEUZE+?= =?us-ascii?Q?y28F0l+u3MQpcPsbBJIAg4F4sQ6eWLEz5yZG/c0cl2V0hdwWGw0F+1OznobV?= =?us-ascii?Q?HtuLKynDSPD/pCcRRfxKsiunE9BJg62X70iaCVCzv3+zIxwAuRmiNxxIvNMl?= =?us-ascii?Q?dUqmG7XhBnaqWn5uszIYjvaPmA//sodLNUqn/sg2UZEPnC1pf7ZyGXzMz+4G?= =?us-ascii?Q?kQzcFYoF6UL+jJboO+TedNXQzogJsjzgsGycEFSQOCHQlWljzHqtoGF3OUU4?= =?us-ascii?Q?JGrA/b5+a8zsEmvFv5F+jtaUcYAWhFd1SDpZcmTkN31NUu17Ab/ijFlT+DBM?= =?us-ascii?Q?vuXwlpdVv6xjDcKkUrpEwlHysLC+vBxNYUDoQz8sZb+tik2LbesKMM6W//t9?= =?us-ascii?Q?JH6KmgNC7Eag0dpegl/6h0cJZ5NI0Ulsg22JZVx0by2ecW+o2CyjHGdDyV3r?= =?us-ascii?Q?oHzeRbiSRXRYq6sRMsX3xVDocifIwvYXuDF/ZeKdiwojKEF1UKYg/tNUOc1b?= =?us-ascii?Q?poyc6nagdHe8HsJ4LZOKohRJ+8yDyj+yY9YjNtZEFqeh/YdoxuPtCZL/f+30?= =?us-ascii?Q?gg++s9fjlkFLoTIp+xflxrKj4TZ4stpRWGPmqI8Aj7vmtCmQ7g+F1KcRLiTm?= =?us-ascii?Q?A2hEKGDLnciO3ATd7nV1cEWfoNe7qiG7pHhG8rMuTOB5E1im7x79KKJ4A7Uw?= =?us-ascii?Q?xbPCt7jA3o4Rxdxfq3cenKvN4ohEFy6MdWezrhXzA35QjWxY6kSaKCJCdsmm?= =?us-ascii?Q?+KkrYZD4VOacdUh0iclV8afq4vZhzVinkfehjF+/j06q2+/RSUAij+GJlZXk?= =?us-ascii?Q?fPJYCrBFE2TMqboPs9WSgs5QdXsC94VOUVzJpebY/1H7aw0M0zD3O6c5xJ+G?= =?us-ascii?Q?aIKRBCa7GihMSy2kDkBEvmo3MkcTX9+IBTQCMyWTC26b2YsfVpFtVF5irUJl?= =?us-ascii?Q?J12yd7Zx7kC5E7ZfHR+AMo1nfdWbcDztwoQFCixLROhbysFUfRS9PfM24FTl?= =?us-ascii?Q?EA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0aac9611-adad-4073-8a6a-08d9a9c3d90f X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Nov 2021 12:14:47.3737 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0snWNtG0bmzOUdtI+M9RoCOM3e35YswxEsJKZ6cutz4aYH9/uvfUUPoIwtXBN/N1SeMSg7L5ZGWNiVDQmVJodQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1914 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, David In general, I'm OK with lowering the log level. But we do not expect the warning " is not power of 2".=20 What mlx5_hlist_create() call caused this? > -----Original Message----- > From: David Marchand > Sent: Tuesday, November 16, 2021 22:34 > To: dev@dpdk.org > Cc: NBU-Contact-Thomas Monjalon ; > ferruh.yigit@intel.com; Matan Azrad ; Slava Ovsiienko > ; Suanming Mou > Subject: [PATCH] common/mlx5: decrease log level for hlist creation >=20 > Initialising mlx5 devices in OVS, I get the following logs: > 2021-11-16T20:08:37Z|00021|dpdk|INFO|EAL: Probe PCI driver: mlx5_pci > (15b3:101d) device: 0000:3b:00.0 (socket 0) > 2021-11-16T20:08:37Z|00022|dpdk|INFO|common_mlx5: RTE_MEM is > selected. > 2021-11-16T20:08:38Z|00023|dpdk|WARN|mlx5_pci: Size 0xFFFF is not > power of 2, will be aligned to 0x10000. Can we remove not too meaningful details from commit message? Date/time in messages: 2021-11-16T20:08:38Z|00023| ? With best regards, Slava >=20 > Those logs just make no sense for a final user and were raised to WARN le= vel > recently. > Lower them back to DEBUG. >=20 > Fixes: 961b6774c451 ("common/mlx5: add per-lcore cache to hash list > utility") >=20 > Signed-off-by: David Marchand > --- > drivers/common/mlx5/mlx5_common_utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/common/mlx5/mlx5_common_utils.c > b/drivers/common/mlx5/mlx5_common_utils.c > index 775fabd478..c83333b4b4 100644 > --- a/drivers/common/mlx5/mlx5_common_utils.c > +++ b/drivers/common/mlx5/mlx5_common_utils.c > @@ -406,7 +406,7 @@ mlx5_hlist_create(const char *name, uint32_t size, > bool direct_key, > /* Align to the next power of 2, 32bits integer is enough now. */ > if (!rte_is_power_of_2(size)) { > act_size =3D rte_align32pow2(size); > - DRV_LOG(WARNING, "Size 0x%" PRIX32 " is not power of 2, > will " > + DRV_LOG(DEBUG, "Size 0x%" PRIX32 " is not power of 2, will > " > "be aligned to 0x%" PRIX32 ".", size, act_size); > } else { > act_size =3D size; > -- > 2.23.0