From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Asaf Penso <asafp@nvidia.com>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
Alexander Kozyrev <akozyrev@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
Raslan Darawsheh <rasland@nvidia.com>,
Matan Azrad <matan@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check meta register width for modify field
Date: Tue, 18 May 2021 12:45:02 +0000 [thread overview]
Message-ID: <DM6PR12MB375325DF79C626BB8651559ADF2C9@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <DM5PR12MB240699378BC7CFF83C977D41CD2C9@DM5PR12MB2406.namprd12.prod.outlook.com>
Yes, It is palliative, it is not perfect, and, IMO, it is crucial - with always applying 32-bit wide values we can destroy the kernel part of reg_c0
in some extended metadata modes and this would lead to steering malfunction.
With best regards,
Slava
From: Asaf Penso <asafp@nvidia.com>
Sent: Tuesday, May 18, 2021 14:33
To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Alexander Kozyrev <akozyrev@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>
Cc: dev@dpdk.org; stable@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check meta register width for modify field
I didn't plan to have it in this release since it's not critical and I'm afraid of such changes... I didn't mention this in the status mail today.
@Raslan Darawsheh<mailto:rasland@nvidia.com> can we check tomorrow regression result?
If not good we'll need to revert it.
Regards,
Asaf Penso
________________________________
From: Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>>
Sent: Tuesday, May 18, 2021 12:43:34 PM
To: Alexander Kozyrev <akozyrev@nvidia.com<mailto:akozyrev@nvidia.com>>
Cc: dev@dpdk.org<mailto:dev@dpdk.org> <dev@dpdk.org<mailto:dev@dpdk.org>>; stable@dpdk.org<mailto:stable@dpdk.org> <stable@dpdk.org<mailto:stable@dpdk.org>>; Raslan Darawsheh <rasland@nvidia.com<mailto:rasland@nvidia.com>>; Matan Azrad <matan@nvidia.com<mailto:matan@nvidia.com>>; Slava Ovsiienko <viacheslavo@nvidia.com<mailto:viacheslavo@nvidia.com>>; Asaf Penso <asafp@nvidia.com<mailto:asafp@nvidia.com>>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check meta register width for modify field
> > The modify_field Flow API assumes that the META item is 32 bits wide.
> > But the C Register that is used for Meta item can be 16 or 32 bits wide
> > depending on kernel and firmware configurations.
> > Take this into consideration and use the appropriate META width.
> >
> > Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action")
> > Cc: stable@dpdk.org<mailto:stable@dpdk.org>
> >
> > Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com<mailto:akozyrev@nvidia.com>>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com<mailto:viacheslavo@nvidia.com>>
Applied in next-net-mlx, thanks.
prev parent reply other threads:[~2021-05-18 12:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 19:54 Alexander Kozyrev
2021-05-18 9:31 ` Slava Ovsiienko
2021-05-18 9:43 ` Thomas Monjalon
2021-05-18 11:32 ` Asaf Penso
2021-05-18 12:45 ` Slava Ovsiienko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB375325DF79C626BB8651559ADF2C9@DM6PR12MB3753.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=akozyrev@nvidia.com \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).