From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E65AEA0A02; Tue, 18 May 2021 14:45:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5DCC54068E; Tue, 18 May 2021 14:45:05 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2040.outbound.protection.outlook.com [40.107.101.40]) by mails.dpdk.org (Postfix) with ESMTP id 14D3140041; Tue, 18 May 2021 14:45:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nCDYwHtQcu48YmbqITFaDDz6h4dCC1MArt4qeC3EekSmbq0+7hKcV686gGPdN4g9L3wAXPgPfDHFBrANfwURnlkRNwLP1T62aoINHLZzHueGiRhLiAiGoOGgNstxq+Pqm/T6gNM6XZT3dtNpT6Fs9nBz0LiAwgSDiVKTSujrVwLFuYGJTY03hqLyVIHb7lfKFXcES4UO0kIUwps84TgOdG6WfT09leyUcSygsp3Ra//S5I/G8GP9rCs68/HP2hnjfafuWn9f0zaiAYp9htt2aTSeRMPfA6c8tIAQKSJ5GQqHA5ItMqmIEeXM27dlFAheu8zGCP6s2SSICxj/HNy5Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/PVFsW41je118dpfRtPljZ87jR0LveccRwhKNrg4bV8=; b=gAvGFTCAdTxNa3hgaxxF1n3LsOB1ODfupiGg3FoC9vve0yW+IzznrIaNvEjib+12JXRF74a79Ka6ScdINK7dkrjTJLDPFUzqiGD4d+C6aDcNlIqb1nwmZCecR2H7EBgdeuv/U9MlgpII44JX6pOnjJIxUKC0uJBmh/anPuugjIBcUnTY8D1R2VBH0mEK0b1k4eK5pcRVsAeF9YRM8SxN/TfgYnrrFyBU9HhHqsJJJ4w+NJlq5fa7N8kp7uW2d44IB+c3okStUgf8AM1qzh6GboIGsucrBGwyuL8F+B/54AdwbyHkgAz8f6/HABAKW7jlB6u7xxX92FsGXG4A21fwCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/PVFsW41je118dpfRtPljZ87jR0LveccRwhKNrg4bV8=; b=lnzC8uqblkjdNCpm1ovyRwIf2PMC1Y4R6fJ3qp2wQ1EvmLxwxgbRTZD9d/xxPB/0YQqtLbU8PHgPYTZWzFQdEgHme48svbEXmIKDFSgWV+9Sfq2viHKbODdUKHcF3R9O7jDVbGrGcYjandMOm2W2G7RLgYP2Kmbo5g6romL8VHgr4sxb8ohvVz7xEYEUek4tm/PzANfsOMeNh3m1Rt5HEwM6liIx/smM15UGsE7aPBHbzAT3NltHjbI4GiDjtNRNVTpIs6OvhVLTgmTEfYHEuPHPcAScxKJtr9QsQfiu0QZ9EbFjWT1xJwTC4y4Y0VKR01VjWe9RlsSgrXskLV1HBQ== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM6PR12MB3498.namprd12.prod.outlook.com (2603:10b6:5:11a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.28; Tue, 18 May 2021 12:45:02 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::c595:e3bc:686c:16a4]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::c595:e3bc:686c:16a4%5]) with mapi id 15.20.4129.031; Tue, 18 May 2021 12:45:02 +0000 From: Slava Ovsiienko To: Asaf Penso , NBU-Contact-Thomas Monjalon , Alexander Kozyrev , Raslan Darawsheh CC: "dev@dpdk.org" , "stable@dpdk.org" , Raslan Darawsheh , Matan Azrad Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: check meta register width for modify field Thread-Index: AQHXSDHsyZkopNtDEUmYfnvl7VZ8SKrpAISggAADoQCAAB5/gIAAE50A Date: Tue, 18 May 2021 12:45:02 +0000 Message-ID: References: <20210513195458.258410-1-akozyrev@nvidia.com> , <2199211.lUFL8MgVHS@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [188.163.75.124] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ab73a79f-958c-4a77-ecc4-08d919fac135 x-ms-traffictypediagnostic: DM6PR12MB3498: x-ld-processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QJlcy3GRCWAxF2+OG9W3loKTr98dOZCDAz2jMzLzCARtrMymApR5ZIJf9uUy9ruA1BbwF3SHSk1TLFUuwC6ScqbT+/voHpAQ7ZjvOyBBvvhzVy6pNMIsbxLmoPqkhUcPJoV3ozg0vsjTIsLcqF1A+/AbwGqMOcoROEMEolVRrSpA94IKgTu0ysTbCl1SultmRxqEiFvpNMAWaG5J25Fv7F/f2xiEbejFLDzdodJuxTH/ZGUEPYx0vIb0EPDvxj2pAtWmm+4CmDPVUtJr0Ty6fxQuak9sotDB6Zkp1D7BmyN24zwftjp9wx+iqZDtKHWd4UeMaigre/nzEwYOm0v2rYVMUqjMjKVK0FVzaqOTW1wSPzq+iq2zWSb6RD+h7Yoq7P77VCuuJPO4zs/jpfsSc0EMPsuEvGNLUu7/7m+QffQPoUyN/WLMZejjwUP9oWqVJ93A/zBwknebYlEAKN8zg7MTo7d1cuvpUAlnDhGeCdh4603r8rn0EgraAmzTstq/mGxHdAcgX6fS24Zip9mFseyhnP6eAWxnBdhtm1gIWMOfWJu6EVMggT8nHfmaA/eRTuOLhqnlfsen5ICLlmSXMfJlFe7RA90JTD/pz/JQ7UA= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(39860400002)(136003)(366004)(346002)(76116006)(53546011)(6506007)(9686003)(5660300002)(52536014)(2906002)(38100700002)(316002)(478600001)(8936002)(33656002)(86362001)(55236004)(122000001)(54906003)(66556008)(66946007)(64756008)(71200400001)(66476007)(6636002)(186003)(4326008)(66446008)(26005)(55016002)(8676002)(7696005)(107886003)(110136005); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?hok6GaEJ+aAf6VPgsUnUoF2n2PJUW1F9A4DQbZuxEzBRE/086pak+dFIdaw+?= =?us-ascii?Q?1kAs31IW5zYCC1/IGYVGjfuZLve1hxsM6+9++QxVkOi07c81s7yIijvV2vVU?= =?us-ascii?Q?qYOr9VVY87v7Yv3HpbYl4Hgjs4RiZB7SZIpv8ccptTfbBeBMYU/FP5j1BjEW?= =?us-ascii?Q?snuSSDs5CnWS5C0Dv6Oa9z2XJqEaR56ytw6DmjEmYet67F3Qt+zs1alhyUBW?= =?us-ascii?Q?yZ2aHBL00vbmL+qCC1JtackJLzjfruYv+DAl+Qg3Qpl6xEdAwIiqDjNCfTW6?= =?us-ascii?Q?tJXibrvQkItqZajAZW7PFwDsBOE3mHLDxRVjQGc4NfdQY1eWcsntYtsGydX6?= =?us-ascii?Q?AmllyJO5ux12I5zA86emC3JRtR5qLkyB3AqyT7KcfJi7d/Qi5wJp7DI4jd2N?= =?us-ascii?Q?zGxr/KzW6Q9zx9EqMlV9IQYmPyeLed0WE4WaBsrWusD1+Xaf4TrJSTSJNMxg?= =?us-ascii?Q?0uQzI8WJ46aB36vq9yLO+ALIO5e7knJGuYVEP7uYzGnQS1PaUYsPUaV1NLuQ?= =?us-ascii?Q?54jSmcLYVEV7aZB7eBRlGiFTL3r7H6PMfierbJoeBAc2sbFTc5mQgz6nfXiw?= =?us-ascii?Q?AUpePWR1BpNEylPe3PYeeOYhR7nPnX4ecVugdein9e8qRDOWiUs5mCCzdEcP?= =?us-ascii?Q?+g+EYO+XDySOaLXmYicUX2o0VmhpAf7bZ1BbNVUlV5uzOr5ciW4kNJBEYpan?= =?us-ascii?Q?Gw+8j9qY019uVoplddgjhZTtjQbx+GB5hF0xDY8qdHYcD8XSxuGZG/2gwRzr?= =?us-ascii?Q?knsNe6ObHUsarpP9ViOHDvt6XDNd5oQ71O66qg86blFXfEC2nMnXF4S9XOqs?= =?us-ascii?Q?ZeglKFK2yXEIvAxFADHkr0SiWPIK6IEKNuc/ZgySs882DQ+DVj7pMWuVrhkl?= =?us-ascii?Q?+GW0x7TxAmPOS34Tf3mnixS47UrFFdLHePXQK6IuqnmpJZPhRTNL5/un/JML?= =?us-ascii?Q?QB44HLsx1TgxZFcAlaYuSHtw2Gcv9mJ+OCS+NS2xKX4UGSTejebaio1DvAVN?= =?us-ascii?Q?M1mC0ZqxSFWcjwyrt31rl76A0TIUoQlz8C4PexYp+3N+lkkDovIto5YpKunK?= =?us-ascii?Q?Jv8hqmqmn2n57K2HAAA2ZMWOEuaWfTwwWh54wJURw2FA7a3dGJGjPdXwxFQ2?= =?us-ascii?Q?WxcsaiwQCdVr1mpQgzaSvjuEF+24wwQUl4yH2BFbyNWx2DiBpmo5buPo6Xx4?= =?us-ascii?Q?EnvnI0NaeQ7M2B5TJPxKv9A4kvQhF/EV66UcRZ58P7wFI911jowZRzRIiwtH?= =?us-ascii?Q?8RreMcvmAwpqnI+bf+utbc4rLmQCMO4TqvlJHEK93V9J+jrj9svwihuKZVwX?= =?us-ascii?Q?i4E4f/HOKAmpKeM5yV4Fr1l5?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ab73a79f-958c-4a77-ecc4-08d919fac135 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 May 2021 12:45:02.2191 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RjaUzKbr/UKqvgHxavt7QJzlbr34y2xvX0RJx8IZi3/MfaV58dQoxSA01FWoOcXzVBQA9cmwXiem2n9+fVmvRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3498 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check meta register width for modify field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Yes, It is palliative, it is not perfect, and, IMO, it is crucial - with al= ways applying 32-bit wide values we can destroy the kernel part of reg_c0 in some extended metadata modes and this would lead to steering malfunction= . With best regards, Slava From: Asaf Penso Sent: Tuesday, May 18, 2021 14:33 To: NBU-Contact-Thomas Monjalon ; Alexander Kozyrev ; Raslan Darawsheh Cc: dev@dpdk.org; stable@dpdk.org; Raslan Darawsheh ; M= atan Azrad ; Slava Ovsiienko Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check meta register width for mod= ify field I didn't plan to have it in this release since it's not critical and I'm af= raid of such changes... I didn't mention this in the status mail today. @Raslan Darawsheh can we check tomorrow regressi= on result? If not good we'll need to revert it. Regards, Asaf Penso ________________________________ From: Thomas Monjalon > Sent: Tuesday, May 18, 2021 12:43:34 PM To: Alexander Kozyrev > Cc: dev@dpdk.org >; = stable@dpdk.org >; Raslan Darawsheh >; M= atan Azrad >; Slava Ovsiienko >; Asaf Penso > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check meta register width for mod= ify field > > The modify_field Flow API assumes that the META item is 32 bits wide. > > But the C Register that is used for Meta item can be 16 or 32 bits wide > > depending on kernel and firmware configurations. > > Take this into consideration and use the appropriate META width. > > > > Fixes: 641dbe4fb0 ("net/mlx5: support modify field flow action") > > Cc: stable@dpdk.org > > > > Signed-off-by: Alexander Kozyrev > > Acked-by: Viacheslav Ovsiienko > Applied in next-net-mlx, thanks.