DPDK patches and discussions
 help / color / mirror / Atom feed
From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: wangyunjian <wangyunjian@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>,
	Shahaf Shuler <shahafs@nvidia.com>,
	"dingxiaoxiong@huawei.com" <dingxiaoxiong@huawei.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx4: fix mem leak when a device configured repeatedly
Date: Wed, 12 May 2021 14:04:41 +0000	[thread overview]
Message-ID: <DM6PR12MB375336E8B07573BAE554FB77DF529@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <1620825508-29440-1-git-send-email-wangyunjian@huawei.com>

Hi, Yunjian

Nice and tiny fix, thank you!
Could you, please, remove the empty line after mlx4/5_proc_priv_uninit(dev) 
to follow the mlx5 coding style?

With best regards,
Slava

> -----Original Message-----
> From: wangyunjian <wangyunjian@huawei.com>
> Sent: Wednesday, May 12, 2021 16:18
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>;
> dingxiaoxiong@huawei.com; Yunjian Wang <wangyunjian@huawei.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH 1/2] net/mlx4: fix mem leak when a device
> configured repeatedly
> 
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> Currently, configuring a mlx device, it will allocate its own process private in
> mlx5_proc_priv_init() and only frees it when closing the device. This will lead
> to a memory leak, when a device is configured repeatedly.
> 
> For example:
> for(...)
> do
> 	rte_eth_dev_configure
> 	rte_eth_rx_queue_setup
> 	rte_eth_tx_queue_setup
> 	rte_eth_dev_start
> 	rte_eth_dev_stop
> done
> 
> Fixes: 97d37d2c1f6b ("net/mlx4: remove device register remap")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
>  drivers/net/mlx4/mlx4.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c index
> 7cd35cd3ca..c72587b7ef 100644
> --- a/drivers/net/mlx4/mlx4.c
> +++ b/drivers/net/mlx4/mlx4.c
> @@ -201,6 +201,8 @@ mlx4_proc_priv_init(struct rte_eth_dev *dev)
>  	struct mlx4_proc_priv *ppriv;
>  	size_t ppriv_size;
> 
> +	mlx4_proc_priv_uninit(dev);
> +
>  	/*
>  	 * UAR register table follows the process private structure. BlueFlame
>  	 * registers for Tx queues are stored in the table.
> --
> 2.23.0

  reply	other threads:[~2021-05-12 14:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 13:18 wangyunjian
2021-05-12 14:04 ` Slava Ovsiienko [this message]
2021-05-13  2:36   ` wangyunjian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB375336E8B07573BAE554FB77DF529@DM6PR12MB3753.namprd12.prod.outlook.com \
    --to=viacheslavo@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=dingxiaoxiong@huawei.com \
    --cc=matan@nvidia.com \
    --cc=shahafs@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=wangyunjian@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).