From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7521A0545; Sun, 28 Aug 2022 20:34:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99AD440DDA; Sun, 28 Aug 2022 20:34:02 +0200 (CEST) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1anam02on2052.outbound.protection.outlook.com [40.107.96.52]) by mails.dpdk.org (Postfix) with ESMTP id 479A840696; Sun, 28 Aug 2022 20:34:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WdJfRqq1uUdY6qyZ1sRWdgcs/NKL3EAobl8zpTXrStA/72skvLDFkkluL3tnm5AwPiYggfl60bJKM+ojly39Cgs5wr+73Q43XXBoql3H37XQUG+DgKEE/fb6ZzDR67SIDasdrxZtvuxmMOaFHXkGl3o5O75OoI8LuGCwS0c8mGx8XKTB2mWs1ajaf4A6/IfrxLVz0H20y8kWmudZ2nGOIN2xyO0ShTiUjmqDLtuWBTfjjhsdo3FBZPoj99/gYGJLpVbR09ptxFPV6qDxx7co5fC2aH4q3YUue7P0E15cruF8oS/JU/4Ylxg2oSVOq1TD5VQ07A2Lof+K6KK3PD8mEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LngJeaL1rJWBJzvfmYzehc8sAJYQsd12bVSYaOIdaJc=; b=C6WL4HMqsxQ6AAEF1cUk+dxkxvxtu2NBQK8MS7D89T5U8wSca4JV0cdUcXjsya3HaPS5sC0MSoB2TrDrhiGObmFjiPGYljEcUz6wToq+vowfcKGGEAjlqU4UBx3ZytE7+IKEhoxh4auKi8UwRbQ8Izf81FFWGrgh8cu335fsX+XILmLUTv+Mdf5++Zv5PieEQ0XGd2mMg3hHN6i7uqQJtAerZhtbXztLGM+VcfobYA48rGGe4F1MuvoOOWX1y1HhFYvrP28/szsCiMhg5XVsaXs8ZdX3qlugU3ZFVuohsVGBbbENZe0LARqO3hDi581zvNPPh1w6i2g7QBIYagzsKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LngJeaL1rJWBJzvfmYzehc8sAJYQsd12bVSYaOIdaJc=; b=svq8R/L3ANpv3bxQCuBGRE33EybVQtFHzLMwnhLn1yaTCZxm0KkqOrtLjRmDKztLp7oIgUSzEBqHj/i5jRCo41rYLN4clW3YRWDHkJYtdqh+3irUnfJhSXZGwMHxCJYoGL+yJ7Efw5LO+4gM8CbNGH5QoEmzOuaU0yPN5vJNPmYRpBUfnMDMDJ8WjMD0mjfTyWynqsiyScE6dmimkGKB9xF+/BFR4TaflWy72vj8q2FC82gIdLGqPswfDGePD2kFC2bABwgYCH4QFfsKNUeT1S5gFV0AAcvTSH8fGwlOLrTatdWJnwCn7B8xx2teUboVjXhGGhHScARu0lpl+gktEA== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by PH7PR12MB5656.namprd12.prod.outlook.com (2603:10b6:510:13b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Sun, 28 Aug 2022 18:33:59 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::6024:e584:2770:7bf4]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::6024:e584:2770:7bf4%5]) with mapi id 15.20.5566.021; Sun, 28 Aug 2022 18:33:59 +0000 From: Slava Ovsiienko To: Dmitry Kozlyuk , "dev@dpdk.org" CC: Olivier Matz , Andrew Rybchenko , "stable@dpdk.org" Subject: RE: [PATCH 1/2] mempool: make event callbacks process-private Thread-Topic: [PATCH 1/2] mempool: make event callbacks process-private Thread-Index: AQHYqws78FfSEbFp+EaaH/MRGBhp6K3EwzsQ Date: Sun, 28 Aug 2022 18:33:58 +0000 Message-ID: References: <20220808094236.3395516-1-dkozlyuk@nvidia.com> <20220808094236.3395516-2-dkozlyuk@nvidia.com> In-Reply-To: <20220808094236.3395516-2-dkozlyuk@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 673fcb08-6e4b-4ee0-3bc5-08da8923df3e x-ms-traffictypediagnostic: PH7PR12MB5656:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: v8rF0rN57C9NZVr21Y+ay4RgJoeWDXeQ4pn3L5PHZfM9U/KdfsiIkM8NYKVfDpLjKZJlsJ1ypsC+7wOEmhNbSLLh/KbOVqQHxc160SEZx4/k1AsTmQsGsAhB7rAEaDep7Kgwo0LKqrokXVpOHolSYYZr3GXVry2E3gkdj72PyeFnceI6yKF7OCSFWckP+XYpLxn3wKWqF1U3eCQNEqePU+COLtCQjMR8LtLHL0UMiH360drYblFBZzADdGG7liFslG+bJcUaDcYsyp1gw6gGSE4CvMKkMtfZzk7P/tuYehfRs/O1Ax3fRdMPe2WWoVIuMDCNnxgBHqBDcyoxnTZnwPUBjSVXdBRDFrnwKXIrnPymCd8c/cuU2IVto9T6l9z3/bVod4jQmmnzdJdQQCP//ZLb0R1w41X1N8BYh7O84VrbMXCtS/acLdm8GJUNA3+0LNV+6uZs0Z3D+9u723m3EGFemWTpdnd9fbmM8eJvMRfRxfZkA4qIiNWVwdc4EZobInMb2RAFREaLBp4zZVa+3Y7PELvXU/1Kh3JxwKFIcJDrMAoxAfHJhm3RSWIfLCXf3wwZ6h3bRCTeSxt1ooUaXgBlRv/wqpDVbtd2EojzLUVC7fbKNySwaD996xWVyRUGaXk+iYbOP3FPqOh5+/S30U1yMP8TW0WeaDi6CR/4Fp62vcjZMQHI3UzlDnsFFhlEFjEStjzazQJpoqitOP4pcjzSQV51tRWYlaZ5erfpjnefpfhtA8vLUdnjA0ldWEunlHTD59RKNNGRQizbPJYbLQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(136003)(39860400002)(396003)(346002)(366004)(86362001)(9686003)(7696005)(26005)(83380400001)(186003)(33656002)(2906002)(53546011)(6506007)(38070700005)(55016003)(4744005)(38100700002)(54906003)(71200400001)(8676002)(316002)(110136005)(122000001)(64756008)(52536014)(8936002)(478600001)(76116006)(4326008)(66446008)(66476007)(5660300002)(66946007)(66556008)(41300700001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AK1Sv/9mtXLURUSde5Zp0YS0NfnwKgthLBxBYLbxlHJ9oB+rmD6tr70cWatY?= =?us-ascii?Q?RXLiHMkwym35zOqHF0X9nbFEsBvPy8d+zZl6z3CS1AK+8eNTgKyQ9aQRSNjv?= =?us-ascii?Q?k9rczworBp1BJqWNoxjP529xCeJAua0iYvY/PQZtBaZQsRmVekdbzejq+G9R?= =?us-ascii?Q?TcK5LbZwrcs07dt5kNc+kIrv+7ZlAG28LoHZAW+/ubXmCowOH4yNOYajQnmh?= =?us-ascii?Q?KfKoR7dRfgjEdH/8yXeksMNsvvM8FIsBXajwhIJPGW5oay/GWQfCIOK0166R?= =?us-ascii?Q?LswejE1Xz8hoa5l6DvFr5M+VP4OH+12z2ncKoylOoTblcbezo70W7kRkYTGa?= =?us-ascii?Q?AWZ9O0hq1VVAeIvxowQmhKhPbKZMBzsr9CusDLzjdiJP7RCsx6tkKFYKY8aa?= =?us-ascii?Q?gwPstnAPGNJGvXyfpB3zZXWDSCJWMCEIoI8pcGlxQJW62Ld64pG6DDSD+jRN?= =?us-ascii?Q?E27nM0biaasWJZKYayjv7GMr5Xodqo8PjQsIJQLls4MiKdfaI+Ap/vQ2T5Wr?= =?us-ascii?Q?rAfSom+8CyYQ6CezUa0L6jxVKn7EJ5l4wNRdZ3L59L5x/BKB5zxXv0GdS7+U?= =?us-ascii?Q?fq/CoysprZVMsdQLaB2Zf6EHivtdQzmgzPO1q1fv9S9Mfg1wEbB+Vm8evejv?= =?us-ascii?Q?90N1qQr6XsvzeFQmbJ6Bf5S4FQUMz4KGZX2x/NLm2Z15UBOak6iXZxjDvdw/?= =?us-ascii?Q?lINRTH2PhilDOnrurag89EGRtjoZ+HYzUNMuiKM26SsJpQD21cH9uppXcSfr?= =?us-ascii?Q?XzBV/OCdmvzqEqIcepm7S2lgnlHJW9GbfuGbINCrjknL3HNJFbseIRxsG4Sr?= =?us-ascii?Q?FvCgg5jSCSZEZlb/rEd4oqKmXjFuFF0YFaeaXUSZxuwNZp/82VgzY61U2Rrr?= =?us-ascii?Q?t7Tsa4y0U308q3sEpVc/D0cBNHJyPkBS/0ZBL/T9B969tcsvsZpcJ/XB6NKP?= =?us-ascii?Q?ZqKdP6UKrPyNeY8bHoRoEpd9HhFO6wFJHoefd6oHvunSyCHtTxMoTk6Gn9U6?= =?us-ascii?Q?VSmU0tVUx1pm9ZoA5aFMuNrI6tbpLnIYGMK4hwue3x0Gy6yhG6Jn7l/xlbyO?= =?us-ascii?Q?m4+U5LM19UaoEYQaL/AlwmBNjYI8dLVRxtxbm2bDk4bBYemNZnVd4fwIt/99?= =?us-ascii?Q?ed0w0IxADnySKesTEAB0FvAoPV1DRU9x0y/V7z9dmnuKYJfl9A5CCiuQ1moi?= =?us-ascii?Q?wKPxyA24D7lMRqmtMJYwArR0bvEPpK0+rkleXDDB59yTp7cFu3V7B+VmTf02?= =?us-ascii?Q?r15HaQ6qNvq0rU2f4plsWfXVzAsFg3UZnUZSzY3J9m5gubjbqETZ31sOATpe?= =?us-ascii?Q?8cE7Ohd4nRT8Sd33+tdrX01uVieHiWS+tupDwQukucr6Q4uyZIt5SW1KfGej?= =?us-ascii?Q?LGwt4AGyokw4uocSZSGALuwvCu9+tFBFLXW//b78VhZFalK049P/FJ98XdXp?= =?us-ascii?Q?jNF09BAQhnT2wzmEJDlQUzB41tj7lMRY9Xu1SbYGFon0thJXi1/sDxUvwGMT?= =?us-ascii?Q?S22igWBNBnaId14vZDGDqnTR7CqVDZe1pzkustzdV67vfD9VFz21ClxNTaBK?= =?us-ascii?Q?nhfm3KYTcXoxhMKJvYZtkgRMCij3kDqRCooZLd8S?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 673fcb08-6e4b-4ee0-3bc5-08da8923df3e X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Aug 2022 18:33:58.8448 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: y1eZIusA99ZLNr0hQ4TgBvGlgReQYwoXqE9wezkK5uchEpGpc2qoy/LJolQybaBGusPlia8xVJNmdhwaBDqj5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5656 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Monday, August 8, 2022 12:43 > To: dev@dpdk.org > Cc: Olivier Matz ; Andrew Rybchenko > ; stable@dpdk.org > Subject: [PATCH 1/2] mempool: make event callbacks process-private >=20 > Callbacks for mempool events were registered in a process-shared tailq. > This was inherently incorrect because the same function may be loaded to = a > different address in each process. > Make the tailq process-private. > Use the EAL tailq lock to reduce the number of different locks this modul= e > operates. >=20 > Fixes: da2b9cb25e5f ("mempool: add event callbacks") > Cc: stable@dpdk.org >=20 > Signed-off-by: Dmitry Kozlyuk Acked-by: Viacheslav Ovsiienko