From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Souvik Dey <sodey@rbbn.com>,
Raslan Darawsheh <rasland@nvidia.com>,
"Matan Azrad" <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5:fix storing the synced MAC to internal table
Date: Thu, 21 Jan 2021 16:56:15 +0000 [thread overview]
Message-ID: <DM6PR12MB37535837808D510405211A19DFA10@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201209151108.12352-2-sodey@rbbn.com>
Hi, Souvik
Thank you for the patch, please see my comments below.
>From: Souvik Dey <sodey@rbbn.com>
>Sent: Wednesday, December 9, 2020 17:11
>To: Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf Shuler ><shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>
>Cc: dev@dpdk.org; Souvik Dey <sodey@rbbn.com>
>Subject: [PATCH] net/mlx5:fix storing the synced MAC to internal table
We have the warnings:
Wrong headline format:
net/mlx5:fix storing the synced MAC to internal table
Wrong headline prefix:
net/mlx5:fix storing the synced MAC to internal table
Missing 'Fixes' tag:
net/mlx5:fix storing the synced MAC to internal table
The patch headline should be:
common/mlx5: fix storing the synched MAC to internal table
- net/ -> common/
- space after mlx5:
- synced -> synched
The patch should contain the Fixes tag:
Fixes: f22442cb5d42 (“net/mlx5: reduce Netlink commands dependencies”)
Fixes: ccdcba53a3f4 (“net/mlx5: use Netlink to add/remove MAC addresses”)
The patch should contain (to be sent to LTS ML):
Cc: stable@dpdk.org
>As the internal MAC table is divided into Unicast and Multicast address
>section, we should check the type of synced MAC address before storing
section -> sections
synced -> synched
>it to the internal table. Currently the check is not done, and the
>synced MAC of 33:33:00:00:00:01 gets stored in the unicast section
sync ->synched
>(mostly index 1) which causes all subsequent mlx5_set_mc_addr_list()
reword? : which causes -> causing
>to fail with error -EADDRINUSE, as the mac_list contains the MAC
>33:33:00:00:00:01. This denies adding of any new multicast address to
>the internal list and also fails to add the MAC address to the device
>in case of SR-IOV VF case.
typo: case (to remove)
With best regards,
Slava
diff --git a/drivers/common/mlx5/linux/mlx5_nl.c b/drivers/common/mlx5/linux/mlx5_nl.c
index 40d8620..ef7a521 100644
--- a/drivers/common/mlx5/linux/mlx5_nl.c
+++ b/drivers/common/mlx5/linux/mlx5_nl.c
@@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned int iface_idx,
break;
if (j != n)
continue;
- /* Find the first entry available. */
- for (j = 0; j != n; ++j) {
- if (rte_is_zero_ether_addr(&mac_addrs[j])) {
- mac_addrs[j] = macs[i];
- break;
+ if (rte_is_multicast_ether_addr(&macs[i])) {
+ /* Find the first entry available. */
+ for (j = MLX5_MAX_UC_MAC_ADDRESSES; j != n; ++j) {
+ if (rte_is_zero_ether_addr(&mac_addrs[j])) {
+ mac_addrs[j] = macs[i];
+ break;
+ }
+ }
+ } else {
+ /* Find the first entry available. */
+ for (j = 0; j != MLX5_MAX_UC_MAC_ADDRESSES; ++j) {
+ if (rte_is_zero_ether_addr(&mac_addrs[j])) {
+ mac_addrs[j] = macs[i];
+ break;
+ }
}
}
}
--
2.9.3.windows.1
________________________________________
Notice: This e-mail together with any attachments may contain information of Ribbon Communications Inc. that is confidential and/or proprietary for the sole use of the intended recipient. Any review, disclosure, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please notify the sender immediately and then delete all copies, including any attachments.
________________________________________
next prev parent reply other threads:[~2021-01-21 16:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 15:11 Souvik Dey
2020-12-09 15:11 ` Souvik Dey
2021-01-21 16:56 ` Slava Ovsiienko [this message]
2021-02-02 3:53 ` [dpdk-dev] [PATCH v2] common/mlx5: fix storing the synched " Dey, Souvik
2021-02-02 12:58 ` Slava Ovsiienko
2021-02-02 17:48 ` [dpdk-dev] [PATCH v3] " Dey, Souvik
2021-02-03 8:04 ` Slava Ovsiienko
2021-02-03 12:09 ` Dey, Souvik
2021-02-03 14:15 ` Slava Ovsiienko
2021-02-03 14:34 ` Raslan Darawsheh
2021-02-04 10:43 ` Raslan Darawsheh
-- strict thread matches above, loose matches on Subject: below --
2020-12-09 13:42 [dpdk-dev] [PATCH] net/mlx5:fix storing the synced " Souvik Dey
2020-12-09 13:42 ` Souvik Dey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB37535837808D510405211A19DFA10@DM6PR12MB3753.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=sodey@rbbn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).