DPDK patches and discussions
 help / color / mirror / Atom feed
From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: David Marchand <david.marchand@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>, Matan Azrad <matan@nvidia.com>
Subject: RE: [PATCH] net/mlx5: fix build with GCC 12 and ASan
Date: Tue, 14 Mar 2023 13:00:02 +0000	[thread overview]
Message-ID: <DM6PR12MB37536CF3A3B2952A45EFC5DDDFBE9@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230309090317.847742-1-david.marchand@redhat.com>

Hi, David

Thank you for the fix.
I see the quite similar strncpy() usage in mlx5_xstats_get_names() routine.
Does compiler complain about?

With best regards,
Slava

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: четверг, 9 марта 2023 г. 11:03
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Subject: [PATCH] net/mlx5: fix build with GCC 12 and ASan
> 
> Building with gcc 12 and ASan raises this warning:
> 
> ../drivers/net/mlx5/mlx5_txpp.c: In function ‘mlx5_txpp_xstats_get_names’:
> ../drivers/net/mlx5/mlx5_txpp.c:1066:25: error: ‘strncpy’ specified bound
> 	64 equals destination size [-Werror=stringop-truncation]
>  1066 |                         strncpy(xstats_names[i + n_used].name,
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  1067 |                                 mlx5_txpp_stat_names[i],
>       |                                 ~~~~~~~~~~~~~~~~~~~~~~~~
>  1068 |                                 RTE_ETH_XSTATS_NAME_SIZE);
>       |                                 ~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Prefer strlcpy.
> 
> Fixes: 3b025c0ca425 ("net/mlx5: provide send scheduling error statistics")
> Cc: stable@dpdk.org
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/net/mlx5/mlx5_txpp.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_txpp.c b/drivers/net/mlx5/mlx5_txpp.c
> index 63d98dbde9..0e1da1d5f5 100644
> --- a/drivers/net/mlx5/mlx5_txpp.c
> +++ b/drivers/net/mlx5/mlx5_txpp.c
> @@ -1063,11 +1063,9 @@ int mlx5_txpp_xstats_get_names(struct
> rte_eth_dev *dev __rte_unused,
> 
>  	if (n >= n_used + n_txpp && xstats_names) {
>  		for (i = 0; i < n_txpp; ++i) {
> -			strncpy(xstats_names[i + n_used].name,
> +			strlcpy(xstats_names[i + n_used].name,
>  				mlx5_txpp_stat_names[i],
>  				RTE_ETH_XSTATS_NAME_SIZE);
> -			xstats_names[i + n_used].name
> -					[RTE_ETH_XSTATS_NAME_SIZE - 1] =
> 0;
>  		}
>  	}
>  	return n_used + n_txpp;
> --
> 2.39.2


  parent reply	other threads:[~2023-03-14 13:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09  9:03 David Marchand
2023-03-14  9:02 ` David Marchand
2023-03-14 13:00 ` Slava Ovsiienko [this message]
2023-03-15 10:05   ` David Marchand
2023-03-15 12:08     ` Slava Ovsiienko
2023-03-22 17:06 ` [PATCH v2] " David Marchand
2023-03-23 11:01   ` Raslan Darawsheh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB37536CF3A3B2952A45EFC5DDDFBE9@DM6PR12MB3753.namprd12.prod.outlook.com \
    --to=viacheslavo@nvidia.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).