From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D3D7A0A0E; Wed, 3 Feb 2021 15:15:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2C732405CB; Wed, 3 Feb 2021 15:15:18 +0100 (CET) Received: from hqnvemgate24.nvidia.com (hqnvemgate24.nvidia.com [216.228.121.143]) by mails.dpdk.org (Postfix) with ESMTP id A77E82405C6; Wed, 3 Feb 2021 15:15:16 +0100 (CET) Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 03 Feb 2021 06:15:15 -0800 Received: from HQMAIL105.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 03 Feb 2021 06:15:15 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 03 Feb 2021 06:15:15 -0800 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 3 Feb 2021 14:15:13 +0000 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 3 Feb 2021 14:15:11 +0000 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.175) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 3 Feb 2021 14:15:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=najuVboJtzmtMLw0qQ3JuYgkbJFO1FQcw82SXNkMDVN1LGbqV0dBfqCSRGm5X3QCYdWBHYgbWM7mBhKu+jCnXcwta7+m1zWrB2dPUJBmaGNR/Kd1U8wBeU/0zYGufQDkmKVA2bSJtNPanslN1FODdH3kaJ1cpNTK8H7bCsSVh6bFOFPInQcx+Ab1Yp7GQjSgv9/oICdwgSvTAac1qDklArMxE/w+oM0HIn/OIWxdBf1O0ebB0bBrXAxTHHyZSJelHf5UULbeZoyT9IPk8JY58tB8u+MjoS+hKH8D6qomSc6R80r8glzs++W1kyQKjLCc5Vb07Vmd+rbMg12kVD69pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DuvcQg7DbxRzQWKzu0i0HUJLGEVQe1BqbHRA6bQl36I=; b=m1o/Pa6iv1la7URoFiYsUMfK3vfHp6tv2H1uFzTb8TFVqbdQMhB8EYV9ywwFJrmmBq1R96nhy603A4+JuCRTlcZo+yHHuDsK6puK8RPwTUq7kvvU/ATFRtICdeJk4bCG3lcGqXMlDLfVbCzzBlFToTgpilfrZfPs24pxZJqfBdcRRSH7iR3tPoOuGa2aW2sU29WfQPiP7vqSjYqTK8r6bB8u9RQ8ScNPM+92PsAeuwzVyaP6DLGch1AlTWmGgxw+KG2BV1ajnc+K5FCP9hZDvp1oXCbJZuTRT5l9Sa4OacWek6mbiPzMzSRnWrW6Uw73IlqIqy9nDB3StidJf8Kang== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM6PR12MB5008.namprd12.prod.outlook.com (2603:10b6:5:1b7::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.19; Wed, 3 Feb 2021 14:15:08 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e4a9:f9a1:d873:d07a]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::e4a9:f9a1:d873:d07a%5]) with mapi id 15.20.3805.028; Wed, 3 Feb 2021 14:15:08 +0000 From: Slava Ovsiienko To: "Dey, Souvik" , Raslan Darawsheh , Matan Azrad CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v3] common/mlx5: fix storing the synched MAC to internal table Thread-Index: AQHW+Yu7r6DTVZiNeE2wnhVR9ReXp6pGEI/ggABHJACAACKucA== Date: Wed, 3 Feb 2021 14:15:08 +0000 Message-ID: References: <20210202035352.24512-1-sodey@rbbn.com> <20210202174841.15784-1-sodey@rbbn.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: rbbn.com; dkim=none (message not signed) header.d=none;rbbn.com; dmarc=none action=none header.from=nvidia.com; x-originating-ip: [95.164.10.10] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f2885128-d8f6-4779-616d-08d8c84e1ca6 x-ms-traffictypediagnostic: DM6PR12MB5008: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-header: ProcessedBy-CMR-outbound x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /8mHGdaaW6iK8OMCrDrbyY6dXQxba74BVt1vQbGQM0u+8K5KevEID7LT8JVe0PZqYQTcNsEC9dWj9umxJQZ8eHW6J8s2Z2vizBjSnfcW4MTx2y4sskzZ7QfrfBjhoXxO8vXvpg9yBjjknGqWcaxThZo2vyggz1DvO1pECOpnhC75QFwYhXAAK9dFWuVfM7lWo84yyH9HIdCh5VYIFYFL99Cf1QsxONoaYM78tX9K8I+UT0iLx4b7YG8DXeOFo5M1Q7p78qCI8ADKMnS7AbDKL+ESYbRwmhPj8q7znGIIh4m+1v67d9BBLbArN3BlJwxE6recKmWAYX5Y6TqMKzDuEBKGenAWdjZ/70qTo7TKEbXHEXXv82NYu1NdegQY5VocritDlMUNAVhs3jz/HXH+nTRsoSPA2LslIIOHxo+0ZB+D552MrRLje8TXWoM8FBf3pW/ZRUKD88aJgEB5yqKcoGl6RPhp0lnbVoMY6sK/1eygurq60H7JSaTlpR6GDB9AcbT6k7eyD0ZhDRS7MJWu6w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(366004)(396003)(136003)(2906002)(26005)(76116006)(8676002)(8936002)(6506007)(478600001)(7696005)(66556008)(55016002)(9686003)(4326008)(33656002)(52536014)(186003)(5660300002)(316002)(83380400001)(110136005)(71200400001)(86362001)(66946007)(66476007)(66446008)(6636002)(53546011)(54906003)(64756008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?7jqwQjL9qqzUoozjeLLIstHFvztbSMpRCFkM8HrvvZZZ/c1TIbkmOsNV076j?= =?us-ascii?Q?eT6j0HpuLDcEz3/i1oQ0KeQ8XFi/kxSN/PVV2BZrHMA2QngSuySwngO+pgEC?= =?us-ascii?Q?WMFkes4FWWhi22VoW8pSDFms3VTEDGZ4NqFfTwaadJtQwEfYlE0P778WBARO?= =?us-ascii?Q?y+ObttsOkmdzmQozJvQCw6T7PEMmZV56t3WoVkV6nInuxkddTukPu5Uklalp?= =?us-ascii?Q?Ldr+FmC528Avhqgyb4QEgK2VivpF+NmDtCohx9Sz2qKFcnFbs0vy6ybLO4dl?= =?us-ascii?Q?9vjkTzABkV8DdNT8Qoy/2XqxhQYNAf/O998RKKyaWFk7FkRsdP/s9SLUUTSU?= =?us-ascii?Q?Iqkt5fFOG9tmKHQfPf8k5GSqRRWvGvYdpaWpXsr85M3jzXzXiB8PnRzRVa/N?= =?us-ascii?Q?OjRF5EXCWMiia1E3sn5kk8k9VdGdHK0+BDRhgB3h0o48thfhSQqlHXRhXqAf?= =?us-ascii?Q?NqGOvZxDkWm4Bmq0rDcDIRenhxQqF6TKYn6DsClFnRSeAyiPVr4SxWsK46fB?= =?us-ascii?Q?As30359N5Fl1QgGK+hH15bj3ERcZ9HiggSHlxVQ7LP/6gcLV39xhmjRGDbLA?= =?us-ascii?Q?WKRquCJq2gRG64/xXa6YxdlXJYV8ht5bKOwWMhgEFwk+m/o3494e+YoVTI8A?= =?us-ascii?Q?rHRDhCFYFODR0MJotJ7lNdw417w3PNg90Jk+1lOzJG7Crmm5DmQ9Tkd++9R3?= =?us-ascii?Q?WTbWB5gBho8nV5XG/nhtjm/rrGHgcFikCI1EYiFhs/NeDf+8WkmHEhS9IyGk?= =?us-ascii?Q?CZYTAWQ1GE0WrC/yV8PIhngsUQ35boANNnoYlMiv79EUs0n8YkaQDAyg7hP7?= =?us-ascii?Q?/TzMIJJx6a1TYYo9/+rBTKiZ5/Pk4BITMVdaAQowJ4gNPYEeKEn1FbCXJg+c?= =?us-ascii?Q?Dx/9OO/GydLIhENK+qXDo2j9COkUvtI/4zUFawl2PqfbdCLoP0EIY43j+6vQ?= =?us-ascii?Q?Hm6qRNHjbBtjd2c1b4aLYqttRCTRv1+EOmEL0pfYb+D1VL0oaCTgM1LIdpg8?= =?us-ascii?Q?5BXyKu3S1V129NVgQQZimdtUqoB34Hc/AyymCNO3w+RVwzk5QCJa+IJag+AE?= =?us-ascii?Q?6D9z2og+?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2885128-d8f6-4779-616d-08d8c84e1ca6 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Feb 2021 14:15:08.6025 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aEGzb9tl3RZx4EJ1ZnvJgCx/M1gxLb0LF1WPrkEvpnAynwfXYvDo9n8c7L2vm9klgr4imUz6AbIOm+V8FjLXPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5008 X-OriginatorOrg: Nvidia.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612361715; bh=DuvcQg7DbxRzQWKzu0i0HUJLGEVQe1BqbHRA6bQl36I=; h=X-PGP-Universal:ARC-Seal:ARC-Message-Signature: ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic: Thread-Index:Date:Message-ID:References:In-Reply-To: Accept-Language:Content-Language:X-MS-Has-Attach: X-MS-TNEF-Correlator:authentication-results:x-originating-ip: x-ms-publictraffictype:x-ms-office365-filtering-correlation-id: x-ms-traffictypediagnostic:x-ms-exchange-transport-forked: x-microsoft-antispam-prvs:x-header:x-ms-oob-tlc-oobclassifiers: x-ms-exchange-senderadcheck:x-microsoft-antispam: x-microsoft-antispam-message-info:x-forefront-antispam-report: x-ms-exchange-antispam-messagedata:Content-Type: Content-Transfer-Encoding:MIME-Version: X-MS-Exchange-CrossTenant-AuthAs: X-MS-Exchange-CrossTenant-AuthSource: X-MS-Exchange-CrossTenant-Network-Message-Id: X-MS-Exchange-CrossTenant-originalarrivaltime: X-MS-Exchange-CrossTenant-fromentityheader: X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype: X-MS-Exchange-CrossTenant-userprincipalname: X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg; b=matgyiGFgLpQvpijitcVH5ySjL9e6kcVeWtNl2pGUMHVCAFkNjHulHs/Qlxl07BBn 89CwHtIApAIG8dwp0wQ0bKQGKBws7jkt/txV33LKWRfL4Uffw4mP/Kvu7GrsNXavuX 2iiFUu0bdxt/R3avAGq+qtP4sIzwKyRp0dSRwuuMChhajUDVLq3xu4HiJGtnXaptJE 28199mB9lvoFh50lvZBf9OqoLbUv8AxdpK5bgyWr3w+x6mQgqmKh5E0BGs/N/u9ilC ggJa4LCBFhT30afoy3JJltpVmoi2orM2fsiU6AY4eq8F70gS7skl9wvHFacH8QDRZe SdcVXY1OyCeiQ== Subject: Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched MAC to internal table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > back again, do you suggest me to submit v4 with with corrected quota > character or its ok to have the v3 of the patch itself as you have alread= y > acked ? OK, let's ask Raslan to fix this minor issue while integrating the patch. Raslan, could you, please, fix the quota character in the commit message? With best regards, Slava > -----Original Message----- > From: Dey, Souvik > Sent: Wednesday, February 3, 2021 14:09 > To: Slava Ovsiienko ; Raslan Darawsheh > ; Matan Azrad > Cc: dev@dpdk.org; stable@dpdk.org > Subject: RE: [PATCH v3] common/mlx5: fix storing the synched MAC to > internal table >=20 > Hi Slava, > Initially v2 of the patch has " instead of ' in the Fixes tags, but it g= ave > some warnings as wrong quota. So thought of changing it to '. I can chang= e it > back again, do you suggest me to submit v4 with with corrected quota > character or its ok to have the v3 of the patch itself as you have alread= y > acked ? >=20 > -- > Regards, > Souvik >=20 > -----Original Message----- > From: dev On Behalf Of Slava Ovsiienko > Sent: Wednesday, February 3, 2021 3:04 AM > To: Dey, Souvik ; Raslan Darawsheh > ; Matan Azrad > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3] common/mlx5: fix storing the synched > MAC to internal table >=20 > NOTICE: This email was received from an EXTERNAL sender. >=20 >=20 > Hi, >=20 > I'm sorry, but quota character in "Fixes" tags is still wrong, causing th= e > checking script errors. > It should be " (0x22 ASCII), not ' (0x27 ASCII). >=20 > Beside this: >=20 > Acked-by: Viacheslav Ovsiienko >=20 > > -----Original Message----- > > From: Dey, Souvik > > Sent: Tuesday, February 2, 2021 19:49 > > To: Raslan Darawsheh ; Slava Ovsiienko > > ; Matan Azrad ; Shahaf > > Shuler > > Cc: dev@dpdk.org; stable@dpdk.org; Souvik Dey > > Subject: [PATCH v3] common/mlx5: fix storing the synched MAC to > > internal table > > > > From: Souvik Dey > > > > As the internal MAC table is divided into Unicast and Multicast > > address sections, we should check the type of synched MAC address > > before storing it to the internal table. Currently the check is not > > done, and the synched MAC of > > 33:33:00:00:00:01 gets stored in the unicast section (mostly index 1) > > causing all subsequent mlx5_set_mc_addr_list() to fail with error > > -EADDRINUSE, as the mac_list contains the MAC 33:33:00:00:00:01. This > > denies adding of any new multicast address to the internal list and > > also fails to add the MAC address to the device in case of SR-IOV VF. > > > > Fixes: f22442cb5d42 ('net/mlx5: reduce Netlink commands dependencies') > > Fixes: ccdcba53a3f4 ('net/mlx5: use Netlink to add/remove MAC > > addresses') > > Cc: stable@dpdk.org > > > > Signed-off-by: Souvik Dey > > --- > > v2: > > * net/ -> common/ > > * space after mlx5: > > * synched -> synched > > * section -> sections > > * rewording which causes -> causing > > * typo: case (to remove) > > * added Fixes for LTS ML > > --- > > v3: > > * Changed the "" in Fixes tags to ''. > > --- > > drivers/common/mlx5/linux/mlx5_nl.c | 20 +++++++++++++++----- > > 1 file changed, 15 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/common/mlx5/linux/mlx5_nl.c > > b/drivers/common/mlx5/linux/mlx5_nl.c > > index 40d8620..ef7a521 100644 > > --- a/drivers/common/mlx5/linux/mlx5_nl.c > > +++ b/drivers/common/mlx5/linux/mlx5_nl.c > > @@ -758,11 +758,21 @@ mlx5_nl_mac_addr_sync(int nlsk_fd, unsigned > int > > iface_idx, > > break; > > if (j !=3D n) > > continue; > > - /* Find the first entry available. */ > > - for (j =3D 0; j !=3D n; ++j) { > > - if (rte_is_zero_ether_addr(&mac_addrs[j])) { > > - mac_addrs[j] =3D macs[i]; > > - break; > > + if (rte_is_multicast_ether_addr(&macs[i])) { > > + /* Find the first entry available. */ > > + for (j =3D MLX5_MAX_UC_MAC_ADDRESSES; j !=3D n; += +j) > > { > > + if (rte_is_zero_ether_addr(&mac_addrs[j])= ) { > > + mac_addrs[j] =3D macs[i]; > > + break; > > + } > > + } > > + } else { > > + /* Find the first entry available. */ > > + for (j =3D 0; j !=3D MLX5_MAX_UC_MAC_ADDRESSES; += +j) > > { > > + if (rte_is_zero_ether_addr(&mac_addrs[j])= ) { > > + mac_addrs[j] =3D macs[i]; > > + break; > > + } > > } > > } > > } > > -- > > 2.9.3.windows.1 > > > > >=20 > Notice: This e-mail together with any attachments may contain information > of Ribbon Communications Inc. and its Affiliates that is confidential and= /or > proprietary for the sole use of the intended recipient. Any review, discl= osure, > reliance or distribution by others or forwarding without express permissi= on > is strictly prohibited. If you are not the intended recipient, please not= ify the > sender immediately and then delete all copies, including any attachments.