From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>
Subject: RE: [PATCH 4/7] mlx5: replace zero length array with flex array
Date: Mon, 6 Mar 2023 13:29:35 +0000 [thread overview]
Message-ID: <DM6PR12MB375394AE011EFBE33950052DDFB69@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230114090825.1d3536a8@hermes.local>
Hi, Stephen
IIUC - for now all of the compilers claimed for DPDK compilation support the zero-length-array and we do not have an issue ?
We could eliminate this GNU extension and have workaround, like this:
/* Verbs headers do not support -pedantic. */
#ifdef PEDANTIC
#pragma GCC diagnostic ignored "-Wpedantic"
#endif
#include <infiniband/mlx5dv.h>
#include <infiniband/verbs.h>
#ifdef PEDANTIC
#pragma GCC diagnostic error "-Wpedantic"
#endif
I'm not sure this would make code more readable.
Should we do this WA?
With best regards,
Slava
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: суббота, 14 января 2023 г. 19:08
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Subject: Re: [PATCH 4/7] mlx5: replace zero length array with flex array
>
> On Fri, 13 Jan 2023 13:52:02 -0800
> Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> > Zero length arrays are GNU extension. Replace with standard flex
> > array.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
>
>
> Since Mlx driver enables pedantic checking, this causes build failure on some
> versions of gcc.
>
> In file included from ../drivers/net/mlx5/mlx5.c:40:
> ../drivers/net/mlx5/mlx5_tx.h:187:23: error: invalid use of structure with
> flexible array member [-Werror=pedantic]
> 187 | struct mlx5_txq_data txq; /* Data path structure. */
> | ^~~
>
>
> Understand that the driver wants to enable more checking since Nvidia does
> good job of keeping the code up to date. But having driver specific compiler
> flags like this creates more unnecessary complexity and doesn't improve the
> resulting code.
next prev parent reply other threads:[~2023-03-06 13:29 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 21:51 [PATCH 0/7] replace zero length arrays Stephen Hemminger
2023-01-13 21:51 ` [PATCH 1/7] member: replace zero length array with flex array Stephen Hemminger
2023-01-14 0:19 ` Tyler Retzlaff
2023-01-14 0:36 ` Stephen Hemminger
2023-01-14 0:42 ` Tyler Retzlaff
2023-01-13 21:52 ` [PATCH 2/7] cryptodev: " Stephen Hemminger
2023-01-13 21:52 ` [PATCH 3/7] security: " Stephen Hemminger
2023-01-13 21:52 ` [PATCH 4/7] mlx5: " Stephen Hemminger
2023-01-14 17:08 ` Stephen Hemminger
2023-03-06 13:29 ` Slava Ovsiienko [this message]
2023-01-13 21:52 ` [PATCH 5/7] nfp: " Stephen Hemminger
2023-01-15 15:22 ` Niklas Söderlund
2023-01-13 21:52 ` [PATCH 6/7] enic: " Stephen Hemminger
2023-01-14 1:12 ` John Daley (johndale)
2023-01-13 21:52 ` [PATCH 7/7] dpaax: " Stephen Hemminger
2023-01-15 11:59 ` Hemant Agrawal
2023-01-14 10:43 ` [PATCH 0/7] replace zero length arrays Morten Brørup
2023-11-17 4:03 ` [PATCH v2 00/10] " Stephen Hemminger
2023-11-17 4:03 ` [PATCH v2 01/10] member: replace zero length array with flex array Stephen Hemminger
2023-11-17 4:17 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 02/10] cryptodev: " Stephen Hemminger
2023-11-17 4:18 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 03/10] security: " Stephen Hemminger
2023-11-17 4:18 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 04/10] pipeline: " Stephen Hemminger
2023-11-17 4:19 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 05/10] net/nfp: " Stephen Hemminger
2023-11-17 4:19 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 06/10] net/enic: " Stephen Hemminger
2023-11-17 4:20 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 07/10] net/mlx5: " Stephen Hemminger
2023-11-17 4:20 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 08/10] pdcp: " Stephen Hemminger
2023-11-17 4:20 ` Tyler Retzlaff
2023-11-17 5:28 ` [EXT] " Anoob Joseph
2023-11-17 4:03 ` [PATCH v2 09/10] net/cpfl: " Stephen Hemminger
2023-11-17 4:20 ` Tyler Retzlaff
2023-11-17 4:03 ` [PATCH v2 10/10] common/dpaxx: " Stephen Hemminger
2023-11-17 4:21 ` Tyler Retzlaff
2023-11-17 8:31 ` [PATCH v2 00/10] replace zero length arrays Morten Brørup
2023-11-17 16:18 ` Stephen Hemminger
2023-11-17 19:59 ` Tyler Retzlaff
2023-11-20 17:06 ` [PATCH v4 00/10] Replace " Stephen Hemminger
2023-11-20 17:06 ` [PATCH v4 01/10] member: replace zero length array with flex array Stephen Hemminger
2023-11-20 17:06 ` [PATCH v4 02/10] cryptodev: " Stephen Hemminger
2023-11-21 5:29 ` [EXT] " Anoob Joseph
2023-11-20 17:06 ` [PATCH v4 03/10] security: " Stephen Hemminger
2023-11-21 5:30 ` [EXT] " Anoob Joseph
2023-11-20 17:06 ` [PATCH v4 04/10] pipeline: " Stephen Hemminger
2023-11-20 17:07 ` [PATCH v4 05/10] net/nfp: " Stephen Hemminger
2023-11-21 1:14 ` Chaoyong He
2023-11-20 17:07 ` [PATCH v4 06/10] net/enic: " Stephen Hemminger
2023-11-20 17:07 ` [PATCH v4 07/10] net/mlx5: " Stephen Hemminger
2023-11-23 17:54 ` Dariusz Sosnowski
2023-11-20 17:07 ` [PATCH v4 08/10] pdcp: " Stephen Hemminger
2023-11-20 17:07 ` [PATCH v4 09/10] net/cpfl: " Stephen Hemminger
2023-11-20 17:07 ` [PATCH v4 10/10] common/dpaxx: remove zero length array Stephen Hemminger
2023-11-21 10:49 ` Hemant Agrawal
2023-11-21 16:46 ` Stephen Hemminger
2023-11-21 17:01 ` Stephen Hemminger
2023-11-21 17:18 ` Tyler Retzlaff
2023-11-22 7:23 ` Hemant Agrawal
2023-11-23 1:43 ` Stephen Hemminger
2023-11-23 19:18 ` Stephen Hemminger
2023-11-28 6:43 ` Hemant Agrawal
2023-11-21 7:26 ` [PATCH v4 00/10] Replace zero length arrays Morten Brørup
2023-11-21 8:30 ` fengchengwen
2023-11-29 2:39 ` [PATCH v5 " Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 01/10] member: replace zero length array with flex array Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 02/10] cryptodev: " Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 03/10] security: " Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 04/10] pipeline: " Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 05/10] net/nfp: " Stephen Hemminger
2023-11-30 1:21 ` Chaoyong He
2023-11-29 2:39 ` [PATCH v5 06/10] net/enic: " Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 07/10] net/mlx5: " Stephen Hemminger
2024-01-23 9:44 ` Thomas Monjalon
2024-01-23 10:28 ` Thomas Monjalon
2024-01-23 11:18 ` Dariusz Sosnowski
2023-11-29 2:39 ` [PATCH v5 08/10] pdcp: " Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 09/10] net/cpfl: " Stephen Hemminger
2023-11-29 2:39 ` [PATCH v5 10/10] common/dpaxx: replace zero length array Stephen Hemminger
2024-01-23 9:42 ` Thomas Monjalon
2024-01-23 10:48 ` [PATCH v5 00/10] Replace zero length arrays Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB375394AE011EFBE33950052DDFB69@DM6PR12MB3753.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).