From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 060A1A0C49; Wed, 14 Jul 2021 08:30:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 79BFC40140; Wed, 14 Jul 2021 08:30:27 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2066.outbound.protection.outlook.com [40.107.237.66]) by mails.dpdk.org (Postfix) with ESMTP id BE3FF4003E for ; Wed, 14 Jul 2021 08:30:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QnD/W8YuIi7iTqPKcdMNKApE5xBhJ92IRj7yys/i7Wwd8s6gUgdu+/Joom1Ec9nUv+xaLnVTXyOr6Z6fyI/Bgmm74pQu0cLZP/eEB+5uJwmzzVDFtmseScosClC8sVqrbP6Eq3hojrjTpHaVqO952RFGdmQBxcgEIgDQWvDYWCqoc+tk9+3O7Sw4AclmZJoT9OVrtyXhVxMGzdx3pX+SV8M+sWt5qRH8IVzdXqkPvMBnnJa2SypOrzmyt3ZJHOE2p7op8/xymxNXhs9OFiPk+pgeiV8qq3pcaVozZQQ5ZoJy/M/YK6QMfiyE6cVedwYLxXlgSpywGFnHcsxxHF5sgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E1MHNZC3P5x7WiBr+ZM8hFdhnwWY81+SPeRjx+HiFR8=; b=EzVIbK71++yXeVK0Gx2AC0060lY6Ztr4D3KorsLckZYa0AbUORrpjK0dPKKaq79Td8969HxDkmU/lLLav1JmORywG+is1ew8/c957fFDbBxBI7VFpJQxjOcgfO4MkshcKoVMVbsQiE4QA8/Evhg6Ks7HyGp+Rz0n/HE/s/VMCSM2wSERpDueLZoBoA9axLA15WqqL7JcPfcOM76Qmoam2hV/BFKDDqSVCjqGqAh57QIuesDKLQ6dVStT4ZULTmf16/cxGiQg5z/DAWv7CmAJK5vPF8CmqnqFIQ1M3PrFIItBHx7Ggxc5clpjJ9ZJ7XDHeT4XS5AjkA2EQY7BHERyTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E1MHNZC3P5x7WiBr+ZM8hFdhnwWY81+SPeRjx+HiFR8=; b=jgRO6tWAh+T/AVJR9KTTS4gL3EnPNlfw5P+TDZk0hcGlXgEk449ANt513GLhrYh0e53XiLpJ5r5dPDNbTMKeKQtKEZ8ZHPwh3ULEKbMZZKVcUfj4fx43b3YLIsBEJqfGuDFdj6jXWIT18qDa3zTk4oTW9+KIbduniOJa309ITLsiB6SGPdeWz2jF5Wp2rRGoxmiwh0o9zu5/Vaf6y0tVkf9bEr8j5VZZ/gHhxaJ0Y1TPae8vXhwThlwbn4a2+d4rf1bME3keKaLIRW582TKlM+famktyUVYTr5s1kL6sc/pa/VwaiCP/gF85ehx/Kvt9s9hDtE9hHR1NUbF7GOK9dQ== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM5PR12MB1306.namprd12.prod.outlook.com (2603:10b6:3:6c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Wed, 14 Jul 2021 06:30:24 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::2521:f25e:e8db:6e35]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::2521:f25e:e8db:6e35%6]) with mapi id 15.20.4331.022; Wed, 14 Jul 2021 06:30:24 +0000 From: Slava Ovsiienko To: Alexander Kozyrev , "dev@dpdk.org" CC: Raslan Darawsheh , Matan Azrad Thread-Topic: [PATCH] net/mlx5: do not allow copy to mark via modify field Thread-Index: AQHXYt5xpcrcuC3yNkiT7qtr8mt9nKtCLGcQ Date: Wed, 14 Jul 2021 06:30:23 +0000 Message-ID: References: <20210616183444.2815030-1-akozyrev@nvidia.com> In-Reply-To: <20210616183444.2815030-1-akozyrev@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5a982402-3133-4ea5-238a-08d94690dca5 x-ms-traffictypediagnostic: DM5PR12MB1306: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yjr3lTq/Jo5ySIcGlsLsKYoDOix/b4Pb52eE3bHJBooG5ArnBqKV3AX3bSJxnjpbXk8Af6E//F790wOQlVCGUdUeyx9FN+3M1V4eqBdDwg0AVTAmY6q0RA3BN022wJorrvwjzwRVAe5DktvPbPy4PCDZ6JOEEWdtBUIJVwW1DIQnASVaR+kqzi3EpqA0QqMxuiY4h0a0TfPLX82xfk1NNWutUCKBjp2IqhJ68EWU52gyXZZL/C0RifWGioTrrNKY2OlDHNS4zf4A5+rAJ9hU8kZuiQSN+oawMgDmwS3vZRB0CQTeaKo6ZfbsZkj/OvXGzx36v24Mi5wZmQcO1/nxl4RmdstO8PBy5xU3wteRqMvc+Iq2iQzn4b7vn3pAtVKKcKL/cl2hCG8AwgnTBha9e2C3/lNj566LOtZtD3SXuPNVuSJQPH0ATZXYLvz9466EGUHRBoe3kJpeu+pqGO/BfZGhqJ0zuuGKM0xAQZWOxfszCEUitZzPH0i2YdkL+LiiHYJmD1cH02FF3LLnsHb+2EApVZkXkLfQ51QyvjH+rw6AJWtpXPbxLJo9ouSa+DuS36+wbGL4eRVBYM7fm+/DFKosqosByCsIkxOF9xNhqvF0FBsWe5ZLqMcitgvwrfM47UmlOu9RUqACxiSHvz+D3Am717jKZb9iG1bRZCEaZetLZopHi93uaE/sK2iaAxCi0UKutejPjBt4yzFv6MTZmQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(39860400002)(396003)(136003)(346002)(376002)(6506007)(478600001)(316002)(8676002)(107886003)(9686003)(71200400001)(4326008)(54906003)(33656002)(53546011)(110136005)(83380400001)(186003)(8936002)(86362001)(5660300002)(66946007)(26005)(55236004)(52536014)(55016002)(7696005)(122000001)(66446008)(38100700002)(66476007)(66556008)(2906002)(64756008)(76116006)(38070700004); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4JPdK58358KLkHqT4jpUXIwC0fF85q7UsUMG0EN3A/Vv9GgJWD8UpuDr5HsR?= =?us-ascii?Q?uzJLtD5kFRHNTj1XvReQIB+0Hck2kLTvlOygYjbj24mAYaCYVGlMzl3Qaj82?= =?us-ascii?Q?x1ecUEzLF77UpBlsbk6iOteKp1lcrweychVs+a+t2/1gTi39Og4q/qM1piq7?= =?us-ascii?Q?Nxlje7Hrr565E1l06SuX2AwjRAqdEW367gvoCLLU11/KEYf9I1mnZ7bEbLRF?= =?us-ascii?Q?8B+xmGvOvoBpEBCgSKAWDMSPy9lzCnb0YDr21FAm91Fy/RJggKZwJ0Hshb9j?= =?us-ascii?Q?XswpyX5xsrsNiDxqiFD6fEISiJuUnOGKBD04bziv4qZQ9CzGXF0X88QFPAiX?= =?us-ascii?Q?fOouKGwtqNXudeTwgdo/9LeQrO3B3vF8tdkxJtXzGqFuIjkE3qWZVI90PZg6?= =?us-ascii?Q?LVfOthq0F+XbQjwGqud/ZlHkuvDLBvyhIFv5hOqeY0e9ug+MmOdhHlJ5GWVn?= =?us-ascii?Q?KAGu9iUsa67qVOWEqvqD9XWiL3k+F4mxN1ioTDjuf7OzzHh5/+66NVI+Uhq9?= =?us-ascii?Q?SJwbK8SLCq97JHSQZlAQxDqtM9B3pbrDyAfFd8BTQz2EcdmNUfA/88FJGq+/?= =?us-ascii?Q?2HEZNdzT/nLGUNhQDScvpeUu9k9CYLjT5uDFOpQomFzqPVdN9TcNCaSpf66r?= =?us-ascii?Q?8jN2s8iQzmNEZj+OuNam8iiizmQ1mC/3VGqC2KLTCStj6v+odrbZxVK4ZulW?= =?us-ascii?Q?IYTcxZJNAzHT489VWnXcrKY3KzRFOmkjTIaJodmFaD9sGx3OfQh3jr0/O4wk?= =?us-ascii?Q?oSXk6b2YfEC2CuLniZWxZg/BNcWu1HRDeEF39oSbGccuA+6Khl+Eb5ufpR0y?= =?us-ascii?Q?+R9olSagC4pbieBtP9m+L1NkkioFf7oJzJRLNb1yYmQHuyX+DYamxGpkkTZI?= =?us-ascii?Q?k7FfLLnl1XSe+7KNH0H4PAaMZ3ABFXDYjFYmJ+hVlvIHK1/iO3eLgD1UgAJv?= =?us-ascii?Q?RhXF5nvb5HDyUaVQWhhgJTYRiFUL+PBpoY165yGBLzep3KrCKY1MVFvOZHJx?= =?us-ascii?Q?Cys0Dzi5O6gkTaGWmDlnBh+Dxx6U33f2Z87h4ZECbEmDpwydpdmQtMoNCK77?= =?us-ascii?Q?bVIjwZ0QVSByuaARVPGu1qOVednkyBdwW+h3m1ZylC/RcXa95GoWpYbSYFYi?= =?us-ascii?Q?cuy2KonRNXprLFCRVqaOao/rywSIJMKOwoA2CauLz4PFNePluq1rZXL8Lf3C?= =?us-ascii?Q?IlxPk4VrUbUoA8TnuhLQmplcQzf3i96resZ7Ik/Nt5qs/C/ZQgd7SNnRjbmT?= =?us-ascii?Q?iiTujVcIlt5/sJmQsEAqwz4gjvAkgv4/PfKB8cbopGaIT4FWJVKFTMmCYMSo?= =?us-ascii?Q?wpMPKc8C0LOLYVa2piuco4eF?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5a982402-3133-4ea5-238a-08d94690dca5 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2021 06:30:23.9821 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0DUFdnYRg5JCShxeX7duBo+Er0h/qP39jMC0FqHCIluG8uKIfZmrDQr+ChsBCqA2A+MM2hXr6s0dVAIXAK6UKA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1306 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: do not allow copy to mark via modify field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Alexander > -----Original Message----- > From: Alexander Kozyrev > Sent: Wednesday, June 16, 2021 21:35 > To: dev@dpdk.org > Cc: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad > Subject: [PATCH] net/mlx5: do not allow copy to mark via modify field >=20 > Mark requires a tag resource to be registered as part of the value assign= ing. It > is not possible during a copy operation from a packet field. Forbid this = in > MODIFY_FIELD. Sorry, commit message seems not to be clear even for one who is in context. "tag resource" - is this hardware resource? "not possible" - due to hardware limitation? And I would add few words about the final table "match-set flow tag resourc= e" - not too many details, just explain - if we copy packet field to MARK substi= tution register - we can't handle actual value copying in the "match-set" table. With best regards, Slava >=20 > Signed-off-by: Alexander Kozyrev > --- > drivers/net/mlx5/mlx5_flow_dv.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c index dafd37ab93..26b901e32e 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -4797,10 +4797,11 @@ flow_dv_validate_action_modify_field(struct > rte_eth_dev *dev, > "source and destination fields" > " cannot be the same"); > if (action_modify_field->dst.field =3D=3D RTE_FLOW_FIELD_VALUE || > - action_modify_field->dst.field =3D=3D RTE_FLOW_FIELD_POINTER) > + action_modify_field->dst.field =3D=3D RTE_FLOW_FIELD_POINTER || > + action_modify_field->dst.field =3D=3D RTE_FLOW_FIELD_MARK) > return rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, action, > - "immediate value or a pointer to it" > + "mark, immediate value or a pointer to it" > " cannot be used as a destination"); > if (action_modify_field->dst.field =3D=3D RTE_FLOW_FIELD_START || > action_modify_field->src.field =3D=3D RTE_FLOW_FIELD_START) > -- > 2.18.2