From: Slava Ovsiienko <viacheslavo@nvidia.com>
To: wangyunjian <wangyunjian@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
"dingxiaoxiong@huawei.com" <dingxiaoxiong@huawei.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix mem leak when a device configured repeatedly
Date: Thu, 13 May 2021 06:47:19 +0000 [thread overview]
Message-ID: <DM6PR12MB3753A1D8EC58ED5C4E2004E0DF519@DM6PR12MB3753.namprd12.prod.outlook.com> (raw)
In-Reply-To: <cf94d2836a3c29222a3a1cafa48996c8cebc1a0d.1620876356.git.wangyunjian@huawei.com>
> -----Original Message-----
> From: wangyunjian <wangyunjian@huawei.com>
> Sent: Thursday, May 13, 2021 6:40
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>;
> dingxiaoxiong@huawei.com; Yunjian Wang <wangyunjian@huawei.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix mem leak when a device
> configured repeatedly
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> Currently, configuring a mlx device, it will allocate its own process private in
> mlx5_proc_priv_init() and only frees it when closing the device. This will lead
> to a memory leak, when a device is configured repeatedly.
>
> For example:
> for(...)
> do
> rte_eth_dev_configure
> rte_eth_rx_queue_setup
> rte_eth_tx_queue_setup
> rte_eth_dev_start
> rte_eth_dev_stop
> done
>
> Fixes: 120dc4a7dcd3 ("net/mlx5: remove device register remap")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
next prev parent reply other threads:[~2021-05-13 6:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 13:18 [dpdk-dev] [PATCH 0/2] fixes for mlx4/mlx5 wangyunjian
2021-05-13 3:38 ` [dpdk-dev] [PATCH v2 " wangyunjian
2021-05-13 3:38 ` [dpdk-dev] [PATCH v2 1/2] net/mlx4: fix mem leak when a device configured repeatedly wangyunjian
2021-05-13 6:46 ` Slava Ovsiienko
2021-05-13 3:39 ` [dpdk-dev] [PATCH v2 2/2] net/mlx5: " wangyunjian
2021-05-13 6:47 ` Slava Ovsiienko [this message]
2021-05-13 12:37 ` [dpdk-dev] [PATCH v2 0/2] fixes for mlx4/mlx5 Thomas Monjalon
2021-05-13 12:51 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB3753A1D8EC58ED5C4E2004E0DF519@DM6PR12MB3753.namprd12.prod.outlook.com \
--to=viacheslavo@nvidia.com \
--cc=dev@dpdk.org \
--cc=dingxiaoxiong@huawei.com \
--cc=matan@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=stable@dpdk.org \
--cc=wangyunjian@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).