From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E51E542928; Wed, 12 Apr 2023 16:06:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF910410F2; Wed, 12 Apr 2023 16:06:46 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 64055406A2 for ; Wed, 12 Apr 2023 16:06:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tq8K8uYmF/8IY632ZcUH5Pvj7YWSYu9+59i9hX8YLcgWNnCRPNGPCutU4jMFuFpNDQJaB0kWcFDZBSkapFE7P1La+5ilrX1toyWsq5GtSuIPipJLUUFWe38GHIF1k0TLMLl7p6iCC/whMysQezNgNYJ5sJk51w0qwXSCNHG7JI6ucO++TvStkSl2rvBM8ZnrJJ9PaUE8x5E3mnQIwkrg4mKG7EKWzSXsID8nPk5iSch2krzf5AWgICOBN/A2FisV71Egb0RGMXiXsp4bWLaVtjkNXCc6SDiIFIvNeXGV7VViX0F7KpfnIamkMjOHboKlnIlzUn2n9Sdd+0PutvCkaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dFVVKzhXKiuwNBJdFwI+EjdLHG5/pUYsk545CJLYNKA=; b=NWY4RihI7xuipXwllvi9MZfUv5thdY612ABYabpxrkF7aQbfzJJ5rjbMvFm93TP6MjsISjiiOzoSHWgdtWWwIwuxCNfDP8G6HTpPaCu0zRN3mdEyRJrRNw9YhOCZe1eaQ3CLjZZAH1+EeWIPYLW2IrQYTSW5TBPtdoIPheapOszxryW9BJi/W7O7B3+PufzL/j6nxMIX1CeyfI/Vr0vOUBCtmYjyKo5ZkasZS5ub+31tBUMB1fnJ7Zo9poOM8EwEI6RvtQK/sQsevjjm1hIc7gM6udrUXChPFBdMlS88VJdVaR4hjYyzWjr1eaPrDwVwUzb+I0GSR+W90MBQ5sLiMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dFVVKzhXKiuwNBJdFwI+EjdLHG5/pUYsk545CJLYNKA=; b=qa3XBof1Tv3Dy16hlji9YervMwyiGTiQCTiJ6ntXh4CiH96Xel+Tn7jfL2Vzy6lnC4Y7AclJ5lR37OAsaXqcMENth+iSsZs4dbVus0OUL+tEliMNmoEbiK9FtkluDzHq/OpgN9lkGesHRONZXz3IJ8IlWwI64YB4Ua7ExeBlFY8nKT3fqAJbu/5nbkIXJomXrYWqwVNtfnvQz8DJva9gQlgAFQq5dNFw3qIFWW9FjeknbNrGCNucVwiPGpOwMZFvSrzNGRnlP1VRQEcXSiomUjNTa0t2XvXGXhtP77qZKAn2ONgB/kHupgDyvJPlIAicNa4bCgxCNSiPbP7e787+Bw== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM6PR12MB4170.namprd12.prod.outlook.com (2603:10b6:5:219::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.28; Wed, 12 Apr 2023 14:06:42 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::c32d:330:7415:765e]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::c32d:330:7415:765e%6]) with mapi id 15.20.6277.036; Wed, 12 Apr 2023 14:06:42 +0000 From: Slava Ovsiienko To: "jiangheng (G)" , "dev@dpdk.org" , Matan Azrad Subject: RE: [PATCH] net/mlx5: fix lro update tcp header cksum error Thread-Topic: [PATCH] net/mlx5: fix lro update tcp header cksum error Thread-Index: AdltMteOaZW0hx84TteVXUvFh7iFegAFNFag Date: Wed, 12 Apr 2023 14:06:42 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR12MB3753:EE_|DM6PR12MB4170:EE_ x-ms-office365-filtering-correlation-id: 6f72d25e-9a7c-4f0a-6f58-08db3b5f24aa x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cxjUztTMnpcVBmMk8q2y5JpRp69bsyqO6e92CRqpNBXQoPbui8eZorJqoojQB8XVJFkmRRQ8EU06YaeTLtakfUhYRHidJuqBo5BEFO5kY8h5Pmgy0WDXOZifbxWpLoUojN+jeTPqn//oSXGBy+GB/WKXdWLnIKD/BEOs2FY635peKDMIjcRQ8KTIMKOqXGKIeThwkZ/CGoAOxc35Itr+dtc4WJeMMfGxTdLEsnr3sUHlTVOxOjAJ+Emr5TEmdzBS0Ghw1bGbRLSN/FYG/XR+l/3qi+cJ4B/JEAS7YaGuFH3WqpmerwPLKi41abd0wMq07WPnzhJlMquBNYZ2IU0XQdAugD2fx62yMhjpjiuvTAZJNZtCLvgDYSg+ho/JG6T7s5ISNDwukQfOzKFFn6BeW2l8cOYXaaNUhWpRoIIQ3ELfq/rZtWKk3QwQALzjNMdCw5STQsTGQjK/AU8gluD/qXXCsfQrClo41+kLA8AGCdCWaJ3SfUqkMSkYrbAN6naag9Sy8oMh2relSIxJyjhVn/Gfw9rQj1stFDgX37H35GzYMUKCNILXjJ9Xx6cYplhIATNBp+bpmn7ogHa6IUZLm4iXscARiUjO3c16A6dtIaq/7RUXkuz6VaQdeve5w+ks x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(396003)(376002)(39860400002)(346002)(366004)(451199021)(64756008)(9686003)(53546011)(6506007)(122000001)(38070700005)(26005)(38100700002)(83380400001)(186003)(33656002)(8936002)(7696005)(41300700001)(316002)(71200400001)(8676002)(86362001)(5660300002)(52536014)(2906002)(55016003)(76116006)(15650500001)(478600001)(110136005)(66476007)(66446008)(6636002)(66946007)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?koi8-r?Q?tTSp6cIydEi8ZkxzpaPdJmJRbMjPTQP3gKx0MD9qF/SvTs2A/UJezPRsjv1wP+?= =?koi8-r?Q?wfe8hiMgjdzZSCNG52gOKrrJQfzIkhoNIiz62GQd2uzCcT1tJZ7ulH199u5MfL?= =?koi8-r?Q?8Pz6U9FyDJjzU5MvcpR4oEZvp4i8pdKFohe4pM6KgYoQq0yXksPwO4CnxV7HXK?= =?koi8-r?Q?ic0eM1WDFsA+1eoGD72J+9rIi11Fr1ogTEVFFGyIbSReahvt7vxwWE3YURlmCf?= =?koi8-r?Q?H0gh8jIM9jr4rgUIqmiqFljXCtGW18kdfup9Qi4HE2GBosqAxFHdX2OmPHz9sH?= =?koi8-r?Q?Z/dIU3YmMzKdBNjf65HbuXCKOBBniCDl3HMXlgfjQsiJJuZwK9jyo6VqfKVrW6?= =?koi8-r?Q?Ap4JgVQJFRYbtApKO3vBOoZGhDxE/NeVMFzds63TLc/tGxkJUVT7IVIBhjxcNY?= =?koi8-r?Q?pCpFyjiamF/lKQKlcANcMCAda4i+GNzJLFxyw2QhP0uslbU3nJ6ln1VxWJNI2O?= =?koi8-r?Q?4YzA/oai1QobTQ3of6VadKMI8OwQ/dLJNhUn7s7VoHaRH7NNq2Kcdpz/bAQ12O?= =?koi8-r?Q?3R31k/fnXp0ZAZdPZJpvO7LROXC6Xwoe/boZBxPWwp3yOAuC2mp5d82Ec2S892?= =?koi8-r?Q?6hCX9b71F44VK81VLOZGGilEH0TlzAAULtvQQLAM/jXj3EfKPcYR2RjMhW1Gxg?= =?koi8-r?Q?YhZA1fZJPojbXi1AkU0A5Y6XXybd0cas/lr7hbM4yxiHvhRtJ392tLB1D5oRfh?= =?koi8-r?Q?nBXKDltHXo75a5e/GrOrsisIo7FZhR6zIXCvlpA1CDCHdBeKd957WAOb0mX4Ax?= =?koi8-r?Q?1Gh0doGT+mvGNQ19U2iGkHpxF9I/+1wcc/TMbUGVOV5aKaHbnJOoRGg1kZS/C/?= =?koi8-r?Q?hGqm6tsGYg2kvoFISa4T5Mq/wEx0aYvrN8JRr2OHnmFP5F0H93zNLpz8FycNCF?= =?koi8-r?Q?NQOu3NpcO8RSWe91ucDLshD/EwJrq/LsQy9kEb/+NYb5UU786/fx2HYNuonMON?= =?koi8-r?Q?/WAAuFK6LFtB0G6rNHHEU6eASaUuSd35qFg3poZcYkoOxfMOmTcHhdZK3gCzKD?= =?koi8-r?Q?GHpvnWdLjXwosd7m2DEiMS6nBeGc0/Kenlye22N4ZGrC5henNzO6GdoiJXceU3?= =?koi8-r?Q?tj6sbMZGMWRKcvElPQdEcxN6vQMNNg/Dl+JLcuNpEefkKULkornGpBOOY9DqhR?= =?koi8-r?Q?Ljtt53dv4HeoW4Zahl8Zc3On9QPMv7TdbusmtdyqByemDcBKDTxaIvUAvxg9t0?= =?koi8-r?Q?HG5JnmEI/lWG8w+itQv7LXDqdQAJHHOzg+UU4j3WSyOWRNSEGH+zzOi2xiauq5?= =?koi8-r?Q?k0/4grKz7/hPat6YMWtamQ63sIaNydsEl5c7JAaxPhM/uq3p4MNz5jJvXoaGhx?= =?koi8-r?Q?sIw7FsxvL9BMo5vgjMJZmZQR/y5JK0pFhzOp4dMM29KRoIxv95n4U/+BTdsGxi?= =?koi8-r?Q?/uhvS5r2C+8KE2E+cXMoMlSCMw3x3DyQWh7LY3mbeetkwyXRnyHqPUS2DVqQHU?= =?koi8-r?Q?ecG9MuojX2RZBaAW7Qpr8TsA2tHiHUA9PTFaWAYNIrVvOvB9BuHewavbGSqjQn?= =?koi8-r?Q?yAP11IJPDNK23aq8AGT7i6/0vFG3l8LGbVJdmHMgK1kJc0IV3b?= Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f72d25e-9a7c-4f0a-6f58-08db3b5f24aa X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Apr 2023 14:06:42.5574 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bM3EeDAFXCWYU8eiPcBeh1h32cUUqgc1mgy1gdTJ7MJy/4E2CpB9SPcr6UpAh90R7Y2t99WA2D5hr7m238Jq4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4170 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Jiangheng You are right, the corner case of sum of 3 is 0x1FFFF gives the wrong resul= t. Could you, please, format the patch according to the rules and send v2 ? - add Fixes: tag with reference to appropriate commit - add Cc: stable@dpdk.org - fix typos in commit message - capitalize sentences, add trailing points, = etc. With best regards, Slava > -----Original Message----- > From: jiangheng (G) > Sent: =D3=D2=C5=C4=C1, 12 =C1=D0=D2=C5=CC=D1 2023 =C7. 14:39 > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > > Subject: [PATCH] net/mlx5: fix lro update tcp header cksum error >=20 > csum is the sum of three 16 bits value > it must be folded twice to ensure that the upper 16 bits are 0 > --- > drivers/net/mlx5/mlx5_rx.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_rx.c b/drivers/net/mlx5/mlx5_rx.c inde= x > a2be523e9e..ae537dfffa 100644 > --- a/drivers/net/mlx5/mlx5_rx.c > +++ b/drivers/net/mlx5/mlx5_rx.c > @@ -1090,6 +1090,7 @@ mlx5_lro_update_tcp_hdr(struct rte_tcp_hdr > *__rte_restrict tcp, > tcp->cksum =3D 0; > csum +=3D rte_raw_cksum(tcp, (tcp->data_off >> 4) * 4); > csum =3D ((csum & 0xffff0000) >> 16) + (csum & 0xffff); > + csum =3D ((csum & 0xffff0000) >> 16) + (csum & 0xffff); > csum =3D (~csum) & 0xffff; > if (csum =3D=3D 0) > csum =3D 0xffff; > -- > 2.27.0