From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D259DA0C43; Tue, 16 Nov 2021 10:01:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2F9E41157; Tue, 16 Nov 2021 10:01:56 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2057.outbound.protection.outlook.com [40.107.92.57]) by mails.dpdk.org (Postfix) with ESMTP id 843854113C for ; Tue, 16 Nov 2021 10:01:55 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hOk9yd8UKVlIUqIKTr/c3VG2PvPK96FwSdq5VomdWNJrKevLDe1sIek5XsMAOsJ0Q1qnoOZdkMEP7s5pDW6urQ66NQjLyv4zGHbF1RUmuS/xMAB42BEZ/EqwO9A6mug8kObxut1B+Dms9qxJrr4J4XrFPtCqSc0cc06tmRCKpYfgn7yVlZuJ+YJEilCZcWXQrq5/09J3VH4TnfSH/e9X0WGUgvRA+scxoDIJxA/yWpWG0lTyC0HyfnVFU3x2MO8kwB8KHAGINRWFCgQPvS+18VSRajmbFZddH+EpAEhofb1+BjgtCz9sW5orMnUkXhq2CavtU7bhh7blrYqEZEqKjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xuEocrbME+xjuBvHeP78aW3MlE25/xIsVoyYAf7BQs8=; b=Q/pGxp3dt7wcdyMifKBO7tjdxOk/e+0uequkyI1hXRcezAh6WAZdxzacONBIOSsSEGecE08v7B3izsbnEs3zlqmflj/RmHVFNd3yDmRhxvC0exI6WKJGiSgWkt8IjsRqSBXPiILzKO+mOd9DvBg+aJNbhycJE/djFGheBb3yrOmxZ8XI2iX2Ws163J1csOpFw0LBp1Xl+vyBCMOwhtTteCSSXECj2L2r/HHsplAjWNRcvcK49w6JmE9p2fTbMC28h41GAzmlUbBAl3aRJwn8qXG2WRkn1UaJSH64y7J+4TGDlwM65BZYgEfOtAjls7HIPEwdIq2mUW7uobRw3pfWbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xuEocrbME+xjuBvHeP78aW3MlE25/xIsVoyYAf7BQs8=; b=pU2ns8LXfcuqVnYYbV9Bf/zUWcJttuqaNzlqHlJxhvt9PF+NcSw71jwmbC+E3sj8KJqmU2ku6Xr6aYEMQU7DVzX2AWVkWmnRu3ezhzJTOUCyiE/fEX9y/ki9ipvcdJKPKLhWdiI5dnR/xURJ3vcNBekQ7rJc9ZKBtsYeLkubL1KYnCvY/cV3x8t6GDDcULUBgByJ8SbFnXX3p5y7DR+fuvgHV89kXF3Amf0gMQFHXwLYJDnte3AHSKBpCdpOh+3wTuC+cVsuM84M8tdYBH7YWDZsNBqt/1NPDsrqcx6UjNM1p1nESYBBtpc1vrLYi1pxoySSEcSQGdNHanKoER0UNA== Received: from DM6PR12MB3753.namprd12.prod.outlook.com (2603:10b6:5:1c7::18) by DM6PR12MB4985.namprd12.prod.outlook.com (2603:10b6:5:16d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.26; Tue, 16 Nov 2021 09:01:54 +0000 Received: from DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::8dc4:eba4:b43b:7d59]) by DM6PR12MB3753.namprd12.prod.outlook.com ([fe80::8dc4:eba4:b43b:7d59%5]) with mapi id 15.20.4690.027; Tue, 16 Nov 2021 09:01:54 +0000 From: Slava Ovsiienko To: Dmitry Kozlyuk , "dev@dpdk.org" CC: Matan Azrad , Raslan Darawsheh Subject: RE: [PATCH] common/mlx5: fix MPRQ mempool registration Thread-Topic: [PATCH] common/mlx5: fix MPRQ mempool registration Thread-Index: AQHX2sgYin3H3gQv1EWSHHTLhNifTKwF23wA Date: Tue, 16 Nov 2021 09:01:54 +0000 Message-ID: References: <20211116085752.2419240-1-dkozlyuk@nvidia.com> In-Reply-To: <20211116085752.2419240-1-dkozlyuk@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d51cd50c-07a8-426c-e921-08d9a8dfbc8b x-ms-traffictypediagnostic: DM6PR12MB4985: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6iMaXC047bRlDbOi50UC4cmeTqp2YiyMySBdsfKX9VWpqaCsfm+kdR1sD+rz8dsQ/0OTmD+66+vtcWVdxcONV/aa6UHZGLfSZGMf7FCKkOKRfRgkAbXBXwSoBj4yY3RIji4oqfkPTvmoQfmDeWweDrWfKctf+LZaokj7HoqpYyYo5Rw6QgHocv/1+SBwlhhIDSA4G/9fytCuiYkxSRGdGsR7Y4OtQ2lLkfkHeRM4WpKH1+lZ2O/D+oi7z5w5WMiCko6vi1AkMoiqR1s7tgF+oKA0J7gdPZnU4wOwHOd2Ih74+O5S7BL2y/8SuERybT/uvY+FEVpxnKIHUIpKdibR54O7KtmflvBCvgzOH/36wlAa8C5YwfYxD15v6J4aIQP3Ok4Mwp22OZiNgOEENILStDPHjd/zniznmAMMvfz/FEwcVtAjnwxhjR4AAH0Vit7G8KI9Q+YYNZkjI5DUn1XWTLQmjp5UVNgM0hyJgNkFRR0GlxiX2fG6lqZsXwF8fTfvrKkPfLvw5YqmjQL7tg5c70q2F3bv2ZdMfLwud7vKiX3VYLp7l9BDHBk2nJUgctH7WEyrFW3M7Bc7JlYQvRwMS09YV74SRXr9r5/TMjWivOQHXZhLhhishXOHiQNAYKO44T7pRg3lIHcx9E5q6vhtfy2//LZEz12DHva7G//lZ5zfCDZz9izeYlNGnrXQOJb1mXRSyyzmOAdMtijxlOfRuxsrKbEfvIgU2y9H64whMgo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB3753.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(71200400001)(55016002)(2906002)(66476007)(64756008)(53546011)(5660300002)(33656002)(9686003)(54906003)(508600001)(110136005)(316002)(52536014)(66946007)(6506007)(122000001)(8936002)(38070700005)(83380400001)(26005)(38100700002)(4744005)(107886003)(76116006)(4326008)(66446008)(86362001)(8676002)(7696005)(186003)(66556008)(290074003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pc8309hK2MxrlBCOuqCwOFkTmI1cjQob5vzhPcNrbP0TvrcDBnVUx8MW1hJ7?= =?us-ascii?Q?EBeZ1i11qlt0WC1P23ybObXb2rqkffhBIqwvkNmMsAWqOKjEqCswWFZSgMn+?= =?us-ascii?Q?AX3Rp5Zrit5+6rYHP0qg+FxNa4oXJYv+L55ZPb0pYPpWxbkzZj20wF4Z1Pz6?= =?us-ascii?Q?h9uSXzT2KA5e/hcEd5GT2Rx13yb82+Gioi88ajOHJm1LM8KjWO21f88zGcp3?= =?us-ascii?Q?z9TwWG25dqBsp+f4pZ5HN6WD8Jxx6WepugflnAIcPtCs2dfHJXaC4EREonsQ?= =?us-ascii?Q?pbgBloGboG+Z1uc/uOPzVwHM9BbIvu3bfU9ZWfe+Nh0KigtcuR6JXxnbdRmr?= =?us-ascii?Q?/IdsvaBvI0aOW/sL49qo5fiyf16IRdYeH5ZplyN8UleUsHnDVK1bYS5EX8WS?= =?us-ascii?Q?GfUwHJyFfXk6f8UEmTc0/R2vpYDbSJe7KEp9fYTSzfPsPD2mCDapQbfsyD2d?= =?us-ascii?Q?BqiHj/FnCX8E55WDUxtrNAS66BicjHIL4MJ8yi2nu2dsAxT7ydOp3pfDh0DZ?= =?us-ascii?Q?SDeopcVeek6OsBgu46yjLn8Q1ASSDT54L+x8HDxY5ngaLuURKlkEYk8c8CCW?= =?us-ascii?Q?/Kcmaf8NKeQ8DTvp3evMCb9N143r0+8BEhysnrbOF52kwtFnekKqKqCc470N?= =?us-ascii?Q?w4KV02/eucwDlczwvMPTgcf9t0JOp5Fja49KDXNTMC+VcBnk2Lp/AtkObIWa?= =?us-ascii?Q?mOpAd4zhrKaM3GY/6u1BdUiEcA5Ter4XbpfiIWWExzerbq29DvFfK78uoZwb?= =?us-ascii?Q?GLcxBO8xUhEobl7ZqjiwDfBXMz89QRBfRx7ljQ9QVVvJMJuf9uyFx7xC9o05?= =?us-ascii?Q?N17MenTbXbKp4Bn7Cp44Iq3bpvVzm7jaZNBeaZYO7EblHFLv9roJKay+5I6L?= =?us-ascii?Q?btwNLCnaqPugbn00fyOJl1CvnKD5LWTz9KwIW66i8Jx1CKgD3Hy0LUT/REo8?= =?us-ascii?Q?W3wnT8n14y1nOVxH+pyVwsHrYhEu7UCGvyltJf0t4KNHHAINyq5eXWlYu/6d?= =?us-ascii?Q?eusGW1k2XpIzIZ8Nmo3L2j1ktmIiLfu0f+iyRov9JavOfi2pa6ZLma8scIj8?= =?us-ascii?Q?vABnsaKIwjhEx44fkfGVPFXm0nCZtJQUqVVV0YUWGXAHoA50th7Uf64vzDIL?= =?us-ascii?Q?RdOBK064ixCk09gZpAB4y0th+ZM2+m+SQjs487ZafAZkj5ZaodFEuEZC8cW1?= =?us-ascii?Q?BL7oOjS2L48O5jftT9vHTPamMXwX9fXSjUCW059vW1iQG7I37DEuYQS/cFIj?= =?us-ascii?Q?8V0L/gTUkZpSPJFURUcK6xoAPo+LBwWJAjFSSRXr+3VvmYEPOP4DWMYqLLnf?= =?us-ascii?Q?M+o1A8KjtBwsNvIGLvbeA2W4rIYwrYVghhDeOu1DWVrMc+8gqnZWWCLpMMjV?= =?us-ascii?Q?8vHdet7N5x3v+/BDwxT8SEm2BZQe+AuJRMHpKzQMFALur2uYKV3+QvY4JI6b?= =?us-ascii?Q?tdKWP2B0dS+ccr1yfGSXCoe/xZNJiWlYG7jmDfcgIu8BuXDxpHcEqExnXfjM?= =?us-ascii?Q?NQlTT2pq4bp0cXmYGJhrNuE5/L13i7cdHNQL/AIm29hdtG1sxLOWyjTiL1J4?= =?us-ascii?Q?Y7eMSZtmBOFtYZV+pIwVIPLv27XmxAWjhxI2CLiNlMut0vc7K1zgIcr25EL+?= =?us-ascii?Q?HQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3753.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d51cd50c-07a8-426c-e921-08d9a8dfbc8b X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Nov 2021 09:01:54.2975 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eEIWOBDxWBl2ApO7B4SkVzTaqoVaFojDN4Z1E+MgUIFDWMmngOnl1Eyogx39vYrQmWf6cHpwiQBH8gVqUqCnEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4985 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Dmitry Kozlyuk > Sent: Tuesday, November 16, 2021 10:58 > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH] common/mlx5: fix MPRQ mempool registration >=20 > Mempool registration code had a wrong assumption that it is always dealin= g > with packet mempools and always called rte_pktmbuf_priv_flags(), which > returned a random value for different types of mempools. > In particular, it could consider MPRQ mempools as having externally pinne= d > buffers, which is wrong. > Packet mempools cannot be reliably recognized, but it is sufficient to ch= eck > that the mempool is not a packet one, so it cannot have externally pinned > buffers. > Compare mempool private data size to that of packet mempools to check. >=20 > Fixes: 690b2a88c2f7 ("common/mlx5: add mempool registration facilities") > Fixes: fec28ca0e3a9 ("net/mlx5: support mempool registration") >=20 > Signed-off-by: Dmitry Kozlyuk Acked-by: Viacheslav Ovsiienko