RE: [PATCH] common/mlx5: decrease log level for hlist creation

[Slava Ovsiienko <viacheslavo@nvidia.com>]

Hi, David

I've re-checked the mlx5_hlist_create() call tree.

And it seems all the calls are done with hardcoded  const values for "size" argument,
and all these values are powers-of-2.

We had an issue in the past, but then I was not seeing this warning for a long time
on my setup. 

With best regards,
Slava

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, November 17, 2021 15:02
> To: Slava Ovsiienko <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> ferruh.yigit@intel.com; Matan Azrad <matan@nvidia.com>; Suanming Mou
> <suanmingm@nvidia.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>
> Subject: Re: [PATCH] common/mlx5: decrease log level for hlist creation
> 
> On Wed, Nov 17, 2021 at 1:14 PM Slava Ovsiienko <viacheslavo@nvidia.com>
> wrote:
> >
> > Hi, David
> >
> > In general, I'm OK with lowering the log level.
> > But we do not expect the warning " is not power of 2".
> > What mlx5_hlist_create() call caused this?
> 
> That's something Maxime can see on RHEL8 with CX6 devices.
> I remember seeing it too in the (recent) past, probably when working with our
> QE.
> So far, I did not associate this log presence to functional issues.
> 
> 
> Looking at DPDK mailing lists:
> http://inbox.dpdk.org/dev/?q=%220xFFFF+is+not+power+of+2%22
> http://inbox.dpdk.org/users/?q=%220xFFFF+is+not+power+of+2%22
> 
> So we are not the only ones seeing this.
> 
> >
> > > -----Original Message-----
> > > From: David Marchand <david.marchand@redhat.com>
> > > Sent: Tuesday, November 16, 2021 22:34
> > > To: dev@dpdk.org
> > > Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> > > ferruh.yigit@intel.com; Matan Azrad <matan@nvidia.com>; Slava
> > > Ovsiienko <viacheslavo@nvidia.com>; Suanming Mou
> > > <suanmingm@nvidia.com>
> > > Subject: [PATCH] common/mlx5: decrease log level for hlist creation
> > >
> > > Initialising mlx5 devices in OVS, I get the following logs:
> > > 2021-11-16T20:08:37Z|00021|dpdk|INFO|EAL: Probe PCI driver:
> mlx5_pci
> > > (15b3:101d) device: 0000:3b:00.0 (socket 0)
> > > 2021-11-16T20:08:37Z|00022|dpdk|INFO|common_mlx5: RTE_MEM is
> > > selected.
> > > 2021-11-16T20:08:38Z|00023|dpdk|WARN|mlx5_pci: Size 0xFFFF is not
> > > power of 2, will be aligned to 0x10000.
> >
> > Can we remove not too meaningful details  from commit message?
> > Date/time in messages: 2021-11-16T20:08:38Z|00023| ?
> 
> I don't mind.
> Logs were coming from OVS unit tests but the same can most likely be
> reproduced with testpmd.
> 
> 
> --
> David Marchand